From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 052FCA00C3; Mon, 19 Sep 2022 11:23:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9413C40E0F; Mon, 19 Sep 2022 11:23:30 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id D112B40141 for ; Mon, 19 Sep 2022 11:23:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663579409; x=1695115409; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=RTQFtrFNOD5Epm/Xf2hxdL18jgLpX1ilexS42WYWsfc=; b=kAPtBwHIFlfkUZuSbar7H7lAxDoFmfjif0Tfwrtav9xqppHwj4Pi7XQi ABLRuiolVdSQuioffXej4mwdafUBZfb2zFEKM+RLezs5mAHu/N91ykGjG GwSMy4krPhawaASs3dEALhZy87nOMVNfpOqAKVJr8iLAsSYuiOjaH4qJM 70osxDByMmWpGPTroBUXx9rUpstEqqdCYrAzVfk2WejvKis7f9BlFQlYP LNpbjFbJnfCKgW7BEpMoLSdRleS28zrQL2vciyck02mWkY8bD9gKZTEHR woCoeLeDAjO8Y5S5RXmWmX7qxFWDKxlvWD8nSwjTbERCNSWZv9d3tfkwr A==; X-IronPort-AV: E=McAfee;i="6500,9779,10474"; a="385640393" X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="385640393" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 02:23:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="651598628" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 19 Sep 2022 02:23:27 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 19 Sep 2022 02:23:27 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 19 Sep 2022 02:23:27 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 19 Sep 2022 02:23:27 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 19 Sep 2022 02:23:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GPwe5iG3sh0hYNwuavAllHSjIoQNKPgRr6nu8C0Y/jt8+JoMaMbA4WavfIsg199kmya8EFkVGA9DmNsiTliG9VO5pWdIzAVi7SRVCatdAfTZAn3rrqgDkAQ2sSzFlXPc/n5ZuJ0xEmUJWlp0R3pCBNnYJbUnHg5D9WYzFkVM4lqS5L+lqEtqwElh3M0aguLkhiPGd6F3Gn/YzKQjzNuf9YhphnEHluDxk274mcdBILJAVZCC4FDq/Fv8BLAXEptegadt4fCljRKwJWOBl34sFupH6kPPedavPUu0VJDDIVF6LpY3TgTbM6eqqkQ6O3EQl/GNZAOpR/xpKz7bs97GaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HgIoiI1zpKjsqTh48mfg+AkFH2WGJ+LqhQ8fz6BXc3c=; b=fzbYk9KlXicddtjRuGaz/wmaueXkndK1vjCRATgzNvnKS0omiRilNhT0i3B3ha0oD+OQ+eFu+7mSI1jvPnXh2Z1ERxhlUoPy6qdyPYcx1Fdfm9WtAu1t9aF2MpG+WM0SBUooMDOMOCG0dA+SQKxV9URT8d7u+nAjH/uT5hRGypFlwkVrZTTe0HXshtCTi2TKFOyUB9DIYa99lKDFnQ7KnzfUpUNo3zbf5vDDtjkdoStOr4RpLududEpDfTnU6gqcP3HIrSrZSa1jL3IfzA+VKfm+FPDsVeZXUz54Sdhk7OYS6pdIW8qzSEIRu8dNpIIX0fNrGRrnMcP3QXndxEqGfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by DM4PR11MB6263.namprd11.prod.outlook.com (2603:10b6:8:a6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Mon, 19 Sep 2022 09:23:24 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::180:43ce:5132:adc5]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::180:43ce:5132:adc5%3]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 09:23:23 +0000 From: "Pattan, Reshma" To: Dongdong Liu , "dev@dpdk.org" , "thomas@monjalon.net" , "ferruh.yigit@xilinx.com" , "andrew.rybchenko@oktetlabs.ru" CC: "Min Hu (Connor)" , Maryam Tahhan Subject: RE: [PATCH 1/6] app/procinfo: add version dump Thread-Topic: [PATCH 1/6] app/procinfo: add version dump Thread-Index: AQHYna5OwCa2CXea4EmT7VD8fErIza3myJ+g Date: Mon, 19 Sep 2022 09:23:23 +0000 Message-ID: References: <20220722091236.15469-1-liudongdong3@huawei.com> <20220722091236.15469-2-liudongdong3@huawei.com> In-Reply-To: <20220722091236.15469-2-liudongdong3@huawei.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3366:EE_|DM4PR11MB6263:EE_ x-ms-office365-filtering-correlation-id: 827b659c-4588-4cbe-4e78-08da9a2099e3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y844JUw2vGRWwitIhwAvKvzAUHP0o/6vh2ofObFHUsPzzhgdUOxnVrtFZG85PbLAivxfZq1DFvjrarMANWWBs0DdhyVh0Y/c5vDTbxiwvL646LnN0ALLTmuvf1+INSfvHmXSbDe8WZ0VWmt/fRdf5PuI0GydbQuxMXMQvYQdFWLOWzvN4db9dViLYBp3tlVxRuAAmxUlEHD+aEDwjaqE3q43+TOonp5mN3yRZ7YN0lRMT8STdSLivaXKH8/pvl7kLSYcQiNbrOPg53wm/tWaQaer+/RMFuBU15LRaD09pIgoMWaiDi7udEYSWupcekvtcKl9K3zQs7nIZgf+d2eFyqs/x/FwWpmwaFZhs3ZonJf/d0dVgNzMuv5dbNtzUIEz0bgH32PLOHFlrP+JJELFNjpP8kYu+nHL29yhTLtG7AL9Oz4/gCm2y3mi3lsii788MD/VG31OamCZuNwrEuW2Ji1fbgNcD6SpsfXol12zmpglcPkI50LZOCQjaPnib//GBSt8w3OI41tZCg9/nT/RrXEeSKCu0D+LxbteH+YiM6sRERgzmxqAs4+Y3Ic0uBhPDneJE63HGYUC4m22V2lezX37pOhlBPA+J+YFSM1WgxC3OXKweiBSjwPhfE/yo4+1XeMfIOW9YliKYLbkp/7fvJxhSern3ur40MlQW0YpUcSCXeqc2prj4GAypFYvkXR71togGdc60K4yliRBrRTz+RRC9bKTJYwfdHqfGiJwMNxivjVVWzMy48k+xAzdVftltMaBjfD+JMRDDdF1ATbTuLzGy5e4/dCqeuQFhxQJOrs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(136003)(346002)(39860400002)(396003)(376002)(451199015)(38070700005)(82960400001)(5660300002)(2906002)(41300700001)(71200400001)(52536014)(54906003)(38100700002)(186003)(7696005)(478600001)(122000001)(4744005)(55016003)(110136005)(83380400001)(33656002)(6506007)(316002)(66476007)(8936002)(107886003)(66946007)(8676002)(86362001)(9686003)(66556008)(64756008)(66446008)(76116006)(4326008)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?X2PJOONSNuyhVKijSxusrz3KArGcunND84/KPgcblsi8K8FKDSwAF/y4QWDg?= =?us-ascii?Q?yNShSmnZXwDd7+8oN+KpuAWORZm45voo+VJbdSJ7xjnvclXhLJCmaWgUKuyd?= =?us-ascii?Q?i+KwvtGsLZHM3iC+yUVXcpqS5GBv0yERz3EBCCw7gU84RWn1H/oOv90qs3+b?= =?us-ascii?Q?yFD9l3Tb1AM4tZ5iDjivK4AOywE0NZ3hYCM4jAxJEg0b12jZkQArEgPmDF7N?= =?us-ascii?Q?nBKovWeqQLmNCrjKInPhXebHfezNvUBjVTH1xwkWs+K0DbKWq49b11SRIVlS?= =?us-ascii?Q?NeEETGV5HwFKheo28XwU3RIr4MQ9CfzFIi1m91Dd3Z3oIAI04CqDdjMGAVL9?= =?us-ascii?Q?5UhPCeRQFuT4egxiY+CVqDt7On9TTsjzM28TniNwEO7g1l6X3+G5axIgCkea?= =?us-ascii?Q?fReOt3wIX4Q5rZ5UYghUD5VH9DB1GuEkFqrGRPWmUU9I4Bv49ltH13S/xJqi?= =?us-ascii?Q?i2SkKtaAwNztmM8llITOfrCdKg30vILJ/q8/LSHivzWjyuCfM4L0phKuoY2X?= =?us-ascii?Q?CBL8tXSlamPyN39/uYuaUVNA2Vm+ddjTlbQtbL3h14XtnmJSuR1oerjz5RZD?= =?us-ascii?Q?DXMPg1zkgKve6Qmg5gsPHYcstbNH+WIDxvmqZmgpcjbsOYM21Xs/JdRbkR2K?= =?us-ascii?Q?DXa54XGMqqp5crkoWCHu6iHg6FJvbX8jeUJ0Vhhkid60dconX1aWjWexb34R?= =?us-ascii?Q?LSGJpOQC2DGxtF+zHnCPO7gMj/9NhR3EFL8QdUQ9VNCkBTuSa9R1DJ7skkMn?= =?us-ascii?Q?0xcSH3ID6gJ9mYj8vdW4uPbfwc29PaZEmvx+007mfHtAFvHIeGhcTNzH2G/3?= =?us-ascii?Q?qvi39V12/MnUw9DkAuMmC5KYjy9/P5tXX2nICBAyPmQ+jx8hmo0Sd4sGQxgb?= =?us-ascii?Q?8Tob5lQ1c98PZNyjatJpu4WPD4hgDTUV9ApXiyrdPscnoIMylWp8Rq5UZzvN?= =?us-ascii?Q?TkVEvKP/QqKgHALNGHsLPHAnu79KjeX6h65h6/iGXN9roczoe5biXwNJRCRo?= =?us-ascii?Q?+HNkuX8NVLNl6omurvSAM/lJxOSuaTr3BSn5hnMbcTwRSydVaXTmqbswEL5S?= =?us-ascii?Q?/8Gh4SIUJLret5Yq0KuJfG03Ktf/glvkOT2kftktP+kQaLMCLvQRA6vC3q5T?= =?us-ascii?Q?nWF3UMxhlCoMu+8vdTLGylpDTz1y9Wqj804NPbO9vTG63KABsZfcim2yep79?= =?us-ascii?Q?LFjAJmWWdoSG17EYOMtqt6+F9eJ7Z+KY98G3UfQEkbzawk/nDCTmkUiiLlPG?= =?us-ascii?Q?q/35bhdE0D/kcS6SLoZrDdo/a175BFLLmDOGGbGoXHa0PlmgPHVM3dArINGo?= =?us-ascii?Q?WJqfwTL5LOUOC8iqWdcAFhFxsieQx0VM4dyosLNmBzv2kMZPZ+afQeezNqID?= =?us-ascii?Q?kva4xZYDTSIaLuUAgnPoWSVm8DH1VSt8+Ry9DWpdaFEG4LpwwLx1BjkHnnNe?= =?us-ascii?Q?q21D2LMEM6bExLYYuvuYvSEOKR0Ki/E8wo4HJ07wn/BictfHk7vND8Okv3o1?= =?us-ascii?Q?gP24LwFkDBAAu6w6rEL8BJaaGWCAIOFXHsf/KWYXzi5QbLHNk3CyPDbxvVhw?= =?us-ascii?Q?xSYFem4x6ch2me5NTaz0I8GCBrkblZUv3k+QEc/yXeLOvxfBKCcyMHERFOZG?= =?us-ascii?Q?2gSNsTEqWQMvMo9cxX9poZ7TnD+c4MsxMfsaaOMt59f0?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 827b659c-4588-4cbe-4e78-08da9a2099e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2022 09:23:23.7475 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rIWG4jov8QsdkZfdPa6XMJ5WhJnYJRstl9xPTAEm5b/baLr6OxBH3U52F7yNMFrVbv42c6clu2zL4xHQj4EWcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6263 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Dongdong Liu > Subject: [PATCH 1/6] app/procinfo: add version dump If this is V2 version of patch, please add V2 in the patch heading. And can you mark the previous version of patches "Superseded" in the patch= work. > dpdk-proc-info -a xxxx:xx:xx.x --file-prefix=3Dxxx -- -- show-version --show-version? But not -- show-version. > --- a/app/proc-info/main.c > + " --show-version: to display DPDK version and firmware > version\n" Say ethdev firmware version. Instead of just firmware version. >=20 > +static void show_version(void) Divide this into 2 lines. "static void" should be in one line and "show_ver= sion(void)" should be in another line. Please check the other functions in the file for an example. > +{ > +#define ETHDEV_FWVERS_LEN 32 Can this definition be moved to top of the file along with the other #defin= es. > + > ETHDEV_FWVERS_LEN) =3D=3D 0) > + printf("Firmware version: %s\n", fw_version); Better to include Ethdev Firmware version. Thanks, Reshma