From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 594BDA0548; Fri, 24 Sep 2021 17:33:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC194412F8; Fri, 24 Sep 2021 17:33:28 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id EAAB74126F for ; Fri, 24 Sep 2021 17:33:26 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10116"; a="222209005" X-IronPort-AV: E=Sophos;i="5.85,320,1624345200"; d="scan'208";a="222209005" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2021 08:33:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,320,1624345200"; d="scan'208";a="516063772" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 24 Sep 2021 08:33:25 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 24 Sep 2021 08:33:25 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 24 Sep 2021 08:33:24 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 24 Sep 2021 08:33:24 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 24 Sep 2021 08:33:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yv43oQGm0BOSXY4C5ihH4KKP40O3PWL0347KpdThKXBLVBTv1mtG6VV80eSzWBcnYhyXalA6sXI/QFX0R/LYE7S4d7PHd7bkKY7bLvi1vhkf1mzcPrdSKdZT7IsbYmbzROwSCTYmpcFes5HluPIZSDBCqtvOioZxuKLNh7gRw3kjz8ed4B6Bg1SYRumYSbhnJJ0G88TKcl3Jy4mFPjVWHOB0JyE4FmE2SoKWTvr294pr9kSVa4IbovpAEdjgLwg9D7UB8gg/LJiVSQ8Yk1uA1r0q+9mfjEqmwm4R32n6YiF8EtlSBjMlfLzv1l/RxXqlZ7n0BnRwRuUcsy+12ox++Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=k1bkquwAe+QCwbIkdAuERHLg3KJbQdFY+CDCmSIRWXA=; b=SP1hePob1bhFEESnuIL+nArrIUbOvJ8bAgBD1ZOV7LlhDIhQZAoKoBJWIxHEbD1IY501fDxfHJiNdxyYtRNTYUcSyt12p3Xu6HYW5frmJejMEzxzozgw8ik75tqGYj/NMo84TKMES3OR2JzpU9RurMNxnQaIyivoXpn7USpTKCEyD8pZUbjOHKi8NtRzFsXoxnMNX2/eE4LWFHDIe1dCrVokaLocHTZwZYeftWPnrNhlzw8hwc4CYk8Gq3lsPyHHlJXZTT0qSNt6fBROTXm+pgTLvcdqwuc7+EpAAPhbodqsZ7PPAhpeJ8D3AD6jc+SES3ztmTWdyzt0j3Lcq8zIdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k1bkquwAe+QCwbIkdAuERHLg3KJbQdFY+CDCmSIRWXA=; b=MfGweKtigfCk1d0qrHMwAVherKKoiZtvQXve+09+e25oPMeMgiKpFghCSqGkL2+nUS3oZsx/x4b2zqUMJQDjWRMoPYCg05PVtk/0Yxy4vAORL8b7RXUDRnDvexoO4/v5+BITHVVX6+2zPOr015pZcMFwmg6u37hKXugbqVxkgn0= Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by SJ0PR11MB4973.namprd11.prod.outlook.com (2603:10b6:a03:2de::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Fri, 24 Sep 2021 15:33:24 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::81f1:6506:57b8:65d]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::81f1:6506:57b8:65d%4]) with mapi id 15.20.4544.015; Fri, 24 Sep 2021 15:33:24 +0000 From: "Pattan, Reshma" To: Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering Thread-Index: AQHXq0oP4DaQNcP7hkSJYA1sccIcZKuxr7OwgABJ4YCAAWIv0A== Date: Fri, 24 Sep 2021 15:33:24 +0000 Message-ID: References: <20210903004732.109023-1-stephen@networkplumber.org> <20210916222630.71543-1-stephen@networkplumber.org> <20210916222630.71543-7-stephen@networkplumber.org> <20210923112317.1d8e0591@hermes.local> In-Reply-To: <20210923112317.1d8e0591@hermes.local> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4d5f92a2-3cbc-4f6d-c567-08d97f70a5ae x-ms-traffictypediagnostic: SJ0PR11MB4973: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PO6PZGxaY1PkyRU/JmnIEGmL4300TsWlL01FGQxzAtTmREeAx3RkKTM5wXB3kfnKpv+XDOD3cLXi1rMlY3kuzqw0dugfVe1IApus+z0PbmbfuAemcTIvQocNLpK0ie2QhcoDaFAIVF/yACzR6yvPTs2mmfXkqsVO9WfEh+EsBcYo8YBQjlK+K+b8MSjGuLSSf5UcX4Fde0sVymGmCvYSrNMT5ZfsllOT2fr1RApB7LCEyiCX017BiaL/0t92yg1e2ivfnkeTlndLAtLSAS+jExSl7NNN7Xn1GSkeumEuCVGWVFaRRBSrGs7RLQb4pOFGnoaPufdzYR/E57OehC+rjnsL2HTg78Pf6ONaYRtifyfndbn5o6BeAxoOW4D3uZYV32dQSyL7OF8zbjMPKx0yP2FGYZwx/nF7YUv8HpeeXnVthWYpW89+5FHLasNgYYAS0L8IQg1OBySGEexsa7Wza5kA66PmG5WGtf+P5teTJhR3kC2wGHiVoNGNwLLECktU0K0uJbFnrgAWjtwZhIF33/XlO3iiopLU2gEad1uaufw2P6uSgqJtXxVoY5cT1VoCY1DOdUSkK+sLrrZQFezV1CK6PWU/eccbxdzYZ/EDEAVZ9A93uQ4cwSfvz5sr4uZwsDsxrmzhzKqGAInOlJwnk0OMy+07HtIGrBy5wZYKCUKbVKUJkCJ9Ofw+NtZKtaWHKQCVB/s5t3GZLb8K+KWNJA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(316002)(66556008)(8676002)(52536014)(76116006)(55016002)(4326008)(66476007)(9686003)(5660300002)(2906002)(83380400001)(4744005)(64756008)(38100700002)(71200400001)(66446008)(122000001)(8936002)(66946007)(38070700005)(6506007)(86362001)(7696005)(26005)(186003)(508600001)(33656002)(6916009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1jKqTNEsG+YpTAdYbNchEVATNRChfH6ej8gKVIpt0H1UAQCzotMqld1I/hOh?= =?us-ascii?Q?BecWD/3aVpp5erVkf+zzY2c8arEVC8iQg6KRys/c6ta6yz1ge5Cs8H4Jni4Z?= =?us-ascii?Q?W4babqRptjALvnRl8xfRHVjnqra5TTC5TY5ORMt282YqOr9KV/h+P2etlYwf?= =?us-ascii?Q?XmP7O/1Ec6guNzOmaDGl4cLj0BLllkw18WQLV7zqoeehupcd/A7DoP4JiMu9?= =?us-ascii?Q?sFTwgyiFbidY5k/0vtUm9rDE8POh6CBv4GVXT7JFTXH+eDMNw3jui8M7vFE+?= =?us-ascii?Q?WkjdZEp7r+GCOxvehfb/iUUgufSA/fvKpT66bwrcCpUqy4hmYNhFSha/WdOR?= =?us-ascii?Q?Ksi+sJyMPSe6EYgh+3E5ohzdR6VJ6RX+xfqgrfjiprQsIT9WnIo6bOBEhW2n?= =?us-ascii?Q?oZD3lIW9kWJhoClaogBsdmaz8+v8wR6AISJfu3bPkNdC6Q9NER+KhKYubXN3?= =?us-ascii?Q?AlTUvxkiXD3mjHttoQjdWGBhY7M/upl9L4iBVqY+WjetvDIprKgjm1b1ulj9?= =?us-ascii?Q?4lapP1fKZr/x1qMMAeH2BOfNVmPy9ggibrDd+IW8mhF/RZZajM0jnBDE8kWg?= =?us-ascii?Q?HgWkRxFd+3886NQmDnGjaivqXiPserROMv4pS2AmWkR+d+ZZaFK5DIeSZv7w?= =?us-ascii?Q?iEtUupJ9EWzoDTJdfvOYhw1n6yErjaGzlirlNo2tldMCtw6iXjXzqeew2uLh?= =?us-ascii?Q?QXygzP8p+QOPrZW1sEziON5zIsr3y/fO4rKEa+Na7ec/5Bi5tuRSrmqufvmF?= =?us-ascii?Q?aJTrB2piMYoEe3q2/UkSYy0SB4dMNW92ZeQWZtPb2DXLwHo1AM4F6TPcNmmh?= =?us-ascii?Q?D+fNqEbphZJd7WmTgovUJe0Z7IIcnoNa7ODaeqnaIGRMI+rG/uusM4mbQ61Y?= =?us-ascii?Q?vTOBVOLRasqBct5uvW7GfOWlchjUqqx2++Q5Qs5+Or6AhkqeS9euWDfZIcdD?= =?us-ascii?Q?91bccD7/Tkl7hBTUFWOYd2F9jT9cira0oiwMg7oL1oi4ikKMZ6YvvSxwsAf3?= =?us-ascii?Q?GE83G/8hyb040qIeG5/0pmCptvdZQepTNe5Mjvr5dCcn9kQRQcmaN1C6749f?= =?us-ascii?Q?LCJO6WxZAunPis1MF4elnPfv/XbkY3w/dRimkpH6AAAxi2OlorqVW5oPcJyd?= =?us-ascii?Q?ecFVoxk9evZ8S+ZRIgqJF9rVYajEk1H8ylMjjcQjx1/Gp2sFPzwiMeUj4oV2?= =?us-ascii?Q?yiv/EMkL4F/dUT/InNrPOOOC+B13BgSE49zrBiQkl4GoSzgkD50UzM/jYPH8?= =?us-ascii?Q?GXsWjkzeQmkOKIoRLkpCPm++1O9QQPxlNq4g/PyDnLJFebE9c3xOfc16JGQf?= =?us-ascii?Q?dRAEHPtosMLUxXpx+7MGuITY?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d5f92a2-3cbc-4f6d-c567-08d97f70a5ae X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2021 15:33:24.1375 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qaYXMI1aiu6x7tUTRkGl1Kfi83BCsCl3Zdh/PjUMrvqbg9e7JCJT3q5zxcMMOgHt1bj4zJxRrmzSw9Yr7CBnbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4973 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > > > > > > + * Similar behavior to rte_bpf_eth callback. > > > + * if BPF program returns zero value for a given packet, > > > + * then it will be ignored. > > > + */ > > Looks like wrong callback name referred in the comment, should be > corrected? >=20 > It really is pcap_offline_filter() and Linux kernel socket filter. Oh ok, rcs[i] is basically "return value of the filter program. This will b= e zero if the packet doesn't match the filter and non-zero if the packet ma= tches the filter."=20 got it now on why is the below if check. >=20 > > > + if (cbs->filter && rcs[i] =3D=3D 0) {