From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F8BAA0C47; Tue, 12 Oct 2021 18:31:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45603410DF; Tue, 12 Oct 2021 18:31:25 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 448E2410D7 for ; Tue, 12 Oct 2021 18:31:23 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="214351867" X-IronPort-AV: E=Sophos;i="5.85,368,1624345200"; d="scan'208";a="214351867" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2021 09:31:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,368,1624345200"; d="scan'208";a="570503418" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 12 Oct 2021 09:31:19 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 12 Oct 2021 09:31:19 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 12 Oct 2021 09:31:19 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 12 Oct 2021 09:31:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=koLgupOhXGnoTjqMzeJX1IcrnbPNkoqi4qeeuJgxfND4zGxXQLsI2sYNX8WbQrIeM++Q6uHga+zVacZQVDaq+xPI9eMpwqUnZVO5z/H3vWkxg19qHJTuWvbn1/JO6MuzQZ0/4FBHtyXTAMKUKgzbIzUXK44tsxiNDTtV56hh36bkpgsb+Yus86dCaQmZKTUbzDTGr300cgbcFSvMS07VDx0qmXhheN0qHwuw2FUId1UCu1r5fgSDE9e6yh5QfmiMBitOUP35/RQO1YVRtgbErtSnoSgpIUn7kARTVNnyqrcUGichs4fPAiQSzEMJAG0pxulV4uA2ffTbmY3u/lIYWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L9tgKAYKU7qKWw3F+l8suG2k09en9K5PhU8CrFI/OjI=; b=oK2n++oK5GsJ7pp4SNzuHJ2dDjqn/SxFR7V6sTwW+2sS3IAXakzXzyU35DnIj1ofrfU968l6L3P1O73Nwz/VaorNTBGzWkvzVK35owCxuPRSctqEak8yrpNi15vBeIzYO2Fl+Zs47NCkFUXPNRbCApKKiBCNH7KHYXAjF6xw9mg46mIG+JOYdLs2xgT9qndYZAz4BpzM/DxQGoSnoBnsDD9MMOnHrCtezlJ2DdFQmf5urV5IizguvYsloWdbPVzAFcSWJkcvuolBLfDdM4bu1BvL9l1lgX7NugMgZhkeT9nbSWfu2+Ebm1uk0OxFQZbGbYpyyULBNzKxAD4/tDS00A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L9tgKAYKU7qKWw3F+l8suG2k09en9K5PhU8CrFI/OjI=; b=l2xqZ6DEKAwDgsYJs4qHWykMXcbcl0JazMG+84CFtZ8uAt4sztF/mcY3QvvauPZ+oK5fRKorL18aXWX7R1a6pCr1D1kgOInPlMm7yLk9ZEfe59VW52aKCLahIjPef3LRFDfgLdg9GXNa9bSTJfGvEdPa0wHybBxwNHYyCHyMPKc= Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by BYAPR11MB3080.namprd11.prod.outlook.com (2603:10b6:a03:8c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct 2021 16:31:18 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::55d3:9984:a672:2b3c]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::55d3:9984:a672:2b3c%5]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021 16:31:18 +0000 From: "Pattan, Reshma" To: Stephen Hemminger , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v12 06/12] pdump: support pcapng and filtering Thread-Index: AQHXtuJjktRG94laK0qk8SJBd5PVAqvPnojA Date: Tue, 12 Oct 2021 16:31:18 +0000 Message-ID: References: <20210903004732.109023-1-stephen@networkplumber.org> <20211001162705.442298-1-stephen@networkplumber.org> <20211001162705.442298-7-stephen@networkplumber.org> In-Reply-To: <20211001162705.442298-7-stephen@networkplumber.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ea0e4735-bfb8-4d50-4162-08d98d9db7f0 x-ms-traffictypediagnostic: BYAPR11MB3080: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2201; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iRyb+PJ6nRhB4+VS5MP12kjX1vY2zIvG0kw9LKsNEbKBmY27zFhbGMIv2+wCdRFLJMwANmrJvoK+/NajSpNoGxedQ2JIMH9V/Pe4Bm1IRN0YSYeLdqx6V4Invg9pOIE7se0Ta9+OrDUtiWcQbBAz98WDDabS9eu4sjsisplkerhV6gp6lcFu27eAEK12nNseHW9wo6iuCUSr2SFzhKj+2HJNYi6xratkCDroWEglj536D+l1wX5ehgOkFlBu3dq623ez0aFV2sUaU/bP8Njg85HjlwYFpyKGcz1nOa/iBO9Rem8cXePM3c5j2umuFZ4pxto1qTGcLI0X2IoX+Rf3+serCfMp0XsOYju/qePbQmrfEphKPTOBRMkDWDoXZOkD2cpjdSDYfjp2NT7CKpBtbP/4q+vF+hYoL6fyOrdRou1hO3n4g+Wg5R/fkjZSpcY4WwrUtOmLJO8Pynw+2ENmdyBINtjRlx6qvyQ076FVxJqzaLYLcq5u0CY0r2KigzHiVahtnLDdLVGXsi76Ev7GuHlX4QAWeGHQbT1v4YWOFspikv2YKIUE6lzrMPexz0uffdEhcq/XSR1q/idcd08TI+OEMALthgFTHSCgRkQ0zmv4R2VMB4vW0ftqjqc7+65M440vAokkLrh2N1UMh7BQxO6h4T8mWVO7AB6x5wa9SWvUdrpdPV8d3dSRsG30i681hOA4JrkMc7K7HNX+ShgCSQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(6506007)(66556008)(86362001)(64756008)(66446008)(110136005)(33656002)(186003)(26005)(4744005)(7696005)(71200400001)(8936002)(83380400001)(66946007)(2906002)(66476007)(8676002)(122000001)(76116006)(9686003)(55016002)(52536014)(38070700005)(38100700002)(316002)(508600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d5U+/8BZAuuqB35XXLaBnMOBweKUF6lFrJ6EmlO1DTHrlqlIwmWMnpwe93cV?= =?us-ascii?Q?NmIbbvbbIs1lwRXH4zyt870I5iwD+5wrYp/vEjsuJRFA867EEYJ/fZOSZJn0?= =?us-ascii?Q?NvT6s0tonf4bTA/Ra+rM6OWGMvYrHC/bUIMWHxusvqrJ4b85mTkMUITmdFZo?= =?us-ascii?Q?WL4DuH8OORTbpxBwoUyZGlPPUpxrR47XCXIgZ1KeuM1qWyU8kR7ZdXiMW1uh?= =?us-ascii?Q?lT2rw/4qezuN1NtppcN/vl1xaCBv7RXyE9TxtWh+qSCO2xB35ZBXQ7xQhcNi?= =?us-ascii?Q?BeqE7EX1vXuR/JKfyw4GYmDShFTOrfMWW9b1R3f9P+2S/jvhfRWSLWPQgM4G?= =?us-ascii?Q?PaT+UQ2sIa+axEQHXkHTgHsWKeaXYa9Y2xTYAe3ocfa1QIWJsp27erqef2fx?= =?us-ascii?Q?9LZRGQCB/CoOqTyax2okZj0dnI7xbHqa3NV81waHl6DLdklANcMUtUj+cmEt?= =?us-ascii?Q?UkvZo2f1hBapbEWJigvwHzd8dTcwJGb5NNTjFlKjwTpJNalJL3hzn6i9SH4F?= =?us-ascii?Q?v7+/7rNcMfaj3mz8FxUH4Ri/baUrl+g2vNVR0wlklgiSvhZAB3yrXSSBBcMZ?= =?us-ascii?Q?o62RPBupZMvAE2guJXGFWczUHNDVM9xmhuh+iWtGG5MnqIGLrAHnxlpNPnrS?= =?us-ascii?Q?fBnNLgmDWn/spswwq7PNszgVXgLWYeuNhWY+/bZt8iFJR/qu3TX6WUkRUjHB?= =?us-ascii?Q?PuchPQboI/DMEeDld6K2QoM4sSTHcC04f8Elfo/o6Vr5F3QCfFnIRgOlqAto?= =?us-ascii?Q?3iAGIVdrde4cpJbKAjGPimo8lNATMtu3AxiAWnfk8gkFCAdiqwMtU1R7z+Dg?= =?us-ascii?Q?PE9QWfRDuoCCePd1Hqr/eF5G74QkNCWQqlORFlNr7H3uc2zlwxUYa7QzzrNq?= =?us-ascii?Q?IUbKK0sobJyNkvd0VCjxiLh9RiQO93G+8PAOYcPxdzDZG58PfUe/53fbZsat?= =?us-ascii?Q?UxDM2vxrWSrAPvH4Zido/XfoFoKy2ukEiXU6X+2F1E9KtfFoW9dQ1vLzgT7T?= =?us-ascii?Q?YxM+XyxbKzVP+hOGNAMIuTgK2PvcQbisSgKJmRjQ+JR+QsmxASyMwer/n8kR?= =?us-ascii?Q?dFzfuMlampKhPOBDsccbUDDoVgb74RN6XlTUQ1OSiTeUzw3GsZBaj9nCYzAZ?= =?us-ascii?Q?8KP621keXwRVp8WxCar5QvkjlVPffpL12OAwGJIy6/ca9LLjO8WsmhJFChnd?= =?us-ascii?Q?Nb9fXuEBNgAcs7gabnvsbLa11rJyjXuToDv1z9kLLpIyAubghdZXQt/daXtp?= =?us-ascii?Q?GcQekpYHeuo7sg0TITd45oBw0djLuNc/xT3z766qmZ4V1ZUjziVpTnJ3+vbF?= =?us-ascii?Q?kYirWED4MkZlBaVAjo56g0nA?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea0e4735-bfb8-4d50-4162-08d98d9db7f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 16:31:18.3454 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yEZngr74lS8qKk0INuA0zZMuhUxoHl3xlEwq2YHp9Gw1J4Q189PGABHt10mtl0nzHEYLFg7bz4FieRpgof1s3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3080 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v12 06/12] pdump: support pcapng and filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Stephen Hemminger I see all comments from v10 been addressed. A small Nitpick,=20 > + if (pdump_stats =3D=3D NULL) { > + if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY) { > + PDUMP_LOG(ERR, "pdump stats initialized\n"); :s/initialized/not initialized ? Acked-by: Reshma Pattan