From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F7F9A0544; Fri, 23 Sep 2022 11:22:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B22BD400D7; Fri, 23 Sep 2022 11:22:40 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 606154003C for ; Fri, 23 Sep 2022 11:22:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663924958; x=1695460958; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=//e43mbz/XZnJcPcDbIijq7k8DTUODTuBcmjZ5lQqsE=; b=bcndslgPY3sp+q+HFm53tRNaxNMiQKVUUJt7gbVZSAE5yg5L1AkDD4+B 4o0ZTpynAc9XKCiffy+Kc3OfPeSZ4vJeg6TNLyLf+kf+hK21gX8PLF6lZ FXYt2/hLyQHGUSV9WrS4B6G1OcPLd1tnh7/agVmXg/uuIuHtc5NLJ09LT 7Mt6bqnUyWV8L6cgHNxVpE2e+UAMVEcjdcJ4k9kYJQOeQTR7njjR53YCC xlotr8CXFjIu6X9yQVjU7CB6rzsoWcC44zI3nQ3XdjRb8Zt9vSlj2SPyI 8nuPdzyc68KeTUvjI/ndD6WRINXHHIiJfEWSzvomuXg6Ct4JbWjBsmBa1 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10478"; a="280277008" X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="280277008" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 02:22:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="682596598" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga008.fm.intel.com with ESMTP; 23 Sep 2022 02:22:37 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 02:22:36 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 02:22:36 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 23 Sep 2022 02:22:36 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 23 Sep 2022 02:22:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DcQlAUlFsSU+ClUnxbYxuGemBdkhT66jSb6LBIc1GOKWJO63Je0Hb6iTHBQ+lTNSaQtyGLZX5f+R7S2fUE2dQ9GtH9RhWbIzGMIq0/1dxrt5cAxzfldMbIY5bDWHi16y4IoB90AEQdM+SRhF7/bzGv4c8TZlAzx/fmybg5YVbpuDFcPRCGuelb56qXHXd8eJIl14edS4W20asBoEvXmPSH9xv3Iy+zcAnhHSiqH6Y+8Qbs2X5rbFlhY6TQbTPGMv8gwtpgi07589oyZA+l7X67sdNrtHa9NiIKrzx6sQEugxLHq8xeRcU3JAhFT/Wwcb1JFDnaGEGYRUFf6PkttFKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9GdGghxXQH5Ssys+McR1QleqX2GvkWPK0IlgmrHSRP4=; b=ClxGPdVsY/oD8VJTvJED251RtDMRvfROS47Nn5575SRNwmSDKNVr3wyGc3gvFSQ8W0WDL0ZiOx9sVeBTVkWTCCuj0LzcT0W86EidsEjaF9ZHPx2ytg4dqFGnDa97rlc9Ry+VM05p/QVsTec4eA8ZsrmY/j8SqCgaYjS/GwMa6dPIyHmUgWXrhP8p2sxPDjzElmzVFdChMbLqz1rG+XxljRlwAieaK0mqV9NgkKY1DYHuuZrQvaUMO8i0V9ap2gZauTnmxl+5QZSRXR0ZZzzEadS+WdZnWFQkn6q0etzLzzDbz9bPhwSfwr+ELSHVzlRuiff7+5nA9UJQx7lNpEjtKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by CY5PR11MB6462.namprd11.prod.outlook.com (2603:10b6:930:32::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Fri, 23 Sep 2022 09:22:27 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::180:43ce:5132:adc5]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::180:43ce:5132:adc5%3]) with mapi id 15.20.5654.019; Fri, 23 Sep 2022 09:22:27 +0000 From: "Pattan, Reshma" To: Dongdong Liu , "dev@dpdk.org" , "thomas@monjalon.net" , "ferruh.yigit@xilinx.com" , "andrew.rybchenko@oktetlabs.ru" CC: Min Hu , Maryam Tahhan Subject: RE: [PATCH v3 2/7] app/procinfo: add firmware version dump Thread-Topic: [PATCH v3 2/7] app/procinfo: add firmware version dump Thread-Index: AQHYzcZ725vyZ5l6dkCG5Eep81RfL63sv02A Date: Fri, 23 Sep 2022 09:22:27 +0000 Message-ID: References: <20220722091236.15469-1-liudongdong3@huawei.com> <20220921142655.16427-1-liudongdong3@huawei.com> <20220921142655.16427-3-liudongdong3@huawei.com> In-Reply-To: <20220921142655.16427-3-liudongdong3@huawei.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3366:EE_|CY5PR11MB6462:EE_ x-ms-office365-filtering-correlation-id: b1d0b164-98aa-43eb-0aac-08da9d4521d0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v0euKwnVrwSEDUujqYO5PE6l02bFFevWAvWBXAHemsgKS0M/Kz/3M/C0FXkEid0Y4xghEPsYd35gRZxDLFtVPXYdJyNUfLdXllINihCsXeN4jU8Dw+NoI3eVnF0EOLvHcbMckDyNuoCt1EjL8vzkeWlTuyke94uFaADrvhsJ1yH3HlRF1rEY5kJWMQdDA2p3I5efrArxPem4NN0vMGRtTWEeqfcM7Ml7YY7kRNk1E3yw84EvnVr3p7GHCNTEjNg6zuBcHBkkYHo74RvKC/D0PgwnLwBYv16r0WMp1sjMq4B/XW3ChpC9cGhvmkeWt/QidX+PukFWSvnJ4eXcQg/6PB8bgDepmKhrpbAkzfv8FlumKPEVE/8J7jKVnJ3XnWuzYJPdXgVJ34e4T+SrAdJxf8iXzE8BmTjwrgRimb02uiUlo3GlrvXgZD+ccwgsmX76z/4S3iA7arvBUjzM2HkKT/6lhdE3B8fEdUrGq0qNeK5reR1RfzSkmznb6Ho+eF8sDpuigT+vCu51XRCDgcAbjnO+aANcdBG1PG1UlRDpvYW+s20t1EIHdFpuowGtYTihAUOOb98ZZhbwGodLCh9zPYFqI3qDGW9/10XdHsv8ROcJhVn4enm0jvj37qlTId9oXaASzgP1SJxW4NYOtGTES8zZ+PDe6zLBdVzbwzR2EqI838vSLWzdwAwjcXp4JGyCizY6yk/jDXNomFh3Bf3yjYOKZpV5KjmBouvcNvySoJfEu01jpa04CV06XwS3xJKCMXDEwfIwbm3A3h2CdV7aB0zLyoVMdsRtWo8rHPkPGEs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(396003)(39860400002)(366004)(136003)(376002)(451199015)(38070700005)(110136005)(38100700002)(41300700001)(76116006)(8936002)(52536014)(82960400001)(4744005)(5660300002)(8676002)(2906002)(66476007)(478600001)(66556008)(33656002)(66446008)(86362001)(4326008)(107886003)(64756008)(316002)(66946007)(6506007)(55016003)(7696005)(83380400001)(9686003)(54906003)(71200400001)(122000001)(186003)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nx8dJ6T5fDCkxE49RInie2y2OVnzAOQFve+P7ReD2HZHuNU6m3iFfIz2pOll?= =?us-ascii?Q?nYHSPG9xxyhS1Y40kn4hZZj/eSXXms5oLdoHgioPvCSfBIBCZ0i6Bg3dO4iN?= =?us-ascii?Q?9ycF7oP5DdAGpENsNNjc/Km7wS3dGlziQLm/LPzxX1sp2LclwJb4Ui9l5LuH?= =?us-ascii?Q?cBefR94Ag76jM1X5cs3J69oMvzSXgReqkkUKMwN4B3X43gXzlmnDhoh1U/5D?= =?us-ascii?Q?uokmL0ZxZEMwACMdHkrqR+llDeQqqwTSLVpKCDc/WD/MetwAKXBNP3yeriW2?= =?us-ascii?Q?aNCm6CIMfkWdQgdRbq+BNnrWctCZfCzLF89iHvtzJAW5cXDgSV+fBj2V7WCl?= =?us-ascii?Q?iPrgMvROUIWbZC2zpWpKK4cltTqMoQpcsUfNhUN3lTLIjyASlYaoT/4zxTby?= =?us-ascii?Q?preThQbEQcoUy69YSpf/8RAAU32xGZNq+Fc1uD/YP0nLDvo6Qw6s+vrJGFM8?= =?us-ascii?Q?n4QKr6QCDBA9240CK659NQutKjb4zart8PDBtg9Gwrk//pCQcRJFFYSEyS/Y?= =?us-ascii?Q?1izKMJNXdmYzA8Wwp3wc/Y+tI+jpNdsWaYOuPXAgvugUereKbaorSfbQZr2X?= =?us-ascii?Q?M2lMK+p2GbL46lsf76OjmqLeLuPap+TNoD+Nt2Zb+vleowhx8YXUWhMiZjOe?= =?us-ascii?Q?JDenouLD9sQnN+qwqNueczSQAmx9lLhFBlgBrbjzgbwqNtx7yyM53PunrhV3?= =?us-ascii?Q?85YWLdvI0cGEtiyKJbBOxnq954osRYDsBIlc5XYqznagq4kSwX/9np+DDTbI?= =?us-ascii?Q?AH/9K4KQvulcJxyfW7+XF9jSlHdQcFH5eU+luGVE/JNWnnDG/18QTxmd+LHx?= =?us-ascii?Q?ZPAsPtYE6cC0CNGwAOmpS/0pWf7nywOVWbyehaVAJkdJ7lBqFTLOZTowa7da?= =?us-ascii?Q?FhZUkb7tsJJyZvQZ7PJW4KAnRlIiNI7A7GseiqhxwmwQrfTVi3S2GDUNcoJO?= =?us-ascii?Q?YpNejQNPmg+VFFepwHf1gSuAfLE8tojrrJrbN8PPAcpi4yjeCroOb62QXUxQ?= =?us-ascii?Q?bq3FoOCLj8uHJsl+KmWoqFLMBrn5RxvhRBCdR4+fu2GR6PifBa5fvUZFewNI?= =?us-ascii?Q?Wy8JJcUgRCvPWtCCrMtJrgq3qoBBp3IHRp5OFMLAWVK2loggURoIcycEu5EA?= =?us-ascii?Q?3ma8IHdO8hdVvis1eOiQU9A+K8Gq8A6C1P64Kik8v1aXzI+P/GyQortSHudl?= =?us-ascii?Q?c2VrY22cyHqnOfyFSDR5FkXuNfLrkPkYp7xc5mlM7fg0K/WUPfAoxo2ZZyp4?= =?us-ascii?Q?ErfzV8n1xCDKnZTJRfDI+YCfjMVE0EfB1FUHLA5TJmlws/M5OMxTnfvVt3tn?= =?us-ascii?Q?Cdrr4mM6vUesV+Z9BRxIEeHgsgvhPJTJ5zHa7s0rJ/fxuu1c+0OvynGjnjxu?= =?us-ascii?Q?zNN6f4JnB6Y+M2ZGsADlabL25ieFvX3ZOPv9jQxx+rtamCp2nA9wrqKaBv1q?= =?us-ascii?Q?nPNvs2yGoO1/yolFRQvkSXv0Plzjq1IIEIZwg8Ii5PwpAzc0mAqLOZKjv64h?= =?us-ascii?Q?BtSU0hd2eXsk6K1uRaORI6Yj7NgunVbTIMXCdms9oee/W3j9LWWypPO2nmSC?= =?us-ascii?Q?vuAk1NO3XnEzW27ZtiVPlz/GTJOn8HxQXGDlnyUNpA0zFJmB+9qmZ20ic9z/?= =?us-ascii?Q?tTDpGJHloYCkcKnwfYUq+9IligkqR/tguAkt/U3kHOQ4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1d0b164-98aa-43eb-0aac-08da9d4521d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2022 09:22:27.1464 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8mU0L0jNdtK/WMcOBKEbo4+QmjriWP+cChJfYgBSYqTsVwzXF6VLbRh9uJjOwFUxTL83kUvHHQimaaWWCZfGFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6462 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Dongdong Liu > Subject: [PATCH v3 2/7] app/procinfo: add firmware version dump >=20 > Add support for dump ethdev firmware version. >=20 > The command is like: > dpdk-proc-info -a xxxx:xx:xx.x --file-prefix=3Dxxx -- --firmware-version >=20 > Signed-off-by: Min Hu (Connor) > Signed-off-by: Dongdong Liu > + if (rte_eth_dev_fw_version_get(i, fw_version, > + ETHDEV_FWVERS_LEN) =3D=3D 0) > + printf("Ethdev port %u firmware version: %s\n", i, > + fw_version); > + else > + printf("Ethdev port %u firmware version: %s\n", i, > + "not available"); Small question, do you want to show generic msg "Not available" ? instead = of different printing messages based on what is returned from the " rte_et= h_dev_fw_version_get" .=20 Acked-by: Reshma Pattan