From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 759E8427F6; Tue, 21 Mar 2023 10:37:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22F4C40A7F; Tue, 21 Mar 2023 10:37:22 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id DCD7140A7A for ; Tue, 21 Mar 2023 10:37:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679391440; x=1710927440; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gIN+hsSXXqTAMAIrMU6OXceEfey3lWoXfLXRMPnfFdY=; b=VnP4soHARFfoM1QjBtY8x+tgIrombnDrX8IeaPmcJnzVGCQqlm/10pwi 0K2fZy495+jj/v3BVVIeNcqoaAoX6eIdUTmZqxgdfliuUH9TT01+iHjKr tY/AGLmwd5pUcMg3FFEswdzm2s6T0OBp7kQVqauUDGYOU/VQybqGWUCrd tKOoe1UJMj8Uis3cHSWcifZ9v9RIYWW89BMOKnxV6dYyEJNsRnSANMot2 NBaOP9UqnbrSmVncteQwA22lkFcFPj3op0fT2QmquaXtOpovYxNTmny73 yQdslqsiSfMymYRL9NWJOpN4fQyxW+a1Sy6LXaA8ROwg0TbA0yGg33l/7 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="337614739" X-IronPort-AV: E=Sophos;i="5.98,278,1673942400"; d="scan'208";a="337614739" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2023 02:37:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="631493734" X-IronPort-AV: E=Sophos;i="5.98,278,1673942400"; d="scan'208";a="631493734" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 21 Mar 2023 02:37:18 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 21 Mar 2023 02:37:18 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 21 Mar 2023 02:37:18 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 21 Mar 2023 02:37:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jaeEhua0+1pzWBSqma89l6kofr1WyzRmNLStvmScsVqOSTcqM4rnRMK3uNh2hZLwadJRChp4WcxVUn71yMfOivTdnjuHUV13Uzs8MnDBJL9/nDDP+/rzvtFkSRmGoo7vFX9ETJbjk4DWTAuXyf+4X1G9BF1dvFXSwdPYI0z4qIi7MDD4tdcn77NEXJ41unBXjmxIboMx6pgXwSoPS1JnW6K3SVTDXX9SflyQiGwDZFi0HZoOWy7ns56uYY3s3K3MgiM7F8SxaIC2LOjHNh9gIMFhNXm51doot8fgMYmXe0/xbszq1XFj2fZh6Rm7PkwOY8GVN6GoqnSnOp1OUdfhFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZldXwRamqnVaZEhqJZz7zfU4GE122liZEevuPDVcGu0=; b=dNq4GR1tSgxrUA+H9491Y4KDnAblp5tSNNyCV7Ov+djJnC8ClfIeRpQyrwoufGZcoH2yfljkxZZf+UISndSleXk5inZbz727sOPCjotXAsNCy36OwuaGSP7BGFvV94W9T/GiTczf/Lf5pF6+zYG4dfG3Q+l4ygeI6zGqygJ2aAwGPMr9j8J+exSkEVO2KQTfvDJiz9D6Fzrmw17g8CC6ifYAEokQ/vHabXKIZbD1YxtLaX6drVIaaXi1qHYwmXnRfoU136/cAFFx/lAzHR0BiICgSpeEdHuTZsNRyoMwd1dw8VTHhcByXsnytKGpjefGCrO0MiyOsrcM/LfWZgznPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by CYYPR11MB8387.namprd11.prod.outlook.com (2603:10b6:930:c8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Tue, 21 Mar 2023 09:37:16 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::7d29:65ab:81a8:91b7]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::7d29:65ab:81a8:91b7%7]) with mapi id 15.20.6178.037; Tue, 21 Mar 2023 09:37:16 +0000 From: "Pattan, Reshma" To: "Sevincer, Abdullah" , "dev@dpdk.org" CC: "jerinj@marvell.com" Subject: RE: [PATCH v12] app/procinfo: display eventdev xstats Thread-Topic: [PATCH v12] app/procinfo: display eventdev xstats Thread-Index: AQHZWtL0Do/ADha4vUS1y45YFoV5Ka8DsrEAgABNGICAAPkQ0A== Date: Tue, 21 Mar 2023 09:37:15 +0000 Message-ID: References: <20230309185143.1006949-1-abdullah.sevincer@intel.com> <20230320022316.2298874-1-abdullah.sevincer@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3366:EE_|CYYPR11MB8387:EE_ x-ms-office365-filtering-correlation-id: 76dbf30a-230a-4107-389f-08db29efdb78 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lmQ1X2F3HarHSn3ARgaJxHZnW01K2C3slpX6G9TzGKcWpR56/LXdLczbgAMQQTqJX0Mm3GFW1o8vc2E68NsOXWjSy3egsZ3ju6jO9f8J/KjMXOHSbHNMxRmexw0m+7eo1e9021oF5+wBLQHQ1FFej8D/Oo0nHX1xCBFFjULDn9HmX4JkzTU1q+XVUlWGrfJcLfbgSVAMSok9yq2e/fi8ZhqK5OC0tz+SeOiQsCB/uhWxq0VDz3nCj8ESbCaWRQPadRAeSKjBAv5ig25c7gPWAVc3OMSC0TpHbmjEoyWpwJbNn5/myJyi2L/0vfeRBNetTUVSspi19goF14ID3epBCiC7BOvcVj0sDSYXHXzaFhCxCwofKV1MWFILsNsJE+kZd20tEW456ApHDsM/P7zozmdptGSc4BY196zQkhqC70Zjt4AEFHYxt37eUoydDKJv2H3Qf3brBmsmLUWTqtDx4alNBFqF8z3yCe+ShjfDqr6+wx1b4Tkr70TLR6AMgFUCNCN48f3LJMSzamCDXYIZtQF3D1Y5lJzCoHCksCmmFwql9ZK07tr/0a8EMbXwybu/GiKEqtkpNVD9i1XczkP+//JQc9OPjvFrW7tXPIJsLWQrqqPQ5kuZzXQOlNmGQbUzYBMZRn1FE9ysJuQ+lywf4wC3BdRBQ2uuQZLuoB+GkRwHYWBTYolJhnaUr36/0baFJlAxtgc4E6kA5zTi5IWIXA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199018)(52536014)(8936002)(5660300002)(41300700001)(82960400001)(4326008)(2906002)(122000001)(33656002)(38070700005)(86362001)(38100700002)(66476007)(478600001)(7696005)(66946007)(71200400001)(66446008)(64756008)(66556008)(76116006)(8676002)(55016003)(6506007)(316002)(110136005)(9686003)(26005)(83380400001)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HoYw1GfGxAgvGrAcClJ5qBxSliL7klIIJqdPuF+sD+eznmeD9MqgCJ+pRoa/?= =?us-ascii?Q?zz/wMA9XM3wM4Yrrmc2UJknGrbnn6h++BGFBB+/vrLJfQr/ry9AIrn30eKlY?= =?us-ascii?Q?2tBqSmLE25iY67SN1xBe/PCMX+HJ0S0yFCzbfVdK+V3i03EfedRZxyolKc8A?= =?us-ascii?Q?90ff6mHtTmBHk8wxkTtZ2CPPnklrutE1NmvL9Rw0aaZGHf65IOGcBu4gbcxn?= =?us-ascii?Q?3Ga6LnNJXdCfGn4Z2ImXyQyPxETFRZf5KnYT3BZBYTle2FvPPV4JXGxF/Dnn?= =?us-ascii?Q?sgDPEbxCoCnkSLgFiRPdMWDjQke49Sh0/0RkQgXCQkiUJdAur2A9/+qA3jlE?= =?us-ascii?Q?pyQVn048rlcbsXXM0D1GPyt8MTI5sgblZVYCyFAcuabgdcfcN+yOxMplzJdt?= =?us-ascii?Q?YkJX0L0ZHHjZuJka5pKL/v0aIz7f2aCjxIlny6WXnM9FtN+OL19cSeJFyKJd?= =?us-ascii?Q?niEhyNowI21xtO+ABtxXaWMcEOhkqJgEPlIXo8mvb6yXFd2ccwouIGGiKqyt?= =?us-ascii?Q?Ctu9/XaMPXZIxlbklFRTzh3WFNqR7C3kQiB/x4d8cHyTvkCJpY6PK445EFcd?= =?us-ascii?Q?uQZPagtcfJ18JweOkmCC8rOj7wzCGDI/fPQOLTXhyyOaFVjBWPRY9U9hNbZQ?= =?us-ascii?Q?RIVtL4EQLSAuglTtKbQY+GE5qt9zsr8pIHfEsD72LvCSHPO7R/EL2T7Ur/fC?= =?us-ascii?Q?p4MgSJpWGFRWS2OKzIZUDu+gLklQCQRNYk3aePqYiXLeCzkJMT65nMB86drM?= =?us-ascii?Q?3CK1+gnFtuavG1KNyk5uvn99S3M1sJVkhKuiC4yBGT9GNMnaKb8awMBzT486?= =?us-ascii?Q?m4PCAijiWxVkz4rx5X1Gdh3E9SsWNd8A3HWCiPlqhc3LAYu5Vve/IeKWH7Cu?= =?us-ascii?Q?qdgo/p2+CJt/VSzuFoMuKZYO122SFTn0fLUhgrZRQox9Nnx+suOkmdAFNYji?= =?us-ascii?Q?+/JT5HVTqRcXoSEjJpPl3UkxI8iQjEh3S4pJPvEpK6/NVftKTNGzEzpe2pTK?= =?us-ascii?Q?gM1j8F5YRxg6LHibEWy1JM9AbETIM43NpII/vuGVE77iyO4N/mp8CZ+y0kt4?= =?us-ascii?Q?HOpQKysA4YKc35Enpvyz9TyzoVvcs++S5D6mKY7oKFF8RcDlMMgAvvdV7rYB?= =?us-ascii?Q?dwYfiddQntCvXYY093YNGXiH9dfUznUqvtQ9T5JIwcfntQXuTUlvwlqXdRxA?= =?us-ascii?Q?sHno9TNpOMY2Apw/sA0KTFGUUyjwJPN/AmS7CV6NABVx16s0Whnd2maNgULV?= =?us-ascii?Q?4iqGHqUoo4H5jJouuQU0v7apqhlHky9FqYxR0nkOE6IGiygCFTOuyMRA/Cpn?= =?us-ascii?Q?VH1Uk5r74CZVOHOvrHbIstuueBbI9b2n+8Nzs1UH+qZkE7Fl5Ghks1K1PSp1?= =?us-ascii?Q?rW5YmJa5dxMtA6KSXZ2i1u27Yvs/FbwJK7YQGYjOKwDxG4msnQw48CO3j8Om?= =?us-ascii?Q?7cL4Hy3Vlyzt2846yeAXw+vUZENUfwCVONtEvebytpI9SyTOykX5CDuHh+Ms?= =?us-ascii?Q?+Q4JPp8rFDCkkzNHRpItmg1EG4zBMpjVrrF/watQArzVSyN1jVdc69DnkwTu?= =?us-ascii?Q?mBfIfzRL3sdKQQAdPD+yz/nMG0p9+wJv30hmF3w0?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76dbf30a-230a-4107-389f-08db29efdb78 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2023 09:37:15.8912 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tBjrC0Z1U15ecbBsNzSenjWzzdWkcyEYeiwoffO99XSDls/C+eYHM4pSOHRPc0KuP6OitxUc1622kKrkuCoX6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8387 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Sevincer, Abdullah > >+Ex: > >+struct eventdev_params { > >+ unit8_t eventdev_id; > >+ unit8_t ports[MAX_PORTS_QUEUES] > >+ unit8_t queues[MAX_PORTS_QUEUES] > >+ static uint8_t num_queues > >+ static uint8_t num_ports > >+ > >+ static uint32_t enable_shw_all_eventdev_queues; > >+ static uint32_t enable_shw_all_eventdev_ports; > >+ static uint32_t enable_dump_eventdev_xstats; > >+ static uint32_t enable_eventdev_reset_xstats; > >+ static uint32_t enable_shw_eventdev_device_xstats; > >+} >=20 > Also, all global variables are tied to a command itself like "static uint= 32_t > enable_shw_port_priv" or "static uint32_t enable_shw_ring" . I also want = the > same for eventdev params to be called a command like the others in the fi= le. If > user wants he/she can chain commands. The "struct desc_param" is handling > one command only but its 3 parameters (queue_id, offset and num) are put = in > the structure, for easy parsing. None of the command line arguments, henc= e > global variables are handled/put in a structure. Would you like to change= that > for proc app going forward? >=20 Having structure like suggested not only help-s simple data handling but al= so would help for the cases like below , where you need to maintain differe= nt event ids in the code.=20 With the current patch version the below scenario is not possible as you ha= ve only one global variable for the eventdev id which always holds the late= st evet id in the command , from below example evetdev id 2. Ex 1: Where you want to show queue 0 xstats of eventdev 2 and port0 xstats = of eventdev 1 ./proc --show-evendev-port-xtstas=3D0:1 --show-evendev-queue-xsats=3D0:2 Thanks. Reshma