From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CF86A0562; Wed, 14 Apr 2021 11:24:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16E671618E0; Wed, 14 Apr 2021 11:24:59 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 580861618DD for ; Wed, 14 Apr 2021 11:24:57 +0200 (CEST) IronPort-SDR: UwF55IZVmHIsmBdIVRj1HxPHs9G8j+1wiGRxGplWNxqfwOeCA9qPldFdfMxJ7ALiHxSOyO9fGW zdSwTCGh6tCQ== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="181723922" X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="181723922" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 02:24:56 -0700 IronPort-SDR: dniOubv+l24AVR80tuIpf2iEr0b3TeLeWg1coh3Lm+aHyjl3rlz7aL3iqEwLcUGODq228NVIOT 1FdhHPcqPL6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="382300368" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga003.jf.intel.com with ESMTP; 14 Apr 2021 02:24:56 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 14 Apr 2021 02:24:55 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 14 Apr 2021 02:24:55 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 14 Apr 2021 02:24:55 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 14 Apr 2021 02:24:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k+0kUsJEfTOXpieVGXoF0qhBGO/C9xjxZb9MoKy08tRZ9i6cJ9V3Y65rMVxTyIwAuLQg9co9ymimbAknxiMj9N+fbhr7BrXyyv19KPukSQ6ZF4zeBazm4Q7BT4n21OVQLvSoMoydlx8ZPxAWBNrpF8dnJ19LWkDT+wC4yhHvFq2dGWZnD7bV0fGFbpm/5U07oZpTkQEE3mj9KtTIxPA+guFzQfRZ/h2iwTUySs6ivUshCdw4QzlU3ZpTeAe6N25W/shzZ0IokwylVvAeLEILX806EUO22rC1g+PCajbWhOYcphyyHvD98HA8RgbKfFmtCMwwUzVK8CbXDHeJZVuzSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y5hpPZEOOewVJF9wcF+mMyICkrPtmeUbE2bMwVwBHTM=; b=Eh+Ezvca9sHdwCOLoPwS92+txFEFJ0zK5qobQ42jGr34/helqYfjbuhIm1TVsOhKO+57heGZzkq1mwLGTVhDYzWlEVCm6n9pSKjRiiHE81JPVgjNmT8sZd1r8heUKalNxh7i4SlYyXU8PYMabp5sBpVPIzrb+KXntpViTQhD7f+Mcbp/doa1a4M4B9tzyQ5xyl6D+gv9T80SNqGH0IeRYO/6yqKhnooAniw9IQV0cnLXnneEsvmMIVa7coI0E7f0V3idUKXwpPjtuliJ2uVD5C6HxajF1OsUd16Rb6l530vgatF4mGZd34kCuhZhSp8BhW/21syga0lgZUhWJHX17g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y5hpPZEOOewVJF9wcF+mMyICkrPtmeUbE2bMwVwBHTM=; b=G5YVruDaVIQEvAa87gIMsUuO5zMhdvKkwlzpgC+nUFgsB01ZA2e7O+hlWyFs1rcmX7q9IYROIDkLSJPNrSWmT+LdUbp6VFIygOuk0xinFvvfq5VMQK6XPOQ07kU17nQxAjkGEzYUI/cgnpCv3gBJh7f5v64Engh4fP120NdpoiU= Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by BYAPR11MB2981.namprd11.prod.outlook.com (2603:10b6:a03:83::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.21; Wed, 14 Apr 2021 09:24:51 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::ed18:33:3d2b:36d0]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::ed18:33:3d2b:36d0%6]) with mapi id 15.20.4042.016; Wed, 14 Apr 2021 09:24:51 +0000 From: "Pattan, Reshma" To: "Burakov, Anatoly" , "dev@dpdk.org" CC: "Hunt, David" Thread-Topic: [PATCH] power: fix resource leak Thread-Index: AQHXMF+k2MKVjTvRl0G13s2z8svcnKqzvs0g Date: Wed, 14 Apr 2021 09:24:51 +0000 Message-ID: References: <20210413122208.101057-1-anatoly.burakov@intel.com> In-Reply-To: <20210413122208.101057-1-anatoly.burakov@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [93.107.9.168] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5351d11a-da3f-40bb-dd6e-08d8ff2727f5 x-ms-traffictypediagnostic: BYAPR11MB2981: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gHK2pG9EhO5ynFo5Gx284coQY81DP4RoijXVq+1CXpIFA8Mby2/A9GpnVzwSRHhwwCSWYePnU+KqPy7tiCVDq7+vosRWk3jm7NrB0ryKsGEyIVdvsZmCnw+g7HGZhPZEX2nUPogPw5S/0BMloqaRLCYb2Po0am2aapNnJlre3cyvouJerPtLnenUmvAtu3z+U6Aet9L6SVGeQqzDiiveWUt4M5Ht4TTBEYbKd59d+bvteBzNtiR0BzcO+t9tMr5BpvPeDqQ2zORcBin1vrZoAlKqJfBAB2hvTaMYGmcCMBOSox9d0qMWitzEr0qw8t/xZodJ6Zh0SFHOLmQXvSjn0rOIpQP9pLgJbAWECbK+YsWWWwPkXS3hpuKtJWGB2pUbNrTrataCZtWDhYAX4G03i8L8bk4eXGjzVt0FeKQheqOQlVzJJSPNy2Zuk8iTErTn6KbhXY0njvSaNOXsmMqPEBLo+Ck0n6yEXbjkeBlzrqMds1p8qUekwB5WoXDDpDmjofXbNNf58cvCBMUj1Qdu9xk6cSNsV7HHhjP6ZEERVNE3UG/gkas3/wDf7nkXTQuvBpPZxTEEi9GMZTs0roRplJ0ruj7x2/8huHzHRx94Prg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(39860400002)(346002)(376002)(366004)(136003)(478600001)(8936002)(186003)(38100700002)(5660300002)(86362001)(122000001)(4326008)(76116006)(66446008)(107886003)(83380400001)(71200400001)(2906002)(33656002)(316002)(6506007)(26005)(110136005)(9686003)(64756008)(7696005)(66946007)(52536014)(55016002)(8676002)(66556008)(558084003)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?1b/eJOvZcYT4KYmlDehj5iKClLee2lf2fBLGnBAlY2pdqbyEe1yCO4GZjEWF?= =?us-ascii?Q?qru9PUZZyJ2IXYBm9ZVdktfqLEuKIGqKB/6ypz78VZFASWCulzFjaYsGg/DY?= =?us-ascii?Q?FB9Homx8ZJu6QWFBkvc3v48KNEngu5teHeQ8sn5uXKfbzDFDA3jBhc3HtGED?= =?us-ascii?Q?+9An0lI1x+MM7X0OrAy5yIrqmKZFXaJtfr2PayJRiBAkN5sZKpdpN7AfnYED?= =?us-ascii?Q?wxGUEvXTeBe3OEPOpamsv5g1jop+zopGvF6pHOSgtp8aIDj+5v+tKr0OwMpK?= =?us-ascii?Q?EOBhVOEnSaTTRChmP61MuMqit1xCl+uLKCJ7/5sdg+YWXV+Q+jG9/VjmqQDq?= =?us-ascii?Q?Y4okJIXwqOqc0ODZ33U9GxergOdMzE0efLR91F6dA85WQTEcvLD4yZwU9NsF?= =?us-ascii?Q?eUyAOn9LO90OrAk4VLBWckMyBcXIwsUBZJDuoas+5ubch954s8a6DsV3ADcu?= =?us-ascii?Q?+PdDexWhGFZeWRjQKR+8mMJF8Tz4qosi57jfnRyK4ReA6KkRfMWHNnuFJ97f?= =?us-ascii?Q?ecKvYBctu2Xtw+5VVgGWzFfiTcbieItHOM0i/BWwI/KN0xRlbRSVJZHK7whu?= =?us-ascii?Q?bwfyKdn1uy9lIf/Zq65POxWZHgc4+CdPIdUdsTnfyMKBRHMn+/uB6OOxNITt?= =?us-ascii?Q?UAGDvHBbs9WwxajMlmOtkKUaAPnBUCyUFqQZPLT02aARLGz9RXHcDg0a6399?= =?us-ascii?Q?OwTaf3SxLE8GCls3FRaFXB43NJvikCV8KDhmbJ+SSQ9Txjx6nFDSVtyUNXMB?= =?us-ascii?Q?WtfYeLHY4vMoLsfyPATicjihk4C3/jB+g0MdWbVe2kaBVaZdpA9oH3Ej/aEa?= =?us-ascii?Q?fcFCcQurGwtdKjNEr4Qu2M/i65YwKULH+gDnsE1U2xrmAnSOjB9TSsJ1LyPx?= =?us-ascii?Q?Wye4z84xbYoNue1bJuDs9dUb33neT6oIZoaQrmbNF5Uk8YL1z6NnUgy2xI0Z?= =?us-ascii?Q?Op+4yZFRc46oCXJfUPyE6Ko5acAHvrbditwUUjUiEgsksTeJeXoSF5pdUeqD?= =?us-ascii?Q?7CCDQuqvsH6dxOdq52u8p3Uu4GZ3MhHj4TQWA5qNbUJ1XTQ07o2vl7mhTPCU?= =?us-ascii?Q?uaMttXtJmxeXQ8H78dDnfiV2xmduG9TMECJRqvIQunPy4hNYp0I9x0xdMH+G?= =?us-ascii?Q?E4GQleDchFMV65V8H38yx13n4XjpVoHi3adaK77JewVMiWa+EfVMCa3GVVJR?= =?us-ascii?Q?B2wx4Eu/hThiKW/IQZzGg0/SMeSY2KJRXurhFLMHhoGw9LlK2OxXEnuUxKIi?= =?us-ascii?Q?oqqAG47vBfO9KZoiB7HxMBb5ouhJ3zaZY4FY3AIilEjGJXMDwWSEAqPB/Jfb?= =?us-ascii?Q?sys=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5351d11a-da3f-40bb-dd6e-08d8ff2727f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2021 09:24:51.0907 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LC70/u7iRUlOZJAJu5Nr4JorsBsGtn/hHfh7lpEb/SIZotz9WNr21S1OxP8vjiyG0OMnzWj8x7vUafcR3WdNNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2981 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] power: fix resource leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Burakov, Anatoly > base_max_ratio =3D > strtoul(buf_base, NULL, > POWER_CONVERT_TO_DECIMAL) > / BUS_FREQ; > + /* not needed any more */ > + fclose(f_base_max); > + f_base_max =3D NULL; Should this be moved before FOPS_OR_NULL_GOTO() call ?