From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05F3CA00C4; Wed, 12 Oct 2022 14:25:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4477B43059; Wed, 12 Oct 2022 14:25:31 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id A143942EF7 for ; Wed, 12 Oct 2022 14:25:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665577527; x=1697113527; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gGlhKJUa8Hl+pCBYARVHYDJOHqQ6Se9boz1wYkaemVM=; b=doSAfPmx8oX/j0GceSgkJvD2fx5dF6gxuDmFtrnH+9PoRCPF6FhCM66M FVYpCZwJbBfUhMOfQcOGfl6WS82eCbf5Z6wMyJyes9JKNV4eKsOZm/NcX 2bjybIZQxZANONCAoy+cNDKEWSO8Wg4KlNkC5nbKcw4BzcRA494Y8ebMo zYHLktAVOB3VzU7tR4iuYJ4jQLpZ0ZGZ2stZdoEhe8TD9sINT/qR2yykL s0TVqwla3g4kDokWzv90UayF6Trb8AV8TtFF7e44ma42XUt0uDMlPgjTl XXM2B1wIdaHuy9zhg4+WE87rnxxc4JlIJc3LeRgzc+TNOxIC2+9weO5RS Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="368946132" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="368946132" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 05:25:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="657753721" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="657753721" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 12 Oct 2022 05:25:26 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 05:25:26 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 12 Oct 2022 05:25:26 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 12 Oct 2022 05:25:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jAaUpjQkkZu2bkrjN8PEQuoIz8bVA7VR3VxiU4pedpXtpu759S6rFrJTYXyGcxTVprqF+1cam4Nw4MhmdqKpaDcLJ6JNt75tU0SgoPiOurkeuFkJ8OMDys9M/drDEHcZgqQkCkN0i/P8/e/cUunUmNv6aVQQXF4gYcdxHRGV8cWE9wHAm4XhxsIhx/e8f8R4agHCitkmQaxmP/xBSNfHbvR9IamduM4wUKM3n8S10mX1hX93rUJoKcQ+9r9oTApkSYvqcu0UCA/khe8+q3g0+ksELwCW3gn3bko7Zi2560eE0sNoODUoLzj/WwZX3dl3Ux+D8G4gUw6rUKtIHyGEAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JQ7h50vrSxJyaX7E5I5/wVJQQYbjjA7BgMMtj+E1bFM=; b=VIU3oJB0/WQRgg3/nBvUsrar53q59UOvKK6tICDoNWKTbw3pK8b7RRIideYXP/nMyqF1gqJedeAc95ELgJEZA3XNBVZVZTCqkklU7jSPGk/lnoshGs/JiT5zeR6iPOdnqOJ4IWAKBYe0F7bjElr2mUP+lbszbrsvo03PGkSJzKcyOY9naDp8BVh5DScCw0t81grMZ9oQfUQxIwsG3Kwc/CZUwbNtocy0xZc+WF2d+yUzYL99x6sykaz3QC5Pr+Mr3ciN7ixxyfeQd4cz1zZYK34/61nFcu5TlH3h+xaoz+vl0w6s3+HTf401HdtN4OFXAmKlmmLOlZ3FaDLXm+u65A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 12:25:23 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::e7bb:69c6:ff4f:1d84]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::e7bb:69c6:ff4f:1d84%4]) with mapi id 15.20.5676.032; Wed, 12 Oct 2022 12:25:22 +0000 From: "Pattan, Reshma" To: Markus Theil , "Hunt, David" CC: "dev@dpdk.org" , "Theil, Markus" Subject: RE: [PATCH] power: fix pstate number parsing Thread-Topic: [PATCH] power: fix pstate number parsing Thread-Index: AQHY3i6JcMc42lmt2UmxxgsT1nZcfK4Krgxg Date: Wed, 12 Oct 2022 12:25:22 +0000 Message-ID: References: <20221012113342.7931-1-markus.theil@tu-ilmenau.de> In-Reply-To: <20221012113342.7931-1-markus.theil@tu-ilmenau.de> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3366:EE_|BN9PR11MB5276:EE_ x-ms-office365-filtering-correlation-id: 3af3a6a6-d26d-4bfc-d4e8-08daac4cd57c x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NJj/0jkz7acaAnLm+knC2Bg3qtTo42C18a4sptczG1vOmWfWHF+d3KXBo7yUpheyAL0vs16fqVhazTvvcm5O47Lw4F6NkZoWgJXqJ/C45q9sxC0nDgETtktzcOA7y6iutDrvyGPHwkOs+Z2f5zzGth7Fu2VUrqg9o2iUW/PcPwFSGHQnlY5Mxa+CCgyZmr55V9wNbLrGcq2YVz0D+dfO72EqIMiVoiEQ8z0oQ5Y9ccpLcUUncWv/wchmnrA3YnNDlc/FgD92IWFUvnbinlhX7fKddotVQlDVZ86CsXy48SN8J3I48WCRd9NG9Cz0wFOionNb2ugLdXrNk39oNdsjccBoa7cOL9HFlQHyz1b1SNlA6EGpwuV1kkaNZqwy2t2QGY4yGs+rQSoYGX4cZeeFHQfQ7ww7ozgNONeiI56/aKWlW8TSfcsFHZA+ceBFEZL2yRhdqkcYBSp2Lggnht36uqTlQ2IW2VLEa8kJudJ64iUkJzIuFbnO/vbiIOQWMIhl6RpufMJoCu/R13LhLdR8Gk8wi9XJRYt+wp34pTgcfI0stydvmb2IMdumMbmpWTtYd821fnUEfrlW5sIuca8O6CJPmX91GApc2gF4a805nOD2DwtRIi8dG7WFr0N3ruHEEy7KwEnzi+D4FypbcBzCKvbDek36mEI9DgFN3PQ2Qs6+rda3qrswCA2UbK/hBOSjA6pkYJxe9/iHrVG9b2aB/OnMALxAiKa+Yi79xGBtj3prVgUUVw7Be0t7e8kZwMETa9J0syHC74CupugZ2U0CZQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(346002)(366004)(396003)(39860400002)(376002)(451199015)(66556008)(76116006)(64756008)(66476007)(66946007)(66446008)(4326008)(122000001)(8676002)(186003)(2906002)(33656002)(86362001)(52536014)(9686003)(7696005)(83380400001)(41300700001)(4744005)(5660300002)(55016003)(6506007)(8936002)(71200400001)(38070700005)(6636002)(110136005)(54906003)(82960400001)(316002)(38100700002)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DHYfk6TETyrEi6X+QF0eIJjmZNMgll3h+tKzb7tAC9mO+tvfXaXOCYIxALqR?= =?us-ascii?Q?b11HQHIWXUKXx0agQquUiut7KE3nAOWhckWjA1FzMjF5oJuuVjboC+92xUws?= =?us-ascii?Q?CivJBX4KjZYupVs5Z884nS2Er7w/sbYFZOoiuF0LDoegL0IPs7x+1bfdJBIv?= =?us-ascii?Q?0kssFYQFYAgYQvG3pbHZk9j12IvOARpRqkux+V8c+qqPzRmHCBWcJuk3+G9F?= =?us-ascii?Q?oKKrZy9VrxdwAAiZ2n5SRPl9G0ibQ1Ukfi4GMOqDCMlnNnBou6G9QxGtViu5?= =?us-ascii?Q?ktZtGWvKy7kjNDb+gBZ+g5eggIMW7wgDEe+RF47UFRGqTDbNmpE8P24hTXkS?= =?us-ascii?Q?6Z4rTLFZxHEMEQ58WdxqKo8rCKOSR7H/D+wOUo9i0CM3xghZmgTbACuA/JEZ?= =?us-ascii?Q?0PVnt5PORnzabQNHIBIJmeaAEeubgqyAnhrmwutlwFhKZJbGztq5PmtHyov9?= =?us-ascii?Q?9nQ9kxqs/SVjo1FSh7ytkx4aVS7wimNAsSAcwVSD5bbjD78XX4ieqHzHkvdT?= =?us-ascii?Q?amY+Js3J3qmhxu75JP6/c5A5AJKpLRAa0GTqDLyPUpwFoIMk4qHybzcQDMZ5?= =?us-ascii?Q?yWQRmqQ1GgOgD0YXF00hCbJ/P/SjFqxLTp7GMxYqi95Dbufwh6hjPviMvZ8o?= =?us-ascii?Q?WqxGhuFZgCx8b8IE+EiHGrkyQgv5HBt6dShrdtQzmaPA1DmeHDSfZbwKmLRb?= =?us-ascii?Q?vI0rUFPgYRBrFIOzVYViTJtfocnDGaG75osHwYSgCHEn1G6P/1Q3VvzZ4qju?= =?us-ascii?Q?dFior7B9Ux8wwcfJZjPbo/hguk+FJsXzfbCWV3bAE03Gsq94x7gRLeygQkVz?= =?us-ascii?Q?mXpRlHrhtiq+kjisYB4/W8AUFouZPWtq0epNuhaaOxycJQnjMTWgGg0KMWBT?= =?us-ascii?Q?X++zR0h0to0oUNg2JG23Ck9BmczPprNAZ85bFc5DzViZmvfwNTNo+cbJdpOa?= =?us-ascii?Q?EDVRuzVpMjLVXrf2BsgbMO/ApvyzXwbbE04BWRuxjjChqmGCjtDSVXOoFuFS?= =?us-ascii?Q?yTUtWcFEkytjKYV8puRxRwxY5G7HEwrMUsoBvg5tUd2izL75CGVGtn5tyoWU?= =?us-ascii?Q?8tizSyN6rSnAWczObJyAQXSz0EfPxc2fNQpTe3rjNSOc7IyAqS3UZYHS7dXa?= =?us-ascii?Q?EswjSPsBJA7a7epefbLpGq/rBEaiNzQl//zmd96/KDR4xddqrTHkEv0CNr8H?= =?us-ascii?Q?jCVJUOxrz+C2Z1pMoiafGX75uZGqq1wUBhu/ntz69WlDm6THuNt1rjMOpXfu?= =?us-ascii?Q?epZoohpJ0wni2r5mOKUxMSq9wPnR1LvkrWBdxvTUvU7EpNVxWeWASj86/d/h?= =?us-ascii?Q?jhRoBvjU4Ka3UViarSZ0Gce7eCt7FEnTief1jUX2gaClS+6D1uxP7Et08hBZ?= =?us-ascii?Q?rWvaNb8XoRR2HYnnB6gDq2aCvKXJtLB1QKIR0gdodhh3IXRSAuZm4NVZfdLa?= =?us-ascii?Q?SZMwusWJDp8G4m3oG+ZIAbNmTaFj3GWzhnggWiRun4Fq59SwKxwNhPlzKuc8?= =?us-ascii?Q?D8Nz4UhXxACqXAWftoKBnEAr8m+JnhZi+Ead2RpXRARfjIRliHG050/xtJLV?= =?us-ascii?Q?hZKRM3oQB0NXg2AlNsYYi6zkT5t9qHM+9i/CMN6EPS9ZWH82k/k54CUvljmr?= =?us-ascii?Q?IJWj15V8UWSKI/L8G65b4Z6HrNyPQaUwMfBjIk/FOgQd?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3af3a6a6-d26d-4bfc-d4e8-08daac4cd57c X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 12:25:22.5253 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VBX1q6lPremvEA0+5vgX6bF7UOeblQsIjFL0ElDlhhXmWWghS2YTs3rN6S9qjGOpuOPSbXczBXjNjrclkzLtPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5276 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Markus Theil > +#include This is not needed right. > #include > #include > #include > @@ -96,7 +97,7 @@ power_read_turbo_pct(uint64_t *outVal) >=20 > errno =3D 0; > *outVal =3D (uint64_t) strtol(val, &endptr, 10); > - if (*endptr !=3D 0 || errno !=3D 0) { > + if (errno !=3D 0 || (*endptr !=3D 0 && *endptr !=3D '\n')) { I encountered today that power library initialization failed and the reason= is this \n check.=20 This fix fixes the issue. So if you are sending the next version be removing the above mentioned head= er file, please keep my Review and Ack tags in next version. Reviewed-by: Reshma Pattan Acked-by: Reshma Pattan