DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Troy, Rebecca" <rebecca.troy@intel.com>
To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Power, Ciara" <ciara.power@intel.com>,
	"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	"Doherty, Declan" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v5] cryptodev: add telemetry callbacks
Date: Tue, 26 Oct 2021 08:22:53 +0000
Message-ID: <BYAPR11MB3399AF91C89B9FDA7D69A97C80849@BYAPR11MB3399.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB44849992C00D4BF8BC912FA2D8839@CO6PR18MB4484.namprd18.prod.outlook.com>

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Monday 25 October 2021 05:32
> To: Troy, Rebecca <rebecca.troy@intel.com>; dev@dpdk.org
> Cc: Power, Ciara <ciara.power@intel.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>; Doherty, Declan <declan.doherty@intel.com>
> Subject: RE: [EXT] [PATCH v5] cryptodev: add telemetry callbacks
> 
> > ---
> > v5:
> >  - Added missing telemetry dependency to meson.build.
> > v4:
> >   - Corrected doc heading underline and link.
> >   - Replaced remaining -1 return values with -EINVAL.
> 
> 
> > +
> > +static int
> > +cryptodev_handle_dev_list(const char *cmd __rte_unused,
> > +		const char *params __rte_unused,
> > +		struct rte_tel_data *d)
> > +{
> > +	int dev_id;
> > +
> > +	if (rte_cryptodev_count() < 1)
> > +		return -1;
> 
> EINVAL missed here.
> 

Good catch, thanks! Will fix now.

  reply	other threads:[~2021-10-26  8:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 10:21 [dpdk-dev] [PATCH] " Rebecca Troy
2021-08-20 12:59 ` Zhang, Roy Fan
2021-09-28 10:47 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-09-28 10:48 ` Akhil Goyal
2021-09-29  5:14 ` Gowrishankar Muthukrishnan
2021-09-29  7:51   ` Bruce Richardson
2021-10-07 10:17 ` [dpdk-dev] " Rebecca Troy
2021-10-07 14:11   ` [dpdk-dev] [PATCH v3] " Rebecca Troy
2021-10-12 14:30     ` Power, Ciara
2021-10-13 10:22     ` [dpdk-dev] [PATCH v4] " Rebecca Troy
2021-10-13 10:57       ` Power, Ciara
2021-10-13 12:15       ` Tal Shnaiderman
2021-10-13 15:22       ` [dpdk-dev] [PATCH v5] " Rebecca Troy
2021-10-13 16:08         ` Bruce Richardson
2021-10-25  4:32         ` [dpdk-dev] [EXT] " Akhil Goyal
2021-10-26  8:22           ` Troy, Rebecca [this message]
2021-10-26 12:00         ` [dpdk-dev] [PATCH v6] " Rebecca Troy
2021-10-26 14:37           ` [dpdk-dev] [EXT] " Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB3399AF91C89B9FDA7D69A97C80849@BYAPR11MB3399.namprd11.prod.outlook.com \
    --to=rebecca.troy@intel.com \
    --cc=ciara.power@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git