From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BDD4A0C47; Tue, 26 Oct 2021 10:23:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E1F540E0F; Tue, 26 Oct 2021 10:23:25 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id F323740A4B for ; Tue, 26 Oct 2021 10:23:22 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10148"; a="230128921" X-IronPort-AV: E=Sophos;i="5.87,182,1631602800"; d="scan'208";a="230128921" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 01:23:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,182,1631602800"; d="scan'208";a="497202015" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 26 Oct 2021 01:23:21 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 01:23:21 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 01:23:20 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 26 Oct 2021 01:23:20 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 26 Oct 2021 01:22:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z/hRAOVAepbmwZ2guOo7YHSLLoTJxznNNQceNICbhKYk7kf4JLqJho1ikrjJUlu8RcBBRs6W/++Yi5bxy72Gi0gb3TCWuspzq2tRoUag7q7eMDzBGDGh1arwVlV//6CNUCfUHkDngWV8hOgZmVr+EErEOLzgiYf9t5nSMIJYhIZtN+nbH+1dZCkWamYYHCa+Jyzb8Lo+NzkCsKbx55B9IzrUYSxAJqp/qc3upWtaG+Cl47OQCWJx4CXZkOOH1cJlZaeNKFV8XMojn6AGQhluaCaKo4xfEHP4iHXy44MlTw3T/eQ8OX7OZbgxuXA5rEtlP+8AkZn/U0vNSzk0GL88WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mBtoOqAvnEcu/joS6aQ6QHeGjba43Gd6N5Nd8V1qQlg=; b=IDIFp0lmlunNtGLgQ1V1qLpIDRV5v052HbrRjsU8Ksnb8ubic2LJ8WTn8/rfQD2JZ9DLm5Az5hGgYurmtrMlqOxBYqpwIZMLlpFjTbGHRiFzqqu60asNaEPrdDU0nhsLcD8kPuv5qiAbUefABljJWItX1zJ0HXR9L/pwNGy+padDIREKpTSbVXW6M6Us/SZ0eOZnutZb7W0nZF0tFxK4WTCFVdd0pMxYRd1+uXTIGzpvvFy6Ml8ODRYTjhn2jWgW5gKsZs4tVbdUHFtNdgTHbwlG9KFrg/VeF4Mz9XiuasXXVhb3X7cREW1X3LtUgumN7mCvrq0QEOxkwPEsPAzPqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mBtoOqAvnEcu/joS6aQ6QHeGjba43Gd6N5Nd8V1qQlg=; b=bWhxan30lhjomgEjPpTwBKlkFpKedsToQNxXfPvRI3KPCJPmj5WHr+5b9AM+P+qs1PfcKyUn6orbkOYonhfAJO3nbOSYUc4S8dXRWghrCDigCu7+1CAl7gmPTTitJvpOxra/1h8q+RZdkTPCHu9AcjOllbu0HHV+EvxPux1leaI= Received: from BYAPR11MB3399.namprd11.prod.outlook.com (2603:10b6:a03:79::15) by SJ0PR11MB5200.namprd11.prod.outlook.com (2603:10b6:a03:2df::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Tue, 26 Oct 2021 08:22:54 +0000 Received: from BYAPR11MB3399.namprd11.prod.outlook.com ([fe80::2d17:a4c8:8edc:713e]) by BYAPR11MB3399.namprd11.prod.outlook.com ([fe80::2d17:a4c8:8edc:713e%4]) with mapi id 15.20.4628.020; Tue, 26 Oct 2021 08:22:53 +0000 From: "Troy, Rebecca" To: Akhil Goyal , "dev@dpdk.org" CC: "Power, Ciara" , "Zhang, Roy Fan" , "Doherty, Declan" Thread-Topic: [EXT] [PATCH v5] cryptodev: add telemetry callbacks Thread-Index: AQHXwEYgvjWVsX+u5kaIQWglTjdqc6vjMg2AgAHRuOA= Date: Tue, 26 Oct 2021 08:22:53 +0000 Message-ID: References: <20211013102214.108814-1-rebecca.troy@intel.com> <20211013152206.148589-1-rebecca.troy@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9d00d9f3-84d4-44ea-61e8-08d99859ced7 x-ms-traffictypediagnostic: SJ0PR11MB5200: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UDC0Agdhytm4dmfSVI2+QU4XX63KMEpswRkJydirRer7W/o/aF/l18Bg3E6RDParZhY4WPmPhs92OFR+eCM+ubGgo5kR4m9b7fEbnyo/nlg0iCoAwILTJfxaYNhCuKf/xhq/WmMuX6WbL2HoWJVxqQHuSFcKwAIv4ZKAEoCJi6GkqUo6R05LgRqH/zxVUACgfnQXFWJe1jn/5oeVtMzu+SZFaMUc4BbWY/MqEkSJOMfLGHaTcKMcfxtJABRqAjP48XumfW2U8aaTGMGpGdORIaJjJn///TKHkM5jrTNT7mI9+jNkkCD363SPEwPAz/rYGgtR/05fL1d5r4FSsMmYqAjbDjyL1HNZrDM2P3M8knnmebTewxfqxpYTuHlttpFJ6E69Vbmes0MjWp6xn/Vpk2jfPQ+mS8V8jAIWiC582PKWYjvPMEqFg2kadDQSsdb/GIEQ7id38NXvMfKCmLYhdzLnPSZTQ6MTJdRbQKNvEmabPwwxuBan7nQWFoFYKeTNCCmK2QFr1COBXU1aXN+UZv0W7IiAFr/+nFLl4FlEsFWzE4tS9NZT2fMYK/kE391MMY/DGepNBeYfmPrWNWuwuX/6gebkdkwd9gNSeTyY+/ADvPSy8s10Qa23QcThJzSNtFrp7E0b8TW/89a17W9lvcq6kl0HrXz1pWY6HIA47mUyPYhnB4zT7plyRoQmE3jpJyxq4u0UzZ/Ko9wdap1dUQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3399.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(86362001)(122000001)(33656002)(71200400001)(38070700005)(186003)(26005)(9686003)(4326008)(7696005)(82960400001)(107886003)(508600001)(8936002)(66946007)(76116006)(38100700002)(4744005)(83380400001)(8676002)(52536014)(53546011)(2906002)(6506007)(5660300002)(66446008)(316002)(110136005)(64756008)(55016002)(66556008)(66476007)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dx3ZZQRhkT/fYrkL0lWgaywVg7FyNbLE5aTV4t8mU4GQ8lQPhpDoH9GIDhZr?= =?us-ascii?Q?BXQKNFx/X+VNRUIjqUmWS8XofHo+3juzUnB4chPrcqNgDO35efQn1UJ3PNhM?= =?us-ascii?Q?BKI+SuORxeko4uJOp3N5zZS7dYN5mdTgGkFqEnjNXIytawX4baVPDng8ds2S?= =?us-ascii?Q?S1is1hVYcJuWSe3JurvtbkvcMI+ytRRfFerQu8nOuuWntiU2URmIYeE0p0yW?= =?us-ascii?Q?f3PlKt+EMZAY1ny0yz/SY91t3MPY7pzZMOIl5H+QtGqVWfuhcQXufjFjcnKL?= =?us-ascii?Q?98JYr8eu89GG/k96bn2XP1Tg6Jxp290lsxLDm4bBayPTroGYgCkloGScqLrH?= =?us-ascii?Q?s4VZ9CSc1BcZkK4KbVcpJURU5LShETMe8CzjgHAYUitz+Yd38dGbdhAVnNB+?= =?us-ascii?Q?f2Uxjlf4R1I8bdSeYLh8SI7jCQqWuD97935FAS0uWx9CTCh9EOiWeFAr9pgk?= =?us-ascii?Q?DT1nHV7qPxuDVAPhdPjXCsGIjZKEqjsAC8IJIwG/FoWitDwEvDeyYRQN3vU/?= =?us-ascii?Q?Hnweq7pGN4Y0+niroeTJ0iVJqHPHPr/XE7zE9PRQZgWEBI5hSKlSMeoK9agg?= =?us-ascii?Q?+Fb0P50yg4lG7HwrQz4IIolrS90R6VBgktSj+/PdbHuErnRr7K5wsw5OK83h?= =?us-ascii?Q?7j/D+Ca+XQRwuE/lyES7kRqXTp790U8vGhwfu+L9VgZfsenK5yfGCOuImmQ4?= =?us-ascii?Q?jYAf4Mcl/gMVO9aXvmLVkpqkEcv6dKOUl4hKmufySm588TNXKIpEaFyzyHoK?= =?us-ascii?Q?DwoMmh/cSh+rEuqiTb/yBQJiOuAzIswZvLcel1LeMVNy6QkpJaIEYv4xXEGe?= =?us-ascii?Q?dsNJ2BjTPejq4LnnPqJJtn/9sJG2J3C4BtgmFKzoH+GFsj+atfHrVRYC1ZtD?= =?us-ascii?Q?2Edm5qaRBVmY7X7kNrknNrzEVZbOCjVsk0qlskbxd7kZK73WaTuEp6UKIk+b?= =?us-ascii?Q?t/EXRl1eh4IR66aMDRVj2ylJqReJshVibuqANgK/B+cLFBYAsboHJfmvXycQ?= =?us-ascii?Q?0cTrbJ2DuL1NnKtnWO7XCuHI/7dwOJpcHq/hH196zKf9tATS70xcz9w/9P2T?= =?us-ascii?Q?8ZZmtO1ogoa+Eh9oeKvXg2O04xa1/yr5F3lKI6dZbgP7dsVVzde7ZoAeGvyy?= =?us-ascii?Q?3KxjwiQ4pQMAgLM1PmAukyE0057ng731J7NUUu/ChXlVWTsl6W4pCqpdlWBg?= =?us-ascii?Q?pxoooy7D5VFuOLlMCzHw3uGUjc2mHwrz3EiAuW/ujJ01bgA2W2D4tCQ64vxO?= =?us-ascii?Q?IRQcCqwQAK5UclMA8+gFQxxunp5NVow/I4cQIgJAoWX/5jh7bdNTJCtIBFAl?= =?us-ascii?Q?KsP6tVvB1cLurHKzxbw9XQIO+HXyzAR6BjhFd9c2mR2A5Yhmi+BWMMAUmKLQ?= =?us-ascii?Q?Kfz8h4lidF7qEl277ZavYeq2AQaTBKFBEkztbdAo7O2vx1EAUO+AdUGZL8q3?= =?us-ascii?Q?i1kigy2jI5whmVaLru2XOYBgu0koKISjQlEIrIaiRL4Sm67Fh3/DODd8HH9o?= =?us-ascii?Q?pCAgLAYl58yskaPLe+Q7ffY7QSm5s4F+ASaR8czt3ISr5hfx4ZrxXvGxCoOf?= =?us-ascii?Q?dNT3BnsUJxo7YIXGSWLdOw8euiLqQxUiz52CTfw1rFQpj/JqA2jxmg6iLU1D?= =?us-ascii?Q?Sfwp4wiCcVVylGedcogVti8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3399.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d00d9f3-84d4-44ea-61e8-08d99859ced7 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2021 08:22:53.8329 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qtWq2N+cB5DjGmy3rgUklLRpGOJ93CfFMoQpJ35NGDdWEpv7V1kJeIKJibRZ7xBowF3OK5IXZGvHsPDg77qwmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5200 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] [PATCH v5] cryptodev: add telemetry callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Monday 25 October 2021 05:32 > To: Troy, Rebecca ; dev@dpdk.org > Cc: Power, Ciara ; Zhang, Roy Fan > ; Doherty, Declan > Subject: RE: [EXT] [PATCH v5] cryptodev: add telemetry callbacks >=20 > > --- > > v5: > > - Added missing telemetry dependency to meson.build. > > v4: > > - Corrected doc heading underline and link. > > - Replaced remaining -1 return values with -EINVAL. >=20 >=20 > > + > > +static int > > +cryptodev_handle_dev_list(const char *cmd __rte_unused, > > + const char *params __rte_unused, > > + struct rte_tel_data *d) > > +{ > > + int dev_id; > > + > > + if (rte_cryptodev_count() < 1) > > + return -1; >=20 > EINVAL missed here. >=20 Good catch, thanks! Will fix now.