From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id C3B4AA0547;
Thu, 28 Oct 2021 13:03:24 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id CF86C41100;
Thu, 28 Oct 2021 13:03:23 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by mails.dpdk.org (Postfix) with ESMTP id CFF5440DF4
for <dev@dpdk.org>; Thu, 28 Oct 2021 13:03:20 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10150"; a="230642476"
X-IronPort-AV: E=Sophos;i="5.87,189,1631602800"; d="scan'208";a="230642476"
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
28 Oct 2021 03:41:21 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.87,189,1631602800"; d="scan'208";a="447923318"
Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19])
by orsmga003.jf.intel.com with ESMTP; 28 Oct 2021 03:41:21 -0700
Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by
ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Thu, 28 Oct 2021 03:41:21 -0700
Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by
ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Thu, 28 Oct 2021 03:41:20 -0700
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12 via Frontend Transport; Thu, 28 Oct 2021 03:41:20 -0700
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170)
by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2242.12; Thu, 28 Oct 2021 03:41:20 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=dMBkv7ACqwPJsw2SEStLLnArviDoApk9ENKeMfqbKjzzOW5+x5iim/4++vKu2w1aNAB79twArD68HwTB6y2JWNfKsxRwHuzuQM3t6DyTnchN7Tu7Oy/BGmZOyAI0rvCkr2OdnC7nEInyQKvlFBpZxDnWKUWuv2ijr9Uvp5I7jaMfOwvrqVVi7Z3PGTpioILiMxZRJVFpIyhPfhxSOuHvOaC1Nz6o+9lzLJ9S+bw0p150xg8ud0CUbOvCTzQ2dK4rKzpMRPGosdYa8npMrKQ3XssyxQExWy8GTwnFmsY5l4SY8C9oLlP97aCbno6yEwrCIyPAvvDTwbWBq8ApRcVvhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=IN6lsS2L5kQ0FRO4BF9aB81ak1BC3KTps1szUQ9z8sU=;
b=CK8ogTUX+81BZPta6HVXzZduPF4DM/mPf3aRXeQM/k1cyHekQDlnBFupBXH29dLgsjiWP8WZjHL+pcr1BLMV0RliP2BKX1krbLlVZZCHzRw3K3FGpg98ghmbElXyBAC+bLSa/wqW/Bwz3RoX+DQVnEHLZBgmuPsS8DcLwb0Al7plab8gSPMAJ5iMeSRQcqBlyTugPgrLSD3KrkUeQk3EOK4MyaHDZVgcNzhDod+QBMwu0NHpR7CKSHjjzPZK5JDHh38iejDn9wWenomV3pXP8JKhHkU11IqGDozY5mg24KtHhTSauuDIfAzqkTWEV57DHfRJkRjiMH4LGV3XbPOK7Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=IN6lsS2L5kQ0FRO4BF9aB81ak1BC3KTps1szUQ9z8sU=;
b=pAqsr3EDNG1NUK630QH68lsluo8MdXjOjDesZxLNvC0lxNiK9EwOD8lGNZpnXTYAkW/cwyF7Nwg2xO+qr0ENziLwXiTIcKQuEweDwmnSzmfUGO2iNc0P9Rwi/WvW+nX3lAv0Gyv6cXKSCfl/SW7LwoG7OJPX9Xf63NUNHgz7bks=
Received: from BYAPR11MB3399.namprd11.prod.outlook.com (2603:10b6:a03:79::15)
by BY5PR11MB3910.namprd11.prod.outlook.com (2603:10b6:a03:185::13)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13; Thu, 28 Oct
2021 10:41:19 +0000
Received: from BYAPR11MB3399.namprd11.prod.outlook.com
([fe80::2d17:a4c8:8edc:713e]) by BYAPR11MB3399.namprd11.prod.outlook.com
([fe80::2d17:a4c8:8edc:713e%4]) with mapi id 15.20.4628.020; Thu, 28 Oct 2021
10:41:19 +0000
From: "Troy, Rebecca" <rebecca.troy@intel.com>
To: "Coyle, David" <david.coyle@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>, "Power, Ciara"
<ciara.power@intel.com>, "Doherty, Declan" <declan.doherty@intel.com>, "Akhil
Goyal" <gakhil@marvell.com>
Thread-Topic: [PATCH] test/crypto: refactor docsis to show hidden cases
Thread-Index: AQHXxzMGUl7M/dyzRkqBxSWc4jC2xKvoQGCAgAAAwCA=
Date: Thu, 28 Oct 2021 10:41:19 +0000
Message-ID: <BYAPR11MB3399C8469E7747486AB273A580869@BYAPR11MB3399.namprd11.prod.outlook.com>
References: <20211022105302.3652-1-rebecca.troy@intel.com>
<DM8PR11MB5575CCEBF1219E9A98C1AF40E3869@DM8PR11MB5575.namprd11.prod.outlook.com>
In-Reply-To: <DM8PR11MB5575CCEBF1219E9A98C1AF40E3869@DM8PR11MB5575.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.6.200.16
dlp-reaction: no-action
authentication-results: intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6eeb2210-114d-4664-d837-08d999ff7a24
x-ms-traffictypediagnostic: BY5PR11MB3910:
x-microsoft-antispam-prvs: <BY5PR11MB39101C5329510093E099DD3B80869@BY5PR11MB3910.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: DMDHnIX5Fegcvn3QrVyc0u48QAQznUF+yBzWVPDJTOlti1yokj6rgdvmPb4dGBeBBC3Np9TcjRGqQ+xaAuFUj1CMRsBi31HwUDOTwpVI3L9BDo5O3wJFpDlI1UMIWirOT/0CLkG7SeKBk2Ce5022LvTSkDjqS4EuQhzVtojMftPlykEXZdBZC2GtWzr2vHoGKau6u+vj699InVwDZO90xNOC0zkijkQrk2HYGSJH9GMShgjNFKmYE4GwwAVChlMqLOv9LoeG1Jrt6bGdVYBbhDjdejWdlmp21Hisp5YkC7Q+E5js6wsH/otQWgaZiAwoNUJswGQMmDXrULWGmyaXunKva/yASk/SWdav1GSNg+ZJzcETXLIjHuG19H2IErJQvdZ0ITV/j78UuABJhy5l/YxetS60roIiIWt/eq/+7YACHcRUWFzZxozbLgKB7xlKwy8pExTwWsko4GYUhUDOq2fJD65314m4q1LW7ygf9fYJMStHomqO8vDwfxuzpRaS3dNx8UxXIEUJNXBZZ4lKep6cB34hp86pEI4Tp49wO56cokV3kPcBmYhAnNFg0d5pmdUnZBP6iHVSVHjfGtlSmczul2Q94VvAxcRICbf5Yk654WyjcvT66p6klnv4fGNt2ty37u8r2Hb23dmecaKX2sPj3i7TyzO5sqKBS9+/YTdRNnKJ4YgE7XJpFnkV9/WPWDMWAjqycOG7JUuElA7VQw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:BYAPR11MB3399.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(366004)(52536014)(54906003)(82960400001)(110136005)(8676002)(122000001)(38100700002)(8936002)(4326008)(5660300002)(76116006)(6506007)(86362001)(53546011)(66556008)(26005)(66446008)(38070700005)(64756008)(66476007)(316002)(7696005)(55016002)(186003)(83380400001)(71200400001)(508600001)(2906002)(33656002)(9686003)(66946007);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AS16wRJ4nuRfiMpwrHFdXTkqIdqUXTMkC75PwLUy12L21tTxvQAkvIzldWFL?=
=?us-ascii?Q?tGr7dLRvOXMd4u0EBco2EWAPGs2LzTfeQ8TSVV50WkGr0Vh1/hAblgw4UjN+?=
=?us-ascii?Q?wHPmWprPGsIbGgt8oooDYxNe6OP1QdVKsM7BHdajHbfnHTXHeXYNLV/bomoA?=
=?us-ascii?Q?WYCKiaqR7KVn5PYksdZ7UgXOK1LoyfJaksonmg+wn/aRs9L/RAUA5qFez9Qu?=
=?us-ascii?Q?qZFev4Ej2KJ0uXuKlpu6MI9ioqmXykg+ENP/NiC2Y+tvSqLR6LMBaReygI9b?=
=?us-ascii?Q?ohO7qPRH9QZ1RpdENfkXrv4/dLc2jOHv2ExybSHwa35nXDIFddwXjcOFB2lh?=
=?us-ascii?Q?YCHBP1EMofm9NSXivUw5DG04DE3b2E9XRI45lXKJPj3dh6qMpF6e9QYjyMuZ?=
=?us-ascii?Q?I70R5XEULAGbmx1E609VBY5jgLca59Wwmg54kbKQQPte7GNRSV9k/2pBijZp?=
=?us-ascii?Q?QTF5GmkBwuzkZHNeR0UXCUY2vJrh7EmB5vImIreD2jYYzWimfz27iAqS6Rur?=
=?us-ascii?Q?RiVg0sSyBLuyJG3O44ndDvIgnWLQN32w8IxGockuRmKmBXvzueNhtXAar7LG?=
=?us-ascii?Q?UlTgsLqntL/32IKURorL7qTiNoavjivmuhvNCQTgC4dv3eGLRJ0g7B15XA/t?=
=?us-ascii?Q?DdDz2XQoyR/JjzVHhojHDjCFAR3j0sQGz/Br6yHnb6tlf9/BXcUMFxtaXucU?=
=?us-ascii?Q?1zABVEkTStkGGQY5BHC25TbNePQEQyk/2ERQBO9L4ldySrjRRvNwiAIRUgRk?=
=?us-ascii?Q?hhjpMFLhzDFdjmYpE3uHJwOG/cRbdumzB9ZAihQ/S6FmxVoWuvxjKlhNx1SQ?=
=?us-ascii?Q?paYT3SyeSs2SWdyqH8a6a0FLe0tI/k4lkC/4r+QUqPwXBL4g7od1Ns8dJc8t?=
=?us-ascii?Q?OmuCQkQEWbaTCG5ZXmewPXaH68aEM+xlGK3toWnJ0AtoFe6NlhKFpQeL6GIz?=
=?us-ascii?Q?lJbk1MdVBk+WflicBzVjLtKC6jrCnRChSIzoUu8kNrNM5GeGMBUvdfPrITrt?=
=?us-ascii?Q?4Zo05gFKQmwjUn7VEjJwQndh7Nr1ciqKR9GrGiLB040jPi8oaMtJ9l8UB16Q?=
=?us-ascii?Q?+6YznY1VsDh+Zdc6cDz1bSzi2Rij3n7dsQW5iHvxbgs1wKm5BVAYenoSRmNV?=
=?us-ascii?Q?o94chfaDXl2A76gAY3oPqLM4GsE8Ei+M+QD1m7SewCHG1rGDAHafYi7uDSmV?=
=?us-ascii?Q?r6sIv0X2mIn0HXi0xJqszEr5XVPzgsBrCPHqjnejJJ7fOuRIvA1Ke4tFBB7y?=
=?us-ascii?Q?p1CAbF+FBP1NTH1klkBdJCZ8VGo8e4C/PkHqB3+dAH7hU1bFmTXdckdcK/Yi?=
=?us-ascii?Q?WKdzG3i03+Pt2oBparwJBy8NPiooZUZjfutej3Pvf8sFrqW5RO13kw9Ja0IA?=
=?us-ascii?Q?YeU6Vh2/a4e9E6XCKlK6K3UvmhmTlfqKN9rDIvK6EhswbncKxg5s3w9pH7/0?=
=?us-ascii?Q?e/8WUusx4mFRqB7gQF2XncGVyY5J1WaEWTMl549JjNq0gfqbozrfbKXZ9Rli?=
=?us-ascii?Q?2GeVZDKlpon0K3xQsf+psF7mf5WvRmrHBuBpThHjMIl7qW1wBtRLjF7KdkWn?=
=?us-ascii?Q?bKTHFDlD0a0hfRROJYhQkx9/ApHA3f6GJTN4uj/NZM8jr/jhQDWEsWgTcfEM?=
=?us-ascii?Q?G2rV6Xk5wIp8nZ9N0GsQzgs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3399.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6eeb2210-114d-4664-d837-08d999ff7a24
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 10:41:19.2912 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xGxrUFDRuYyMuyoDX/k2QowNIzk5P11SA/r+eVEII8ZQDfTvm6x/VgGH+IhZDAvw7tXL4KcUmMaAwuk5dk3QrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3910
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH] test/crypto: refactor docsis to show hidden
cases
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> -----Original Message-----
> From: Coyle, David <david.coyle@intel.com>
> Sent: Thursday 28 October 2021 11:34
> To: Troy, Rebecca <rebecca.troy@intel.com>; dev@dpdk.org
> Cc: Power, Ciara <ciara.power@intel.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>; Akhil Goyal <gakhil@marvell.com>; Doherty,
> Declan <declan.doherty@intel.com>
> Subject: RE: [PATCH] test/crypto: refactor docsis to show hidden cases
>=20
> Hi Rebecca, see below
>=20
>=20
> > -----Original Message-----
> > From: Troy, Rebecca <rebecca.troy@intel.com>
> >
> > In the current implementation, the docsis test cases are running and
> > being reported as one test, despite the fact that multiple test cases
> > are hidden inside i.e. "test_DOCSIS_PROTO_all" runs
> > 52 test cases. Each docsis test case should be reported individually in=
stead.
>=20
> [DC] Should make "docsis" all uppercase in the commit message - "DOCSIS"
>=20
> >
> > This commit achieves this by removing the use of the
> > test_DOCSIS_PROTO_all function and statically listing the test cases
> > to run when building the test suite, which are then reported to the
> > user by description.
> >
> > Signed-off-by: Rebecca Troy <rebecca.troy@intel.com>
> > ---
> > app/test/test_cryptodev.c | 265 +++++++-----------
> > ...t_cryptodev_security_docsis_test_vectors.h | 159 +++++++++--
> > 2 files changed, 241 insertions(+), 183 deletions(-)
> >
> >
>=20
> <snip>
>=20
> > +
> > static struct unit_test_suite docsis_proto_testsuite =3D {
> > .suite_name =3D "Docsis Proto Unit Test Suite",
>=20
> [DC] Outside the specific changes of this patch, but "Docsis" should be a=
ll
> uppercase in the suite name too - "DOCSIS"... could take this opportunity=
to
> fix up this minor one
>=20
> > .setup =3D docsis_proto_testsuite_setup,
> > .unit_test_cases =3D {
> > - TEST_CASE_ST(ut_setup_security, ut_teardown,
> > - test_DOCSIS_PROTO_all),
> > + /* Uplink */
> > + ADD_UPLINK_TESTCASE(docsis_test_case_1)
> > + ADD_UPLINK_TESTCASE(docsis_test_case_2)
> > + ADD_UPLINK_TESTCASE(docsis_test_case_3)
> > + ADD_UPLINK_TESTCASE(docsis_test_case_4)
>=20
> <snip>
>=20
> >
> > -struct docsis_test_data docsis_test_case_1 =3D {
> > +const struct docsis_test_data docsis_test_case_1 =3D {
> > + .test_descr_uplink =3D {"AES-DOCSIS-BPI-128 and CRC Verify (24-byte "
> > + "frame, Small offset and runt block encryption)"},
> > + .test_descr_downlink =3D {"CRC Generate and AES-DOCSIS-BPI-128
> > (24-byte "
> > + "frame, Small offset and runt block encryption)"},
>=20
> [DC] This one is my fault when I supplied the descriptions, so apologies =
about
> this, but all the uplink descriptions should say "decryption" instead of
> "encryption"
>=20
> Also I think all the descriptions should say "Uplink" or "Downlink" at th=
e
> start.
> This can be inferred from the order of AES-DOCSIS-BPI and CRC in the
> description, but when I ran the test cases, I still had to think are thes=
e Uplink
> or Downlink tests.
> It would be much clearer if it's stated explicitly
>=20
> Regards,
> David
Great, thanks for the feedback David! Will look at implementing these chang=
es in a v2.
Thanks,
Rebecca.