From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12FD2A034C; Mon, 20 Dec 2021 08:24:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D49A9410F3; Mon, 20 Dec 2021 08:24:51 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 3AB9440395 for ; Mon, 20 Dec 2021 08:24:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639985090; x=1671521090; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Le5F2yVgQQ0xutvqyQD76tPBFz9KBGw9z/CW8BN1Rvg=; b=gPOr+XlSoNGLJARBNrEeoeNbtyPhTG5y6qoLfEPBS/vyzsvoZmxX2T1A JsR0iOY+u4y48WNucfbd5pHNITbU3c/TS2MqsrLs0eIhsvczlf0Bnm4tL 7eRYdWOK6hg2yYXrlmV6gYDt7JjsgP5o6ZXO+UsTA0bw61v18XOHEGQkO hgkUKwRxwFgvPJa6uZ1VUz8pBoif/MZjfOhPHh7OR03ka5wKJMsYVEAx4 CTJVoz++7OXD+IUNq8AZzk4JicM/FxqwELjmihIFYaFe5rIG5qdr4/n3D 5BcHbvwHCEDVNZMJcHS4WxW6xcNcT7sTKGyFmXfNvfnLOzeF5BeXe10ln w==; X-IronPort-AV: E=McAfee;i="6200,9189,10203"; a="237652463" X-IronPort-AV: E=Sophos;i="5.88,219,1635231600"; d="scan'208";a="237652463" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2021 23:24:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,219,1635231600"; d="scan'208";a="465855890" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 19 Dec 2021 23:24:45 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 19 Dec 2021 23:24:43 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sun, 19 Dec 2021 23:24:43 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 19 Dec 2021 23:24:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dAyhF9pWXHUDSse62U0PpVcDi+H/qrCMaMNVSmGZLQICi+dDGqcLlhYjlp8B+PuBK9pg7URjLdCEWKNuFdArWU9a7yfHe3vLWJ1KR/NKg8qlywXBeZ5IjTpBNwbKW+FdXRZjHBTScA07MIgQdvTKWBD2VNPm+pUQwJlC2J3WyUiX7uFBzB2Y5QGuJvsmXSgWAk0m8eRL17GxgdZukW3Ydajb7zGb13DrgkIxHGQx0nDR/RtxwRzM+KG/gHgRw6TF0vK55Xfe9iHjISXDpHznBx69lO7XBByWQpbcbwxPVfeAovNXkyj11N96Kd/fH/91T1IwqjgzWoeWpTLQp1GtfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P0x0BYKbrKdUoxye/UFH6+GT3qO+dYYzKjUWXTe01uE=; b=oS3Y8PTR90YxtB0kYfGEkCe5IPZed6DJ4BB0+15TvmSch9XvYpKXTnLOTnzotvnjUqFl3w4MJOjySu/5Dnx2C9xOB8Js+y46jx/rUVKyGjcQWgVO7+6GRsFTi0uvY/Il4nNzJuDstMcn33199IgVBDS087gpXdazUbrV2jxx4AyzCLOKrPbMbSAm0d2bvODmmwRVa/Dv0yHJNaf80a8yhuaVcXw6HLYw9+uPWyDcOfU5/UJTY++7/loHpZ96egti+lHl0S2APeakQ2LcikzRmNUVIkzBmProg850HzsX87B+RdlwOcmZzelXHXDHJ1wQg/UUFIsmUsN3xMXzEeq55A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3495.namprd11.prod.outlook.com (2603:10b6:a03:8a::14) by BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Mon, 20 Dec 2021 07:24:42 +0000 Received: from BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::8b:8b64:1a16:859c]) by BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::8b:8b64:1a16:859c%3]) with mapi id 15.20.4801.020; Mon, 20 Dec 2021 07:24:42 +0000 From: "Wang, Haiyue" To: Feifei Wang CC: "dev@dpdk.org" , "nd@arm.com" , Ruifeng Wang Subject: RE: [PATCH 3/3] net/ixgbe: reduce redundant store operation Thread-Topic: [PATCH 3/3] net/ixgbe: reduce redundant store operation Thread-Index: AQHX9WWV2IJMxdqy8USsfzU+wW5r3aw6+R5Q Date: Mon, 20 Dec 2021 07:24:42 +0000 Message-ID: References: <20211220055039.4035627-1-feifei.wang2@arm.com> <20211220055039.4035627-4-feifei.wang2@arm.com> In-Reply-To: <20211220055039.4035627-4-feifei.wang2@arm.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 33f879b3-5747-4c12-8259-08d9c389ca47 x-ms-traffictypediagnostic: BYAPR11MB3143:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZoEf9PVNKceeeIxfO/kejO6EXufdsVAHdc0SukOvfk81qZRtzdqgXJol/2Hy3YXgRVVWzEeLG71izjrg5UissNVh1SS0joF+DfvHNpKalxekNGIWhnuxtIr8d+3KvfudhwxW22YE0Ibm2DPC7ZwHE7F7ugWIOo1pOTQHa9qT4pKfNwS5qSySk7TiWbTb6MQ9R7ywYyqmTq3KpFg1Zsh5zmjBs5wpYZQM0RIp/A1XLI7Oqp1kqnV2wg/gMCUl0vnv7r4WwDixQtVLEnxwvqpy5W5O0plP6SqtjlGZqR/teX21ISjWZrv/kqegudaSOLmwBZ1Rg16IQNq+BZcwisXO6F9nQPqyIDXQJDVktkqtR3sGvjcRsWuxIfns8xXc+0NPnH0kKrmo66PntkBli6eurDJItHyeIvZ24mleGafT/w68JjZFyZnWybRL0N/H8KvRV3EO/kl7L1nAeYw5SCDgRohvoPF/nZm0zCZAc3EGeC0M6ZYWIXHYGuNMNBV8djQckGNDuHzbx44YeoNWwSJIIrSKtqmWhSfAfLxyAwmKaeGWp0E+vMLkmoEJxNroREIJfz7tmT3eeo/BHeRf7o2HwjgW6W7Dp93OhADAY7n3wItXGtckCixH8IvIUBZwblz1LOQdLIv4LCI5cmsbCkFKHHEV485bIG2X3zImIOIRyFGZtO5OTc9/j7FIEqUdZxVGiVF2ya+u+ZYlV8TyWksAXQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3495.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(38100700002)(122000001)(54906003)(86362001)(9686003)(82960400001)(55016003)(38070700005)(186003)(33656002)(83380400001)(76116006)(66946007)(7696005)(52536014)(2906002)(66556008)(5660300002)(26005)(66446008)(66476007)(64756008)(508600001)(6916009)(71200400001)(8676002)(4326008)(53546011)(8936002)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8Uft8hFgQo/V6B+7o10gf4ht3/wnFAAhkpjV8JhIdIverZjMhlJXseBwss/Y?= =?us-ascii?Q?eiIczWigpyyRyzKPgaN8Fv780/RxQnu0xdhjte07HXTW2/BrugGqk7ZNVv6q?= =?us-ascii?Q?Q/wBhwNALVBboda3Cam0KutFuSklXgp5FDKUW4iFYbh3Uo+As9T5Un8fCWhM?= =?us-ascii?Q?LIcMl+ZUovoFR3l+NITKhfwZQRnInFVrrO47esJCmYFINtnwnDUJV+JXzrzB?= =?us-ascii?Q?fx5kbw9Jq6jVFXl/dtTUEK/Xad262q++hJMDi5Cx+Wo1hJOqOoEpcythQTMJ?= =?us-ascii?Q?hEzFolVyocKJS/7rHA/8zgVkBRgI8usp7CtP1MKGhDSF8VTHFACp/V+zB50z?= =?us-ascii?Q?T/m8rZyfK19r1SiHWU1vDjwozdr9ceDiBzEJImm49iGZZ0rHV/NzEskjHyFq?= =?us-ascii?Q?44GYWEl3GmzmN9hh+GAYvHrk4JcHqaFIqYyuetFsMnYMtBVjThrNWkRmIaUV?= =?us-ascii?Q?APx2hML4ZYPzvT9IutEhfmvTwPDfQe4FqtlkpQmjH8UdEPw1UItwCPP8NbAD?= =?us-ascii?Q?u3eNDkGkP874XkOkrnSg1nXZyVlNhPmFfPNWvcoojfgkxA0rknRqb/hs72Wg?= =?us-ascii?Q?MnnHA5Bhi3ArM6DStoomB+7ZSbuEC2w0hwBa9K3dBi1WcLEEbkdleanoc6+W?= =?us-ascii?Q?aGYNdq0LU6VCDNvV/3RciI5CpRFD9pV57suzHq8u4v2YrMoUWJUsEgCE/D/2?= =?us-ascii?Q?RodMvjzSIOA5CWBN3vjxwHzn4736swPEAoeSfOZYuFFjSz0JUDIzRh3gNjOV?= =?us-ascii?Q?1rPmmUNfFMlYDzMwlU29MEtsSbvn7+iOefli/nHBuaK8Df32I4Vr/zJYGfF5?= =?us-ascii?Q?dJ7uF1DBonourGj6yvbqBqe6gkaOxhSv6qPEywNCGuHn2qPhZcBPtci6GY7n?= =?us-ascii?Q?1mHaLUDNNi3/K1zVxU6s7ZFrlZtg94EjjXEjZsp7Lb1LRaOEmkvnCkYFX637?= =?us-ascii?Q?12OqKcvceXVxmfa+ennF2kcNU0383p/3tMjs6hgGvbQSEZTeHAdTfR3sS4u0?= =?us-ascii?Q?ccp44bG8d3ImBqUpIWOeD/Q/2FxVp5+j27h9MXQXFDu6Qi+WNe7Dj0/n2bF4?= =?us-ascii?Q?CG9LBkDrXFNWFBlsIbdZs8Xq4rtrVieMlwQQC9cYGQmgOmoGIXW4Zq/8D1Qn?= =?us-ascii?Q?aRP4iWA5VibBM0RVXRPhQOc4EwM4gz3KgXRARMFaI2HRCg7//cfBcF2dJ4PJ?= =?us-ascii?Q?e7GBnxR9Lh2BdB5g2lD9a3t+IwxJQenyyCaggjN/I4KQ9QaNeARG4hTinIzr?= =?us-ascii?Q?OfnfJSKVGNuqIkV6AJbSN4e45JAkXp753SbPpMMYYJ6VKI4db5RV7hUpgiVt?= =?us-ascii?Q?qj2CrdBnPMSOqm+EHeZxvAe95PjVyW/cvPCWEoecJzgqzS89T6mINA+A5n8o?= =?us-ascii?Q?DRtZNt//NNgKMcnldqLcH1yzLc63lli4DttPP852HIR/w3peXVX4fyOnBRHl?= =?us-ascii?Q?kFPVyxQ4QGODBEm7fzOzG7CaF1lzHQzIFd/1YqxaC0kK7ls0aRhLNbbPOZsZ?= =?us-ascii?Q?kaqgHVBJApybtoCed6z42+Tdok+DdAwh07RJ3ZSsUct1LuXj3Rq/BM3eGZaV?= =?us-ascii?Q?AbJe7RBf/Ixd52HD+aa6hmrbSI8B11kwqR7V7Qm2lS/NY7Uk2p9yQOocHVJL?= =?us-ascii?Q?+C5t0LAx0mSc9pKqSilwxtg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33f879b3-5747-4c12-8259-08d9c389ca47 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2021 07:24:42.0466 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: omyiDz59Djk7c5JoO+rN8nC2yHLMtL1y+6tqlXaaq6Bdp6AC4ioLwXKC92l8e30XR4NmCGhRwu34YRlGYKXyVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3143 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Feifei Wang > Sent: Monday, December 20, 2021 13:51 > To: Wang, Haiyue > Cc: dev@dpdk.org; nd@arm.com; Feifei Wang ; Ruifeng= Wang > Subject: [PATCH 3/3] net/ixgbe: reduce redundant store operation >=20 > For free buffer in ixgbe driver, it is unnecessary to store 'NULL' into > txep.mbuf. This is because when putting mbuf into Tx queue, tx_tail is > the sentinel. And when doing tx_free, tx_next_dd is the sentinel. In all > processes, mbuf=3D=3DNULL is not a condition in check. Thus reset of mbuf= is > unnecessary and can be omitted. >=20 > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxt= x.c > index d7c80d4242..9f3f2e9b50 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -120,7 +120,6 @@ ixgbe_tx_free_bufs(struct ixgbe_tx_queue *txq) > for (i =3D 0; i < txq->tx_rs_thresh; ++i, ++txep) { > /* free buffers one at a time */ > m =3D rte_pktmbuf_prefree_seg(txep->mbuf); > - txep->mbuf =3D NULL; Not sure, but at least found: static void __rte_cold ixgbe_tx_queue_release_mbufs(struct ixgbe_tx_queue *txq) { unsigned i; if (txq->sw_ring !=3D NULL) { for (i =3D 0; i < txq->nb_tx_desc; i++) { if (txq->sw_ring[i].mbuf !=3D NULL) { <---------------------------- ? rte_pktmbuf_free_seg(txq->sw_ring[i].mbuf); txq->sw_ring[i].mbuf =3D NULL; } } } } >=20 > if (unlikely(m =3D=3D NULL)) > continue; > -- > 2.25.1