From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B95DCA050B; Fri, 15 Apr 2022 03:10:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4EBF640140; Fri, 15 Apr 2022 03:10:50 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 186A54003C for ; Fri, 15 Apr 2022 03:10:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649985048; x=1681521048; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=66UnkNoGqvGXdQEAt6vnTRszvzFJCUoQCU8u8HrNsKM=; b=ap7MFC8G2bxMxAhyVknDNN/yeXpFxxk0x6mpflRKBg6Opgkglb5Ri3sk mMcfqcN8ybk7KlgXE5I85KSJ81m1T/CVb1/b7/SeNFCcB+r0+zo9n/j+H 0HcKUhY2TPihnI9rUJbSTloLBtt/yinKYATrYCX70/ifduDyMEG7TEupB zUaVjXblUJV7MdATDyMDil3jL+SZ+CdL3hXW65BLUrdhy1EFcHHu/1RsU QIwcpPdk1gDNWwXTj5Gt9XYQoefECxw9wwkJO4q+7A4WFRbh/mQtuYmJa z7vbXZZOqzCd9R4VZTE/JINwlWkyfRlmbMj/nXwCWJbG0lVJTYQ31t+DP w==; X-IronPort-AV: E=McAfee;i="6400,9594,10317"; a="250367519" X-IronPort-AV: E=Sophos;i="5.90,261,1643702400"; d="scan'208";a="250367519" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2022 18:10:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,261,1643702400"; d="scan'208";a="725588803" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga005.jf.intel.com with ESMTP; 14 Apr 2022 18:10:46 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 14 Apr 2022 18:10:46 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 14 Apr 2022 18:10:46 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 14 Apr 2022 18:10:46 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 14 Apr 2022 18:10:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xv+/vR7ii9PijX47MX7j+635YW7bmEnTk5rhDYgVVA3904+X/yKsL66cD6z+kv1T5aLkIc7Acgx95FHKjpMP47+lqU5oKqQmkyBpbc+AfBLlbvxmuoA5H9sGreGPWyp+5+ToeWW5i+6dyh1BGhSnjXCkFoXrBPff7wd93bEGhRx9NkFZn6UjkYX5tajWgmOKr5GpGN/a8Gq+O3udeTt5NuQFWKyMcBuaotWgw9aS5C89tAI8jZWpAdQwZ719JiNWwqh2iYTBqYO84Z73K2K06hxUNsh578DNr/HvJJQO9DpGCOZuBoh2JU97xJ8kji9XNPOK6FW5Rq1yNU86/7sGgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qSIViYsxK3Ylsg/LvECWDrXImGr5xY+6sFbGJ+ZzoW8=; b=QTBHcC5IRvdTZcCu7eW1WkREXAXrIH1+F7152bOOgpwaMHh04tzvAZZIE4LyylSy9k9bRjVIw0Nlwqy0ckehyL+4aj6451b2rCDooi7BEbscaNA/4+HYY5uwY1kl0oN9mOy/rgYl+oo67s4fYVB8eYeYVEDcK+CiHyMeZjPNqGoO7h2m/0kiJcY7suwu/4cJ5xAKzUJYN47ryr3YlytquPw2cbWkS0pjL/wKQpgNHMrpJFLxMwoFoAyt1WKyfm/yXqUu+yjnrhazWPFA/EIEa3vzAfE2vsVTt4fAlB603fog4BhXRPtgWCokeHZZuuWtbAcMgpJykun6PccoYObfCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3495.namprd11.prod.outlook.com (2603:10b6:a03:8a::14) by BYAPR11MB3429.namprd11.prod.outlook.com (2603:10b6:a03:91::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30; Fri, 15 Apr 2022 01:10:37 +0000 Received: from BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::784a:cab8:f035:d8ca]) by BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::784a:cab8:f035:d8ca%6]) with mapi id 15.20.5164.020; Fri, 15 Apr 2022 01:10:37 +0000 From: "Wang, Haiyue" To: "Daly, Jeff" , Thomas Monjalon CC: "dev@dpdk.org" , "Zhang, Qi Z" , "Mcnamara, John" Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYMnOuiff82ZUQlEWL3X/zT2fgs6zu2SEggACJxICAACmoMIAAAhoAgAAwWwCAAKYswA== Date: Fri, 15 Apr 2022 01:10:37 +0000 Message-ID: References: <20220307223442.28012-1-jeffd@silicom-usa.com> <1889452.fIoEIV5pvu@thomas> <2937496.687JKscXgg@thomas> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b58f4efa-6a45-48c5-9184-08da1e7cc02a x-ms-traffictypediagnostic: BYAPR11MB3429:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I0kI7vmvADNhwU/jIVauHQwTZrzI75hm3B8jMI9b1sHRQ483mkiwxYbPU3CWqy3qQ7jJp3szjDOd222B2hQEoD8++LEt6O8xYh5HcKxvNjRE9CSism1UaldYfSvabqDTXvHbMqFt7hdL1MRP/fJXgJCpGqJ6MqNm2/zqTG5h/Bs25tehSZiQ2J8y6VgtUdWkTS5HO18W8cnl/iFIwako1TGBH2k8SHyMFTvaXS811XgLEK5tYSZYDLvhTNexFWVr9NNuUAb3AFemfHWdBcSRCe3uVvOTGFbJ368wBUik1nKKsRySXjIHhFvCiNNXwTZcf1xLYWKSbzhAViyHYAj8dhOPXyp2KYGZIYIUJYrbeEkWA2QB1JLER8HPRfhCWYcCUPnRZ1ARwUibxd7oUnXLMYopQaOupPuyeG8Q7YWG7G4wZ9yDtoEuapJ+Irt5Ek10Jz+1kczU7ryFO0Ej1Fm48wkyWYtCgmAuKjFUbH6Zi1HBSBto/H+h9gaoz/n4LgiKUgpz4So+Hg3ICVGWtLD6WivdroU6h4k2YLYojgNOm39D+7bFzwZ3n3/k9NqVvRPtFH+SGIanvlU2c0Zft1OqcyUYfLoenFht3x+3kONfIS1Wo2meNg2JzX4T0uNHvPnXc8etN0bL7ORa5kkmk+Kn/V2auMVi275DqoQyiViZvf89Nww5SbaFTOltD6LFpHP45KYOpqKkiQYMh4ybQefZuuS4D6exHyQPfmCGZuUVwacQp3RCsM4UI/NcceztqD8Mjw//+CaAxoemrTIPpa5Jf4BMVyWRsUN9UND043I+te0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3495.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(83380400001)(54906003)(71200400001)(33656002)(8676002)(4326008)(76116006)(508600001)(7696005)(38070700005)(38100700002)(82960400001)(122000001)(53546011)(316002)(6506007)(966005)(55016003)(66946007)(110136005)(9686003)(26005)(107886003)(2906002)(66556008)(66446008)(64756008)(66476007)(8936002)(86362001)(5660300002)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?c6m1tyhPnHOEGnTGBRtXTK3Sey4r4IS3X7UyiDheo/Gxm2bLrMm42ClY4GaD?= =?us-ascii?Q?MkXqzWVDkulKG+RYFezrcOFDXiIJLPYCHMH/TP3a9+6WhS9hcNuK+V2Nkpws?= =?us-ascii?Q?AQsMv+QSOy6JAHx8NW2r0FzksjTQ/vr933YvU4whR6e3ZMUwp/PIo/NHmw+P?= =?us-ascii?Q?S0FOYIqmuOdh7cdqRcROYMPF7aCRJ6iLwPRUqSYEzYPxMg9FELYHmEXej9DW?= =?us-ascii?Q?aZJumJUgXLpjqRp3BfbkDG0ubxSlBceO2Aao39DgAchrkXrgCJZ9ywJz5aeJ?= =?us-ascii?Q?FJtZzOh+lAD0FN3xxNEsqYXE3rTSlA7cf9kG+3xRFvOkXScBY5oGONuPoK+N?= =?us-ascii?Q?nvrX0qkypG+jbKzXsEzks5md6zlX8hyqMjID3OlakIAWg7UKhmwY6g2jRRJQ?= =?us-ascii?Q?OFfL1iA2i00OKiTlc9xL420vxpZBYewtF4H7qcCvSXaEPWiAluXKlzT99wtN?= =?us-ascii?Q?GsoYHZi4LUS5wKo3uhhqeqrcM1mdBBPorikE47JuLkuh5s1PHVqgYnI5QMoJ?= =?us-ascii?Q?el1a/2e8oAPkUWIxg7dbkBtCzNLTh14E/UODbDa+mb2vJLlohilxsUwOUdr9?= =?us-ascii?Q?onmrWMINQbXKQ+XK8TJnrQgjBNfPkmYfP9bVW2Pk47OT7bPLJaKKboPcLgT8?= =?us-ascii?Q?aQph0S0KoStJPs0muZuXqjlVUO7wcw8dQ1o4Kim9itq/dY1wbSb8kUiQuQtk?= =?us-ascii?Q?0DdzRBxT+q36Ml2LFyKTVjl2HSHySK/bfuoYFMEcGu9owMJYeiyAy4D3+jyy?= =?us-ascii?Q?ExqQhiMsOVcCiitStOBdGlZmxNBCe7L5ipgefu5LJtkPyyQfD/i5jAMd+Jjx?= =?us-ascii?Q?FQUMAzhoCNUhPBouW0q2idUZfR0oGJGt1b+3ciRSvH3KsP+397kz81i0xyCN?= =?us-ascii?Q?wYj/t7GKFkC7lLOSMgkVM8OH5fCv1CyB2KWKnmp9OXytmBe8ZFKK23Dd7acl?= =?us-ascii?Q?9BuA1nTqP2pACB+YEdgakhHRCCneRx5YfPNEn4ZjHCrfV1MvU3muWZhGjrbJ?= =?us-ascii?Q?LrP9PJ+tYQ2+kAxivFtk99e3U0ZSel1rLwTOHfXCei0y4HKVUjYm0pdhhZwg?= =?us-ascii?Q?K9DWzce/QOJt6+HaS0qfSkLT0RIEXbtQaxinwK7Sds9yq327jSy9OJ3WCAwH?= =?us-ascii?Q?VYWP4lyaJFR8fnXa6qeM4oGoEF7aQE2xBGsA7+3MtR4o3L0bisgUsVX0lNR9?= =?us-ascii?Q?wjsMxsIsecTm5ETfvfYGo/W5bo/JYWnN6J2k+JKfNPn0k2PkmIBb1nbxaZGX?= =?us-ascii?Q?TH4UFGmJS+pzAj/Kn1a0lm8FbbUMxPF/0IoCL8KgAXHrvlIOlj2RLKCGnJTz?= =?us-ascii?Q?Mkz9tGpPJaRzoFP0xziwtZEFr4ZSd5BKIhBq09aPjV0oEk6k3PbSABLztN91?= =?us-ascii?Q?QWCWCQ2SIeIc1T5oPRd36pFPxHqbW4Dk1a6eTrmens4yamtLvtTtf61HSZia?= =?us-ascii?Q?TA8+j5gxcuOjRSZJEinDedqk2YO9TsMFMEwKhyzDsN4Gnqv1vUEugkIbZ8a0?= =?us-ascii?Q?m8CHNWjj6cy7cZrMvfaHXOAzhi+Y2ixx66oAgLM1l1vs36kA4WPex+k833Y2?= =?us-ascii?Q?Wcc/h303elFPgUXdcV/AZLLWoQZGA7wL+4DxYNxBQ42uMXg1+s//oZESK6oZ?= =?us-ascii?Q?5FU5R//+3Quu1lxROQz8NWpsybaMmZYanArKw28XCxIbQuzgJyqZpA/Fn/kw?= =?us-ascii?Q?AEFJ7FTLwZnkay0Chhy7zmpsOmhSQMVqyf33eZ6dCHLZL5QaqUWPItYeLYb0?= =?us-ascii?Q?04fDYOZ2fg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b58f4efa-6a45-48c5-9184-08da1e7cc02a X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 01:10:37.4514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fiXygPxyIzqqVZVQlr3YNY95AIAsQGp2wEKlCspgE8QbmnSywpBjBNMgW4r9MpSKKAjFl5ESCn46NvSJKkMIlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3429 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jeff Daly > Sent: Thursday, April 14, 2022 23:12 > To: Thomas Monjalon ; Wang, Haiyue > Cc: dev@dpdk.org; Zhang, Qi Z ; Mcnamara, John > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 dev= ices >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Thursday, April 14, 2022 8:19 AM > > To: Wang, Haiyue > > Cc: Jeff Daly ; dev@dpdk.org; Stephen Douthit > > ; qi.z.zhang@intel.com; > > john.mcnamara@intel.com > > Subject: Re: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > > devices > > > > Caution: This is an external email. Please take care when clicking link= s or > > opening attachments. > > > > > > 14/04/2022 14:13, Wang, Haiyue: > > > From: Thomas Monjalon > > > > 14/04/2022 03:31, Wang, Haiyue: > > > > > From: jeffd@silicom-usa.com > > > > > > From: Stephen Douthit > > > > > > > > > > > > 1G Cu SFPs are not officially supported on the X552/X553 family > > > > > > of devices but treat them as 1G SX modules since they usually > > > > > > work. Print a warning though since support isn't validated, > > > > > > similar to what already happens for other unofficially supporte= d > > > > > > SFPs enabled via the allow_unsupported_sfps parameter inherited > > from the mainline Linux driver. > > > > > > > > > > > > Signed-off-by: Stephen Douthit > > > > > > Signed-off-by: Jeff Daly > > > > > > --- > > > > > > drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++- > > > > > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > > b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > > index 8810d1658e..8d1bc6c80d 100644 > > > > > > --- a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > > @@ -1538,9 +1538,21 @@ STATIC s32 > > > > > > ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool > > > > *linear) > > > > > > > > > > NACK. > > > > > > > > > > As for 1G Cu SFP treating it as 1G SX, some 1G-Base-T SFP modules > > > > > require the use of RX_ILOS and some Intel Ethernet products don't > > support that. > > > > > > > > So what is the solution? > > > > > > > > > And the DPDK keeps the same design with kernel. > > > > > > > > It should not be a justification for limiting DPDK features. > > > > > > Um, this is upstream version driver to keep the same behavior. > > > > > > There are also some kind of custom release ... > > > > I don't understand. > > Upstream DPDK (and Linux) must support a maximum of hardware and > > setup. > > Why rejecting adding such compatibility? > > >=20 > so, I will ask a question directly in case people just aren't inclined to= make a suggestion > (and perhaps this should be also directed to the Linux kernel driver mail= ing list), but > if there's a driver option: module_param(allow_unsupported_sfp, uint, 0) = to allow > enabling non-official support of some SFPs, then I can't image that it wo= uldn't also be > acceptable to add: module_param(cu_sfp_as sx, uint, 0) to be able to sele= ct whether > to enable this specific handling as well? >=20 > if a patch of this nature is acceptable to Linux driver maintainers, then= it would also be > here as well according to your explanation of the NACK, correct? Correct, let's get more reviews in IWL. https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220414201329.2= 7714-1-jeffd@silicom-usa.com/ >=20