From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E082A0508; Wed, 13 Apr 2022 09:01:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E6C340E03; Wed, 13 Apr 2022 09:01:44 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 5D1E24068B; Wed, 13 Apr 2022 09:01:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649833303; x=1681369303; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=V8JNt4HHqvvFvP7GbN7ONuEd/Wpx09pUCuPAd73vwEM=; b=fNO5XEQdbFghUCiJbh+kdmts5EwdeTFS2yzNAlyeR61zi63pJQmyj6Dj LTtE81jKjLRbeuoyb/BQ5ylISQrfmW16lXibMg1Xodm3/y1lB4t1ijT5O G3Wkp8APSRJCvevFUOkkAnZ74z57oegm7RphHgzhuyN9SApSi9vD8NilJ HWtm//ejJCfzMMivZS75Zaz0tL2KaZHW02P5Fx24Y9kTa9URqY9HCIWXS cZxOLfQsqbve4P/KnGnvKF1c5+09OHYc8dUdrRgd7uDKgx2sA97d4YFNX VGR6lwWatjWMxSFYoQzYf2sUMEEiv14O1qusHw6+l/TyTkq5m6j70Zdfy A==; X-IronPort-AV: E=McAfee;i="6400,9594,10315"; a="287617668" X-IronPort-AV: E=Sophos;i="5.90,256,1643702400"; d="scan'208";a="287617668" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2022 00:01:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,256,1643702400"; d="scan'208";a="802578538" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 13 Apr 2022 00:01:42 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 13 Apr 2022 00:01:42 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 13 Apr 2022 00:01:41 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 13 Apr 2022 00:01:41 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 13 Apr 2022 00:01:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R+H6FYvK6IXs3u9k7aDHsuFzdPuF73jT7lyeoNTQeeHl9A1jh8rDps+0FK9Zdd+EMQH5075PJpRbJodQYmeFnM3XDFbu7OUtu01vV0ZNGLv9t6A4g3DlSrsdM0DQZvuq8xKcaFX1xQvzkkqz7DCA9a/wjOWUJG5JLlNrB/JSs58njwNzYTMwymBA+GMypaOO7xHUWqr+m2IimwFbjayjUlrghAeUfE6ulmW4eGk07lYOtyRSD9aaIpWloiBQBI3q0RSsR9AahP+gDsz9hzf2S9/pXTZldwTkrUMQgmhsiXWN2Xaq8Tvk1YZ3Z/uh6fKHX1kIYI7ECSs6md67pAxHnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V8JNt4HHqvvFvP7GbN7ONuEd/Wpx09pUCuPAd73vwEM=; b=jYXL9RB63D72jESrjSPrMdUq/GuSuoI9nV0/HPTXr8QJaJ56gRvtKPsSsPuqCN99ypt3VsWRq6CyKX7fU8XJan54VdZgj1l7nnG9Lv/OpVyouoCTESmZerAFFKrcWT+MEqgIYWFtoietobFr4ELr6Fr9X1PX1as/pNc3Iiu6p+eMvsaTxPOxadW4BFdOyfObsoZJaRuBYofEvkNa0W29PuPQL+9cm3i4sYzYAE/y1wmoHrQciky//ZOObqCTFcvpY7vHjxgoWNIWEvjE4qWpmqtimQIRm8EABPuBoxqpDnG8T6r5HMHHZ+iZVNZ+rwu/LkA2Ug6UbeLOMKfpO4NRSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3495.namprd11.prod.outlook.com (2603:10b6:a03:8a::14) by PH0PR11MB5205.namprd11.prod.outlook.com (2603:10b6:510:3d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Wed, 13 Apr 2022 07:01:38 +0000 Received: from BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::784a:cab8:f035:d8ca]) by BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::784a:cab8:f035:d8ca%6]) with mapi id 15.20.5144.029; Wed, 13 Apr 2022 07:01:38 +0000 From: "Wang, Haiyue" To: =?iso-8859-1?Q?Morten_Br=F8rup?= , "Daly, Jeff" , "dev@dpdk.org" CC: "stable@dpdk.org" , Stephen Douthit , "Yang, Qiming" Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Thread-Topic: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Thread-Index: AQHYTpWG7ngQWSPahkCox1ZHMx0Ya6ztIqNAgABE6pCAAAO7MA== Date: Wed, 13 Apr 2022 07:01:38 +0000 Message-ID: References: <20220228152937.21247-1-jeffd@silicom-usa.com> <20220412174220.31195-1-jeffd@silicom-usa.com> <20220412174220.31195-3-jeffd@silicom-usa.com> <98CBD80474FA8B44BF855DF32C47DC35D86FD6@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86FD6@smartserver.smartshare.dk> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3589708a-5f7f-4ca1-2c97-08da1d1b74bd x-ms-traffictypediagnostic: PH0PR11MB5205:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t41+cU11YQwWe3kZcwxXgVAAkmSe96/Hjo0nflJ1PR6N7o5ecDw6qgiYbfhZIvYU0q+RBZp8HI0HY0HwlVHqiaZak1M/2AMBadLYpw9Eib5y/taLurL4s+XNnta3eU3mQZJgE5u98C13HWkx6yUK/PEXmwdWp7b/Q9NBf4eeEfNFbPyCOT96OCbwP2nW5AG1hjvEVBT5oXSJQSh5FX7huppcvVzQKQc9IYurD66oIpvsrR59ATXoyEAi7erGi8RoxhIQm4Yt7zQFBCEjuzG4+S14xPDyqQxOIeMN5qPRlZGHThAEL4fchiPZ8gqgFo4fc6ZVL+u6ezSqqcS5fPiwprmcuXAieqbL36rRVRVC46SeGAS4k6T+zR1L5eij80gPdUJKYBbIPqg1oTAc4QRBgqlOpIZjsCBZz1Xliy5mei6kmY5/Th2Az3VIDmi+M+fIB9bT0c2Q+qZJiwX4yz8udl5+plVTihnq9vYNtj09HAOOtwkhVG5dq034+3rIa2+wEI2PjlJp7X9/8fyRqpcRt6lX5cz5e7DfTMfOGDX9QL8juiFsit1xnvho2mAfN3Z+Zj9lnzhx1LBNGeWU0GytaF+l/Xp0KfUWtI+Wp1Yg9YKkF6ezrsf1VCfZigAx98Yj4kg9l+3BYIEu0/V9k/FbZwoKOar69Qa1tVIDQyQy0GDsyE4qATk0ZMFk3O5IMHnX9NyD8Qi2EbWZOs+MovD07w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3495.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66446008)(64756008)(66946007)(76116006)(66556008)(5660300002)(66476007)(186003)(2906002)(26005)(8676002)(38100700002)(6506007)(7696005)(4326008)(38070700005)(83380400001)(9686003)(53546011)(52536014)(107886003)(316002)(54906003)(66574015)(110136005)(82960400001)(86362001)(8936002)(71200400001)(55016003)(33656002)(508600001)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ozJ3LVAgtpZT2uJOsyEUdzMxGMY3DGYwEjsw0ra4sey3Li8LdKZIfKHOqf?= =?iso-8859-1?Q?AGzo7LCj/+xVwhaXLjChEQNKJ7+rwiu+FOU10eLFokCXbsCgJjHWwIRFQx?= =?iso-8859-1?Q?R3+gFmZgU4EsstBJjMb+wAF1rhq8V+40BNMdx+Lky/dKcw7Yp7XrBPqRo/?= =?iso-8859-1?Q?oNEgZG3Bw9JjBR5iRSggifGbjAYS8BUM7HACHitNsVNyxt0l6eHBo2VpBo?= =?iso-8859-1?Q?KH1rcHu42DXZ87RtA8Q1kT6BHg8L4BN+/3NRA9a5lMiQ/WG5CdRp/nooW3?= =?iso-8859-1?Q?68bHSzGVGHeohsGrzwWjtGeGBP7DAUZCi6L9LSlWlPWLdCdS8e/RSdIxZb?= =?iso-8859-1?Q?SHL2eAqAbFeHHpEOBcoGgySczZcTkBi6F017TZAAfFACM4o/qqzqjvX76K?= =?iso-8859-1?Q?2zyzVw0Mz/RpC389eTnV33GEKyecxmyOaLcvb8uFwD3WVOBmuo7L7Ej24I?= =?iso-8859-1?Q?gNAXaCvDo+1RF+qL8A2Sv0nc+Y+wL25cNLjxPc1jDDvQ4s4iaV1A2Ny42R?= =?iso-8859-1?Q?OgWUuO7dAujLRq/EooC5iTNyAT5WSYkIoKg4r0C5NCN/dz7QnkIJ8xLrvc?= =?iso-8859-1?Q?0xeI2490NBR8ybiA5g00asuJDYRF6rHQYkNyBlhb7ZJE8hbLoxpENa3St+?= =?iso-8859-1?Q?h138KJdW6BgiutrDUTGgU5STgjMy/6FYGPU2UBPtYxgRbqRRpReRmZt3FQ?= =?iso-8859-1?Q?h5jgIrvyhwejQHAGJKO9STHEJ0vUwcIW15GCoUtsNwtfs9/Kjk/kvZ19Ts?= =?iso-8859-1?Q?UqBBPUtkMDe/q/nJ9K/03mNB+CXaTUZvLHD7T63r926U2H7c/uaJG7b66X?= =?iso-8859-1?Q?CL4gVu5LlrMjGJJhhRvN/t6ItW+9gXJJ6tTkzutO8PynfIfQaONX3r24xc?= =?iso-8859-1?Q?uKY1OImmBCsMY6k/bnJdUtf3Ku7rzmj0INUDkr65VS5yvdNV7t7ava6ORc?= =?iso-8859-1?Q?W9H5lo2QOi+80VLZ0iiBx6DeZ3fSPy8QTMHBt2NVRjmpjwNxrwdTbEkpva?= =?iso-8859-1?Q?t5Yf6LFBWVISj8JlfduOuil4xqzHIs8SDSFHil3KTvI70b6hQi10WKiy2q?= =?iso-8859-1?Q?TsFvRab+au9zQandv1/r9Hexp1V6BBga9q547854ivhRxylQk61+XYnT1L?= =?iso-8859-1?Q?/Q2+mdy6XIB1UUMxWNUtZMdHtgFJw2mtkLqnqG1ZcVneK1RmZpjmJvfT/J?= =?iso-8859-1?Q?fBIVPeSTscHqVpe77uwvlqyam4jRHapdLUgiGKnMa+WJRa1gCGoUWIHI3D?= =?iso-8859-1?Q?UBoBIKRlMJw1ow9iw2T2VqesDKFVdP/khHE4f6o6ml0PbO3vx92PZyGylG?= =?iso-8859-1?Q?yaq2BIQY2tiI7vMvwV9AgyvZsa/I55M2A2AehzK/xnDNHB/SfsNbg1Pn+P?= =?iso-8859-1?Q?TMj8fEynOYV2Cc77MpcpXhYL0b5L0kCPBVB667n6piu5ypsfLD6GEGdxbt?= =?iso-8859-1?Q?OGECvVv09VrkkglYvjOs8bcQORelvM3XlqWOil9PMLrha2Gq2jCFU8Hwd5?= =?iso-8859-1?Q?69cAoYsAM+4I91gFAtZMsrNzWR4UDigtebDg/4rNYTIyspG/ieVQRz6fov?= =?iso-8859-1?Q?MXdWOtfgMqLXGv4W9V+0LJhQ+ABrEXSelHxZqXre/SStuf/IIgDbywrHQm?= =?iso-8859-1?Q?8WYhnOZ7EFv4lzuxElz+dZfd0wOICeW22uW97WIKoFKw7O3r0tpo4MDd01?= =?iso-8859-1?Q?LCV1fo0w4FA3/ijfgIFuRHkKjKn2YbJ5J1u+dA93pBmX6oqwuPocDrxVuA?= =?iso-8859-1?Q?5JKn6TantrMg/hOgQYDySPuBIOyiqwj3IcRhUdISrEUFC6k6qcyp8+wU23?= =?iso-8859-1?Q?a5pM3q44lA=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3589708a-5f7f-4ca1-2c97-08da1d1b74bd X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2022 07:01:38.5442 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 84orCEpjgDW6poVfsrSYKK0T5h+XWpjuq42af20KCjRBERS+RgDhQh1L7iVwEMZRejpd3uwUv9fK/oFNtgtZQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5205 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Morten Br=F8rup > Sent: Wednesday, April 13, 2022 14:58 > To: Wang, Haiyue ; Daly, Jeff ; dev@dpdk.org > Cc: stable@dpdk.org; Stephen Douthit ; Yang, Qi= ming > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on h= otplug >=20 > > From: Wang, Haiyue [mailto:haiyue.wang@intel.com] > > Sent: Wednesday, 13 April 2022 04.47 > > To: Daly, Jeff; dev@dpdk.org > > Cc: stable@dpdk.org; Stephen Douthit; Yang, Qiming > > > > > From: Jeff Daly > > > Sent: Wednesday, April 13, 2022 01:42 > > > To: dev@dpdk.org > > > Cc: stable@dpdk.org; Stephen Douthit ; > > Wang, Haiyue > > > > > > Currently the ixgbe driver does not ID any SFP except for the first > > one > > > plugged in. This can lead to no-link, or incorrect speed conditions. > > > > > > For example: > > > > > > * If link is initially established with a 1G SFP, and later a 1G/10G > > > multispeed part is later installed, then the MAC link setup functions > > are > > > never called to change from 1000BASE-X to 10GBASE-R mode, and the > > link > > > stays running at the slower rate. > > > > > > * If link is initially established with a 1G SFP, and later a 10G > > only > > > module is later installed, no link is established, since we are still > > > trasnsmitting in 1000BASE-X mode to a 10GBASE-R only partner. > > > > > > Refactor the SFP ID/setup, and link setup code, to more closely match > > the > > > flow of the mainline kernel driver which does not have these issues. > > In > > > that driver a service task runs periodically to handle these > > operations > > > based on bit flags that have been set (usually via interrupt or > > userspace > > > request), and then get cleared once the requested subtask has been > > > completed. > > > > > > Fixes: af75078fece ("first public release") > > > Cc: stable@dpdk.org > > > > > > > So BIG change for new platform, DON'T CC to stable! >=20 > What do you mean by "new platform"? The ixgbe hardware and driver is not = new. >=20 It's soc NIC, ixgbe not support before. > This patch fixes a bug (with a serious impact when occurring), so it shou= ld be backported. The size of > the patch does not disqualify it for backporting. >=20 > -Morten