From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A254A034C; Mon, 20 Dec 2021 08:53:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8341410F3; Mon, 20 Dec 2021 08:53:07 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 1CAF840395; Mon, 20 Dec 2021 08:53:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639986786; x=1671522786; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TvdtlLSNcmaYUl/QrZT5LUzEuo+V/vMu7/op4nHYP5U=; b=BmXZAUenyOpQcFVyFMFX5vVy7ueeqQupWoKOwaUF07iHMtCBdeK5hyFW QsIm5AuvuMexz0/RB84e23+nWpJlBV54Xde+13rPiZv+Tk0sBeNHQzT3K VNyknUCub7ysYI3j1y4UoU4lwQ5rC1wE4Q+UneSkkOiV5jKXH/wLX+k0c yzJ4ipwJ0Me6fsfWAqeGM20Jfu8yjuH2pkIu2KDWaYaOigqxkZ4bp8B3v OU0jqmlTdMGOndJcjjPsgmkGk39hZRXKBW3xVlSVi3xjoce6kGZrigZyW zubGS3gu/AZcmTHsMn54xTGafdRd3vGUPww6SS73PyT22e4xm0X2PZil0 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10203"; a="300889619" X-IronPort-AV: E=Sophos;i="5.88,219,1635231600"; d="scan'208";a="300889619" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2021 23:53:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,219,1635231600"; d="scan'208";a="569765771" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP; 19 Dec 2021 23:53:04 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 19 Dec 2021 23:53:04 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 19 Dec 2021 23:53:04 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sun, 19 Dec 2021 23:53:04 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 19 Dec 2021 23:53:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KoUssCnMHeya8Pc5wgPrumdoGn3veX9hgNfYzT6IQqxuKVEHXCMJmFvtwcgvA36hvgJZ7AsmeHqtIRdcrY3MWj+6WEcEXSmqxwPZlr6IgaAh5Wkfu52bKj+WeKpFR8oRbGRl9IWvrOgog5jg40kR8baS3gw9E051sHa1d5qEqNdN3CPa0n2FqhrWLv0iBQyJ9oBZ4Vu/ET+AEaxCgLaDLMImAKveuBvHg/vUwJGAGqFNfeOwf/wlfP+Qpsv5nMBzaQifyf/z8pMPvd3xS/BkB1WfjBEWom4jhSnjcrrhXvM89n/oAkVOzgrtLbxubld9H2nD9S+PxWzO0NTpEr4xWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mZ0wfv9egCXa/Y2/b9y+sQKwHzLOKB9K+m9Z3epcopg=; b=dkZ/gGUoCnMBpqAijB4sj6G0uEAWIfrgh2rt7AdatrI7X/QvOKwMxuxqhhUacCS59l9DZKUph2V7Ozq+b7Gn4kZjwAgxBYvTWeGnLWqv0HlyG/Qi6GGpdKuBXuJKiWLvV4NyDQUPO8gjxe9svYFpbmv3W+6wSErQn47OLBC5G2FutHZIpc4ZzMR2FUgGWgFg2jpXJqpDf9HvJpwFlZ25G/+rXkJHucUKYEddyyzB/gymYhuwpwVihmKeC9MTy7v2L43Lw49+5vRwBeTtHd8SkqnEI3CmA5vMgzzZunu0JnHqoD6WNdQHhZDI0TOlQUsoYwvXZbwUwi7mGHPRqm9f0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3495.namprd11.prod.outlook.com (2603:10b6:a03:8a::14) by BY5PR11MB3991.namprd11.prod.outlook.com (2603:10b6:a03:186::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Mon, 20 Dec 2021 07:53:00 +0000 Received: from BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::8b:8b64:1a16:859c]) by BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::8b:8b64:1a16:859c%3]) with mapi id 15.20.4801.020; Mon, 20 Dec 2021 07:53:00 +0000 From: "Wang, Haiyue" To: Stephen Douthit , "Lu, Wenzhuo" , Changchun Ouyang , "Zhang, Helin" CC: "dev@dpdk.org" , "Wang, Wen" , "stable@dpdk.org" Subject: RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write Thread-Topic: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write Thread-Index: AQHX6u9u9ujqxVnog0ydYR+NrxgBwqw7FmUQ Date: Mon, 20 Dec 2021 07:53:00 +0000 Message-ID: References: <20211206221922.644187-1-stephend@silicom-usa.com> <20211206221922.644187-4-stephend@silicom-usa.com> In-Reply-To: <20211206221922.644187-4-stephend@silicom-usa.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c411a081-e9e3-44ab-5ea3-08d9c38dbead x-ms-traffictypediagnostic: BY5PR11MB3991:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:184; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: moo6goAm3fPQlZ/km5U5+cIGy5+2kAPLOTKOrr5ya2NBpgmnI0skytSZ3DB9oIqwDJB+TKgAtPyn4wdn5qwU7s4qF723wKHvlTkUO0npIJ1V4xYZhWbwv7YF4XlDkY4reIuwJyC45V32CR3YyqvBxMZMkIeyEAdW6bGFDldGLTmcQRhRZFOy64lm7yJJFsfdk5g/MBGPS8/HV2FaqzOC53vmPS/3/5CDCDnRaYVi/YaOWgxEm/d0mklebKVVLQBIOZOoOX1Zb1oMIzr+ww6xhaY1ouNwJnTaoW+Xh7Kwy1jO0N4SutOhIElfMt6jcFAzTWZqgGZg/NbgD3KIYvChj6TUB4virHFgb89UjM1SXyAdQF9tTyqnuRmor2h9UC8zgWwJZEz6Vp7l/RPq1Xbe2LDutuKhU4K1inplotETGSEweUy5bM1R+/Sy4tieYjruMIgPHBCbiHRJ5yG1dOqHZiWTOw98OpylWhDc/FlKXxW8GbMb5knLtJnhEs2ZfyWnBNjh+2Lb8DShnOgbp4yy7zSKygPVW2qVErxWNwgiOHAheNqOsRR18pk+r6pTAU2CK3QF6jLbUoqkLKARF24jV5D5AshxRu3Jl2fpWmaPC2lU7Zm578JmTiTH5OrVkBbZsvb/nkaDSmi+DHCciIklPrpxS5GGtSrzsKzbDW3oHX8h7OHgrLHgs/efTlYT6l3HclZO+m8bJAr7RG7iK1ZNKA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3495.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(508600001)(7696005)(53546011)(38100700002)(6506007)(122000001)(5660300002)(82960400001)(55016003)(9686003)(2906002)(38070700005)(52536014)(316002)(4326008)(76116006)(66946007)(66476007)(71200400001)(110136005)(54906003)(26005)(186003)(66446008)(64756008)(66556008)(33656002)(8936002)(83380400001)(8676002)(6636002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o+HqVwcM7JFDE8RlO3mdPRbZgAeNiqvW9CEMlt+TLAbYlrUIebCBIhwg2aPO?= =?us-ascii?Q?L3EkgZWQoOeNz5J/zBb+JhjaABGNLAyZuV9nVkUoWhIdVYYX/n58GS0XHrp2?= =?us-ascii?Q?apHvz7pwUAK7zRa5ls6fm+kjgJVkNixlaTZ+I4/ByF+tXQ66SHwS7CcwDI1h?= =?us-ascii?Q?/p9SNyP9Uh4XKS8jYuNZ9BSAVbAvOjzvHCFTEya+7z/nP3BPoAqvB2IQOMWZ?= =?us-ascii?Q?xk8RXE5SsfqLZzWqwqbxW2ZtTy86lkvoKecNPdiKoPHsLkYAkeFRVEAISQUT?= =?us-ascii?Q?977lynOO5PogF3mbjuxiCEi+CgCh+SpfjFw4CUIKo0CbmV1lx//4M0nuc6GL?= =?us-ascii?Q?50RyQbJSF7jCLELc073CeHKx2s9omQ1boCcMVogk6xCAgn7yn1DYve9xFEou?= =?us-ascii?Q?3H/nI63JfEFr8bhbZkxd0Rl8Ll7zZeYZC/fYNhIYBS8ViN2GbFIZ/aXquSqu?= =?us-ascii?Q?jNJZ25bPpSeSG1PbZ3qSsXuRb41bU72nPomg3Q8ln+U/P4O1iAzTabz5nUAI?= =?us-ascii?Q?o5wHAg29EDnNy7iCXq00vVYQ5qx52NQOPW3Lw3FlgtpN5ucVew5wOlgNJLlD?= =?us-ascii?Q?/GwMtej610YmroRLZBFtfpC4/xEoG050sIUXdSYHCtydHwjTKM5dVSLpROUe?= =?us-ascii?Q?hxb4XuGAoazbL/BtGvpxqPKVxcsEuSzpuy9MExHdZifglYEpgSEjU2riY3g/?= =?us-ascii?Q?N9DDhHz1XEfUpDt94ciFRNgDWIouS5cDek2kscO08vCpLk128rQsoU760YK7?= =?us-ascii?Q?G3HaLpJPHfl5xpmBmb0NWgQTAeLOBAXsptVO0rZG3x52DnOCQ3oUeIFpsRCE?= =?us-ascii?Q?heEPS+E2Y34G/SqXoa7+7XKis4+N73ETIxLYEh5XLf7vp1Z9Kz0nU0dauh7U?= =?us-ascii?Q?6hTT8X/JtWtfF/hUYEL0cvkzD2JyYY9EWvxELO58b6Ozhe0oThRbj760kQAs?= =?us-ascii?Q?EC3RMG8IxqkUI+GmnJ1ID6KqW7mpENeigYudC4xCYNF+VbiSv1/4XDIQ81X9?= =?us-ascii?Q?Gew83A5EhMz/eoeyAeFam3IX1w36OPIFA96b5y5jAX5jUkoaPho57/1atRAh?= =?us-ascii?Q?6PT2DNnSMQSh4gqGpg1wohMuzU436IcJ+DceNE7ZZO3hLVrvv3eSk0034hAj?= =?us-ascii?Q?Qkj0YkikGxQDWrTzSMb0GjObyZg4CRluSoP4T+93DZJVk2S3wcAPhIPDedIg?= =?us-ascii?Q?2PQn1HcEZf9gKIDGsK7gDw20x63UZSqA1+eFszwt9nL6ppmT0eL5lm09Y0Bg?= =?us-ascii?Q?B8P3jUHOAS9axblvfdG8TjXOHCX22j+x9nK/xi8b8kSCLZsv8etaCdcNyXpF?= =?us-ascii?Q?7w6Mm/7v8BGAhrCEw4zswYfnwvDyN4wdqkUlJs5QNli3Weytq8b9RVB2/QEj?= =?us-ascii?Q?YRC/+K6WqGbWnMmtNr0Y2LfHThlJPa6Pf2eIA/xriraGQCv8ZGirMR0rAu49?= =?us-ascii?Q?BoAEo+soh6rVFw1O5T8u07JVEbjDdv/AXGGRUNnuaE5oM/bwI3U9ob9rpKBG?= =?us-ascii?Q?/cgEABfVOF3ZFDrW5U696/M5Qm8DUurIAm91cbqjwDTpzolOr7IdAN6wfHzi?= =?us-ascii?Q?TLP2qVQlt+BgvU1L2+LT1uwdFVGT8efitGNOzxEIg1ScRzbOb4oGG+Y1KQDT?= =?us-ascii?Q?XtbIZNhCLX1B43zJi+Upd8E=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c411a081-e9e3-44ab-5ea3-08d9c38dbead X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2021 07:53:00.5364 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wBGt3fK7XXSUGiAfUa6WCVIOGejn+V0qbFQ9g/xoYN6uHIlImWNl8+/N8yTrc9PyIn9HRmpQqH5RR4KQoqV4NA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3991 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Douthit > Sent: Tuesday, December 7, 2021 06:19 > To: Wang, Haiyue ; Lu, Wenzhuo ; Changchun Ouyang > ; Zhang, Helin > Cc: dev@dpdk.org; Wen Wang ; Stephen Douthit ; > stable@dpdk.org > Subject: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select i= s supported before write >=20 > Make sure an SFP is really a SFF-8472 device that supports the optional > soft rate select feature before just blindly poking those I2C registers. >=20 > Skip all I2C traffic if we know there's no SFP. >=20 > Fixes: f3430431aba ("ixgbe/base: add SFP+ dual-speed support") > Cc: stable@dpdk.org >=20 > Signed-off-by: Stephen Douthit > --- > /* Set RS0 */ > status =3D hw->phy.ops.read_i2c_byte(hw, IXGBE_SFF_SFF_8472_OSCB, > IXGBE_I2C_EEPROM_DEV_ADDR2, > diff --git a/drivers/net/ixgbe/base/ixgbe_phy.h b/drivers/net/ixgbe/base/= ixgbe_phy.h > index ceefbb3e68..cd57ce040f 100644 > --- a/drivers/net/ixgbe/base/ixgbe_phy.h > +++ b/drivers/net/ixgbe/base/ixgbe_phy.h > @@ -21,6 +21,7 @@ > #define IXGBE_SFF_CABLE_TECHNOLOGY 0x8 > #define IXGBE_SFF_CABLE_SPEC_COMP 0x3C > #define IXGBE_SFF_SFF_8472_SWAP 0x5C > +#define IXGBE_SFF_SFF_8472_EOPT 0x5D Looks like this is YOUR platform specific, then this patchset can't be merged. : - ( > #define IXGBE_SFF_SFF_8472_COMP 0x5E > #define IXGBE_SFF_SFF_8472_OSCB 0x6E > #define IXGBE_SFF_SFF_8472_ESCB 0x76 > @@ -48,6 +49,8 @@ > #define IXGBE_SFF_SOFT_RS_SELECT_10G 0x8 > -- > 2.31.1