From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26B65A050A; Thu, 14 Apr 2022 03:31:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B072640689; Thu, 14 Apr 2022 03:31:39 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id CF10940687 for ; Thu, 14 Apr 2022 03:31:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649899898; x=1681435898; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bXmhEl2sBatbRVgCYkDaAyWREu4CyV7WSzjjAQbtBZ0=; b=AnV/igpIdn29odw7MdTbQ7PagKWF/6HxlaYYKetZVUIVGADegah1v/Z6 Efsze/tWV5VM7lohgHDL3J0pNxl+8c/ILlniPxAy1MfjupIBSgXNgmHot NdCWISKUxc/cMx03F4NRe8R4QSnmBC+GhgGdFBtCcFUvCVV6rkXZzf49V hPqWFVZPTIMx8SDwpqa/ZnLENPMZqmHh27b+0yMRwcjZppC7AP/J6tlq4 zJ4XnIIsbhKqv5OwzPONRpUw1JI1DiS0FEQJga+xDtVp+MLWFGwC/+3Ar u6kRRJovUVYadX9nRw27hKfQuXVYlopwvV3WkxYA5f76o+rb/PDfblxpa A==; X-IronPort-AV: E=McAfee;i="6400,9594,10316"; a="262259806" X-IronPort-AV: E=Sophos;i="5.90,258,1643702400"; d="scan'208";a="262259806" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2022 18:31:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,258,1643702400"; d="scan'208";a="559978295" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 13 Apr 2022 18:31:36 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 13 Apr 2022 18:31:36 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 13 Apr 2022 18:31:36 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 13 Apr 2022 18:31:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DTemObgKVOd6xQH9bcIcz3KViSh0qneTESSUL9VPecaAUL9quS/9tppG3PX2WcO30OhN/hnuIhSGZUXUIeYZBpplFh8benDsCZhiHMWH5DjCxoiZ19ZjaQRXdrgHPn6/RJvGVILKCbzqY8jM0g8sp1GwhuL6zq8T2+EXizeD6nQt8N3UHcecLhEUlOB2dWC0zp9+TQ3ElBkzNKP0WNGg7RKFzb5mWNop3V9i13hYW13R5acW0G5B2tBy1dRBtEQEEKlW7B0sbZ2oEHNOJ1ZUnO7SMXDCkt0xheKihzSt7rvy7PCKJbUyBKD8yeCPobxbXllSEPjRpvPTi9uKxJcECg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BvRFPsSWkFlODP+xet2g+eNxaT3doxeQAtNkN5INmCw=; b=ROtmf30DHFIYlSJzH9kuyv6Jjgl0UgpPXZNZ898MHzEanhKO/tXca0LEcwkCmiWTH+IMjF/kUfzQlY2/TAx0cP7UPUewGAs97kjiHXj4QAGI6Fvvw45OYXvr+eMqAZKOUU9a/ldH9SSCOgkc+pOCeEhPX7tAV2hB0Mkt35yHzaaJGOyUcBy11q6USDh/Gz9pfUdLcJ8Gw14J8+cwa6nMEF4QZ2RpiIzyfnpq1OU3sdJr0/3brhUxOUiWS5v3gaZAdXfmdfQj+5dldHRuVZ07n8rmTNmM59ZZoR3Cau+TwlJlL0n4IjJ3GMQM5ul8udvKozPK+ynM4eulRCvdB4XqcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3495.namprd11.prod.outlook.com (2603:10b6:a03:8a::14) by DM6PR11MB4675.namprd11.prod.outlook.com (2603:10b6:5:2ac::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Thu, 14 Apr 2022 01:31:34 +0000 Received: from BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::784a:cab8:f035:d8ca]) by BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::784a:cab8:f035:d8ca%6]) with mapi id 15.20.5144.029; Thu, 14 Apr 2022 01:31:34 +0000 From: "Wang, Haiyue" To: "Daly, Jeff" , "dev@dpdk.org" CC: Stephen Douthit , "Daly, Jeff" Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYMnOuiff82ZUQlEWL3X/zT2fgs6zu2SEg Date: Thu, 14 Apr 2022 01:31:34 +0000 Message-ID: References: <20220307223442.28012-1-jeffd@silicom-usa.com> In-Reply-To: <20220307223442.28012-1-jeffd@silicom-usa.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bbdb069d-391f-4657-6ab2-08da1db682c6 x-ms-traffictypediagnostic: DM6PR11MB4675:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YCXg8opvYBNJMu7+2pJT6m8ODjNmAwFC/k4QkcER4W2GNzPEKqFfX8Gp1FSZ6YQ9mrtHGYB9G1rkESJti7MDCxycD+FdMeKbJOzRsRm//b7GStlC254FxtQMVPfHpOKUfOjjhuH1XDhxYjJPgEF5JsePrXQyuOjMpsTOPzvgyTpPlf0Kr1cF2+RkxMP28LnHAEDERgmYJY7dLdUcEmYMJl/dDcViJlZwSpKiBEwJTUdOdd4uQtCbY8SdXVu3CORYDxXT1imVTxxR6ycFOynYcIGwTiRXzijxaqA4ethP8zPnCu6fqyl3HZgNxNW9nTxeJdPDqLyYFfoeYxPh6GB2HDoGM4fsAYXb8KREGxiEAtrDin+ISWzTmUxSbwjPOoBl4EShAEvvxBv4YR7QaP9s8yK/A6Ly8AmfoS7OJaF4wTo4MrYxMRvsG1qXqMQMslW348hWgH+QLK0b5GIsBERxNF5FrpCSB0lWM15+8e1JDBmAmHyhFUZlEq1nT5LAdDTYpM2zXv1BUcZmz8kx41p2DfsHva5ZpvoVLtX2HO0GvoPyQzHgHjIeVjTk4jnwyOYt1zyIpAmvS+RvUQxWGkyIe26mBquI5z8VxQsoWQDglhQVKMPNLcszTpTsNBFOhxc+h2pAgvVCOwkH4aaUcxbx07+0Gn5eQViHgQWlt6GIIAsuK+hCuNqY5R/6YB5XuCPLFzOkQs7meC9gXl+zuQIwcw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3495.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(8936002)(52536014)(122000001)(6506007)(508600001)(54906003)(26005)(7696005)(53546011)(186003)(86362001)(71200400001)(9686003)(33656002)(2906002)(5660300002)(8676002)(82960400001)(4326008)(110136005)(76116006)(66476007)(66946007)(38100700002)(66556008)(64756008)(38070700005)(66446008)(55016003)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3B/esB9N5MBHH5nnABh9s1Pd18GBddB7GiVrs4zpFrTQgF/OfidZpWp+nBPc?= =?us-ascii?Q?XuRcTAB10wdRc8zyBmM0/scgJvWjX/4kEaq8f2j1ljmsoj9ligUh4xywitr2?= =?us-ascii?Q?NVfLPuVCZw3owcTXjI8NM5LnH1eVHjh7jYjNEUZrQ2ECmEM9jzauCrJWyicD?= =?us-ascii?Q?0gDVY6t80n74TAZ1m5YSb3Xejuq8NWYrkX3zS+U0yYqiIMUw62GP+hhdZzlY?= =?us-ascii?Q?eIzEnZj7Uf2vk+R7JVddp9EmR0CEWB3//yNQDGaEk2b4dSop8/4fZQVjXSBJ?= =?us-ascii?Q?MhNv8yRlC3mvJKbR8+xcybidZmtbf/ZebKx02NbIOpHmQDyx51B38HyppmH2?= =?us-ascii?Q?ALeTIC39JcVS1l+98Ia/0HFqoh+AW53d2WHBrmvrNevdksz3tSTaSqn1JJiF?= =?us-ascii?Q?xdR+fBN7RgdOyW0gn0hwX18ql2QxFqkrfTMH81PDWIDvbUrqyhVzWuQz+P/o?= =?us-ascii?Q?sOmP+FiVRqQ3bjgEFv5LLx3pTCFb3UVj8W5d0euibo6m/pzv6lEpy3xVHv3w?= =?us-ascii?Q?1uPSEDcFnV7ctpZz2h2oCbSqB8F6aAnzj8TWKxQ0ZUCXVFuUd0l7pbwnZQLT?= =?us-ascii?Q?6F07N5hcrejrGc2LvzCNFnLw0VRDGawuCa10TXE/9DZWDauo3Q76mzCcg4LB?= =?us-ascii?Q?EHMLaRDg3ooU8Aa8uP6ZtUOHgToJ6A49zV2LB+zBtz5Wt1dYIeCr7zjGgtjI?= =?us-ascii?Q?xtp02xsQ2T1kdutvlM4fpkGxxoBXEOtkX0CWNf663A1lySVK1BQ+DzEX2qUx?= =?us-ascii?Q?qd6QE3h3YLFThYin4a8tvYVkrig/ZTYRMbLfzNItJhULvmd7LidBs/aexNsE?= =?us-ascii?Q?qQ8fcEo3v7NxRsM651/cTuL5tR/Ppg1Zc1DZ6zhKpOZ01GtYGx7BlD13AylY?= =?us-ascii?Q?LhYXVnAcJU2DqKyly+OjzSivMJXgqyXo+gshtS8jEI6iPenY6XclPwNLeSQ/?= =?us-ascii?Q?LuOlRrt5cd9nDEquo+knEP4qcYE2UH59ld+GyLIeZ7xqX9KeJT+KLyTv0qtN?= =?us-ascii?Q?MVVpcgN1tE/JLuE+MX1fXZRplPpEicB3Hbsx7o4eb8zVMMtWk9piRF+91w3l?= =?us-ascii?Q?KSO/zgQY/egAWSiVEPIAoCMSPYBkJCryjkyLHbOICxL19lXE6iikqlnwqLd6?= =?us-ascii?Q?ISSMvISgz1Ov5H9LoH08dXKlKy1s8RHXTLYbn5H2anVJJQsl/TMgtCutVfi1?= =?us-ascii?Q?gWghs+4nOod6QIVWnm9Ieq9ljkv1OoYnhi3lWuodEVMfOp1PC9F2KgMURljE?= =?us-ascii?Q?KnRx2QMU4ISui1fuWI2iXyLqRx8Nd8pLlzNhW9os6NHME5Ynr6lwoGlZvVB4?= =?us-ascii?Q?7LOjchOt2jWOvGd39sk8DA1JxDrRpTt24AQYCejkEr5DaMPyyay46VmZq6Sr?= =?us-ascii?Q?A9iyyzU7YPwpccBM0GQRF5lM0y2d47gTpoH326iuaDktFVG81a8LdYCeWqlu?= =?us-ascii?Q?yoyUNz7mWFBOdHfP8t8RTZbVVQWAnqc9sPFzqxZ0dRVuQo/AEwfXTLWvAbdD?= =?us-ascii?Q?YMlPQ76S6lVwW85frtGTgaJeXWaKTGfA++Ie3wa/uK6xq/NZ/SHBFeeBl+4N?= =?us-ascii?Q?ucH0XaiJV73p5r+FplyuX4P3hhzf2TsibwFpqvyF0Gsg8Dy1kJUvEF4SQ/Za?= =?us-ascii?Q?sTtlHWRBOHftlgChSpn+tadyM3pI0x+4/yi5BmibETkNCyzToqTFK5Gxnar6?= =?us-ascii?Q?Q9IeznafovPmdfdjIZ+kQc7TvBqtXcHSqyR3SObBQaf4ufIF0pdVgMdzCtjL?= =?us-ascii?Q?bnlJNibnVA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbdb069d-391f-4657-6ab2-08da1db682c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 01:31:34.0703 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PZUS0e/dJXL2B+Dx+/GjlDaEcLINAq1KDOuwQHZ3HUFdLqWGNv4wcnUhdBCtSIS6b+KIWgxvAw/QCmTHtZDq0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4675 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: jeffd@silicom-usa.com > Sent: Tuesday, March 8, 2022 06:35 > To: dev@dpdk.org > Cc: Stephen Douthit ; Daly, Jeff ; Wang, Haiyue > > Subject: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices >=20 > From: Stephen Douthit >=20 > 1G Cu SFPs are not officially supported on the X552/X553 family of device= s > but treat them as 1G SX modules since they usually work. Print a warning > though since support isn't validated, similar to what already happens for > other unofficially supported SFPs enabled via the allow_unsupported_sfps > parameter inherited from the mainline Linux driver. >=20 > Signed-off-by: Stephen Douthit > Signed-off-by: Jeff Daly > --- > drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base= /ixgbe_x550.c > index 8810d1658e..8d1bc6c80d 100644 > --- a/drivers/net/ixgbe/base/ixgbe_x550.c > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c > @@ -1538,9 +1538,21 @@ STATIC s32 ixgbe_supported_sfp_modules_X550em(stru= ct ixgbe_hw *hw, bool *linear) NACK. As for 1G Cu SFP treating it as 1G SX, some 1G-Base-T SFP modules require t= he use of RX_ILOS and some Intel Ethernet products don't support that. And the DPDK keeps the same design with kernel. > -- > 2.25.1