From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1937EA050A; Thu, 14 Apr 2022 03:56:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D1AD40689; Thu, 14 Apr 2022 03:56:11 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 66DAB40687; Thu, 14 Apr 2022 03:56:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649901370; x=1681437370; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GojckvQnCeavPoXdcYlo1zhsXBmWn38WNlfnHoZXKMo=; b=YVuW4H0za7CNWg1wN172+rTrshI1mWES+AlSmgY9EwaTXE++QkOMFKNH fHwoS+XB5EbZ0IeiHcuFAQEXESxrs9EFlPtMoIcxrn4ZxPevRWvmE3lol 8GN13vld/kx2nooYu4Nh3cE+r4WBxZlAEMGCsDrq+NH5+ZRglR3hmk/Wr roqbnnoSDq76vL2gk/+01KooLoEQQ7po/NqMUd2feqaJUrMBDpGNT9X6Y riDhBYc6QVq1mbM6WFKdfsDj11PR5iPrt0SQngPmX7IOkIuObfdd8Iot4 e284DRqlM4Bw6jLMyo/E9ZKyTTSWduSxj3wBVrT5nM383PyeNtCvzZHbk A==; X-IronPort-AV: E=McAfee;i="6400,9594,10316"; a="261667335" X-IronPort-AV: E=Sophos;i="5.90,258,1643702400"; d="scan'208";a="261667335" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2022 18:56:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,258,1643702400"; d="scan'208";a="527189070" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 13 Apr 2022 18:56:08 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 13 Apr 2022 18:56:08 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 13 Apr 2022 18:56:08 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 13 Apr 2022 18:56:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oJHY5DC6H2c/8XhlWkGvNg8eHkzP9WCKO+7NPtLm1HyUAxsPgGIkpvrqbx4TD22U7I8osLOs7R3I6wN6xvfPlmCWMOIMR0zpZBgISU9uZycm1dwy5zV0e0sjDX91Nkjk0ATl6SEIajY0ElmXoWUOMrbNLsxSkQvdGKfSUk40GMReFivALeTNxxzdyK8ES3BGRqz4lntmkqYuCL52H9YwZH2swV25PKGOvONmmvgn94lTVdE2dc4UJIfwip2FVyyHE22WdCyMFqYEbKUUI8iceNI9geZ12wVoeaf+p33A8pWUIGH1wJH4p7kV4WZBKvp6oEhjp6uWbw9rqwAM/nd5eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NJIOf7Gwoi4IoZKp5BU07fStOAcK6/9FMK1zUxGjDIw=; b=OdLjQi3z3ucnDgDDffKMuVZ2Piq+Z4gvJSfg7OuTbCi2y6B4ZYGgi6t6TCqXz3LXsBsf2MLSOkRWjrX7++EwGg5JwT0Sn4xF4NYvq3bTKpkW65vObLBLJvA1LFyirjjngguRfRykuAymXVa7MSxPWGxeNjI5tYff1fZHMuh3i4X2nw/qi7X4TyJdWdAbSnNxUl8SkEKNOOaD1vdjV1fwDfNH7BVvn9wZFyXcuGfbNqYn4WDtez+c+VOQloqU41CdRBU+0lVyMqbU0lMG3XV/My9+UBPHw5Vdo6JuRmUyGdtBvWxWYVz2bRtOAYChpyIGIRVOcoRX+XAGdBQJGyCSxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3495.namprd11.prod.outlook.com (2603:10b6:a03:8a::14) by MN2PR11MB3839.namprd11.prod.outlook.com (2603:10b6:208:fa::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr 2022 01:56:06 +0000 Received: from BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::784a:cab8:f035:d8ca]) by BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::784a:cab8:f035:d8ca%6]) with mapi id 15.20.5144.029; Thu, 14 Apr 2022 01:56:06 +0000 From: "Wang, Haiyue" To: "Daly, Jeff" , "dev@dpdk.org" CC: "stable@dpdk.org" , Xiaolong Ye , Xiao Zhang , "Zhao1, Wei" , Lunyuan Cui Subject: RE: [PATCH v6 1/2] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Thread-Topic: [PATCH v6 1/2] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Thread-Index: AQHYTpWvIV2zv6WvNEOE1l2v3X78qaztC7CAgADuaYCAAKrAYA== Date: Thu, 14 Apr 2022 01:56:06 +0000 Message-ID: References: <20220228152937.21247-1-jeffd@silicom-usa.com> <20220412174220.31195-1-jeffd@silicom-usa.com> <20220412174220.31195-2-jeffd@silicom-usa.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8439c908-519b-4bb2-63bb-08da1db9f05c x-ms-traffictypediagnostic: MN2PR11MB3839:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RO2yA7Iou2ffO0qnu8aPs1BRiw5RBFj73IR4xb10vdAOHgvoZ7w4aF4vtK5MQQNHDLdtfKZ1rrWHhA2z1t48rpVHe6Uibd8e72ubKzrIPRDSua9CSLF+E3+Y8nLriGyIaLGssMitncR6IUHaJv/qo46/+ftlKO8ymcHEdBE90/LB+nh2K54MT6mxRCAs/RCZjrxtlqvuKp/kbTTOjnhY6SkMUyyWtvS4gHprLACBxesYoEaRdY0a5JG5Ed+36fULSvy5E9BW09xQBhLLpuJHKr+DuQOmIbOZ86ZaI7uBbL/Kr8rZm0aokyRLTdWXqKji9Vkcl1lXXszrH/awCY0yZpcys1Q8JUQaUwktp6hMkkrI1uknC/wha0/oHoNGrjqQoBfe49GVOCUYNf/zoOaeVUl4ew2Ta1e5sQzQ0WBpM5LE7J8evqlpTHsoaSuAPWsuFDaR8L9V8SSgCNg6ROW2bAAyZsPq7TU8aUQKcKZvmYubHpvaTf8B+gDRgzpUArQ2ibhweAAfNj7hqMUPAfUambDiqg7LUUgYHcbMsHVJ3yoH0Sb+hRwPPtE1DKsOH6yA3deb3lFv9U+lOQamqJMS6TdyHR8Oo5RlRnUlM7f6TqbCF/UKsUQ0b05hS66ZB5X/EVO5hU16cohM5aOXK6H7TFc+X0JSqYX5b0RmX5unVJnTRPVjg6wV4lHsHPmTbBYrAlrfqusZgnut7EILBCgq5xsotummpDEh7ifOW95Iiwmg6YRwSKGxLuSHL3QRpr0khSa6eka/EGV19t68e454bf6IcLYPXKEB/xsCb/YOJ6ML7iRbEG5cE9KbIRhkW4Zo x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3495.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(26005)(107886003)(52536014)(86362001)(55016003)(966005)(5660300002)(38070700005)(71200400001)(8936002)(2906002)(9686003)(6506007)(53546011)(7696005)(316002)(186003)(33656002)(76116006)(66946007)(4326008)(66446008)(66476007)(38100700002)(122000001)(8676002)(66556008)(64756008)(110136005)(54906003)(82960400001)(508600001)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tBLmqH0hHVew+0f6gs732z747SWdj6D1r5BXEgUxQmmiAyl3YtdxWOh7626G?= =?us-ascii?Q?3TaxlDPdW1+T/VO3ZZkzhX8wqL0RtsU33ZjW+XbwZYTVGXGbNq/OQPpphxSD?= =?us-ascii?Q?y4AIacJys9SkH26UxAujm0p180ppwrtL2ycURgGGamO4MeCyZQuAOSBk0G7S?= =?us-ascii?Q?H8SSuNx429i0wMwvNlWBb/Vs43/wl18xQHmICeAcwOwO+B3JAPw8FRrvUPFo?= =?us-ascii?Q?CB8DpNJxZXwODcMdWAc/mw1g5IfeEb0NXXkEsWBlt94MZog+R20orReFrkQd?= =?us-ascii?Q?37Fh5zmHQX7PLbpKT0IXFvDU5cIoOm13KAqVxjtC7nzp2P0sfdA3Uc2+S4q6?= =?us-ascii?Q?lg0Y8I7NABU6Srx3224w9lfqd5BTKavrb/hRY30kCNQTxeOulhqCJ0wxTIsc?= =?us-ascii?Q?aRPKXmMYYTjSKnBqovyXhcB+93GHVgn05noZb6gPFuAEEoph1+vn8aQyfBSx?= =?us-ascii?Q?GTMcc2z4FrRvE+jj0R3bYGeQMaCgfcMXaLFysiCRIm5OgKG/ZgSpiJXOYBsU?= =?us-ascii?Q?PpFvpRQM8jvmdnkkX5HUXo24RnlxexH+Nafqx1i6BgYYHVrAIQhL27moFetP?= =?us-ascii?Q?J+PwIUru8Agc7DXBOU3nZQ0pfFaHnf318XUBZVgrnYML+c9Bd/0/uSOOSTWr?= =?us-ascii?Q?Hpx/o+OS5NCBnt26Z2MulNkiVbIPunZeI/gHlH0jUhCna3HfKlAabXpjp30W?= =?us-ascii?Q?WP2F4w0pW4sQjqs81O/yA+wtVxdyp64Mi9Tx2DjBJx4tJxh2++sb6OXUKfHs?= =?us-ascii?Q?9UN8GtsMWDWe+cBR+8+ZMMKPkPCL4NdBn4kSVR03VGg5wgG5chhn/IbNoaiK?= =?us-ascii?Q?NhPk+fZtkq8uSmdjbcUYxDSE5u67gclgiGd0wdXxRCqU4JW1sqQyJ96dwmZR?= =?us-ascii?Q?jAVRimv4mkBJI7e2QzXyFuKeJIWZ5WN4I5wIa9Ijf2BZ/CeuOknFcA0pHQ1M?= =?us-ascii?Q?k1WFhhb70Ho1Mn8XQGBbwNh/tQN5+dfc0qB4SgJr0AdliN+TEKJmt6L/gUsH?= =?us-ascii?Q?T/Xul51pJFp/yGe6wDd8VSa3cl2tJfdpcx20kRbXpFgRH/dSnCS6+DBmdzrU?= =?us-ascii?Q?ZGvfDn8WqSyQl6/SvZl6HnAm7Q1TFKmMorRs5bbSWb671XUNm7YVp/DnM1yB?= =?us-ascii?Q?heG7BvhM53aiurHgshJarF3flVqqErhi/gb6RKCLgY9cMxytVnIIjjB7l0P+?= =?us-ascii?Q?fDc3fvbP6tqkrxIlHu0QLEQymHxbKAq1vCeLxKQXkm+DfK360FsgyhrNi86H?= =?us-ascii?Q?c3WyGRh7sYt3WLvefeWwQfW3LAkugXzcFucN4Xv7KBd4bQWfrcyZB0RgjzvP?= =?us-ascii?Q?9ILcv3k92eZVTfjndD7lmA4bE20QInxUMgXpkmpsy0I7Yv1AL0/TBqEG96Po?= =?us-ascii?Q?aCdTyCnlX4dgvbk5QwN6oJ3HYExpAQ+p7djCCS4Og41xhSrLbAg0wUdeIooZ?= =?us-ascii?Q?ttaDh/ntPx0MXrCPSY6VRAkAq4B8/kxl0DXYNDc77ZYh0AI9IvosvnWPVDa9?= =?us-ascii?Q?sbAQWKlJ763x9w/6jTKS/Og9BGAKsLXiKI4I/07i3Ra+IZ/2gWcUw/8Cp+i0?= =?us-ascii?Q?KrPju6r96IstbYS9AVgtTElnczM73e89KPVkkZoExhyIXnrgGIrb+CnowSox?= =?us-ascii?Q?+aIlvhjEGaM5vDFlYVla7U4P1vAVaKA0qnbQz1PR6rGnCn1QPvWwgQozqbNw?= =?us-ascii?Q?0PNhf44YMslThzC2PmdMv9E8RJGBRB6F3c9lyOnam/Yj8+dMkhcUlGNJ39DH?= =?us-ascii?Q?hTOufoVBiQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8439c908-519b-4bb2-63bb-08da1db9f05c X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 01:56:06.4307 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IoxL0iv6IYjrea7loJgKIlZPqw+7MSvsMdi7dKe1HUEHKHGz5eFn96iDz5xLHM15enElK6xnJvE6TIaJELrIaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3839 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jeff Daly > Sent: Wednesday, April 13, 2022 23:32 > To: Wang, Haiyue ; dev@dpdk.org > Cc: stable@dpdk.org; Xiaolong Ye ; Xiao Zhang ; Zhao1, > Wei ; Lunyuan Cui > Subject: RE: [PATCH v6 1/2] net/ixgbe: Limit SDP3 check of TX_DISABLE to = appropriate devices >=20 >=20 >=20 > > -----Original Message----- > > From: Wang, Haiyue > > Sent: Tuesday, April 12, 2022 9:22 PM > > To: Jeff Daly ; dev@dpdk.org > > Cc: stable@dpdk.org; Xiaolong Ye ; Xiao Zhang > > ; Zhao1, Wei ; Lunyuan Cui > > > > Subject: RE: [PATCH v6 1/2] net/ixgbe: Limit SDP3 check of TX_DISABLE t= o > > appropriate devices > > > > Caution: This is an external email. Please take care when clicking link= s or > > opening attachments. > > > > > > > -----Original Message----- > > > From: Jeff Daly > > > Sent: Wednesday, April 13, 2022 01:42 > > > To: dev@dpdk.org > > > Cc: stable@dpdk.org; Wang, Haiyue ; Xiaolong Y= e > > > ; Xiao Zhang ; Zhao1, We= i > > > ; Lunyuan Cui > > > Subject: [PATCH v6 1/2] net/ixgbe: Limit SDP3 check of TX_DISABLE to > > > appropriate devices > > > > > > 1ca05831b9b added a check that SDP3 (used as a TX_DISABLE output to > > > the SFP cage on these cards) is not asserted to avoid incorrectly > > > reporting link up when the SFP's laser is turned off. > > > > > > ff8162cb957 limited this workaround to fiber ports > > > > > > This patch: > > > * Adds devarg 'fiber_sdp3_no_tx_disable' not all fiber ixgbe devs use > > > SDP3 as TX_DISABLE > > > > > > Fixes: 1ca05831b9b ("net/ixgbe: fix link status") > > > Fixes: ff8162cb957 ("net/ixgbe: fix link status") > > > Cc: stable@dpdk.org > > > > This is new for soc for BIG change, not cc to stable. > > > > > > > > Signed-off-by: Jeff Daly > > > --- > > > drivers/net/ixgbe/ixgbe_ethdev.c | 39 > > > +++++++++++++++++++++++++++++++- drivers/net/ixgbe/ixgbe_ethdev.h | > > > 3 +++ > > > 2 files changed, 41 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > > index 2da3f67bbc..f31bbb7895 100644 > > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > > @@ -128,6 +128,13 @@ > > > #define IXGBE_EXVET_VET_EXT_SHIFT 16 > > > #define IXGBE_DMATXCTL_VT_MASK 0xFFFF0000 > > > > > > +#define IXGBE_DEVARG_FIBER_SDP3_NOT_TX_DISABLE > > "fiber_sdp3_no_tx_disable" > > > + > > > > 'platform' may be a good arg for the soc related change. > > > > dpdk-testpmd -a af:10.0,platform=3Dxxx - -i > > > > enum ixgbe_platform_type { > > ixgbe_platform_unknown =3D 0, > > ixgbe_platform_soc_atom, ??? You can specify it. > > > > > > > > enum ixgbe_media_type ixgbe_get_platform_type(xxx) { > > return xxx; > > } > > >=20 > This patchset is not explicitly for SoC platform support. *Any* implemen= tation may or may not use > SDP3 as TX_DISABLE. The previous version of the patch added a check for= the mac being an 82599 that > uses fiber SFP rather than just a fiber SFP. Our platform specifically c= an be fiber SFP, but > TX_DISABLE > is not SDP3. However, our platform may not be the only implementation th= at doesn't use SDP3 this way. > It does seem that *most* implementations out there do use SDP3 this way, = so our platform would be > the setting this option to 1 to skip this check while any others would wo= rk the same as before. >=20 OK, the reason looks good to me. Please also update the doc: https://doc.dpdk.org/guides/nics/ixgbe.html And one more session before "VF Runtime Options", to describe the devarg. > > > > > > + /* Used for limiting SDP3 TX_DISABLE checks */ This comment can be enhanced as your commit message said: > > > + uint8_t sdp3_no_tx_disable; > > > + > > > /* Used for VF link sync with PF's physical and logical (by che= cking > > > * mailbox status) link status. > > > */ > > > -- > > > 2.25.1