From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F03F0A034F; Tue, 1 Mar 2022 06:57:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D938C4113C; Tue, 1 Mar 2022 06:57:06 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 2B358407FF; Tue, 1 Mar 2022 06:57:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646114225; x=1677650225; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wTx+YCOcpI6ZgeVG4IEV4Cbgx5v9uLKQdXUI1NNY3Ho=; b=awFXWouY6AX1Mj0XQCBoVphyz2oiecstzifzgH8jMv9WdpG8etlsTqQ0 2tb6+45BKnuXIcerb47QX1tRfeglE5AAYUHy9qK2mX1aHvXAycI0PCh0S IBfyB9w615RlfLAFRaEeyrprhqyb3K+ZmqQdnQWFK77vZGh1XlRIFT4OF uToPoSBBLdxLEsNm5QsrV4AO+621hAwpe3AGjHjL2sbJc2gXRNTBr10mK +63SGb3usHTqeyZqUIsTdllzMgayEPl1zM9ybBHgPuS+j0lvIJnN+hCrn +fMeqfBtINc3Z9Rb3y6KlHbY5l8lt4RhUg3dqDEm0Y014HBNL6l55edln Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10272"; a="251896765" X-IronPort-AV: E=Sophos;i="5.90,144,1643702400"; d="scan'208";a="251896765" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2022 21:57:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,144,1643702400"; d="scan'208";a="641143644" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga004.jf.intel.com with ESMTP; 28 Feb 2022 21:57:03 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 28 Feb 2022 21:57:03 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 28 Feb 2022 21:57:02 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Mon, 28 Feb 2022 21:57:02 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 28 Feb 2022 21:57:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RpRaVZR+HFOBfG076xFZdY2Tv0lBUqVgFh3GQXUMY7VpK8ompz23v27EAh9f/xmjF9p0vxa8Y/oIk9O/u3iSoil1YnW/gSCcULcA3sNEa+PrwsB2rZ+DCSiVtcxly97nCsRPUUDaNOolPf4Xze31Bl1Ulwy315p86ZgheNv1mdBVQbNFtiXZA6E2wUaEMieBmgqkQsGlMkhjQVFuMwJHn6mPHP3PzGmfi4NoJ+Y1WmRE/l9Z5ZoxvG2JR8JYAY+NSB1hgNFRJMa1e0uxB2jWgHeRudyXRWD2gOm2hwljGrtlLwLS5JqpyRLcvUOL6/UFupbOe595Xu2Ouym6h8nGNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BoyOwhP5fFnDqjrt/SeeSv+ART1BLSS6VfpuYUCCEjs=; b=l0r6DYtK7LZs+Ax/z1uUnEUy+xnLJ/kCs8w5qni73ycQqgVslg368APGnIKw5kqs4oPWMTg97KlQ32hn85lA/vKHqZG7FhbwuWL+NSge6INNEeubV5aRNklD2lpSmY6v1gygxVLDC591VA/U1GgenrTrHmwkJajvXJJIhByyo85oBoYeePjdKFA7Q0RrUQZW46vbSD6XmQnwh7e5aVwzp/9jSpcGLugydvrg4m53QMnQI28ODSxvT9V5G/hSDfl5d4pwCaCxZIfWQpB7/ItBZ8FbUovuZ9A6NpLnZanz0mjrmeCP6Wo2tqP4E0FEqY5u33G4HiYeqQoCkJP35JeSVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3495.namprd11.prod.outlook.com (2603:10b6:a03:8a::14) by SJ0PR11MB4960.namprd11.prod.outlook.com (2603:10b6:a03:2ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 05:56:57 +0000 Received: from BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::714b:35f9:5767:b39b]) by BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::714b:35f9:5767:b39b%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 05:56:56 +0000 From: "Wang, Haiyue" To: "Daly, Jeff" , "dev@dpdk.org" CC: Stephen Douthit , "stable@dpdk.org" , "Lu, Wenzhuo" Subject: RE: [PATCH v4 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs Thread-Topic: [PATCH v4 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs Thread-Index: AQHYLLgko2f3Tz/vpUeRTxIMh/DDZKyqCLSg Date: Tue, 1 Mar 2022 05:56:56 +0000 Message-ID: References: <20211206221922.644187-1-stephend@silicom-usa.com> <20220228152937.21247-1-jeffd@silicom-usa.com> <20220228152937.21247-2-jeffd@silicom-usa.com> In-Reply-To: <20220228152937.21247-2-jeffd@silicom-usa.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6fb956ef-7edf-4c98-2cfd-08d9fb484b51 x-ms-traffictypediagnostic: SJ0PR11MB4960:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uw6ZmytXwvRJ0DYQWjlf8QV8tFGTL2sxBpOgujvc4QTQAekzallUn9EiotI1AyVbXbRPF5B/B1rxIzFn/LvJ5g/wZT6X649b7OvQXvW9slTuBHhb430gfTYkiMDg8J6OXMvOmOTKYfCOkaXE5uHC/V0DmmJCfvFkkzXsO3ys/b/PFa47BE0B7pol/yKoIOb0TK1sKYFpP2JB1d1iGxZYsyi+fqVMrhsGGzY10MjrH/rXo4nlDbXW8PCWeWEOaRmrL8YFLlGCcZxO6wO7059K/BHD3Gs7sLUWfXlJMAK8/JSe7V3dsggDwwKURHK10VYovAICr9C9A6WKS1Rneg1Sz42IzIwGHHAq6qAqbS1ZpTSw1jfohfKuQ1O0pIaZp9UJ155/rLDGIK5c1jrWOectTOWDZg/mF+5H7nq2bOf6cvXszsR1EwT+LoKwzK5c1nVKfcRas+x0VmqvRIBk4kO1UELK8X4aRiH8a6Lz3GHkQjcR7cmiA01P4bMxOf/eSmUEHTaA85x53VoRaEN6dYNtfFBpsO0YMddlp44CB64w1q3G18uzmPUUrLNZHoX+HAAGG4jBJFG1rxDIAHBg6q+XmlszA0UvRa5IBrZkpwZ17cwd4WCW2Vxh+HGDgv11yxspIxc6XMbmIyohQf2jKIxn7AMh7TV0eiVIXQZyZ/qfITOqZr7yBwZDumUhVZnML3/y+INfKPfu7QlS0PRCWSBxOQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3495.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(6506007)(53546011)(7696005)(33656002)(83380400001)(71200400001)(508600001)(122000001)(55016003)(110136005)(54906003)(52536014)(38100700002)(86362001)(9686003)(5660300002)(107886003)(38070700005)(316002)(4744005)(26005)(66446008)(186003)(8676002)(64756008)(76116006)(66946007)(66556008)(66476007)(2906002)(4326008)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?u8GDX4YX5OF6vtWrbx+DEA5FhCR/Sgilq/JHupXnH56vourtS9cKfWOkm2cX?= =?us-ascii?Q?yYofX3ZvSqjgXBDWEQTi3g4L7ekJGPmQcmj7aj/0SyDW/xUNuFUx2tiRWTrh?= =?us-ascii?Q?oCKugXD5KLIHabx+TWM2f2fTwFQh/3doBHPXdNzCffz7CdX0pvSbdHN+CJNY?= =?us-ascii?Q?hGH8j5GnVKyjHwcrZkBdNGjI4qmuPfVsZuyUyaaDhlSBkuu/gDwGaF8aqQax?= =?us-ascii?Q?x/QaU0GSuj019wUupdG6BPLSxg+yqjjmmdUM4B/SbUbFusoNfoIMYCzcPL5I?= =?us-ascii?Q?XUG9h06haP5hzuhyiEL99eFcrk7bUSBLnZVZMvbFnYJiZhC38cErGRbbZcDr?= =?us-ascii?Q?y1ew6hyKtfqg9mrAeIzzdTN7pecbeimHbgFzWzrBmgvXV29kOZkbIHqk0xDa?= =?us-ascii?Q?fqL+TOA7Y1tzh+JtaeVueyc7Qpx1PlI850ugeGrPJUdm0ua1/fU1qWG3kpGF?= =?us-ascii?Q?OvQKO+vreBeJilPH8YQa2qgxn+1RQpGoKwSeyRlCB6GNtWvG+lwjK7NSNYkW?= =?us-ascii?Q?/BxWrQCtG8hLb6u7NQxgVum6yrozdjCUlv9W57HBgaCW7q2L0AkNLVK16m4u?= =?us-ascii?Q?2fTgMFRjfKbQVpWyqFMKR6LFrPfIzrm+Ue8MxmDMTDfK6mtyxl4vbEGrgA3k?= =?us-ascii?Q?FD2qXM7nMXVb00Efzmy7mAZDYnLYJ997ieVbRSc7l09EICdR8KXoOAW5VOOQ?= =?us-ascii?Q?MKRFsahfVflCynPxfL02MotRrziYzEzK2HoEUgdyewueTZgglqxcjqF3sGJN?= =?us-ascii?Q?NaLuSBR4xYarNEII3TgLxp99AIPuVR8Hd1Di0pBstuxSY14VvMy9VBByKv/N?= =?us-ascii?Q?pS0Ja4sKarl4R0zxSxNddgYoRPvIPZMFwWBkVwhPnbe4uFWaRbl+QZcjco+w?= =?us-ascii?Q?4BRP1k+3tB0sgcJC1jJG8jT9v1Ao9dCK+SXqstiBg58vQOsuJbwUi5iDHOUP?= =?us-ascii?Q?s/Vvo+eQ5mESXre1t1RcRmakg700yvk6nQItbVSIBzFnatM0Sw9+5miwa/9Y?= =?us-ascii?Q?lLo/H/YRzKPfbkZ26zgPic3AvRiUKED7HWoRB1Dm9y9fBqTdgZ9DXZXCOYzy?= =?us-ascii?Q?njDdh/wXc++BqjVLHdhg1CoQAsLU70LJcPQ8AldTt6cM6SIm7WRLsKZVhErp?= =?us-ascii?Q?rgcIOAtjEsUDnylD3fC854SZcWMYVYZEnMxM0uvjJbFD22N5v8YS45FLuO/j?= =?us-ascii?Q?9b5H7YX1SaYOdS7wkiG7z+xNMt+0YaTpTpiHipXWl4pTb30ePHNF6IsFJDiN?= =?us-ascii?Q?MXUwHw/34X+dyLGy48UfzrgwPDUrQIBUYNUn21+SPq+H1CeJy+ztzhw42FGx?= =?us-ascii?Q?kT7BXnSFROrC+rtzkpIYyQHexiUPvUnQI01Sb7aa7Lk0la1WhVYSjOI0fNum?= =?us-ascii?Q?0n/q4aVIPOYN4E+Jw9gs/ZnT9P6ls6opTz+Z9tq7EaSWCvpcj8SkDH0EKnCU?= =?us-ascii?Q?mVPjxrJnndRTb7vU4hoPVXEofAM3Ju7kiIw75g0vDh+6LbS+z8Wv3mueVSR1?= =?us-ascii?Q?7kNEQerOdq2ukmXdBUJ9x98KCQs7wm4mL69Ip7qiSVW/MD5demw1G3OtGDuP?= =?us-ascii?Q?A/4xFpvdLI8jtL6hYFQI/bgSvHyqh8oRIQgFhWRwvsA/imMx8X0e3yHjpXYH?= =?us-ascii?Q?S2WaATw6pdYxOPj2OaC0Ko8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fb956ef-7edf-4c98-2cfd-08d9fb484b51 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 05:56:56.5870 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9cmfCVudu14iPEMoCaRZGWvPm2kJVPUaQ3jZL3cHdRccqmfvCQ5XkNMIGgGEMdc8tQ6kjALHxOs4ctte4bWbdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4960 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jeff Daly > Sent: Monday, February 28, 2022 23:30 > To: dev@dpdk.org > Cc: Stephen Douthit ; stable@dpdk.org; Wang, Ha= iyue ; > Lu, Wenzhuo > Subject: [PATCH v4 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid res= ult for X550EM_a devs >=20 > From: Stephen Douthit >=20 > Currently all X500EM* MAC types fallthrough to the default case and get > reported as non-SFP regardless of media type, which isn't correct. >=20 > Fixes: 0790adeb567 ("ixgbe/base: support X550em_a device") > Cc: stable@dpdk.org >=20 > Signed-off-by: Stephen Douthit > Signed-off-by: Jeff Daly > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >=20 Acked-by: Haiyue Wang > -- > 2.25.1