From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B18EA00BE; Tue, 28 Apr 2020 03:21:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 493881D566; Tue, 28 Apr 2020 03:21:12 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 364791D546; Tue, 28 Apr 2020 03:21:10 +0200 (CEST) IronPort-SDR: KDU0ACWAIWg9sX+tc6GmO6y/ihTvVW7uLmMI4khICp7GDSIbTHjAQFfJuuyq0YzJD0zi6Eeoyd 0hIc7hBn8scw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2020 18:21:09 -0700 IronPort-SDR: VVIzlBhn8pk9hogn42zwcC/nfkbonUJxK75hA2650cKuUeq6E1N95A1132vPpnqhzfj3oTxPOB q0MaZQWU0pXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,325,1583222400"; d="scan'208";a="281973890" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 27 Apr 2020 18:21:09 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 18:21:08 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 18:21:08 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 18:20:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KFMI1wdZIF0mIO2bbwG2KlN0t1SaE7Noe544CeuSuXfw+xD+3ohyMAhZxgzxBZ6xm4G1/Um3OzWofaB1XWQG/KvyXHRcO+IaCK7onpzWDGund9an3vA0Hic6IRmXwmCB5ozELx/O+xz3bUpDYfWhKCzzcB/eMhyzmZgqSQ6Sh7jIMWiCYub/yy0m2MytLy/JhfP4GtAQLsVYMeQcSwiffeQXK3GGtv69Lrg/YiLgoUxsTg6NhnpMs42KKifESucHHb6L3enrYbC9PDXzUVcn7UYj4h27Cyrir8IV3ItpTNMOL5gfxxrmrEYhrxzUxcQhQ6BUQhZlwMy3fjNHx2GOhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aro+j4nPONYaMxVekdqG9lqBe6wkBjiHXE8q5aSMg9U=; b=Tfh0332LzgkxLM754A2reacTcZ7wCMB/oWz6+JiDfhsq4jDKF8kRxEC3Arpkk1TQdrQTg5rqd4AAw4YgTz4hkIizDF6jh70HZHe2TFk0YjfzJGsCiu86Rv2LjlZW2dJ+Kbb51DpAerSr2z+GM7B6oNE62SiHPpb0kUjLFbj8I5PSfmeGAfmdK9D25Uv36XM5XGa24TXHYfMIwUrHwTe7kfBfNwewgV3fsVEvS5Z956Z3PgOGbU/taHiNiEmygs3l+huhCMAfpUbF1L7ic/4n8OWlUjV5p93dzoKDz9u0iaF/ijkvdEIA0SHg3Jnk0q/bCO7HQAN2C4D6cXcJZXRz5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aro+j4nPONYaMxVekdqG9lqBe6wkBjiHXE8q5aSMg9U=; b=m+mn+UlBdbfzYmHBbhxUSJ/NetkQv2O+2FBNwmzKVUrJ6r3hN3d8bPmjuhBY/svXyed80Rbbu+zuKLB9mAyciM388itq/qfsXzDBQtenp/2AmN/5QlYgH+GSPITQomS7ZnVlQgwHVYPclSYBZeMmcO/DjR+nKF6wQSg+ibm5ZTs= Received: from BYAPR11MB3541.namprd11.prod.outlook.com (2603:10b6:a03:f5::16) by BYAPR11MB3447.namprd11.prod.outlook.com (2603:10b6:a03:1d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Tue, 28 Apr 2020 01:20:34 +0000 Received: from BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::2c4f:22b:b8b0:27f9]) by BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::2c4f:22b:b8b0:27f9%5]) with mapi id 15.20.2937.023; Tue, 28 Apr 2020 01:20:34 +0000 From: "Xing, Beilei" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "maxime.leroy@6wind.com" , "stable@dpdk.org" Thread-Topic: [PATCH 1/3] net/i40e: remove ARP type check for FDIR filter Thread-Index: AQHWHGbSaPq+7jWLB0aal2v/qe2fgqiNvGLQ Date: Tue, 28 Apr 2020 01:20:33 +0000 Message-ID: References: <20200427071500.14767-1-wei.zhao1@intel.com> <20200427071500.14767-2-wei.zhao1@intel.com> In-Reply-To: <20200427071500.14767-2-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=beilei.xing@intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9ef06d1d-bbae-42c7-3058-08d7eb12599b x-ms-traffictypediagnostic: BYAPR11MB3447: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:608; x-forefront-prvs: 0387D64A71 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3541.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(376002)(136003)(39860400002)(346002)(366004)(76116006)(7696005)(52536014)(71200400001)(66946007)(66476007)(55016002)(9686003)(81156014)(66556008)(64756008)(66446008)(8936002)(186003)(8676002)(4326008)(2906002)(86362001)(53546011)(6506007)(26005)(33656002)(54906003)(5660300002)(478600001)(110136005)(316002); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CRt1jxYwKBMnK99Z0dW/DQ8iFBDAKnvd3mtBmPEZLiZdJXcNRDv8VlJMEo4slRmXaG9cougBma7AXusn1ACRtFIixEE79iUl2cXNeF9wY8Kwkm0BcRzX28GgHsWkiFM/ZS3Rvf05QqbTg9vu5hb3+sN95438/MUZtOG5SG4K2J4IQTBVZ1mVthGCWe29dVN34//LgNP97tFMHTWv0Bv9GKNfrgrwEEs7ew5a+TbUP86tTfSxD5OIPGLM/ROiFf+soJ2u1mjwB6mXDqkaLOCMfACmp62B7KedtHHtUmQT0BuVIUga695aDst8IZiWSPo3dS/FYhFa7s+v62HbhI20SVN5kkSlHlOmvn6LtS/tCh++NtzJ0IyZnaiamhqI250WRmsB9qnjgN+RQF60ebW1tsh8e6CeZLmnvaDqU/tXs2Zep0jNPlLWrbC5455pimri x-ms-exchange-antispam-messagedata: XkOz6xmCHxxOPbsgYZoJ1U3K2C6f9sV0cVl40fstqRFOnVRxHF+aJ/RDsCnU4KLysnP/Kb7gIbLBt6r5IK9E86pfHJ00Dnl0UwTXzf3dyickhBt293BC2PF4mZ1vXF5nB4wDlD3xDP1v0uYPvbQhPyEsWUdCjDB4rkVWwVLUXvR33I5FSd2U2fjyOMMA7YpshNurFzIrd4ddlmLGjyE/6U0qQAg9Oc2EGJwgCTlfdOPj24CdLyBgeJ/lIRN4B8dJALBaXZWnntHe/nzMsdnVGoZBnUamcMXG92F2SLoXetQVkSr6YxanQVJ7ETuk5XvWq8h15qHCDtez0brQ9CCan/KJr1u4q+XPBi1zjaxVepdeJKDCSJvzHa2VE7+wT0ePeu4cB+y65wmHQoG6539m8uHaqOvIssy4sfcQwRJxc1AAU5ebWjVTetWD+EL9GbmfCy0LJFCMjvVdG28mUXYF1cTVRyGqjHizValfT3Da4g4Zl6ZRXRgJTtaOZtElqhG3MJ/+ewFAup8P/AKgTTbUzx88eQnbkDtq4ZSpBfaVZx6q3Ps/kd+BoYwuFykNMtsDicmoLLAoegx2ruoDR1KRDrP0vcSUNLS5ur60IkUeyDzp4io50w+U15oVQDp3Gj4IEL1kKLLgcUjpzfIxAmAS0D7AAqJQA9/v6GOzUK4u4PNFMBmPNZs8Z6ySP6tWdxO+dAr4kmQjUGjIq9fm9tUh/RzBpY2i2RmV7mK2PV+A29q4pvauIFM1jgHJfYhILExC24l74icor0wPxp2F/TOXmIKeAqz16S5+LH5oKMiUSVc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9ef06d1d-bbae-42c7-3058-08d7eb12599b X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2020 01:20:33.9776 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w/rCmpbnh360bdpGPJGn6I9v8GlBTxJttOykN15sYWEGwfyyJ3Ok2ra6ovhwE3HrWvpz3Ps+SndGDhjAgXtFVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3447 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/3] net/i40e: remove ARP type check for FDIR filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhao1, Wei > Sent: Monday, April 27, 2020 3:15 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; maxime.leroy@6wind.com; > stable@dpdk.org; Zhao1, Wei > Subject: [PATCH 1/3] net/i40e: remove ARP type check for FDIR filter >=20 > I have try to enable ARP ethertype for FDIR filter, it work well for ARP = for > FDIR filter, so delete it. Could you rework the commit log by describing the problem and the root caus= e? And the title maybe 'fix FDIR issue for ARP packets' I guess the root cause is: if the ether_type is RTE_ETHER_TYPE_ARP, the PCT= YPE parsed during pipeline is I40E_FILTER_PCTYPE_L2_PAYLOAD. Please double = check. >=20 > Bugzilla ID: 402 > Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/i40e/i40e_flow.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > 7e64ae53a..1533d5abb 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -2666,7 +2666,6 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev > *dev, > if (next_type =3D=3D > RTE_FLOW_ITEM_TYPE_VLAN || > ether_type =3D=3D RTE_ETHER_TYPE_IPV4 || > ether_type =3D=3D RTE_ETHER_TYPE_IPV6 || > - ether_type =3D=3D RTE_ETHER_TYPE_ARP || > ether_type =3D=3D outer_tpid) { > rte_flow_error_set(error, EINVAL, >=20 > RTE_FLOW_ERROR_TYPE_ITEM, > @@ -2711,7 +2710,6 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev > *dev, >=20 > if (ether_type =3D=3D RTE_ETHER_TYPE_IPV4 || > ether_type =3D=3D RTE_ETHER_TYPE_IPV6 || > - ether_type =3D=3D RTE_ETHER_TYPE_ARP || > ether_type =3D=3D outer_tpid) { > rte_flow_error_set(error, EINVAL, >=20 > RTE_FLOW_ERROR_TYPE_ITEM, > -- > 2.19.1