From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Wang, ShougangX" <shougangx.wang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix hash enable issue in RSS flow
Date: Fri, 8 May 2020 01:04:23 +0000 [thread overview]
Message-ID: <BYAPR11MB3541C2D1E3BD2E2F2F8C7C93F7A20@BYAPR11MB3541.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200507094401.54928-1-shougangx.wang@intel.com>
> -----Original Message-----
> From: Wang, ShougangX <shougangx.wang@intel.com>
> Sent: Thursday, May 7, 2020 5:44 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Wang, ShougangX
> <shougangx.wang@intel.com>
> Subject: [PATCH] net/i40e: fix hash enable issue in RSS flow
>
> This patch fixes the issue that failed to create an RSS rule with type L2-
> payload.
>
> Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow")
>
> Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
> ---
> drivers/net/i40e/i40e_flow.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> 7e64ae53a..f5f2f0d5d 100644L2-
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4511,6 +4511,7 @@ i40e_flow_parse_rss_pattern(__rte_unused struct
> rte_eth_dev *dev,
<...>
> @@ -4544,8 +4545,7 @@ i40e_flow_parse_rss_pattern(__rte_unused struct
> rte_eth_dev *dev,
> if
> (i40e_match_pattern(i40e_rss_pctype_patterns[i].item_array,
> items)) {
> p_info->types = i40e_rss_pctype_patterns[i].type;
> - rte_free(items);
> - return 0;
> + break;
> }
> }
>
> @@ -4580,11 +4580,9 @@ i40e_flow_parse_rss_pattern(__rte_unused
> struct rte_eth_dev *dev,
> }
> break;
> default:
> - rte_flow_error_set(error, EINVAL,
> - RTE_FLOW_ERROR_TYPE_ITEM,
> - item,
> - "Not support range");
> - return -rte_errno;
> + p_info->action_flag = 0;
> + memset(info, 0, sizeof(struct i40e_queue_regions));
> + return 0;
> }
> }
>
> @@ -4640,7 +4638,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev
> *dev,
> return -rte_errno;
> }
>
> - if (p_info.action_flag) {
> + if (p_info.action_flag && rss->queue_num) {
> for (n = 0; n < 64; n++) {
> if (rss->types & (hf_bit << n)) {
> conf_info->region[0].hw_flowtype[0] = n;
> --
> 2.17.1
Are the above changes relating to L2-payload?
next prev parent reply other threads:[~2020-05-08 1:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 9:44 Shougang Wang
2020-05-08 1:04 ` Xing, Beilei [this message]
2020-05-08 1:52 ` Wang, ShougangX
2020-05-08 3:32 ` Xu, HailinX
2020-05-13 8:40 ` Jeff Guo
2020-05-13 9:54 ` Wang, ShougangX
2020-05-13 10:07 ` Jeff Guo
2020-05-14 6:28 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3541C2D1E3BD2E2F2F8C7C93F7A20@BYAPR11MB3541.namprd11.prod.outlook.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=shougangx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).