From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8441AA00C5; Fri, 8 May 2020 03:04:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F1F31DAA9; Fri, 8 May 2020 03:04:30 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id BDEED1D62C for ; Fri, 8 May 2020 03:04:27 +0200 (CEST) IronPort-SDR: 6gpqiWENG2KbpP8YU4euJWKUwGen1WDqARfcufDfeWwrDdP4BX8myTbC4J3D/TAPJGYRIGsB1T h294WrvHNo6Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 18:04:26 -0700 IronPort-SDR: hnBqY93EYG9bPViYaqfoZ48BBihnfpsRlhTsa+2tWoTkvOWMNbJQrOXnlq6uAWvl77N0UCJD0q LKAikab/vepQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,365,1583222400"; d="scan'208";a="296710005" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 07 May 2020 18:04:26 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 18:04:26 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 18:04:26 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 18:04:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k9Xe9XVdT6K27PPrWZ46wSm3ra2+TnFly4B95SU+ajKg0fF6wv0wqGBZ2vKtaf5I4HOVJRS6oHorqAzZ9Sxwcw+zb24FFrPaqwICdleNFRRFgG4H/Rg4maMNf9Gy1aymv3BpgdSk1tF4g7f7rZ4qlYiGep/4OYuui0Lv4Y7qsq4TQreVjwcSTXhvlDmLYeff30M6lNU0LRn6ocUla+D5QX17H/wLgmR2tWUkozrhXEX3Tg+a+FGcllkKwbVIkSk0Lxtj/MqVZkG2228o3DowR1lFk3+H1PCvoH/JRIcCGkEntJWn/mZ0brpiiFuwaNgCQvxpx9joCWeVcCeEgCST/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bwgm2IMrTGTX3xSdgSVXWrw6Lp06auQ8CFqnmr8wQok=; b=fvtJ1HaL3cHkuVjDiqs/+tySOA0UfJAZpv+VaVj2ibjfvhgoA92rwZ7BYrMCyFoajW/c1XPal6fiKMRIB4b83qhDLUjgdwNDbh6VH608jhBpEs7hU5tz/bKs9n5ZoLoH529FFxDvLRfnezpABcO0oLzKHlpEy7hS2qfc/p4SG6wCWi5w4XAIXLJTekurwqTzHOSkrv+Cjh4FKW8DWnmVqIBbf+U52Momjlf77Gj+CwqdZ2/J97Lpsgk4VaI6JgrogzRAQM+5HlNGqeacKmTt+C/0CCm2e0fLCv94GY/2GZrE+elFYmyq+DdO2ZUfiUiEnCeuRq6LFb5inRyaPFLKVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bwgm2IMrTGTX3xSdgSVXWrw6Lp06auQ8CFqnmr8wQok=; b=oqCGKIw2cbNAQaIxUTouqdW9AXnnAS2JaSBkE4qepGrX/1IuFZOzCS4ZBu6xs93a6uWO7YGkYf3m0IG5nWDcpujgCf+5VvBUQKQ6xr9GnafZLGdP4VBGhDE5XH8p9OavJzpbDi5Zo4IwTiyLoN4t16+dmXX61bP6IQDboK8BWF4= Received: from BYAPR11MB3541.namprd11.prod.outlook.com (2603:10b6:a03:f5::16) by BYAPR11MB3111.namprd11.prod.outlook.com (2603:10b6:a03:90::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.27; Fri, 8 May 2020 01:04:24 +0000 Received: from BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::9d22:d78d:bdf2:313f]) by BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::9d22:d78d:bdf2:313f%4]) with mapi id 15.20.2958.035; Fri, 8 May 2020 01:04:23 +0000 From: "Xing, Beilei" To: "Wang, ShougangX" , "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix hash enable issue in RSS flow Thread-Index: AQHWJFUl001r7UioL0GgE9kxEfLBCaidX+Og Date: Fri, 8 May 2020 01:04:23 +0000 Message-ID: References: <20200507094401.54928-1-shougangx.wang@intel.com> In-Reply-To: <20200507094401.54928-1-shougangx.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 954aa19a-9cc7-40ec-0607-08d7f2ebbf7a x-ms-traffictypediagnostic: BYAPR11MB3111: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-forefront-prvs: 039735BC4E x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6oYLPf8W4lnVTPngFh79gQR3dDlYdS16i2Z4k7PHO48Hp256Ujb4PSP5FEf8rSh2B2T1ew7FOJYxat0ltyJyVhQpi03r/A9jlqfBVLXsbZgxSliUwkI/ErFIM7I1F0fWFuowVYpP4cxP5gFjC5zm6cQlMGWNWJ3JWjPZRc+Jg0wlECfrGq4hVNIA3tQyhER/rINqDElBPdvpLhsDl9GenFY8GZIs/gaWWHPKbPIjtJ6bfmoMrdkiJNhiZrmgo7sHct3VgBJ68nS7TGxfT8H7vRCz3ppzsfWJy0MvSOWJtipqVZU1nJh8/1dYDiac+gnCdPexUN69xNlxf89gxtyO7aFEC06wx70xVVgZjx2ydSYDXKAPJVI/FuIc+YFsR8vr479zqpVQBnbfn1HmuCUNO6XNcRyfuNHudR4MuFV1792aT/X7ZTQFu0UY8GYG5flp1p06mhCXFNAh2vU84H2GJlg+RJ656zEBtvJZe6ypOlXQ9lVlvkLACt5A/LR2MI8sxalBEJiiTYHh0eiucYHx9g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3541.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(136003)(366004)(396003)(376002)(346002)(33430700001)(53546011)(86362001)(52536014)(5660300002)(76116006)(2906002)(66946007)(316002)(33656002)(110136005)(83300400001)(186003)(83280400001)(8676002)(83310400001)(33440700001)(26005)(8936002)(83290400001)(66556008)(64756008)(66446008)(83320400001)(66476007)(7696005)(6506007)(478600001)(71200400001)(55016002)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: K8uKwWrfR+WTEvEAVyX4gPL/pwLYvb3jHFTxuHebqwR/WZv4OZSPiHnICO6FvPF/8sukbssyNPPIiNWp+KEHfK7f8161yMFDtf4BzyHqNfhI8riIk7/wspg0OUsHLfBZAw6zFLxs5j0E6Basr1yIjGKhR96/0yzl85RJjRNBWtc4GkM+QCYnkegCBJ5TECi5vBksklBw26ybJ112g5cTzKDvhgnM+OxSeuoDSy/AZDDAhp4NVUAJuJCRedgKbz0/qM2T6sqTP3PPzw9ABdP19JwRGVs+m1LjTVfjjmN+n2GwWIiENUtOR4BLDrU7AklSrIxWLmLduFwBzu1twg/qTwTe02hfAPGiDSRA0MHkE/agmZfvXsiPBpwR4c8oyODRWyeCiEM8TEeLn7GKGI4dkb88xBzDG5Xjz1Nrd6bDA62QCb+u8zAzcoH4QH4t32AfGlYoanDy/FJzR1vU/bNQUgQjpVPSe7diP9KopHEUmLr8kuPxxlSlzx6y3coPIM96bwtYxj8C/C1m1aTnw6O8T5FOWOt+XZcmZPVMlSdYhx3L/y0HklLDzBrDF00QU866lVAuH1HaN9Dq7+JtpZkOUdQmbUEXO/PMbDG0Penlo2p08/3agoLceV3gBN0arUijM+Rc7TbjrccxhkrE3kT1S/jqPzatbMg46kf1fBp1bwCzgPVnbp2VI9YrIVLC/vnFtV0o2ZSuQ7j3gXGhKTrN79JFtxGaah6Iz0VCW24582eIhsQ5quGu7Rv0LCCsH/01aOi7DNVmH7/Ig68hNyZwkIfKHoa03Oyw74SdkcIvV2A= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 954aa19a-9cc7-40ec-0607-08d7f2ebbf7a X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2020 01:04:23.8676 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: auApCYQIo+RfgmOVVhJLj1oTPRb/JDrm8owijfHP5ppbGHpHcB877wt0M9ew8Siej/kf27OP33DwZfy3p+fjMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3111 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix hash enable issue in RSS flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, ShougangX > Sent: Thursday, May 7, 2020 5:44 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Wang, ShougangX > > Subject: [PATCH] net/i40e: fix hash enable issue in RSS flow >=20 > This patch fixes the issue that failed to create an RSS rule with type L2= - > payload. >=20 > Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") >=20 > Signed-off-by: Shougang Wang > --- > drivers/net/i40e/i40e_flow.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > 7e64ae53a..f5f2f0d5d 100644L2- > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4511,6 +4511,7 @@ i40e_flow_parse_rss_pattern(__rte_unused struct > rte_eth_dev *dev, <...> > @@ -4544,8 +4545,7 @@ i40e_flow_parse_rss_pattern(__rte_unused struct > rte_eth_dev *dev, > if > (i40e_match_pattern(i40e_rss_pctype_patterns[i].item_array, > items)) { > p_info->types =3D i40e_rss_pctype_patterns[i].type; > - rte_free(items); > - return 0; > + break; > } > } >=20 > @@ -4580,11 +4580,9 @@ i40e_flow_parse_rss_pattern(__rte_unused > struct rte_eth_dev *dev, > } > break; > default: > - rte_flow_error_set(error, EINVAL, > - RTE_FLOW_ERROR_TYPE_ITEM, > - item, > - "Not support range"); > - return -rte_errno; > + p_info->action_flag =3D 0; > + memset(info, 0, sizeof(struct i40e_queue_regions)); > + return 0; > } > } >=20 > @@ -4640,7 +4638,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > *dev, > return -rte_errno; > } >=20 > - if (p_info.action_flag) { > + if (p_info.action_flag && rss->queue_num) { > for (n =3D 0; n < 64; n++) { > if (rss->types & (hf_bit << n)) { > conf_info->region[0].hw_flowtype[0] =3D n; > -- > 2.17.1 Are the above changes relating to L2-payload?