From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CF19A00BE; Tue, 28 Apr 2020 03:13:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DB551D51A; Tue, 28 Apr 2020 03:13:31 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A65271D381; Tue, 28 Apr 2020 03:13:29 +0200 (CEST) IronPort-SDR: hY/4LBOAM0ppCixYpyOesIB8zU+PDjja8bIFc0pyAiUY6ot8EcLdr+1LB4wpWZd2j5Ht+tX31b Xw7vxe8RTamg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2020 18:13:28 -0700 IronPort-SDR: tjv01+04h6jzngtwZHhASg3/G+Xwj3QmdQ+29JBJZYXfEX/VU9YFf6h1MKD6INL7iyuUgfH5sj S1wAEM8ApbCg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,325,1583222400"; d="scan'208";a="260925964" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga006.jf.intel.com with ESMTP; 27 Apr 2020 18:13:28 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 18:13:28 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX116.amr.corp.intel.com (10.22.240.14) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 18:13:28 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 18:13:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LNtfeTSEhNaGGoKzjpUTOzXLfucuG5xI54+M3Gb2aKHZPMIazqY7uX8FF1D2AMTsj7qWsF+1E2QICQv65lkpcPhyAg29sJ8YtGhopHYwfN4nak69/4F1hG2nvYAbD3ikpavnC2AEbb2x5WZSgvsDpWe7aJ0P+TRePAzuK9NNAsAsbCjkpNqhb+uc7EniANqhUhWWfCILGkBkjzVzwsmAGNsGHqnP12WVQ7enuW5jB/tGf5M4kO7xgmc/yQ034yRD96TxTf8JxQNpT5R7kl51nKl6gu1Er/q9AosZmVayvQtMZq5AA1MDTvZ9BG84YN1G9bfKtgxrWx0LRwEUSpRBuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hRAL+oPvA1nSwwOOocI/javQcKAi4IWYkck3imDSPzI=; b=D1uVkioZN/Orzg13Q0cI87L2i/gupP05NcpIbTppa+gIqKBK8sO+2rMPAWxdrttAQkxAUI++26YryYzZG+1L14aryaN3vtxuHsgggUG4csWEcEof+2kEUkj+5ysQ5APW9muczIjnkbMK+myiBkLsL44mXvrR2SknTazrurceqVl/23paCj/1LvlxY1ma1S8LMlR6FspDAbrfPR2R8D9DYpvjRSGlh1Yci9ajU/zYFVvdIAYjLnYJKu0XVnLX85p4X74IF+cdaNN6FIaJwT/Ssjw0jP7RcmxPH4VkViK9GaVSN09CUj8FyygtbD6xuz1Lszl7WEMM7HOWWuNxbN0MvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hRAL+oPvA1nSwwOOocI/javQcKAi4IWYkck3imDSPzI=; b=BddrnA4F8qLPY/TqKVx9OUoLd95KW8pYQpW+jTYsLs6mXBOPfkimUYP4AD28YiaiJN4pPugsUSFlOZMwcG0Q7ga7Le2PaEH/U27Uf4VN4Gw5K5tIo29hEzvTZqj1nObXeYLOY2Mj80z0VnMFi7NDU/v+y9P5/a/vUZZ+4y5U4B4= Received: from BYAPR11MB3541.namprd11.prod.outlook.com (2603:10b6:a03:f5::16) by BYAPR11MB3848.namprd11.prod.outlook.com (2603:10b6:a03:fd::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Tue, 28 Apr 2020 01:13:26 +0000 Received: from BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::2c4f:22b:b8b0:27f9]) by BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::2c4f:22b:b8b0:27f9%5]) with mapi id 15.20.2937.023; Tue, 28 Apr 2020 01:13:26 +0000 From: "Xing, Beilei" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "maxime.leroy@6wind.com" , "stable@dpdk.org" Thread-Topic: [PATCH 3/3] net/i40e: remove teardown when flush FDIR filter Thread-Index: AQHWHGbS3wh8z2RO1UuHXJvGJOQPzqiNuoRw Date: Tue, 28 Apr 2020 01:13:26 +0000 Message-ID: References: <20200427071500.14767-1-wei.zhao1@intel.com> <20200427071500.14767-4-wei.zhao1@intel.com> In-Reply-To: <20200427071500.14767-4-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=beilei.xing@intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cf52766a-affc-4822-3e63-08d7eb115af7 x-ms-traffictypediagnostic: BYAPR11MB3848: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:538; x-forefront-prvs: 0387D64A71 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3541.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(366004)(346002)(376002)(136003)(396003)(6506007)(186003)(52536014)(53546011)(64756008)(76116006)(7696005)(8936002)(66556008)(66476007)(66446008)(26005)(66946007)(5660300002)(8676002)(110136005)(81156014)(4326008)(55016002)(2906002)(54906003)(316002)(86362001)(478600001)(71200400001)(33656002)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EbloSjr8j8UTUxVqi2YbXHLkMgRPOWbFXqAQbHSg6Md1LGPszIyLN9xAwj6L5bOZWs1xQtuIXrO//3Icz/VLdtFXB4wUw2Dy6Yrry5LsZsqPHdx1HSjZ9BEkTqxkszyju48gUqyMM6i/oFSgXf5Y+y6AsmwjZTflrQemSkfaydMMinohIiUAqSRRpTLKqjtWgMKv1bnldRcD1Usnihx+fruSXUzq913WbpxDczqpAZ9XbQzo79oHVyd3IndY6+Fz1XSHKFoCKEcGwX0vQT2pcEpif2SmaX+vwDAHhmJ631lrgNMKHnJzdD7ikBh7FmZwEMKmsNY0KNkML33rjgXn5tBRyzgEFXXnaRtPN/eiIFhZDtekb1cG5NZ98MYnGF9ReQyMtqrXa8zwKnhV03lTAWZhrvWbA583l0kHxLaaY9eoLHETrNwvlmpdK9EMs5+Z x-ms-exchange-antispam-messagedata: ayJbEi2W2JFezlckc0CFm+/fi9z7xMEuhdZrvxLwg6XhqHrcHfxYzD80BgJKRE4W1WbVWQR8D1zE/tnex7rLH2HecAmnQrm/vhNA+lfeDEy5oFUc6fhYJI6GMXOZ3z+5T1uWEfTxNeKpjpfZ2UzLLxSAxr4xar6VCEwiqEfbMiibIgllagsFNiBg+Rs/IBXs1k1sjzZwjviFvPGpPqTB1DR/j6bbbG2yPKmP3vnOZ28KRcgbZ1NCLZ8L6d+RKF3qNUmtSW28N3BovOLyZDY0vYB9kc8CjHviFSDcb5YTgejd4lfRp7MQXlKM7UJdlJpLf8FOHEfVcOz6kEODnvSuiYANQpCiPsV+8BOmk1dm8qfOrgSfhMuHPrzdfgUveB4Lvee4gtQ1oXHc4OU1Poytrk996izB0uKzFN6mCWrCEv1Zdslq3lfGzg16qWakvpWFTSv5f9BYvTga04aul7k5Os2w/e0QsR1e92HPAVi427pi8bN/FZRGL4k6g5vzBEGmPkxz3iWOTfkiZpui1LFvJIWED6GFp8T+NSbMzF73h4Ufz+BPAXJefPSi/my9HIVAwW4x9NLhDcCr82IOeIGCBwYhZZB8TBWL0C5s/FO6HZf1z1b5Pvuf6TkrjBZXPzU7Iz/hmfRSUOzjWz7msDy07gIALa5Ra/sV1OFO+Uu1JcZapfqL3aA5fSp9imUyM37zeYG7tf2SdHh85c/RXYo3fEGUCNuVLKlLQTxJ3O2InsdIKLJQSX1Xgm/5jYWu2jr0A/VCZalY6hNOL7ky4MWbkwNuOt3ol83Zq9u+2p7RdfM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: cf52766a-affc-4822-3e63-08d7eb115af7 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2020 01:13:26.7829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d4eCMJE5NeTobCzBrF+D/sMtjXSWaLcmFMtb/sNRpwBaUhU73EH9wSyP+K3H7JswWtTTmd1jeWwX5BabnwnpUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3848 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 3/3] net/i40e: remove teardown when flush FDIR filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhao1, Wei > Sent: Monday, April 27, 2020 3:15 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; maxime.leroy@6wind.com; > stable@dpdk.org; Zhao1, Wei > Subject: [PATCH 3/3] net/i40e: remove teardown when flush FDIR filter >=20 > When we flush FDIR filter, we can not call i40e_fdir_teardown() function = as it > will free vsi used for FDIR, then the vsi->base_queue will be freed from = pf- > >qp_pool, but vsi->base_queue can only get once when do dev init in > i40e_pf_setup(). If we free it, it will never be alloc again. Then we should teardown fdir in dev_uninit, right? >=20 > Bugzilla ID: 404 > Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/i40e/i40e_flow.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > 1533d5abb..65f877866 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -5145,7 +5145,6 @@ i40e_flow_destroy(struct rte_eth_dev *dev, >=20 > /* If the last flow is destroyed, disable fdir. */ > if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) { > - i40e_fdir_teardown(pf); > i40e_fdir_rx_proc_enable(dev, 0); > } > break; > @@ -5343,8 +5342,6 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf) > pf->fdir.inset_flag[pctype] =3D 0; > } >=20 > - i40e_fdir_teardown(pf); > - > return ret; > } >=20 > -- > 2.19.1