Re: [dpdk-dev] [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter

["Xing, Beilei" <beilei.xing@intel.com>]

Didn't address my comment in v1 patch.

> -----Original Message-----
> From: Zhao1, Wei <wei.zhao1@intel.com>
> Sent: Tuesday, April 28, 2020 1:48 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Xing, Beilei <beilei.xing@intel.com>;
> maxime.leroy@6wind.com; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter
> 
> When we flush FDIR filter, we can not call i40e_fdir_teardown() function as it
> will free vsi used for FDIR, then the vsi->base_queue will be freed from pf-
> >qp_pool, but vsi->base_queue can only get once when do dev init in
> i40e_pf_setup(). If we free it, it will never be alloc again.
> 
> Bugzilla ID: 404
> Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  drivers/net/i40e/i40e_flow.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> 1533d5abb..65f877866 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -5145,7 +5145,6 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
> 
>  		/* If the last flow is destroyed, disable fdir. */
>  		if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) {
> -			i40e_fdir_teardown(pf);
>  			i40e_fdir_rx_proc_enable(dev, 0);
>  		}
>  		break;
> @@ -5343,8 +5342,6 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf)
>  			pf->fdir.inset_flag[pctype] = 0;
>  	}
> 
> -	i40e_fdir_teardown(pf);
> -
>  	return ret;
>  }
> 
> --
> 2.19.1