From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4C97A00BE; Tue, 28 Apr 2020 09:16:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A20631D453; Tue, 28 Apr 2020 09:16:51 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 512631D44D; Tue, 28 Apr 2020 09:16:49 +0200 (CEST) IronPort-SDR: Q6CD86cyInQW62qV5OccN0VpDnX2/Ftgcl6GB6aJDxPaFb8J6kSQEBPp2O3zB06SINwJUdNwIo 1VjP0vBwsxGA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 00:16:48 -0700 IronPort-SDR: xFWdN6CX+tVeH87Peb3yt8T5er9IHcd0i9eZipa1r6TdZky4CVW4WNaZU2tS0k22ujtXOL6C07 tpe0qJYMF8Yw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,327,1583222400"; d="scan'208";a="404601869" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga004.jf.intel.com with ESMTP; 28 Apr 2020 00:16:48 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Apr 2020 00:16:47 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 28 Apr 2020 00:16:46 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 28 Apr 2020 00:16:46 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Apr 2020 00:16:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TjRnNKwVUjCqyu498xEH0zCASepl9Ly1l/YUJBrEFeko/BxuFqF43rVLlrIXo3hTMsNJvXhYMM/49hx6jvdm4uVB/cx2rHGOXwpgWOLEHBcqMnPFK7wkek42LEUlM0xi4mGUGahkGaRYwnuHTAY0KsORvNXg4vGclt5DCbZDwFbtb56CnmQQjrTQgAsvgbbumHXIprArGzZiB/HIavTmmT2/9Nwz66Cc1Zl2EdV2ZsMemvz5VR7fhta24kAj0fM8A2Bb+lBcarsJcDZ/VnoH0l3jQpH2XKI/XnIkOiTefrLQvwUnWvDPi+PebXis+aih2nq/lUKdG1ZMGBWaHq1yEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=raddg6eIbXpL7GXOvrkJmePRhCJ7mQSRWjJx9S8Wyd8=; b=gVellvRVZUBnWoDnGnnE1OLttz4+eZb4nntAVAiZqYJVRxcOrBAA3P3O25SBDVTRaXZ0bAdN/6jOmLMnyzMVz7p4HhyY7TSpLnE6cm/HrlP1IjeLIN7xpfwcPQIYZebE6DnWkTuDN40prLkFxXscdwUjOY9kUJVJsFH14BPIsjnV3J+JtHOLkoiZ9IGhbHjbO5rVofBec0LWSqNwktMJE4F30qpFfO4qSvqEY6bnXL0agc/qDmcA68uZbKYO/opEkOzQ1Hd6TOa6BFrLlrA++fjWhbKAR6b4g9r5XfStMJwBILkZ6GGwrpj/0lKdWWosGoy/96Bn4eTQWxa5w9oVYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=raddg6eIbXpL7GXOvrkJmePRhCJ7mQSRWjJx9S8Wyd8=; b=qts/dozH9CrKXNW7RSbBrx7idd5D7/GQeLP9BXdhqhTHB7iiYOZ/+BCM0Cpi9X2pE9jPk9yqn6qn9L/qS0BVvyiwNuSfclTQzZp407ld8OrwknE/ypa1qV1VQBd6+Yrw6IZM+YdZh15Ettjv9KWkILrZhgD+Vha4BYj9Z288BWc= Received: from BYAPR11MB3541.namprd11.prod.outlook.com (2603:10b6:a03:f5::16) by BYAPR11MB3190.namprd11.prod.outlook.com (2603:10b6:a03:7b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Tue, 28 Apr 2020 07:16:29 +0000 Received: from BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::2c4f:22b:b8b0:27f9]) by BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::2c4f:22b:b8b0:27f9%5]) with mapi id 15.20.2937.023; Tue, 28 Apr 2020 07:16:29 +0000 From: "Xing, Beilei" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "maxime.leroy@6wind.com" Thread-Topic: [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter Thread-Index: AQHWHSPnhgEQBErF9E6x00r65scpJKiOH0jA Date: Tue, 28 Apr 2020 07:16:29 +0000 Message-ID: References: <20200427071500.14767-1-wei.zhao1@intel.com> <20200428054815.3551-1-wei.zhao1@intel.com> <20200428054815.3551-4-wei.zhao1@intel.com> In-Reply-To: <20200428054815.3551-4-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6724ea9c-c96b-4a4a-c07e-08d7eb44125f x-ms-traffictypediagnostic: BYAPR11MB3190: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:538; x-forefront-prvs: 0387D64A71 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3541.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(376002)(366004)(136003)(396003)(39860400002)(54906003)(66946007)(66556008)(66446008)(76116006)(6506007)(2906002)(66476007)(71200400001)(7696005)(81156014)(8676002)(8936002)(26005)(110136005)(53546011)(64756008)(316002)(478600001)(52536014)(33656002)(86362001)(5660300002)(4326008)(9686003)(186003)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: R4iuXxCix4LgNOXuqc74QITmEzX224/vwKvcD2Qbzc19JTQ4eaS2HnuzzruyiJk1DSR7niASdcHO3Fc6xk7eRlIrTAFh7XThsld2TISO1Za6RhGRPxLJNha/e1MYu7rdmderXvKtKVSpuxSm2LDGwJanAQgrjj7CJ2QGYAbtRd/quirtczUkBe11BwqkFBkz9ca+f/5YvPIrXk9K4I4HeVrX1rh5Xeh7/Fx56d+1s6KyLUBMQx/vvnFNmW9GD4ek7noikWXusCDpbaVNyKjVGwPCo1mPwnOkEJtT7B0lyMajJKGqTXP3dV1V4SzwNSdxP+xz7PP8GBghtVZqX8PqwMHckGUMPco6cpWfBeZ8XFIBTXybWoBQgX6C4BEpdWuX95C2EzCYJqSj/uDBQBxagfwu6WlwnYH+0euFU/bRuHbVJ9JkdzosNwiDRXJ2oRqY x-ms-exchange-antispam-messagedata: ZWAPX8eqj7JEGBJDBdCQr8QsItxMWWwBKIc3Zzg+pj9lD6pm3Pri4TTadtBtRqbqXHEZFk8w6468aWFqQJQlHcxTL7gkMpKqrhMJef6Ye3JpmaAXvRIPIfwkNI5Hg8Br9japUdbuw/8PuCkuBK2/LTEv9jxCP4+9l85p7bxCzr84oPWOCnxBnMmReGgmwPaD4ZuYBP3l4Dn47cnN3saFi29gvPrp/uF70WnqA9kN8FrNv5n2wI8lLzfGMJtpsNlBOjvl8eCqVrUeIIu53h6rxzu8q40ibSFSn7+6/UEfMCvrkfHrjGacjNoSiP40EfcLEDDysAy1UMr703uolgNdeJ8XS3GHDRIqNDRSDZ37llAedNFAzKpCuvqeR200K++W1V3YQmZtVV8f6Av8h+MV79VgaX90Pu2WL0dWmM94HrYHxMs0f1FuIzUWCJp0KjzWyiTvLTGDO9ZdJH83h4t7Qq7KPA1yj6sAr/H2f1P23oFKbMZdX7S58JWiNxDEi5ftcXw0ofegb8qwvRyT4fkHMyDcpGffTR8xLfFzTLVccgy9XAi/qgvCS/dqlPfrrGa6gN96ynbwAP6I0slmyefDw+PiDB+Wknwn8971UJt736RejX5l8jjgAw9U3bN3ZjjFADRUiNuEfyOEVwKzZk+eG8IUsQqmKD4mZUNJxgCr87w8N7nK9YQuPvVjk+J2z78mIP/AW3wpgrUMjj5uexcVEwuww7++0LEAbnZ7OcTqnOn0Rn1DNhiSoaBIZeeoe/i7FhrWX8H5ZrJsLkhjzb7diQNUFGDzeWL0vThufrKD0zM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6724ea9c-c96b-4a4a-c07e-08d7eb44125f X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2020 07:16:29.3463 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5ZOPoD8R9HA2RADDrRIqdBHSXJFdUD7JpJjBnonLtss71rKc0pmxeoEEkYdal2UYiNhxX3eIIB1PQfyHzUR5Uw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3190 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Didn't address my comment in v1 patch. > -----Original Message----- > From: Zhao1, Wei > Sent: Tuesday, April 28, 2020 1:48 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Xing, Beilei ; > maxime.leroy@6wind.com; Zhao1, Wei > Subject: [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter >=20 > When we flush FDIR filter, we can not call i40e_fdir_teardown() function = as it > will free vsi used for FDIR, then the vsi->base_queue will be freed from = pf- > >qp_pool, but vsi->base_queue can only get once when do dev init in > i40e_pf_setup(). If we free it, it will never be alloc again. >=20 > Bugzilla ID: 404 > Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/i40e/i40e_flow.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > 1533d5abb..65f877866 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -5145,7 +5145,6 @@ i40e_flow_destroy(struct rte_eth_dev *dev, >=20 > /* If the last flow is destroyed, disable fdir. */ > if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) { > - i40e_fdir_teardown(pf); > i40e_fdir_rx_proc_enable(dev, 0); > } > break; > @@ -5343,8 +5342,6 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf) > pf->fdir.inset_flag[pctype] =3D 0; > } >=20 > - i40e_fdir_teardown(pf); > - > return ret; > } >=20 > -- > 2.19.1