From: "Xing, Beilei" <beilei.xing@intel.com>
To: Tom Barbette <barbette@kth.se>,
Andrew Rybchenko <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "orika@mellanox.com" <orika@mellanox.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] rte_flow: Different devices have different field indianess?
Date: Mon, 30 Mar 2020 00:48:52 +0000 [thread overview]
Message-ID: <BYAPR11MB3541E56309EF1D46043F0920F7CB0@BYAPR11MB3541.namprd11.prod.outlook.com> (raw)
In-Reply-To: <56e1f5fc-e159-6050-0f8e-4ded401db6bb@kth.se>
> -----Original Message-----
> From: Tom Barbette <barbette@kth.se>
> Sent: Friday, March 27, 2020 10:51 PM
> To: Andrew Rybchenko <arybchenko@solarflare.com>; dev@dpdk.org
> Cc: orika@mellanox.com; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: Re: [dpdk-dev] rte_flow: Different devices have different field
> indianess?
>
> Le 27/03/2020 à 15:44, Andrew Rybchenko a écrit :
> > On 3/27/20 5:29 PM, Tom Barbette wrote:
> >> Hi all,
> >>
> >> It seems rte_flow_item_eth takes its ethertype in host byte order
> >> with i40e, but in network byte order with mlx5.
> >
> > If so, it is definitely bug in i40e, since struct rte_flow_item_eth
> > defines type as rte_be16_t type.
>
> Indeed, with testpmd I would expect the first one to be the one that works:
>
> testpmd> flow create 0 ingress pattern eth type is 0x0800 / end actions
> mark id 5 / end
> port_flow_complain(): Caught PMD error type 13 (specific pattern item):
> cause: 0x227fd75540, Unsupported ether_type.: Invalid argument
> testpmd> flow create 0 ingress pattern eth type is 0x0008 / end actions
> mark id 5 / end
> Flow rule #0 created
>
It's not a bug, but HW limitation.
Only FDIR supports mark action, but i40e FDIR doesn't support filter with eth type 0x0800.
Please refer to the following
ether_type = rte_be_to_cpu_16(eth_spec->type);
if (next_type == RTE_FLOW_ITEM_TYPE_VLAN ||
ether_type == RTE_ETHER_TYPE_IPV4 ||
ether_type == RTE_ETHER_TYPE_IPV6 ||
ether_type == RTE_ETHER_TYPE_ARP ||
ether_type == outer_tpid) {
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ITEM,
item,
"Unsupported ether_type.");
return -rte_errno;
}
Beilei
>
> >
> >> Wouldn't it be nice to unify that? Else is there a way to know in
> >> which byte order the spec should be given? I guess that expands to
> >> all fields, but I only compared the ethertype field.
> >>
> >> Thanks,
> >>
> >> Tom
> >
next prev parent reply other threads:[~2020-03-30 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 14:29 Tom Barbette
2020-03-27 14:44 ` Andrew Rybchenko
2020-03-27 14:51 ` Tom Barbette
2020-03-30 0:48 ` Xing, Beilei [this message]
2020-03-28 20:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3541E56309EF1D46043F0920F7CB0@BYAPR11MB3541.namprd11.prod.outlook.com \
--to=beilei.xing@intel.com \
--cc=arybchenko@solarflare.com \
--cc=barbette@kth.se \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).