From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 061E1A034F; Tue, 28 Apr 2020 09:38:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4D2A01D50E; Tue, 28 Apr 2020 09:38:15 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id C8CD51D509; Tue, 28 Apr 2020 09:38:12 +0200 (CEST) IronPort-SDR: X2ygEzTwqVL8vsrgC43QnuE2LjJM9DIUMgytu0mzWd/05FDO9s/5GTNaoey6wIrojdx0I+FiOP UmdQemAcHEow== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 00:38:11 -0700 IronPort-SDR: 2yj9RkXFFz1n4fcu5CfOywW5Cn7aTLnWzZX1AVj1mBsFVBP0sRZuknCJAheeOv9Yl6Rzfqrpl+ ePoJJ1okhXSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,327,1583222400"; d="scan'208";a="261012637" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga006.jf.intel.com with ESMTP; 28 Apr 2020 00:38:11 -0700 Received: from orsmsx123.amr.corp.intel.com (10.22.240.116) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Apr 2020 00:38:11 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX123.amr.corp.intel.com (10.22.240.116) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Apr 2020 00:38:11 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Apr 2020 00:38:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aOvezQzHlOjuL9VkBJg6lG/PjRjgnuy3/EJqV1e8bUKV4QpjBdBOK93aqS69PuADKNJasgwvOyshth5DMGQvU0Mq/wMnBxrgkoWxWP0f4JZeAwpwT+5k7VVewvHX1AQrzyFIELR7xUO9fju+FlsLbPyJ1+IVyCFA609IjIsenzODEpLe+4VZXR02YY8MJVGNXkPKLgDdo2C02qLYmvj5acsmw32QVRm2oRlDRte5VR5P1H5heYW1ymV9RNFWhLj/Boctqy/Sv/wDaj7StSWU0s9ieHcIQprOVdpDmqQw/Gess3mfIAz2PJHceXtXplTj9ouQYEVlUwRkVQsr4eX+eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hFkyZZ1e6N1U45rQv7EOdT79LyNfj3SdhYF8Mx1wiKQ=; b=jEpcp3m+AHFi3mQ80Ex98zQ4C3+Fw1L/RMkvbZJsM+mTptojTX9nBStGrN2NJQOLiV3zoJAqMkbY4XDYfTrtDXWIkYtz3XuVI6B2nh1980L4TpBS7x54UGFGdBhzu8LAfwe5xWKluP0V1C1V19ZsZIskkAgqPOG8cv+Q26rYorCs8znWukmJtBah51gUopoMiuL+0W73ZDXDobAq3+MSJx+no2IbAM/NHSQBIX/oP7EGCo9XVdjGNVfq4RvQxy3qL17YzVQBvdBCqE/dMVJh3aAZlmbZakjkWiWrI6y8WIPDVyZlY+XISKuSGrlGV+nqdWz2iqIk3GWiAUkDXdghkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hFkyZZ1e6N1U45rQv7EOdT79LyNfj3SdhYF8Mx1wiKQ=; b=ioQR5cJKRq/bYJ93mpvEWxtfBkGCwWWE5GtWPbfZiz7bJD8AXJfTNS0jfo5s26mT8mceORVFRBHMnL+HeYW0AIadScO6HDuc7r7yFq19kOuc5Z8hx+YhxTsWt98An+C+mfS3WugTyRi9rlyVAMr1lSfQIx8wH45sXLGMLpiJfZU= Received: from BYAPR11MB3541.namprd11.prod.outlook.com (2603:10b6:a03:f5::16) by BYAPR11MB3336.namprd11.prod.outlook.com (2603:10b6:a03:1a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Tue, 28 Apr 2020 07:38:10 +0000 Received: from BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::2c4f:22b:b8b0:27f9]) by BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::2c4f:22b:b8b0:27f9%5]) with mapi id 15.20.2937.023; Tue, 28 Apr 2020 07:38:10 +0000 From: "Xing, Beilei" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "maxime.leroy@6wind.com" Thread-Topic: [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets Thread-Index: AQHWHSPi9gJq1kcJhkOTGu7cpkOCuqiOH51A Date: Tue, 28 Apr 2020 07:38:10 +0000 Message-ID: References: <20200427071500.14767-1-wei.zhao1@intel.com> <20200428054815.3551-1-wei.zhao1@intel.com> <20200428054815.3551-2-wei.zhao1@intel.com> In-Reply-To: <20200428054815.3551-2-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1b17f08c-7903-4755-7998-08d7eb4719c4 x-ms-traffictypediagnostic: BYAPR11MB3336: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0387D64A71 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3541.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(376002)(39860400002)(346002)(396003)(366004)(136003)(53546011)(8676002)(316002)(55016002)(9686003)(4326008)(186003)(5660300002)(478600001)(2906002)(52536014)(66556008)(54906003)(110136005)(8936002)(66446008)(64756008)(66476007)(6506007)(66946007)(81156014)(26005)(71200400001)(33656002)(76116006)(7696005)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: atVx9Lz7qZ3xqjNvc1Dln8FOOmNzy8i/E8LLxuTt+0FIjK4/UxuActswC09nNLWcNQTQ3ZdABEm4RLY/TZPSK28Psv8Pr+JQCplzX/IKqibS5IjAgWXwu6og8Znd0S0br3kvYTE0assaDykKfIT+qkHNlh1X0VDdzTgrs1opbrx454wqBRj8Q8BeCnsp/H0iOweVVjhq8oLrbgVuEzlQSZ2cRmgf4pnK58vHt6XQdLW9U4PxOZCHO/21VmcINHoj6murc7Xg4BvsxhFyGqUm+qc6chDis8e5YrV4LaJ+Qn5zFuCe7RXQFG7y1iSdDlFDWHxqKLRUmDk9Dw250sk3sHaafkHpgugWSNgRySudoGLijR/17sAbgeHpKSevTp0ypVB7H1g6tdrDNZuu8bAM2Gx1Tycz/xdQ5SeiEXwh8JjwO8nGiWRAfp+BULLm3vV6 x-ms-exchange-antispam-messagedata: aRXYDe6GWrDwrZKPW3KwTgRffhEve4mno7IugCppKAl3KtSODZRdyvoI6+nykCkgFjidsHwGRZOf1n9sBgKNZ9EAL/nu7k/R+xanAfmz+tsm2gRHu+okxlePLIAL84li6ll6GZi1fACXyxEJPM2+hX6GwZTFok7UmB12H1sZYVe5DULi2VTkGiMMQkU7+2DyCSTcLh8HKWZABHX+90VSJqdDiNu+Rve7BtObQPVsbtdLH0sSh8eWDlXQGJNC048WT3Ae+aitQRpc+ocgfnhOJmPgwahxbp324saP7EkMt5pwaunnTxC1uFsm9/ytn6hRiSV29JgoJY313pyeyygnEIVAjcfxNe8SrwMPY1AG96Tu/aLc0J42hcPu8N70EXYSwPjUnR5UMuCinS3olw2XDCObjO4iYiE/S8kAD5fj7eZkinoZ+jf42/fMafzUOqKEci2/Re0nvjkpiz9L9Ctc2TFkQdJo3orJTORqtLI7J1x4P6zF0RKX72PLCLhllqzjnoLltwjbUgAPTx18EBWxdxSxqgwABAgkj0QQpPH9EJ5ByVBukm9d+u/z42dh3+VfLFqoCT0NJ6OvT3+OLHl9wDRKDhstyc0f21jnuPiDPYhn0BMptXXds31CyrNFp0MwNTEgC3LjiINQql2E9qdo7Ont6jCUzwgrOobyKqTo/VNoUg2fpponAyt15dIoUJoaQFJ2iYz0u3lC4sxxFa4UxAhYPFa4Tq+pARIKmixQZoU1x1szr2E5cVRQevdxVZInn/7pCbyKVbzQxvgKU45whQQiDDHKW4+FGY45VGp64tk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1b17f08c-7903-4755-7998-08d7eb4719c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2020 07:38:10.2637 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6oXXXwkVVZbft36tuVWa+zbciEa6bI2IAEVoTM+uTdJLKd/lKosXEV0mb1HOX6Yc/W+Ki4ZmZ6ASc/EwxPL/dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3336 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhao1, Wei > Sent: Tuesday, April 28, 2020 1:48 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Xing, Beilei ; > maxime.leroy@6wind.com; Zhao1, Wei > Subject: [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets >=20 > This patch can enable FDIR awith ethertype as input set for ARP packet, i= t will > associate this rule, "flow create 0 ingress pattern eth type is 0x0806 / = end > actions mark id 0x86 / rss / end", with pctype > I40E_FILTER_PCTYPE_L2_PAYLOAD for ARP packet rule. > I have tried to enable ARP ethertype for FDIR filter, it work well for AR= P for > FDIR filter, so delete the check. How about=20 'Currently, flow "pattern eth type is 0x0806 / end actions mark id 0x86 / r= ss / end" can't be created successfully. FDIR parser shouldn't deny RTE_ETH= ER_TYPE_ARP since ARP packets will be parsed as PCTYPE_L2_PAYLOAD. This patch fixes the issue.' ? >=20 > Bugzilla ID: 402 > Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/i40e/i40e_flow.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > 7e64ae53a..1533d5abb 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -2666,7 +2666,6 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev > *dev, > if (next_type =3D=3D > RTE_FLOW_ITEM_TYPE_VLAN || > ether_type =3D=3D RTE_ETHER_TYPE_IPV4 || > ether_type =3D=3D RTE_ETHER_TYPE_IPV6 || > - ether_type =3D=3D RTE_ETHER_TYPE_ARP || > ether_type =3D=3D outer_tpid) { > rte_flow_error_set(error, EINVAL, >=20 > RTE_FLOW_ERROR_TYPE_ITEM, > @@ -2711,7 +2710,6 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev > *dev, >=20 > if (ether_type =3D=3D RTE_ETHER_TYPE_IPV4 || > ether_type =3D=3D RTE_ETHER_TYPE_IPV6 || > - ether_type =3D=3D RTE_ETHER_TYPE_ARP || > ether_type =3D=3D outer_tpid) { > rte_flow_error_set(error, EINVAL, >=20 > RTE_FLOW_ERROR_TYPE_ITEM, > -- > 2.19.1