From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Kevin Traynor <ktraynor@redhat.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
Date: Mon, 25 May 2020 09:54:39 +0000 [thread overview]
Message-ID: <BYAPR11MB36711E77C8F3E47D16DEB141FCB30@BYAPR11MB3671.namprd11.prod.outlook.com> (raw)
In-Reply-To: <2374873.m242xcD6Ei@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Sunday, May 24, 2020 11:47 PM
> To: Kevin Traynor <ktraynor@redhat.com>
> Cc: Mcnamara, John <john.mcnamara@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
>
> 11/03/2019 19:39, Kevin Traynor:
> > Make clear that spaces are only for alignments less than tab size.
> >
> > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> > ---
> > --- a/doc/guides/contributing/coding_style.rst
> > +++ b/doc/guides/contributing/coding_style.rst
> > - Global whitespace rule in DPDK, use tabs for indentation, spaces for
> alignment.
> > + Global whitespace rule in DPDK, use tabs for indentation, spaces for
> smaller alignments.
>
> tab Vs spaces 😃
The forever-war!
>
> I am not sure what is the most followed convention in DPDK.
> I thought most of alignments were done with spaces only.
That was my understanding too: tabs for indentation, spaces for alignment.
John
next prev parent reply other threads:[~2020-05-25 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 18:39 Kevin Traynor
2019-03-11 23:08 ` Rami Rosen
2019-03-25 11:36 ` Kovacevic, Marko
2019-03-25 11:36 ` Kovacevic, Marko
2020-05-24 22:47 ` Thomas Monjalon
2020-05-25 9:54 ` Mcnamara, John [this message]
2023-06-12 15:59 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB36711E77C8F3E47D16DEB141FCB30@BYAPR11MB3671.namprd11.prod.outlook.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ktraynor@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).