From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0E1AA04F6; Wed, 11 Dec 2019 17:32:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7AC232C6A; Wed, 11 Dec 2019 17:32:01 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 23AC791 for ; Wed, 11 Dec 2019 17:31:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 08:31:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,301,1571727600"; d="scan'208";a="414912591" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 11 Dec 2019 08:31:58 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Dec 2019 08:31:58 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 11 Dec 2019 08:31:57 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 11 Dec 2019 08:31:57 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.57) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Dec 2019 08:31:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eKnt1rHuGqaoecQQoxzTyOq+SdKnWtQmOgbdkygRhOJn1StWyze4YqkI5zmGBpobkHDKAX4LEvNZgygkY8EzFSndTWiNjI+o0Q6bNIswmAB2QrenHtmknHeFhjaKIpfF5aVHLLdTStF0qEAow366bqTPUdW/sRO8ztUiwKoN0mUF8SBtIs8VRBO1Ur3CVAj2OmY4tdP6YtU1O2MCSxg6yQ0LdHP756xteYeZi1XAdRRdT8hqM59BQXXJJCvbPAXz9o/EtGWDReCjUIVLAcepG4q5Z65/SlBMgmNTkLLpiVlNRzoZyh8gzMh6NOsF7ViHkcPvLVsPlvWHYu3igi/2jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KXB322SJtLckF1ulPHwu5LCAjyjKr8tO4t6tc4hzTF8=; b=VeJofi7yADpDDnj+OpUYx8dHOdtSKr6pa3KxiUk1pxgFn8R7rTyY7a06oKeTve2PqEpWa9Pjg31RUnzsS3RX4ihFmO9Bn3iXiAASC0AltYjrBd+U6UdMvS9KlDtEovf19LejwHGo/75d8NUjqXDdrKo3mbRggYOT4UwLKtZWc+XM625mtDJFdpLdTyjzN4nNnKJkdSkVDrDd+eDZYXFGnjzajrnN5jOCIb9Rz+k68vZI9gyHNWAD9PR2wEHH1O39utTOBywcOmwQy770Ou/SSQRG9k4d/fSmlcfbNdRhUDiZSpHf1kAPt7Kg7tMtB0cm26sj+dfjLSUFajASiJVfgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KXB322SJtLckF1ulPHwu5LCAjyjKr8tO4t6tc4hzTF8=; b=SdYWONWxAifqWmO1eMyUpIgMh/eFd02cnhC8P56tVT3BSyg1HJYlMsW2mmNnR3qq/71p8CLDAFUEiQx3xrjKkQgRpChImpO6qtse1plsKd3nXcYQ9uIesn0cSfYeGRWuUi23tU57OGN9zKUzEp/aRCAxrktjqYNfsAvh+lOfGXk= Received: from BYAPR11MB3671.namprd11.prod.outlook.com (20.178.206.79) by BYAPR11MB3430.namprd11.prod.outlook.com (20.177.225.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.12; Wed, 11 Dec 2019 16:31:25 +0000 Received: from BYAPR11MB3671.namprd11.prod.outlook.com ([fe80::5c22:16b9:2d35:4f0e]) by BYAPR11MB3671.namprd11.prod.outlook.com ([fe80::5c22:16b9:2d35:4f0e%3]) with mapi id 15.20.2516.018; Wed, 11 Dec 2019 16:31:25 +0000 From: "Sexton, Rory" To: Ori Kam , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Xing, Beilei" , Adrien Mazarguil , "Jagus, DariuszX" Thread-Topic: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API Thread-Index: AQHVqq1WuGnZL6ab8EC6Oc0BGrrb+aezMF2AgABIiPCAAGOWgIAA9PeQgAAncYCAAC6LUA== Date: Wed, 11 Dec 2019 16:31:25 +0000 Message-ID: References: <20191204141055.3647-1-rory.sexton@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDUyNjk2YTctOTgwMS00NmU4LWE2YmUtY2VkMjRjNzRiYjIwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoialoxRytMSlpoV3JWdHR0YkhRMXROR0pcL3dnTm9DMVA1ZDF3OEZtc2J5bEtZNlZ4UlBjb0g1Vk16WHJRSFFuUjkifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=rory.sexton@intel.com; x-originating-ip: [192.198.151.177] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a2d87af-97b6-4900-5be6-08d77e579121 x-ms-traffictypediagnostic: BYAPR11MB3430: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 024847EE92 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(39860400002)(366004)(136003)(396003)(346002)(189003)(199004)(51444003)(71200400001)(55016002)(52536014)(86362001)(316002)(66946007)(76116006)(2906002)(9686003)(7696005)(54906003)(66476007)(66556008)(107886003)(110136005)(66446008)(64756008)(8676002)(8936002)(26005)(4326008)(33656002)(478600001)(6506007)(5660300002)(186003)(81156014)(81166006); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR11MB3430; H:BYAPR11MB3671.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5N+bJRnYncD+HIM+XV/fZ42OIsWutaejWj6qVz8AQThj2Sl9MbWQpLfGauvhgHrA1rVusIlJ58eTwJRrePucgB1jkwLuUZq7h88Tbb8vDUQ5Ennv23z+kOHB/5XdjWxH1TYJEnJFGB0xdsTQdXssu3KVzunegn0K0m10v6owWB2hQsQ8KZPkWylClXrmn30V5f4BrUMcqlAtmp3bknqOsvI5zy7mpxEd4xgHUWOKCXSUjeF7jw/9htHosGfS3eOYb0UdDGxSRxy4QMpboCRB4U+os1LSWWwbanNp80YuZWe5hh3oQY7k0INRa/7OmkL/KjVTt8GRxhTXu00+gJat2/tz6rXgKgrK22fkjLn++Oa5YxRRv5tPzc7B3AufTFkrgjGwaaNj48VBNv1ehHt/YCmcyXokJz2dyd3t7Lj1wunLPjcpFQaObjnTPd+bC8CtnZMHySqXA4Rmo0Ac9f6XLDIYJ+0wey0lLaugSXjsaoy1SXeaHSYlgTlj7zZ/Vq7w Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7a2d87af-97b6-4900-5be6-08d77e579121 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2019 16:31:25.6272 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9ncwn7YZgtzUv2510aQc+Z2o2Kbez3Yn4uPQjAcuf9PQsWxhpGe2+LDcdIQhOOgThoXmoSzh2sgvbvPNJ2ABXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3430 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ori, See comments below. Regards, Rory > > > > > > +/** > > > > > > + * RTE_FLOW_ITEM_TYPE_L2TPV3. > > > > > > + * > > > > > > + * Matches a L2TPv3 header. > > > > > > + */ > > > > > > +struct rte_flow_item_l2tpv3 { > > > > > > + rte_be32_t session_id; /**< Session ID. */ }; > > > > > > > > > >Does it make sense that in future we will want to match on the T /= =20 > > > > >L / ver / > > > > Ns / Nr? > > > > > > > > > >Please also consider that any change will be ABI / API breakage,=20 > > > > >which will > > > > >be allowed only next year. > > > > > > > > > > > > > I don't foresee us wanting to match on any of the other fields, T /= =20 > > > > L / ver / Ns/ Nr. > > > > The session id would typically be the only field of interest in the > > > > l2tpv3 header. > > > > > > I think that adding all fields to the structure will solve the=20 > > > possible issue > > with adding matching later. > > > Also and even more important you will be able to use it for creating= =20 > > > the > > raw_encap / raw_decap buffers. > > > > > >What do you think? > >=20 > > Based on the differences between v2 and v3 the only field of interest=20 > > in > > l2tpv3 over IP is the Session ID. > > I agree it would make sense to add all fields if we were implementing=20 > > l2tpv2 however v2 would require a different implementation to v3 due=20 > > to the differences between both Protocols. > > Even if we just support v3, I think that it is a good idea to add all fie= lds of v3.=20 > This will allow the use of the raw_encap / raw_decap actions. > Please also note that you didn't add the new item to cmd_set_raw_parsed = function. > this function is used in order to create raw_encap/ raw_decap encapsulati= ons. I think the confusion here is based on the fact that there are 2 separate t= ypes of l2tpv3. - l2tpv3 over UDP, which is very similar to l2tpv2 with only change being 1= 6 bit Tunnel ID=20 and 16 bit Session ID changing to 32 bit Session ID. All other fields rem= ain (T/L/Ver/Ns/Nr). - l2tpv3 over IP is another type of l2tpv3 that is carried over IP rather t= han UDP and as such the message format is entirely different and consists of just a 32 bit Se= ssion ID. The other fields mentioned above do not exist at all in this l2tpv3 header. This patch was targeted at creating a flow to handle l2tpv3 over IP exclusi= vely. This is why the Session ID is the only field in the flow item. I can add the item to cmd_set_raw_parsed function.