From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C13A6A00C5; Mon, 6 Jul 2020 11:08:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60C0D1D6A5; Mon, 6 Jul 2020 11:08:23 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C909E1C00D for ; Mon, 6 Jul 2020 11:08:20 +0200 (CEST) IronPort-SDR: oqgfNjPkEKx4exHHxckHmX3mKXXu1JM38s9IYqn7+EV0I7F2p08Ou8q2xyupw5TpMjn6hREkVS jztET+QE1SsQ== X-IronPort-AV: E=McAfee;i="6000,8403,9673"; a="148879379" X-IronPort-AV: E=Sophos;i="5.75,318,1589266800"; d="scan'208";a="148879379" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 02:08:19 -0700 IronPort-SDR: qdLsD1mMPflgL27wEnK8KOWIozFOKO7uqCQ+37JZfnV3VRKRvGSKcLOsnrhSFtS9J51VjX9gye pw6qVc6G1Iyw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,318,1589266800"; d="scan'208";a="296939557" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 06 Jul 2020 02:08:19 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 6 Jul 2020 02:08:19 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 6 Jul 2020 02:08:19 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 6 Jul 2020 02:08:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vqqn3X7k8Xp//zgsXyTBfM2JHzkdhVF/NMHMLfcEVoYxwvzBUtQdhFCNZGEo2yv3BYr1FqfzoGo/qovk8BJLjBQ33YN1psgE4ELB9knKpyk42W2a1lL0Z8bjnDFNA77JkkbcoONXQqmJ7NbCGaXDMwM2yj/x4QDrR2t8F4RpGSFCgA8NZVGJVlcC7AsH5ZADbW6Xhe5Fbvh+lMAH4EuUcKKlauC0Oq9lclfhcwhv//FtM6i0Ns6oNqz64dhEWqLZYc9OBxqcUa0LKeY3hkUpBByBeQoVzqiy/JRL5v1x9Mj973DSbCGK80vZl82tIkrgd0maNJuEKzYezIy/dgvg6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gWlXYC/QlVghKU0rgRG4TJKnTyqCcfxtnO/ytnUkCoM=; b=YLtYGkm+ysT7nLR+1kY0MEPkJznASWyQRIsxsIVr05JeGX/S9E5RbTLuSXYk5CD/npVYJMWFMHfakTdyB5rrZjTBPDBMQSqS1S0SaiqoT/9J7kNfVcKqxxYJRQVFcCiSRNhZjeJ+U0KEIPO+urxeNHrBmIVN+swR4zkDto7rV9nDs2PmqBYcncectz2MdMJKjBAhhInjoN8F8TTwi9bo3LLghOq4rn9BMR1TOAIGzXmNy53pcgeLQoFFS8hji409n34dC4lyDThsVWz8nFmyHm20WOWSykx+4bowDECrIqVwQAtyVXV60/jJSLMstvybiobZUf9ZDrnqsLAbGRvfDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gWlXYC/QlVghKU0rgRG4TJKnTyqCcfxtnO/ytnUkCoM=; b=novBTTdV3XAMlY+Pa50aNOdIawc1Se5zPQhnCUNavHcjRstssoYCfT9h7xiydExfhLqvELQcX8m31pKQbEOD9Nhlwb8PgL+d/0aV04/nQGvDuoKvUc+Q+/ESi0jKfq3sDtYEXLwfka6z+mKzahJcrWwTrSn0o+ASGIpooDoN1jo= Received: from BYAPR11MB3735.namprd11.prod.outlook.com (2603:10b6:a03:b4::31) by BY5PR11MB4039.namprd11.prod.outlook.com (2603:10b6:a03:18b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.23; Mon, 6 Jul 2020 09:08:15 +0000 Received: from BYAPR11MB3735.namprd11.prod.outlook.com ([fe80::2571:24e3:140b:d78c]) by BYAPR11MB3735.namprd11.prod.outlook.com ([fe80::2571:24e3:140b:d78c%7]) with mapi id 15.20.3153.029; Mon, 6 Jul 2020 09:08:15 +0000 From: "Fu, Patrick" To: "Liu, Yong" , "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "Xia, Chenbo" , "Wang, Zhihong" CC: "Wang, Yinan" , "Jiang, Cheng1" , "Liang, Cunming" Thread-Topic: [dpdk-dev] [PATCH v4 1/2] vhost: introduce async enqueue registration API Thread-Index: AQHWU0Jg/VgcKXFBPU2LclF/yszdKaj6QcMg Date: Mon, 6 Jul 2020 09:08:15 +0000 Message-ID: References: <1591869725-13331-1-git-send-email-patrick.fu@intel.com> <1593778906-47832-1-git-send-email-patrick.fu@intel.com> <1593778906-47832-2-git-send-email-patrick.fu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E63616C54@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E63616C54@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f104d085-dd71-43cb-9da3-08d8218c1dd8 x-ms-traffictypediagnostic: BY5PR11MB4039: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 04569283F9 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nBqyZVUFxcJU2dDPpEd/jhqQgR8kTXUbXCsez8gloGtLwaFHZvbkRyqswHLQIm//5Ob9MqSpDGQO8wcp85wd7vapefQKInamYQVMK5WxQuRX7ymi+gw7sKAANdVcQjYshHjYQ1F0Jh4hN6JcDLyPaNVvXioaIH7JIFLkiar99pr0QnzurjzNUJdtwBsv1H0hILPq6g1xO1Z/73FzEFJbun4xkdvn+pp+onedD5i5DLlCqam582wfhL816G292HsbITNrRAY3MY7/zDurmSRWIVgEQGDQqysUnrv2w+6oFK3++FV31/MBieJrfdCX9iPTIkm78X7Z4qdsHswcXaSPuQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3735.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(366004)(346002)(376002)(39860400002)(54906003)(110136005)(316002)(8936002)(4326008)(107886003)(66946007)(66556008)(2906002)(9686003)(53546011)(6506007)(55016002)(66446008)(66476007)(64756008)(186003)(76116006)(7696005)(26005)(71200400001)(86362001)(52536014)(6636002)(5660300002)(33656002)(478600001)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: omN1ELksK/GEPfbTqj8EuTqZXAlLjnG5Bo/tGGgL/6ulYETSgtSq2EVSB1x7ZfFCitsYsnZRdSLeWeZb/MA1x63nY6HtvicHtiVZYTwMp70yYjipMHijdrSDrSjWIxszQ3FxVytnvZ24KnDIx5+WH7HjDLXF/Z2Oy722WPV1BKmerSmsUf82NlaU0wCEFadkJ5Yh/jU9Mm2Rok4V/9Dw/MAR9BAYAN11F07dIL6vV9rvf6mgpS0arhVunPAJ1nZnwWIWjRYcsXR1HExgv4xRZtgfFkgl33ZnSDphqhav92IOLML0wKsC/LhCnVzZuKOs8bIFmOgwapQTBDPZSz4BW8hrGBFlreLE4G+Ag6kSrWQ8hks6WeEE6tYMJ8qbc6kVLKGVx2mG9z8tOQjAMQPwu2k6hjF/A21CRbvngFUjfpgju4bTN75WRUtBGqi4S5++vuhiNRvdohqZQGBhJrPhel3GDk0XzklXycxwcEI9zvi9x5gQWyJcMvCJaRAQXX4e Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3735.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f104d085-dd71-43cb-9da3-08d8218c1dd8 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2020 09:08:15.0969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PdH0CJMV4T1IkBymYqJaigNZPf+hLnyn0vceEtm/AXQ/a/ij4WosAv5XuDQqe4Gms3z+UNDal8MW6V2Az6rC1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4039 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 1/2] vhost: introduce async enqueue registration API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Liu, Yong > Sent: Monday, July 6, 2020 11:06 AM > To: Fu, Patrick ; dev@dpdk.org; > maxime.coquelin@redhat.com; Xia, Chenbo ; Wang, > Zhihong > Cc: Fu, Patrick ; Wang, Yinan > ; Jiang, Cheng1 ; Liang, > Cunming > Subject: RE: [dpdk-dev] [PATCH v4 1/2] vhost: introduce async enqueue > registration API >=20 > Hi Patrick, > Few comments are inline, others are fine to me. >=20 > Regards, > Marvin >=20 > > diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c index > > 0d822d6..58ee3ef 100644 > > --- a/lib/librte_vhost/vhost.c > > +++ b/lib/librte_vhost/vhost.c > > @@ -332,8 +332,13 @@ > > { > > if (vq_is_packed(dev)) > > rte_free(vq->shadow_used_packed); > > - else > > + else { > > rte_free(vq->shadow_used_split); > > + if (vq->async_pkts_pending) > > + rte_free(vq->async_pkts_pending); > > + if (vq->async_pending_info) > > + rte_free(vq->async_pending_info); >=20 > Missed pointer set and feature set to 0. >=20 This memory free statement is part of vq free operation, which should be sa= fe to leave the vq member pointer just as is > > + if (vq->async_pkts_pending) { > > + rte_free(vq->async_pkts_pending); > > + vq->async_pkts_pending =3D 0; > > + } > > + > > + if (vq->async_pending_info) { > > + rte_free(vq->async_pending_info); > > + vq->async_pending_info =3D 0; > > + } > > + >=20 > Please unify the async pending pointer check and free logic and pointer > should be set to NULL. >=20 Will change it in the next patch version Thanks, Patrick