From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2689A04AB; Wed, 6 Nov 2019 17:04:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 75DDB1C300; Wed, 6 Nov 2019 17:04:01 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id BFB851C2B2 for ; Wed, 6 Nov 2019 17:03:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 08:03:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,275,1569308400"; d="scan'208";a="377093359" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 06 Nov 2019 08:03:58 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 08:03:57 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 08:03:57 -0800 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.50) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 08:03:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YSvBVMxd70f2XVHgMNWMDEAkimx07NnEIgnXtYJvwpOTIKRYYAWkvAPflHWtFYGFh32NF4Y+Sh6p5x8fCwmnONIqTNp1J0ZzDfnEHvTBbIODNI88AjwzkGZ43iJbYG45hHQXJi8b+HxaLAwEDWhTXamL/1sb48z2Va6O0izPEMZFOi1cO27mzEANxhw/MTXrsl/Mw3SH/QROpJhhFB2XEKXNuGkH2fqb/STTVySQgmLB7Eesl0Fww/1sIt9RaVkqw9EZFikD/NLXEKqzoLFP0mAdQo0opf+MG02SKmGucOYcVXTIDhL9OGgxPI0fdJxFDc11LXADx8MWoTHs/Xi6mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7OXz9amuKreYIBo8mm7Os6CCw7e2bOQ5qqVA5H0KRp4=; b=ON/Us/1I0gukP9qucZKdudZEKG8ceG3YBeGpzV7Ewbc3tYuEKMGa9JrgTZ0GcHVWpvLrd9qEMlT/Djtj82sQVumEG02DHrebH9JfwD6dKQ8DpCByuf2uPh8aUIWHmdq1mHZK+L7lNjqGQMJCSguozLACZoAMU7jCGpzPV3hjMHIAz7+JHbupSoUBxhjKzcUv5xEo6qnUy5r52PrhXpasZSmVs6PEqqM1xDaQKnQzwfmneufOXZwg3R/gO9fo/WbwCMC3kAyT0F7+2XNQ/+ERK7mqHwS8Bg6N2sBuaCoxvD7X27WBDdTha0NCeGDgsE3BTeUIeT5PiikIishhwpRQLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7OXz9amuKreYIBo8mm7Os6CCw7e2bOQ5qqVA5H0KRp4=; b=J1qRtlymlyhblLuRkTzhqAB7lB7Rp1LM3py5DHPiyC/4deZt4NZkCYixyc7/WUkjifxmdFN7EOrZ73ds2BSZSSh9sjVlVVsLXthvnCTadiXApxPNkmtPI/RceuANvw1gMxHGK1z0xH3qGryC4IjlC/pO8CtIsRizJG9mlemZmcA= Received: from BYAPR11MB3829.namprd11.prod.outlook.com (20.178.238.32) by BYAPR11MB3687.namprd11.prod.outlook.com (20.178.239.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Wed, 6 Nov 2019 16:03:54 +0000 Received: from BYAPR11MB3829.namprd11.prod.outlook.com ([fe80::d41c:ae89:68f0:536b]) by BYAPR11MB3829.namprd11.prod.outlook.com ([fe80::d41c:ae89:68f0:536b%7]) with mapi id 15.20.2408.024; Wed, 6 Nov 2019 16:03:54 +0000 From: "Stillwell Jr, Paul M" To: "Su, Simei" , "Zhang, Qi Z" , "Ye, Xiaolong" , "Yang, Qiming" CC: "dev@dpdk.org" , "Su, Simei" Thread-Topic: [dpdk-dev] [PATCH] net/ice: fix segmentation fault for RSS init Thread-Index: AQHVlHEwrlZZsHMK7kW7rN5TgkJipKd+TmRQ Date: Wed, 6 Nov 2019 16:03:54 +0000 Message-ID: References: <1573024135-267218-1-git-send-email-simei.su@intel.com> In-Reply-To: <1573024135-267218-1-git-send-email-simei.su@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmZjNzY3MTAtYWM3Zi00OTIyLTk1MjAtN2I2NzMwOGQwOGZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS2JQYWYxSlM4ZEc1YWU2aEN6NnVGTDdHM1NvWWpFN3pmQTNxbmRSK1wvUHRJYm8zZDNyYnFiSTFyeUw5VHJneEkifQ== dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=paul.m.stillwell.jr@intel.com; x-originating-ip: [192.55.52.212] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8e06db28-e355-42ca-7a1e-08d762d2eca8 x-ms-traffictypediagnostic: BYAPR11MB3687: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 02135EB356 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(396003)(376002)(366004)(136003)(346002)(13464003)(199004)(189003)(6116002)(305945005)(5660300002)(486006)(71200400001)(71190400001)(9686003)(52536014)(76176011)(86362001)(55016002)(14454004)(66946007)(33656002)(229853002)(26005)(6636002)(6436002)(8936002)(3846002)(64756008)(446003)(11346002)(102836004)(53546011)(76116006)(6506007)(14444005)(66556008)(256004)(2906002)(316002)(74316002)(99286004)(6246003)(7736002)(4326008)(66066001)(478600001)(186003)(476003)(8676002)(66446008)(107886003)(110136005)(81166006)(54906003)(81156014)(25786009)(7696005)(66476007); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR11MB3687; H:BYAPR11MB3829.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VTe/FYv4BHaNAKMSRfY92qvZjP6KSCbaTnG+TcaZGE2izOjxoT/zvgz9aHXNKGqKfdsmD6zkNqpV+0fxv6PkRnAWmbQ5SsKzAJUHUCxVsE23O229RqDZOpRNeQh3RajqNAm0hyf0sw+JHS2l1B3Hjt2ln+JMCAElOKPBFw/Kgo1hUkQWZMnA+f0cMIkiAfOQ6kLXfbqtzuzlnrhzcAjLrlE2IxZZRdNMUJ1G6dhKKBB7/h+uSU3j9/60HUTFQB8m6iJKxeVukjPUH2JK1Q784UG6tPyyPtERcvyp/7aOjUvsSmMVMHBNsvzwv7jSaG5hcOOpjMzSNhwbMzRHUKPvr65ioAWgnzeLDEERCZ8AsT3kbYP4YKiwXLNGb3qmtFB16/DUixPFuT5cZJfWqwQhT3u5OfDTwua5tpLssGg0hXg4TVC5HufILpWQdEqUl58M Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8e06db28-e355-42ca-7a1e-08d762d2eca8 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2019 16:03:54.7484 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HHi9vaJxJ9lQcHjMbCqAh3DJ9BS0M9ft42s3qY+mrQajlZu3ygd1KJYWPH4STb4UafI3X6Bw85pZMiFJHb863ZTXXLMCcUGAuWxNzn1ePvs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3687 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ice: fix segmentation fault for RSS init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Can you provide more details on how this fixes the issue? Looking at the co= de, the pointer *parser should get set by the code so I'm not sure how this= change does anything. Paul > -----Original Message----- > From: dev On Behalf Of Simei Su > Sent: Tuesday, November 5, 2019 11:09 PM > To: Zhang, Qi Z ; Ye, Xiaolong ; > Yang, Qiming > Cc: dev@dpdk.org; Su, Simei > Subject: [dpdk-dev] [PATCH] net/ice: fix segmentation fault for RSS init >=20 > This patch fixes core dump issue when entering safe mode with a wrong > package file. >=20 > Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") >=20 > Signed-off-by: Simei Su > --- > drivers/net/ice/ice_hash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c inde= x > 3381b45..04ec30f 100644 > --- a/drivers/net/ice/ice_hash.c > +++ b/drivers/net/ice/ice_hash.c > @@ -236,7 +236,7 @@ struct ice_hash_match_type ice_hash_type_list[] =3D { > static int ice_hash_init(struct ice_adapter *ad) { > - struct ice_flow_parser *parser =3D NULL; > + struct ice_flow_parser *parser; >=20 > if (ad->active_pkg_type =3D=3D ICE_PKG_TYPE_OS_DEFAULT) > parser =3D &ice_hash_parser_os; > -- > 1.8.3.1