From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD248A04AB; Wed, 6 Nov 2019 16:58:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 421201C2EA; Wed, 6 Nov 2019 16:58:25 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D51741C2B5 for ; Wed, 6 Nov 2019 16:58:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 07:58:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,275,1569308400"; d="scan'208";a="402402369" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 06 Nov 2019 07:58:22 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 07:58:22 -0800 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.52) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 07:58:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MLewoLVyTAy2Hi46Z60LKBK6KFrAgJOqyPglJUqDYdCohQXq25NKnN9udVTXN5ybjnmL7xgFuX3pPvczAqd+mauBDSMS8ifestjDjkw7Q1+VWeagLjZU2du87zFcMoKSp8DaDupcfWjLolkyaooAQBhDXoD77YWWZ0nzRQDE1+9GuVfVttkkZb27NQ7QNMxy9kYRP6ePwEs8LGN36KR3juWo+Rh+RDaV0iqFIRMiRrAFvnTeSHzC6uJNgxuhvyBaxIDVRGcY/r6aluYJTZhnvU/hVjTeY3lsjg3YVSrP34RhWmmjkcomPsfG0QC68dUsOHZecIW14xmTuxkfUDi1Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sS1YJqHUqfF2CpQZZq1Vdqu7KA7sc7zU69BkmSDDxIo=; b=HAVx0JNPkE4QvfngER6P7tQVYhtHcVC7KxVwleFDl0GS2/6TwZfupr7As9ZURkgs+6jw0n0hrhpbaNUWKkM0IHpTgHA356x0D1gYnBaK4y1SH7H821eaCybcmwrMCXEk0EaFyiIOIMBCtND4pp5rVuYvYPWAO2MNhTZ4C/oASUZQmr2ELseWA6+4GIYgVZ00gmqU8iZDxYV+DGpv0KPwj0YKng1lYrLjzR9dfH8kCOe48ZurMMqS3lgMja6VyfxJtXMVFJ90qWWwngeXlkTnjL8HiRHlzvWG13XaiUkLxUj0mQ4XgVRorJf+mUxSxouI/GMgWPOCA2jOJOcnUAV9vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sS1YJqHUqfF2CpQZZq1Vdqu7KA7sc7zU69BkmSDDxIo=; b=LGni6/VcuSvQwT5bm9INAGqS4IFZ0kglvolQoGFQ2sn9BPEPR8EsM5eegUtNo7Kl20PfOngJvrDt6eItTVJRCXyT3L8cBzuM7hFI3aX6gu5SCJxQYueEKZu8X3NolaJ+Or8zpQPIoT/tOHvSp4FvCsDGFvWPxnMfHH6tkkVEHzQ= Received: from BYAPR11MB3829.namprd11.prod.outlook.com (20.178.238.32) by BYAPR11MB2981.namprd11.prod.outlook.com (20.177.224.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Wed, 6 Nov 2019 15:58:15 +0000 Received: from BYAPR11MB3829.namprd11.prod.outlook.com ([fe80::d41c:ae89:68f0:536b]) by BYAPR11MB3829.namprd11.prod.outlook.com ([fe80::d41c:ae89:68f0:536b%7]) with mapi id 15.20.2408.024; Wed, 6 Nov 2019 15:58:15 +0000 From: "Stillwell Jr, Paul M" To: "Zhang, Qi Z" , "Yang, Qiming" CC: "dev@dpdk.org" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH v3] net/ice/base: fix wrong ptype bitmap for GRE Thread-Index: AQHVlGgWbDAdMDcyWECBw4DPcONhIad+TOkA Date: Wed, 6 Nov 2019 15:58:15 +0000 Message-ID: References: <20191106060703.15963-1-qi.z.zhang@intel.com> In-Reply-To: <20191106060703.15963-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjE5NzRjNzMtNDU3Yy00ZWRjLTk5OGMtYTRlNzY5NjQyNDkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia3pydTRVaHhsMTNVRVcwNkVkRnRodFRkd2wzSGF3REZrb2xRUTM0cXNjZU1rSDZ6YTRPdjhIbVp2NnJTelJPYiJ9 dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=paul.m.stillwell.jr@intel.com; x-originating-ip: [192.55.52.212] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f88cddfa-cdc2-42dd-7b24-08d762d22296 x-ms-traffictypediagnostic: BYAPR11MB2981: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:323; x-forefront-prvs: 02135EB356 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(366004)(346002)(39860400002)(396003)(376002)(189003)(13464003)(199004)(305945005)(102836004)(7736002)(26005)(186003)(86362001)(6436002)(52536014)(229853002)(9686003)(478600001)(14454004)(6246003)(81156014)(8936002)(486006)(7696005)(476003)(4326008)(81166006)(5660300002)(25786009)(110136005)(99286004)(53546011)(107886003)(6506007)(76116006)(316002)(66946007)(6116002)(66476007)(8676002)(66066001)(66556008)(3846002)(66446008)(256004)(33656002)(71190400001)(55016002)(71200400001)(446003)(76176011)(11346002)(6636002)(2906002)(74316002)(54906003)(64756008); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR11MB2981; H:BYAPR11MB3829.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:3; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JHSOrYGfsYI3pO8GWU9Y3G7VXONh2X65jbwITkXx+hSa5659yn/VvZSpZTkvWuqo3QilsDrI07Mf7+pUZDyAPTLGgmy3LlfypWm2S9eXuSvi0YmmZt3Xpyi2yJ5qEINsc5+43PDh+VT0oFCEkBwLfSbMKF2ViswxhcsYSmq/tBiL/d50OfV2XylGWmfwjmTNB7rekpo07C3OUhlE4zy3RMkP0WgBDye/1Shbf++wT8XyEm5V5Tw9lBOiG8yy43jDdDSK+ZtHP8rrTOrrE38pPxZFWbaf+zC2L7vhfYtJM/h1xio5qUzIPm5vITg1Oahr02pblkLkBCUw8kRZ7YcilbdCiIyK7SVmwhM/lOxTeB2tdhwIbID/MjYZrn3tNSxC/TcQb/vUQq0UaSMnt1HUI5koLiaITuQQCo05Mz44gd79CiVE25Yfx1ViIGymUXFg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f88cddfa-cdc2-42dd-7b24-08d762d22296 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2019 15:58:15.7696 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3TO7UQawUCO07BfoDLgd2wGjZqW/lspOfAccSeTA2rE/rvAlU8Z6X+FCSzzIAh+mMunq5QrWrdW5hy2ujmYYgFfk0S4GvaEEj/lKLd04Kk0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2981 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] net/ice/base: fix wrong ptype bitmap for GRE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Qi Zhang > Sent: Tuesday, November 5, 2019 10:07 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v3] net/ice/base: fix wrong ptype bitmap for G= RE >=20 > The ptype bitmap calculation for GRE packet is modified by misktake due t= o Minor nit (if not already fixed in subsequent patch): misktake =3D> mistake > commit fc845a9d78ce > ("net/ice/base: fix ptype mapping pollution from GTP flow") which is targ= et for > GTP packet. The patch rollback that part of code. >=20 > Fixes: fc845a9d78ce ("net/ice/base: fix ptype mapping pollution from GTP = flow") >=20 > Signed-off-by: Qi Zhang > --- > v3: > - fix commit log format. > v2: > - fix coding style issue >=20 > drivers/net/ice/base/ice_flow.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_f= low.c > index d6e0556e7..eaa7a3b96 100644 > --- a/drivers/net/ice/base/ice_flow.c > +++ b/drivers/net/ice/base/ice_flow.c > @@ -573,9 +573,11 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params > *params) > ice_and_bitmap(params->ptypes, params->ptypes, src, > ICE_FLOW_PTYPE_MAX); > } else if (hdrs & ICE_FLOW_SEG_HDR_GRE) { > - src =3D (const ice_bitmap_t *)ice_ptypes_gre_of; > - ice_and_bitmap(params->ptypes, params->ptypes, > - src, ICE_FLOW_PTYPE_MAX); > + if (!i) { > + src =3D (const ice_bitmap_t *)ice_ptypes_gre_of; > + ice_and_bitmap(params->ptypes, params- > >ptypes, > + src, ICE_FLOW_PTYPE_MAX); > + } > } else if (hdrs & ICE_FLOW_SEG_HDR_GTPC) { > src =3D (const ice_bitmap_t *)ice_ptypes_gtpc; > ice_and_bitmap(params->ptypes, params->ptypes, > -- > 2.13.6