From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E9D0A04AB; Wed, 6 Nov 2019 17:10:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D05A91C2B8; Wed, 6 Nov 2019 17:10:26 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1A3C51C2B2 for ; Wed, 6 Nov 2019 17:10:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 08:10:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,275,1569308400"; d="scan'208";a="227528690" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 06 Nov 2019 08:10:23 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 08:10:23 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 08:10:23 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.56) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 08:10:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=myc3Qwh6iT1GzRb9y21gwTblVEilKGI+vPOaybpo7sPEgqJOh+W5NZavEgkUKXsnz7ryBWxgJrNqh1aXlur4N5yVWe7J2wvsariwdZONYKr4i7L124n0flQwF8/RvnKM4XD4AosNF/gRtXBmw7rfl6x7ko3Mf0BW5gkV3RWD0CTz1iXO6uO5r6fHkP5PWs/GoY8fHrYUXWFaTa/TEE4jiL3PkCjDlQl49K0hzFN8C3Oqwu5Fp5RCS/BQYrmtIrlLBYNDSWsPNNfqI4jhJ90olp9IAMKV+I6JBGBv7pvWULo3dagO9uyaSbLhNCg4YMu0hakvCiCXsL9IZ0VYD17Jjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bNNVPdv82LM4HCUq6L2AZ5tq0ZpN/4mpWhB8MQr1dAw=; b=TmAFmu8G+kjrTg/DcbXcXNkRsN3XIYSTSXJVVXJejIJVa2M5dApic9NpgaXU/IzirEsXQFcnH9yxcF4mi2sDjN8+XVKxUcRbB+d/CwQauKaTyMhhfvJBmbIZ573b/LDn8uFVcbOdXhJDK7KbEW+feU2xnkWoxzvKPfNcFL9vEMJP93r0VwCAc2/93/WeIs31Uxe15Tpia2b//AY1MnaocTkQgNQ/wNojzQ8puKZo5NOf3xTv+GJNeyc14hECCQmk96EWmXJHB/gl8Kucimh1YWcpLj0KZffdya7+aIz5fx5TYXfrfjcthpKnO5+8MGUb381QjSEauqMqWWMkzerDNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bNNVPdv82LM4HCUq6L2AZ5tq0ZpN/4mpWhB8MQr1dAw=; b=iCqH1WWNSYq1o6UJvQTIQW/1417xvCRGqHHl/APZE05NGC8oFFMLX7Tn/f/whgfD9HeXw5vvK66JgLg+n/YMLCrM5m5xhNmbyQuG2t73o5bkCN5KcoswfNHoP1HNP4Qo0YIdi7g2OxDqnBpAQiT1cdT8DpM3SklRreL9Bj5C/4I= Received: from BYAPR11MB3829.namprd11.prod.outlook.com (20.178.238.32) by BYAPR11MB3176.namprd11.prod.outlook.com (20.177.186.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Wed, 6 Nov 2019 16:10:21 +0000 Received: from BYAPR11MB3829.namprd11.prod.outlook.com ([fe80::d41c:ae89:68f0:536b]) by BYAPR11MB3829.namprd11.prod.outlook.com ([fe80::d41c:ae89:68f0:536b%7]) with mapi id 15.20.2408.024; Wed, 6 Nov 2019 16:10:21 +0000 From: "Stillwell Jr, Paul M" To: "Su, Simei" , "Zhang, Qi Z" , "Ye, Xiaolong" , "Yang, Qiming" CC: "dev@dpdk.org" , "Su, Simei" Thread-Topic: [dpdk-dev] [PATCH v2] net/ice: fix segmentation fault for RSS init Thread-Index: AQHVlHv4H268PRqqpkC1Yjhl4b8wZqd+T9KA Date: Wed, 6 Nov 2019 16:10:20 +0000 Message-ID: References: <1573024135-267218-1-git-send-email-simei.su@intel.com> <1573028777-185130-1-git-send-email-simei.su@intel.com> In-Reply-To: <1573028777-185130-1-git-send-email-simei.su@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGEwMDI5OGYtMzVkOC00N2JhLThlOTAtYmY5MGVjNmE3MWIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYXhKaXZEN2ptZ3ZuZlU3bE9mXC9JMDhHYTcwNGhwUVRLaEIyb0FvbWwyRlRsc2xxNWpWbmdxcFRMbjdZSmx5ZTcifQ== dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=paul.m.stillwell.jr@intel.com; x-originating-ip: [192.55.52.212] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f1b9f3eb-2ba8-46f5-bfb4-08d762d3d2d2 x-ms-traffictypediagnostic: BYAPR11MB3176: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1850; x-forefront-prvs: 02135EB356 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(396003)(366004)(346002)(376002)(39860400002)(13464003)(199004)(189003)(7696005)(99286004)(2906002)(107886003)(66556008)(4326008)(478600001)(6116002)(25786009)(33656002)(66446008)(64756008)(6636002)(71190400001)(11346002)(14454004)(7736002)(74316002)(86362001)(446003)(76116006)(5660300002)(316002)(476003)(9686003)(6246003)(6436002)(66476007)(256004)(305945005)(486006)(3846002)(14444005)(76176011)(55016002)(66946007)(186003)(52536014)(8936002)(81156014)(81166006)(110136005)(8676002)(26005)(53546011)(6506007)(54906003)(66066001)(229853002)(102836004)(71200400001); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR11MB3176; H:BYAPR11MB3829.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JkhUIGj6y8a5A8qjC8g3aW6foRdgnNejs51LDDhzrPNh2+g3rmSvbqqI1W4SmduXudJbA/GSW9w7PQxdpVEopAF6ervKpKAvzPNmTjVjSggpneRu9NB1bVh7oJYw0G3hgUUMXDWyKHfe1WrVCypSf9KQas741SjU7YVYAxlr65HumFFe36QM0MUJVJRnY95Php+Ukyw7sEucqX/mRYPTKmEllm5yFr06pfpG0za9AuHyaIdc5NacJZZ05HPBkDZtaHHwGNZ6Jy9XHu+F4J3SQwyFo7Xc+6HcNn8FR7Jvgg0vGfKy3pxUsaq9ghm0MdlGgEhMdOydtQKjvAUtyDnlTdL+DgssINyfsn6v01JJiWdb/VOBv0Ppp9M1UJgOV31WUP3lIYsxZvUuyaQ10C0lkPJaT67IPBBOU3KkluTBJNe6x3LOKqGCKmZHc8v/V1JN Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f1b9f3eb-2ba8-46f5-bfb4-08d762d3d2d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2019 16:10:20.9054 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 39X7A5xvM6lN2FRMarOnhAXcEsBTr+faYBNwGbIaz9e8Jtkr/kJeXBO+kLGmAs0biUqendYmH9UYhFIpGf+eHKaKmPh77RcAUKoQeigspaE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3176 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix segmentation fault for RSS init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Disregard my previous email, I didn't see this one. See my comments inline. Paul > -----Original Message----- > From: dev On Behalf Of Simei Su > Sent: Wednesday, November 6, 2019 12:26 AM > To: Zhang, Qi Z ; Ye, Xiaolong ; > Yang, Qiming > Cc: dev@dpdk.org; Su, Simei > Subject: [dpdk-dev] [PATCH v2] net/ice: fix segmentation fault for RSS in= it >=20 > This patch fixes core dump issue when entering safe mode with a wrong > package file. This patch also fixes build failure issue. >=20 > Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") >=20 > Signed-off-by: Simei Su > --- > drivers/net/ice/ice_hash.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c inde= x > 3381b45..08b2502 100644 > --- a/drivers/net/ice/ice_hash.c > +++ b/drivers/net/ice/ice_hash.c > @@ -236,12 +236,12 @@ struct ice_hash_match_type ice_hash_type_list[] =3D= { > static int ice_hash_init(struct ice_adapter *ad) { > - struct ice_flow_parser *parser =3D NULL; > + struct ice_flow_parser *parser; >=20 > - if (ad->active_pkg_type =3D=3D ICE_PKG_TYPE_OS_DEFAULT) > - parser =3D &ice_hash_parser_os; > - else if (ad->active_pkg_type =3D=3D ICE_PKG_TYPE_COMMS) > + if (ad->active_pkg_type =3D=3D ICE_PKG_TYPE_COMMS) > parser =3D &ice_hash_parser_comms; > + else > + parser =3D &ice_hash_parser_os; This doesn't make sense to me. Why set up a parser at all if we are in safe= mode? Safe mode means 1 queue so there isn't anything to RSS to. It seems = like if we are in safe mode we should just return an error here with a mess= age that we are in safe mode. >=20 > return ice_register_parser(parser, ad); } > -- > 1.8.3.1