From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49815A04DD; Thu, 19 Nov 2020 18:26:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4EEA3F3E; Thu, 19 Nov 2020 18:26:38 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id EDE5398 for ; Thu, 19 Nov 2020 15:56:13 +0100 (CET) IronPort-SDR: OVzC0unzYG/uIQ1QjDxSSnANE1HBNGYKCHXZXHtb/31/Oxa1QLkn02YiT4yus1Q9n5HBwCzNY+ lqdm562ngcfQ== X-IronPort-AV: E=McAfee;i="6000,8403,9809"; a="151146671" X-IronPort-AV: E=Sophos;i="5.77,490,1596524400"; d="scan'208,217";a="151146671" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2020 06:56:11 -0800 IronPort-SDR: Tt9hjH8siwXp4Z/lky6gwqTVDQVNVrpdkSGM2HHYgZADzmJc9EF1A2lzmjVVXky/eNBnJPh5RG y4za3bCUdpBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,490,1596524400"; d="scan'208,217";a="330957305" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 19 Nov 2020 06:56:11 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 19 Nov 2020 06:56:11 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 19 Nov 2020 06:56:11 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 19 Nov 2020 06:55:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X/T7Gy/lFWN2UfY4d2hzqWJso4+BP7uuLqDSilsxdqu4fkSPfjPrnzu1N3kc6rIV/CsF7wxXgLx/hRv1os9TKHlRHNA8ITDK3bMW22u9UF1LaQZQcyK1USYKCwNaimjJF6tuiAUhKLAGqNB5+pkMKcBZ75u+x2pwx3piH88LHdl3iUb2EfThj56vYsi9vDwo3yKGHNyu30ln/EKVjl+lWiXa7cvoAlL+cajqkn4iog/h08xZfHog7f2OtBWxASwinIEyYJCb+yyHJkfF0oI8DrSt8883/TZauK46eLITcN2vqZzoXkzZ+qUNHJs4Fb0G4DJf+KMNzrpj8hc65c7+tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hPj+MsSN7S6bokAIqi2/GOyoYs7lSrkJsV+t6NLQvdA=; b=K2x/8OTfvWbuGqNo4qOVQkvQ94KsbjlLZU0deyGV8j7Dr34C70AzgqrpKRahRpzRLSi7yfgRjP2hmVQP9aE3m4eiuyBQz5fwvGsdAR39027sFeypG8kuZiuYpqhgT6WBtmNBbEw3StpYpmtpa5wwK8NbcTgigWxlcu31kK2RLBkIgRA2tmNnsZYcwol74kch9MNkJeCR6rauL0oE8vva0EZnoMQ7doM33XbONb970kQuc/X2PtK+E6lmyQRMnYI+QTShbcwPONzmivlcHT2Ipf6751/bp8eNzafp9exTmoied4Ew1zbkEEEfRv7hSPewo8d+w9wd2lAGJxUQOwPSuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hPj+MsSN7S6bokAIqi2/GOyoYs7lSrkJsV+t6NLQvdA=; b=sS635RjOO/L9oe5RY/rbzHBFRi/GL36CYWZqnrrnu69oKGYisg5Y07nmAaeKb83oYLITIUwNJqYmpw4Ks6gbyxpsca16g+gF3z5JyheQ0chOBO1B5l9zC0y+q2176hm1hWtLO+SlR6t3ybL3t32ug93HwHWyZrvZycqSiROQtWs= Received: from BYAPR11MB3831.namprd11.prod.outlook.com (2603:10b6:a03:b0::22) by BYAPR11MB3830.namprd11.prod.outlook.com (2603:10b6:a03:fc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Thu, 19 Nov 2020 14:55:43 +0000 Received: from BYAPR11MB3831.namprd11.prod.outlook.com ([fe80::e97a:333b:df97:4709]) by BYAPR11MB3831.namprd11.prod.outlook.com ([fe80::e97a:333b:df97:4709%6]) with mapi id 15.20.3589.021; Thu, 19 Nov 2020 14:55:43 +0000 From: "Luse, Paul E" To: Thomas Monjalon CC: "dev@dpdk.org" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] Question about recent change to rte_mbuf struct - user data and udata64 feels (breaks SPDK) Thread-Index: AQHWvgjM2SJ9LbOpEU+Hnri8Ny3zGqnPMO2AgABbDsI= Date: Thu, 19 Nov 2020 14:55:43 +0000 Message-ID: References: , <2681525.FU5bBsX61N@thomas> In-Reply-To: <2681525.FU5bBsX61N@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [184.190.142.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 59cac50f-333a-47ac-540a-08d88c9b30a7 x-ms-traffictypediagnostic: BYAPR11MB3830: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: u4iPVId+eDVLX3i+kHRze3g+K1u3iPXGEE3pn8/QBx7/AwPRvS8cchyQXavWOLlnKAC3+apGA8Bu5xn1u6ScVbz3QAcATI6Vui1vFYc8w+/PRc4DCGHBWzgx8CKcFO8BYHKysqNPL4E93m9fsE3yFnFQCwenvFKZuB8CFpCmYlLoxsgmJ7QRKZRj/VmExAKHtFiw/sGs0c2hIsV1yg6QYf+Pzs8dcBaFHeR7XVQrBqXK8T8ZqK7KjKRAa1ZnXWQwJbmYwHT1EhL38SKKyo6dx0KMw9nzHjNjmAUg/B2gZqNST8Eu+cJPCmD5A1AM8VbDVUcBSaMonMy3D0Wy3EgpuuQdPcFbEAbtLc1CGz+uQsCfO5HHBQdpvpkEA1+52QNThwA3wX4WOQwSC5SQ2yCmCw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3831.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(136003)(396003)(376002)(39860400002)(5660300002)(478600001)(9686003)(6916009)(86362001)(66556008)(52536014)(8676002)(53546011)(6506007)(26005)(7696005)(186003)(2906002)(4326008)(66446008)(66476007)(54906003)(71200400001)(66946007)(966005)(91956017)(8936002)(76116006)(316002)(55016002)(64756008)(33656002)(83380400001)(166002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: jsmoZSAIfntiifI5ob8UTYeWD0VnndRweFspJcmWXrKwc+w5KP9x/FITBaIBDJhMP/voiLGhjh1Bxg/SK/MpKYaFw+8fzy3mNdHoPmWbDEkos5PnESZ2f3VJk2n1ehqyRdIWUt+4WuX0hfyBRO+YIlSggZZgsbY1mrOMz5JIDYdBIG4Jf3m4drRZL8PlbE19+7TIi9kDtQ6qdV9g6IVfaeWOzPOqM8c0F1l7VsF0xFPCvdquXKhBCdY8XgVeECyeXIb6ETQU5ENMWZgd6A/+jgZ47sCNaLZizKcyyGng65WUGNh21IwrdXWfyqLyqqn7SpKG7SuhCM9eyj8IQdrNH9tvCpOHUDULvf9Pol0cJy2akS6694glu9wxtsBtWma2aRxx8B6C8C1g4sb2dxndLIDeqvMO31X3H2Msy4JZkwmo/QbvLSPlMe2cnmm17p7AGxYjRZ0g2eFEum2StmzEqda8/31t3H949wikzUYSIInZYD3X6Tzp9MdK3wFQryoQcpk9q26poUewkXkKrGU+dDN4KIEn+zwymjV5eq01S7GHtGGihT8qFdSqx/I5aYSkaSQ/mm2qDZDgUW4DQ49l3piyJ8hiXXlZRUw8EhNZviegAJ0MviZ5Qilcrwoycpika4gpF+BGvdl7MSiv90dO6A== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3831.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59cac50f-333a-47ac-540a-08d88c9b30a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2020 14:55:43.6097 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gomMIuL66meJrVC7i0NYsEWZQ/R19A2nGqJkcKMBQ766w35JZzUliYuX4mQlVZnl3K0ZRy86XIyXOK9cb2sRPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3830 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Thu, 19 Nov 2020 18:26:37 +0100 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Question about recent change to rte_mbuf struct - user data and udata64 feels (breaks SPDK) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Great, thanks for the quick response!! -Paul From: Thomas Monjalon Date: Thursday, November 19, 2020 at 2:30 AM To: Luse, Paul E Cc: dev@dpdk.org , olivier.matz@6wind.com Subject: Re: [dpdk-dev] Question about recent change to rte_mbuf struct - u= ser data and udata64 feels (breaks SPDK) Hi, 19/11/2020 01:17, Luse, Paul E: > Hi, > > Recently this patch https://github.com/DPDK/dpdk/commit/5284adad3e95025f9= 901869f581c8c04ea642d32 made the following change: > > * mbuf: Removed the unioned fields ``userdata`` and ``udata64`` > from the structure ``rte_mbuf``. It is replaced with dynamic fields. > > Which breaks the SPDK project=92s crypto and compression capabilities as = we use userdata to store context for our operation so it can be retrieved u= pcon completion of the operation. It=92s not clear to me that we are safe = to use the fields that were added: > > uint64_t dynfield1[2]; /**< Reserved for dynamic fields. */ > uint64_t dynfield1[3]; /**< Reserved for dynamic fields. */ > > based on the comments. Can someone please advise, why was this done and = can we use these fields? We are doing some API changes in DPDK 20.11. The mbuf changes were explained one year ago: http://fast.dpdk.org/events/slides/DPDK-2019-09-Dynamic_mbuf.pdf The API for dynamic fields is available since DPDK 19.11: http://doc.dpdk.org/guides/prog_guide/mbuf_lib.html#dynamic-fields-and-flag= s If you want an example, look how it is used in example apps.