From: Gregory Etelson <getelson@nvidia.com>
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Anatoly Burakov <anatoly.burakov@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] examples/multi_proces: fix Rx packets distribution
Date: Tue, 9 Nov 2021 11:49:36 +0000 [thread overview]
Message-ID: <BYAPR12MB263126DCF313C5582850BB24A5929@BYAPR12MB2631.namprd12.prod.outlook.com> (raw)
In-Reply-To: <4872412.G4mxdARt5T@thomas>
Hello Thomas,
> 09/11/2021 10:58, Gregory Etelson:
> > - uint8_t client = 0;
> > + /*
> > + * C99: All objects with static storage
> duration
> > + * shall be initialized (set to their initial
> values) before
> > + * program startup.
> > + */
>
> Why adding this comment?
>
> > + static uint8_t client;
>
>
C99 optimization that was used here is not obvious.
The patch relies on client=0 initialization.
I added the comment to clarify why the client was not initialized.
next prev parent reply other threads:[~2021-11-09 11:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 9:50 [dpdk-dev] [PATCH] examples/multi_process: fix RX " Gregory Etelson
2021-10-28 14:29 ` Burakov, Anatoly
2021-10-28 15:14 ` Gregory Etelson
2021-10-28 15:35 ` Burakov, Anatoly
2021-11-08 21:27 ` Thomas Monjalon
2021-11-09 6:42 ` Gregory Etelson
2021-11-09 7:30 ` Thomas Monjalon
2021-11-09 9:35 ` Gregory Etelson
2021-11-09 9:58 ` [dpdk-dev] [PATCH v2] examples/multi_proces: fix Rx " Gregory Etelson
2021-11-09 11:35 ` Thomas Monjalon
2021-11-09 11:49 ` Gregory Etelson [this message]
2021-11-09 14:17 ` Thomas Monjalon
2021-11-10 16:52 ` [PATCH v3] " Gregory Etelson
2021-11-10 16:57 ` [PATCH v4] examples/multi_process: " Gregory Etelson
2021-11-16 15:07 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB263126DCF313C5582850BB24A5929@BYAPR12MB2631.namprd12.prod.outlook.com \
--to=getelson@nvidia.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).