From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 778C8A0C4B; Tue, 9 Nov 2021 07:42:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 003FF40687; Tue, 9 Nov 2021 07:42:19 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2051.outbound.protection.outlook.com [40.107.223.51]) by mails.dpdk.org (Postfix) with ESMTP id 0E12D40151 for ; Tue, 9 Nov 2021 07:42:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jHWHLfcIwSjNSswW89xdYdYB6KSkVa6HVmzSy+2qzsFLOah+SHgCEYhFL9TYRYKOMwD1FT7kcTtaeht7msxhJ6eVMebKgGo/RxFd6OuwI0V/l4+fPfMs0SXqaKVg60ZXHhw1YXjK7uQVYe3hsdzMKjHZkZ6Td/7duhDOOSlmfzY6sPUl4X17tRO9HEOitZYZ7ANq0UuaHqKyhmwjvx0quPMgFObqXCUuOIMY048zJuuZeuVI6wTgAGhljoyZYVmR8dx1cb9Dey6djZy9QmZVzWlA3RPslhp6MpeBLRXeA0Ve+IkPhNgFhfDUYuTtXF3piHp7YlYA8dAodW7EYHU2Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3eke/Y4zWvPjBwulR7PZnVPmtMIDlhiVrPAHzZJkioo=; b=lW1n9D7m0IrbSzl/fQ1O2ESKqzapYzRGwpB1GudcP7pl33nGDpt11gTUE6EIj/43iCHOQfbL51ITMGDAKN5FAXq/ysmS+munwdMq4VzOH0obeifoQcDmoSLtb66sib98hli5u7lTZqF0EYl3GifdWNi/gCIBnmZISdnJW9D0Zb42J/CFjBfwLnmG4NoTuXArDII7zq2j+lsLI2TmNRJ8NdpKr4gjC78pw1etmohUzL02pd4piXa7DbqiGWt/QSS+kLBch+LNIfdJ9ZSqAvuEqHGiU/R+6ZkMfBaa/2O3dVJpHofUtDlzM37HqSJW5/yX2KmZH1GeBIdZwwFsw/jZVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3eke/Y4zWvPjBwulR7PZnVPmtMIDlhiVrPAHzZJkioo=; b=BIAxDdiXV3Q25w0x7YtuuMGTRanRu0KxZDVUVZfCe3/zLJXkZUL9s1HrTtrNbilypNyYwlZqR0RLug36aoXH6eUBG/6qadTna3UxxYfG6pvbun8ZCWRnw8bZHo4fnhia8OS4X7H6D91C7Uz8EeLcKL/BVBK1z77YOnaWfcWTBxPqrCMrBE00NctLB0qcOsrwgbaOeyTeoXlF2pVSAhN4oJTeJAws+BBv97nQUv3MU5vJptcsM4dBgl6MRVzbehLw8FuZt4btod5mNA9SNb7mqEDI98c9PYBjY1nwVLPquYorWtqts+iX8u/vx6GF8poVWiP4wlxdZEdve2bUwgyHog== Received: from BYAPR12MB2631.namprd12.prod.outlook.com (2603:10b6:a03:6b::22) by BY5PR12MB3825.namprd12.prod.outlook.com (2603:10b6:a03:1a2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Tue, 9 Nov 2021 06:42:16 +0000 Received: from BYAPR12MB2631.namprd12.prod.outlook.com ([fe80::8508:89a5:d1f7:9050]) by BYAPR12MB2631.namprd12.prod.outlook.com ([fe80::8508:89a5:d1f7:9050%5]) with mapi id 15.20.4669.016; Tue, 9 Nov 2021 06:42:16 +0000 From: Gregory Etelson To: NBU-Contact-Thomas Monjalon , "Burakov, Anatoly" CC: "dev@dpdk.org" , Matan Azrad , Raslan Darawsheh , Dmitry Kozlyuk Thread-Topic: [dpdk-dev] [PATCH] examples/multi_process: fix RX packets distribution Thread-Index: AQHXyk8JsjIn7aZOIUmIGAqzqKs04Kvoe/GAgAAGE/CAAAxLgIARq9IAgACYBLA= Date: Tue, 9 Nov 2021 06:42:16 +0000 Message-ID: References: <20211026095037.17557-1-getelson@nvidia.com> <1880770.nP2jOJxqqx@thomas> In-Reply-To: <1880770.nP2jOJxqqx@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4e115489-009c-4e5e-8b9e-08d9a34c11de x-ms-traffictypediagnostic: BY5PR12MB3825: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g1PMiydkTcXU/xGYqm8Jt6pXC4I4v9MzSz2b+9vtkjTtu/6oX7UuqngrROcIKwP/9ZDED2/E7QoxIug8vZXO2gM8eYpyV24d8Dz+WBLFqMldXQRO+oG3SzpfjtqTScChawHor+DQNS/MjNRLTWUSJJM1IWLIUpCPy/gVpta+lVxLZR5OlqysYIrb8ST3BQeVLrpRu51JUZX7LTKRrRoJM9+BKTd5/gdhVIl7mk+UZTH0EJobCziVgaVGUxgJ//tysJH3GqfEWEyA/p1hN/kivNJD8rayxjziacWQeok4TrRe8cGvjy1SplyhHyd+tsu/1qmORKLu6AztbEionxbQXLxJSx/7IH7U3tBpO1snfry0XyST43t3LZUGkE2lJX9j7nHEF/18+s8tMFD1RS4I83/NM5dXH5O96wKClDTFFiMr4zpQg/KmriQLoOENyYftlzai4w+O5ncikkvhHfFSymUP8s7Rl90JMUSnPxIWte6LnXCNSjbW4P5LxhQbLw/0KOZx/GfiPPvNSKMUXDamrunSVars3Yo2WQKhFr1rp7zWOUOHt1uhMLlzInvdii9bDnCLQm50YoPKn9hRo1oNkIer39X7Jg+6CzOOev06tkU3fDWj98hvERo6sXYFr0beUoU2lxxgHdePhbn/aW8sIdvxh9Y8ZUaajrvarJwW/tUUaaz7+rm8hYpJ+iJUj27Xczp/RCtNkObOokq5gC0vpA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB2631.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(5660300002)(8936002)(38070700005)(508600001)(107886003)(7696005)(71200400001)(83380400001)(53546011)(6506007)(9686003)(76116006)(186003)(2906002)(122000001)(38100700002)(66556008)(33656002)(8676002)(64756008)(86362001)(66476007)(66446008)(52536014)(54906003)(4744005)(66946007)(110136005)(55016002)(4326008)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YH7mjm8cvvgXlzxP0bZT/kvxrkyGIuHJfmcqUgxF8JscI15GWSKBETbIeixy?= =?us-ascii?Q?/VJoSGEd+Z7o2joDHM5rS4W645bsm1bKCpogOpGEMunQdLYfpWpq4/XfFg3F?= =?us-ascii?Q?R7puqJBV8A5pZhyKbMnKCXX4+8DLwz+bGpKhdyVoodznSQH2qxhVywzFqg/o?= =?us-ascii?Q?bI3j2r09QiBwvadDH1KvWv4xW8p6DNIczP7babjKj29akI6vLUZR1S4xNRaJ?= =?us-ascii?Q?T4W10mPhJB3lUViJrLbLtkhyJhRwIJZFSmAXXj5e6egdk24/7CI00vp1kCqA?= =?us-ascii?Q?ac9KjOLNdfI5fXAqUmhefz9zt9LdaLEi/etrmSWLC+RC7rIynzuzTEXxYopq?= =?us-ascii?Q?6jszzloJK4Ny03kbSd9P4MdFkLlmkWbvyulzIZ5lhJTqS+1TFODejUO8hTmn?= =?us-ascii?Q?mwhUxIvE4Ud4yfaWLYYal4xEjVowozUxfN4TqzbaeMZm97tjUTNnsaok8AZe?= =?us-ascii?Q?te/PVknzzIhVmIFodNjynSPhn284Oh4RU3gsyDJ/4RUWvjd7PC/Dkz1b7MoJ?= =?us-ascii?Q?9bnLNBHFJQyEB6WwGDn0rJYNeHMUwRhQ/3CZ3bYdWUZswgofqm5GJZZZ2MsN?= =?us-ascii?Q?7XErheyhZQc6Tj1EGpW/PePu1gTM8Mw6nsqyCNlUw9mdippUzIMupwFJ9utZ?= =?us-ascii?Q?VJNmFobmlQ/TH0+geaJxfLPSEBJ+MZjMMbrxC39hVQJ2MgTqfmqrC3h2/Llc?= =?us-ascii?Q?P8WFd4kQoUVUwXs/tgEraECagOM/NdFegEKGSt1PWJheMslwqsXkENNh+Dox?= =?us-ascii?Q?F4RBDzND4mpskjELMmvz7V1WVLsA0JmJXPzga2xW+s4oXk362JUoQVVXynrF?= =?us-ascii?Q?UBpvfxmCPhXjEeHrorHA4WgQPhwqNRouaeJMORMa81+WflGp6bwvRLADiO99?= =?us-ascii?Q?I0NvPWl3aKN0TuaIC/YLZoJ4xVhE95a6af1p/Xk36YWWWccIaAa+2ptns42E?= =?us-ascii?Q?HDhX+nyLgD0edZBzRuC1NG1bwwg0nV66/BZ4Gc3zDjzgqJs/bXpymw66DkX8?= =?us-ascii?Q?GQNCIZGN/ZAekw5tkwqycyJHVMh8S6xCB6db2syHQiRqL3Njp2TEMpDMe8zI?= =?us-ascii?Q?npesSkSPQ0co0szBaAnpqs21IHA5HmQvXhWK4RgeleLxqRs/bb/Tq1f4i0cy?= =?us-ascii?Q?U1ioduydHk1Dr2ci/4zsSBVPcKtWM0uqdTjm8pVlNx9srwou/JOjxYxf8ATu?= =?us-ascii?Q?0p6c/vWrnN80xNAty7avF1lLDHNswuFKOumvqw7jYJd3Q4/10yurtB/bBbqT?= =?us-ascii?Q?YNhlScuneY5z0VuBdAoIXcwP7RFzUn5ErRumCbnVthJUclTpcXRFKMliMLps?= =?us-ascii?Q?15c3ADAvUgLOsf26HZm/bd+KTXDHw8HRA4d40w0iYsv+gKzert+V1fGijGat?= =?us-ascii?Q?Q/SYjwKPbH/qu1g7tQUyJSxHnY2Q84pACXSdG59THu2ZooHBeji2nRHmnH1W?= =?us-ascii?Q?A4hwalL05qT5bwpy+XigNcZYC4oLqo/QoD2vG9Tla9WLuYgWZAaqKOSOgvLy?= =?us-ascii?Q?4HEW13BoyMOvM2MNBoY+pMlXyPvaTEqH0Rrn+uTt/1gs5b9dVY5ecW/OePjV?= =?us-ascii?Q?dv1JPcydixqwPhJNRB5w8/uVSyOgzovrWndPcMe3K6dNJWfsz3LMXb/JSAir?= =?us-ascii?Q?EqL+5QrMb880eQuB2Bq+NlA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2631.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e115489-009c-4e5e-8b9e-08d9a34c11de X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2021 06:42:16.0786 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GQ+glpj5vU0zHAildMB/uUa5zsIx8ZjZPVnvpo61u9yGM2OsvctBiM+/dC3D2poyO3xFKMyvm/DH94KbQkzKJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3825 Subject: Re: [dpdk-dev] [PATCH] examples/multi_process: fix RX packets distribution X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Thomas, >=20 > 28/10/2021 17:35, Burakov, Anatoly: > > On 28-Oct-21 4:14 PM, Gregory Etelson wrote: > > >>> - uint8_t client =3D 0; > > >>> + static uint8_t client =3D 0; > > > > Acked-by: Anatoly Burakov > >=20 > checkpatch has a message for you: > ERROR:INITIALISED_STATIC: do not initialise > statics to 0 >=20 Turning the `client` variable to static ensured that the next time the function will be called it will proceed iterating clients instead of starting a loop from the beginning - that's the main idea of that patch. The variable must be initialized to 0 because the application model=20 requires at least a single client with index 0. ANSI C allows static variables initialization to any valid value. Do you know why the checkpatch utility denied such initialization ? Regards, Gregory =20