DPDK patches and discussions
 help / color / mirror / Atom feed
From: Gregory Etelson <getelson@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Ori Kam <orika@nvidia.com>
Cc: Matan Azrad <matan@nvidia.com>,
	Raslan Darawsheh <rasland@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix variable length flow elements support
Date: Thu, 4 Nov 2021 09:20:43 +0000	[thread overview]
Message-ID: <BYAPR12MB2631A31408EB9D2370F618EDA58D9@BYAPR12MB2631.namprd12.prod.outlook.com> (raw)
In-Reply-To: <c22f3551-00e3-d10e-c800-e2ffa66f1e02@intel.com>

Hello Ferruh,

..snip..
> >
> > Negative type values assigned to PMD private
> items and actions.
> > RTE allows private PMD types in flow rules
> since
> > 5d1bff8fe2 ethdev: allow negative values in
> flow rule types
> > We construct flow rules with private PMD
> types
> > to implement tunnel offload.
> > However, negative type must not be used as
> index in
> > rte_flow_desc_item[] and
> rte_flow_desc_action[] arrays.
> >
> 
> That is what I assumed, but wasn't clear from
> commit log, commit log
> reads as it is updating an intended usage.
> 

I'll update the commit message in v2.

> >>> +     if (rte_type && desc[type].desc_fn)
> >>>                sz += desc[type].desc_fn(size > 0 ?
> buf
> >> : NULL, data);
> >>>        return sz;
> >>>    }
> >>>
> >

Regards,
Gregory


  reply	other threads:[~2021-11-04  9:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26  9:05 Gregory Etelson
2021-11-03 21:04 ` Ferruh Yigit
2021-11-04  5:33   ` Gregory Etelson
2021-11-04  9:10     ` Ferruh Yigit
2021-11-04  9:20       ` Gregory Etelson [this message]
2021-11-04 11:27 ` [dpdk-dev] [PATCH v2] " Gregory Etelson
2021-11-04 12:46   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR12MB2631A31408EB9D2370F618EDA58D9@BYAPR12MB2631.namprd12.prod.outlook.com \
    --to=getelson@nvidia.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).