Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e

[Odi Assli <odia@nvidia.com>]

> Subject: Re: [PATCH v3 0/3] AVX512 vPMD on i40e
> 
> External email: Use caution opening links or attachments
> 
> 
> On 1/18/2021 1:58 PM, Rong, Leyi wrote:
> >
> >> -----Original Message-----
> >> From: Odi Assli <odia@nvidia.com>
> >> Sent: Sunday, January 17, 2021 7:26 PM
> >> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Rong, Leyi
> >> <leyi.rong@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yigit,
> >> Ferruh <ferruh.yigit@intel.com>; Richardson, Bruce
> >> <bruce.richardson@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> >> Kadam, Pallavi <pallavi.kadam@intel.com>; Menon, Ranjit
> >> <ranjit.menon@intel.com>
> >> Cc: dev@dpdk.org; Tal Shnaiderman <talshn@nvidia.com>; NBU-Contact-
> >> Thomas Monjalon <thomas@monjalon.net>; Raslan Darawsheh
> >> <rasland@nvidia.com>; Ali Alnubani <alialnu@nvidia.com>
> >> Subject: RE: [PATCH v3 0/3] AVX512 vPMD on i40e
> >>
> >>>> Subject: [PATCH v3 0/3] AVX512 vPMD on i40e
> >>>>
> >>>> This patchset aims to support AVX512 vPMD on i40e.
> >>>> And the changes are only target to AVX512 vector path.
> >>>>
> >>>> ---
> >>>> v3:
> >>>> - Extract get_avx_supported() to get the proper vector data path to
> >>> choose.
> >>>>
> >>>> v2:
> >>>> - Add return value check on rte_mempool_default_cache().
> >>>>
> >>>>
> >>>> Leyi Rong (3):
> >>>>    net/i40e: remove devarg use-latest-supported-vec
> >>>>    net/i40e: add AVX512 vector path
> >>>>    net/i40e: optimize Tx by using AVX512
> >>>>
> >>>>   doc/guides/nics/i40e.rst                |    9 -
> >>>>   drivers/net/i40e/i40e_ethdev.c          |   63 +-
> >>>>   drivers/net/i40e/i40e_ethdev.h          |    3 -
> >>>>   drivers/net/i40e/i40e_rxtx.c            |  196 ++--
> >>>>   drivers/net/i40e/i40e_rxtx.h            |   13 +
> >>>>   drivers/net/i40e/i40e_rxtx_vec_avx512.c | 1136
> >>> +++++++++++++++++++++++
> >>>>   drivers/net/i40e/meson.build            |   24 +
> >>>>   7 files changed, 1301 insertions(+), 143 deletions(-)  create
> >>>> mode
> >>>> 100644 drivers/net/i40e/i40e_rxtx_vec_avx512.c
> >>>>
> >>>> --
> >>>> 2.17.1
> >>>
> >>>
> >>> Applied to dpdk-next-net-intel after revert v1.
> >>>
> >>> Thanks
> >>> Qi
> >>
> >> Hi,
> >> This patch series broke i40e compilation on windows with failure in
> >> undefined __m_prefetchw function Please see details in bug: 619 [1].
> >>
> >> [1]:
> >>
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbug
> >>
> s.dpdk.org%2Fshow_bug.cgi%3Fid%3D619&amp;data=04%7C01%7Codia%40
> nvidia
> >>
> .com%7C4b212e1ae3d045b6264108d8bbbd7703%7C43083d15727340c1b7db3
> 9efd9c
> >>
> cc17a%7C0%7C0%7C637465769725929951%7CUnknown%7CTWFpbGZsb3d8e
> yJWIjoiMC
> >>
> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&
> amp;s
> >>
> data=oSmKjG6Za9DCSthbn72YfsQ1JsrUoaVSUCLNt7c5R4o%3D&amp;reserve
> d=0
> >>
> >
> > Hi Ferruh,
> >
> > Could you help to squash my fix patch into the patch series? As I've verified
> it works locally.
> >
> > Hi Assli,
> >
> > Could you help to check after Ferruh squashed the fix patch into the next-
> net?
> >
> 
> Hi Assli,
> 
> The other-way around is safer perhaps, can you please test with the patch:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> hes.dpdk.org%2Fpatch%2F86804%2F&amp;data=04%7C01%7Codia%40nvidia
> .com%7C4b212e1ae3d045b6264108d8bbbd7703%7C43083d15727340c1b7db3
> 9efd9ccc17a%7C0%7C0%7C637465769725939943%7CUnknown%7CTWFpbGZs
> b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn
> 0%3D%7C1000&amp;sdata=ZQU7m8zNXw%2BKxeG6AcveYp9Dpa4k%2BdeO
> 2hK5DiBT3lg%3D&amp;reserved=0
> 
> If it is good, I can squash it in the next-net.
> 
> Thanks,
> ferruh

Hi Guys,

I tested it in my side and it works
Can you please the Bugzilla bug 619?


Regards,
Odi.