RE: [PATCH v2] net/mlx5: support symmetric RSS hash function

[Raslan Darawsheh <rasland@nvidia.com>]

[-- Attachment #1: Type: text/plain, Size: 2172 bytes --]

Hi,

> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Thursday, July 6, 2023 2:56 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou
> <suanmingm@nvidia.com>
> Cc: Xueming(Steven) Li <xuemingl@nvidia.com>; dev@dpdk.org
> Subject: [PATCH v2] net/mlx5: support symmetric RSS hash function
> 
> This patch supports symmetric hash function that creating same
> hash result for bi-direction traffic which having reverse
> source and destination IP and L4 port.
> 
> Since the hash algorithom is different than spec(XOR), leave a
fixed a typo algorithom -> algorithm

> warning in validation.
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---
>  doc/guides/nics/mlx5.rst        |  4 ++++
>  drivers/net/mlx5/mlx5.h         |  3 +++
>  drivers/net/mlx5/mlx5_devx.c    | 11 ++++++++---
>  drivers/net/mlx5/mlx5_flow.c    | 10 ++++++++--
>  drivers/net/mlx5/mlx5_flow.h    |  5 +++++
>  drivers/net/mlx5/mlx5_flow_dv.c | 13 ++++++++++++-
>  drivers/net/mlx5/mlx5_flow_hw.c |  7 +++++++
>  drivers/net/mlx5/mlx5_rx.h      |  2 +-
>  drivers/net/mlx5/mlx5_rxq.c     |  8 +++++---
>  9 files changed, 53 insertions(+), 10 deletions(-)
> 
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index b9843edbd9..20420c7feb 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -110,6 +110,7 @@ Features
>    and source only, destination only or both.
>  - Several RSS hash keys, one for each flow type.
>  - Default RSS operation with no hash key specification.
> +- Symmetric RSS function.
>  - Configurable RETA table.
>  - Link flow control (pause frame).
>  - Support for multiple MAC addresses.
> @@ -708,6 +709,9 @@ Limitations
>    The flow engine of a process cannot move from active to standby mode
>    if preceding active application rules are still present and vice versa.
> 
> +- The symmetric RSS function is supported by swapping source and
> desitination
Fixed typo desitination -> destination

Patch applied to next -net-mlx,

Kindest regards
Raslan Darawsheh

[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 14545 bytes --]