From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDC6BA00C3; Tue, 18 Jan 2022 09:34:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D967426E8; Tue, 18 Jan 2022 09:34:01 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2072.outbound.protection.outlook.com [40.107.94.72]) by mails.dpdk.org (Postfix) with ESMTP id DDFAD426E7; Tue, 18 Jan 2022 09:33:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mHED5wEmzqayt6Sl4KHO3Y+dOlAko5MtA8PVFY2QmpswmqlzAePXz4+ueNeDmsRCdawNtJxjAhx2A2ZYp0embLJhqRnd0a6/lZQKm8LvGyc9kG83xmjtgf0D92M3nKg9iURoUSNxnpyWImtbO8yJ54gIX4oeanScIfxxTIpQX3Ck6ZdEmcpc1U3j8SiC1SO/Dok7RHwBAnPBrqSF3gImFD5kkYfAnrdLyxtoLPUY56Xz2DcPDiF0iHwnofA+v4gSGlmfcvsKB8NDZwnPAtBRgNz0pHBiOnlXFQGaLmsT2dcbTTr72pDG223pymc9BsY7AfSoY5hEbRLcBPzSovOl+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BmoWc6/HUQo02XmWHYTji6vsOLqUN9oX5aAbX/ZP8Rw=; b=GuRrgwSKOuHASGcDi7x72PwMX1IemsPFD2kQ7N56aDadoANCcqCS70h4KXQLWyYzgGHO/JpSdgxIpPo8mrataiELjSl6uyPMypg1hOY08mo03ETYeOK/D49BDz5xtgLpLjnPIcrpqx0VSQciNEX3q+v5qzAN3eZ/UZZxUqVT/95XH4+t/yhNhm7qbnc9qEj68ECt26ZueISPvw/RDaO7LkE337s4uF8WJByC6RKeKClcqweD1NoH0AS3ecCyOqCQKk1jW6Y3cUvX5FaO6DKPxWI0VZK2lYOmpKFKcu+HH913u4ovwjA2g6sO7oiLvhHyyLN8anC7xTNPVRAyrRL5NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BmoWc6/HUQo02XmWHYTji6vsOLqUN9oX5aAbX/ZP8Rw=; b=jBU0R2rGuhobUdF82aTiY6zqKRQzLcZGH18n1vWyl5UBd30VTckfdoc+wnVWYX1qOVxHv7m8B7B5W6zPmC0Rkms8Mdlf9Ioi+QrxM3J1/ceb5YT7MsAO9oF6hMPhL6dGUBofjvgRbkwso+G4ds6g8XmRl9iS/FofJspZVniX26W9ec7NCMRsZRAEjxfnmm+WDvPz2K65cMOUyb4+ffL0yfDmUrrteWqJAEIsHTBdEFIpJ4/RatYdZ+crO3LiNQ2ifWzd9aNScF7G446QCEKcTj9sqPo4gI+9Rjj7pHSXFjA9HSVODKEj17AlWdZcMuDl+Vh21Gty/Z5ZkRtbuC0WQA== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by BY5PR12MB4196.namprd12.prod.outlook.com (2603:10b6:a03:205::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Tue, 18 Jan 2022 08:33:58 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::587a:420a:2c5c:90ce]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::587a:420a:2c5c:90ce%6]) with mapi id 15.20.4888.014; Tue, 18 Jan 2022 08:33:58 +0000 From: Raslan Darawsheh To: Alexander Kozyrev , "dev@dpdk.org" CC: "stable@dpdk.org" , Slava Ovsiienko , Matan Azrad Subject: RE: [PATCH] net/mlx5: fix maximum packet headers size for TSO Thread-Topic: [PATCH] net/mlx5: fix maximum packet headers size for TSO Thread-Index: AQHYCIpzQqcM0fZ+P0eMcqBy4IBYHqxoexeQ Date: Tue, 18 Jan 2022 08:33:57 +0000 Message-ID: References: <20220113143229.3530296-1-akozyrev@nvidia.com> In-Reply-To: <20220113143229.3530296-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 62105727-5ec2-4518-6b06-08d9da5d4569 x-ms-traffictypediagnostic: BY5PR12MB4196:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BqvSe8TW2bViAi8T5beFamBQMiScjRHu/ksqsbQuDgugenMigIhc8mkfWj220DUe9P3VOwvomIg4Gf+IzB5LR+UU2G66finV0233shbAdarTwqgTqC+1f6EBfr2GiEq+1kQBcHjH60jN36jPBin10JE4x+MFxN3ngx8obBrHw+MtX2yqRFp6CfnuV6AGc2DJUxnJ0s+3JO/0KGPjAkGBe2mB9qWRoEmmpVvHZBKq7zTgpFSyMLXI2SpGGxPWPU6kPB45BSwNGxKMSCJbK/rC0hmM+QexhDA08DGOqlJI+GDjmhYORJXoLbNjSO0jQ5sdDivhXellx5OMKBCSyNziqjMakYiorSENQKSH8vT02bqbAMMar+dcP81oZ8sBLoLeP/fgOqueN05NNRsZERzdVuO0iDypEqvNlqkTQxty4oWtchmSYu0XAm5ePmUfG6oDT4CSUuxCry3X7N++aiuQkNILHQV9FuV8U7J6+bN9WXQrSZoElpwrt8nsDJ+QqUV+m4cIdQiMpyNT9cZs9SPozj/+Zp2fPMvVvuPgR8/Durh8XH5YNlIupCkQRxVC/teEfY6Tz2xAP22yuLiYBoxPYU+244FApIdvm1wcmluTt884wXlCo+EGcaJGpO1JYgJVyrGXUN42beKCkWk7SMcdLsTR3BDOrEk/IngRpNGc1K6Bdl883NdpwhfBTW2mpQXthJlCuwrePAwR8HiJeePxEw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(4326008)(26005)(450100002)(110136005)(508600001)(107886003)(316002)(186003)(54906003)(7696005)(86362001)(53546011)(6506007)(9686003)(38070700005)(5660300002)(2906002)(8936002)(52536014)(33656002)(38100700002)(122000001)(66446008)(64756008)(66556008)(66476007)(71200400001)(76116006)(66946007)(55016003)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eNtZ3ZQUDgtrqU0+413Cv9E2kKFikHgeTnr4zigKyweBiyX8VjWA+ME9yZOW?= =?us-ascii?Q?lVUhWasLy0SEVrANr2i0E7QpjYYsNV30HhmYghE87r3ruYzBpxOgc/Ut0uEC?= =?us-ascii?Q?RfE0MqNMJ7iaXKZMRXChGToMpbcnQgL8oG+NchbA6F4dL3hBf12u8T3eBgun?= =?us-ascii?Q?v/DndgliLtY0YAFheABTMpZ2NR6AJLsb84BEoDn19c7fzt8rgGCMXJcrWEEu?= =?us-ascii?Q?bY1ehKKoDDrypISO/Mxjpuo3t7FCz2J5w8bDEd436LLY7q4n7Y6DCQ1mmxEs?= =?us-ascii?Q?Bcl8tW1yvyBnnV31x44i/BDtNBZuqRpOIhnwMcteh/N/r/8Novz0ufsObUIr?= =?us-ascii?Q?OArxVqcrC7+jZT/2tHtqDXEbJ+ER0cpHC3OBr+A/5LfqLF7XBBcxFS+aG4x+?= =?us-ascii?Q?LxsrOjLkEp5u/G4yytEIg35KJhwT5g9IvVlCXea9d/klZ4NAzOsL2A7rlQ1v?= =?us-ascii?Q?fWPsEKvdloSOoclBYG4wgK5Uy46oyPyqaFr18N4bvzWlkm737/3CbUSVpYuw?= =?us-ascii?Q?Ywg9TwaEjLjWV6Dsx0chgaJkpE0fnaIvYXftjMlIsNCoI3bfy8Kf0AMfuzA5?= =?us-ascii?Q?l6Euo8zXkoqeJnIbIOOgLu9yL6ChuBzebCHBYoMwqDwAj9f54KiuMemYxOWd?= =?us-ascii?Q?hXuOk6Wzr03wxSNfpKYxDxtJ+s5sWAEJbcJx0auQrOxI8vp8KWZHazuxMDXh?= =?us-ascii?Q?4IwfmchthuXis6U01mmZK2dUGgXsKc7BqUNt9YaNvBjkIhKasV6oEa4RSc0A?= =?us-ascii?Q?cUBjp1QhLXraTzBQGwg3mxeGvkY/+QShOpoMFSjrDV+hIOmRVuQUtGoPiXMD?= =?us-ascii?Q?KCqb7MnloertLAm2o/m4Ux2N10gF78ttM+Mq4Odu9ohEgDiZ1mchflj4fY1v?= =?us-ascii?Q?FMfyupgrAXvlmERdPsOvv27i1WaXkznmLq3OQnPXBICEfV6twZMouae9c0jN?= =?us-ascii?Q?Jv7IPW0NyZNf+T6IXsKFP6dBSkV9m/omMq+6JkuriSO9YqyoB7Z43TFy/pNQ?= =?us-ascii?Q?D6YsN1s6nKjpI/m9fs+sufF+c86kbIo7tUWPLKhzhxx9JCdPm+oP84U1JIHo?= =?us-ascii?Q?NWcM1VgVtGtaNu9FcQ4vAfXqvjw9vuJ+sqLMNBsCacrYttlzAoTWRJrW5MiM?= =?us-ascii?Q?etGD//ZSofBc2rlL3dAx/AkJb2nhH77b330sNJzOuBuVW3/d8BzCwdXkS1VQ?= =?us-ascii?Q?WVAris3sWQJsrbZwleQUH+/a3jXR1xZKwA/s0n/Di0rvjT+aogf35vv0i4NV?= =?us-ascii?Q?4JzBc5nb5YISpejEycW3dxPYJAIo+iYU700S9jw927MUt+fVSpJRrVPUWn7q?= =?us-ascii?Q?bkB/TeOaTEuT2X4qJbnusYJQ4gfwSoMDBATvaVOT8xta0bjtAdyuiF/L0Tc+?= =?us-ascii?Q?GC157Nm57fL+sQ0rYK2v28vtC4I/oX3Uk8m5o4QdmOqa7nKMAulk3vo3T/Bj?= =?us-ascii?Q?tJVZPkdvsLwG3hNhO6bVmrhiuDf/hFiJHPWX70KVC91+EGMPoJsvutP5NRdm?= =?us-ascii?Q?KggVE/JF6e2S+n4rfEvO/iqGYVxHkhTr0NRvfppSNzIpeyLU0hzps2gfbnsi?= =?us-ascii?Q?r8UD1rxj40ZUqQ3Nn749OxIbwWlyaF0UwpJ2yPo/wFtv60aXSp4b8swsaZfJ?= =?us-ascii?Q?xrgohycPdtD9vVTaho49c4M=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62105727-5ec2-4518-6b06-08d9da5d4569 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2022 08:33:57.9579 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1UMH/CbTI3IsU9ldDzR1BCOJc6opCyKne4RlsE2P9cB5WlPgQ3uyKyI+VeRIZdXPdKkgMnKl3R9RSqaPmW27nQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4196 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Alexander Kozyrev > Sent: Thursday, January 13, 2022 4:32 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: fix maximum packet headers size for TSO >=20 > The maximum packet headers size for TSO is calculated as a sum of > Ethernet, VLAN, IPv6 and TCP headers (plus inner headers). > The rationale behind choosing IPv6 and TCP is their headers > are bigger than IPv4 and UDP respectively, giving us the maximum > possible headers size. But it is not true for L3 headers. > IPv4 header size (20 bytes) is smaller than IPv6 header size > (40 bytes) only in the default case. There are up to 10 > optional header fields called Options in case IHL > 5. > This means that the maximum size of the IPv4 header is 60 bytes. >=20 > Choosing the wrong maximum packets headers size causes inability > to transmit multi-segment TSO packets with IPv4 Options present. > PMD check that it is possible to inline all the packet headers > and the packet headers size exceeds the expected maximum size. > The maximum packet headers size was set to 192 bytes before, > but its value has been reduced during Tx path refactor activity. > Restore the proper maximum packet headers size for TSO. >=20 > Fixes: 50724e1 ("net/mlx5: update Tx definitions") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh