RE: [PATCH] net/mlx5/hws: fix shared context to use local defaults

[Raslan Darawsheh <rasland@nvidia.com>]

Hi Erez,

> -----Original Message-----
> From: Erez Shitrit <erezsh@nvidia.com>
> Sent: Wednesday, March 22, 2023 12:16 PM
> To: dev@dpdk.org
> Cc: Alex Vesker <valex@nvidia.com>; stable@dpdk.org; Matan Azrad
> <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH] net/mlx5/hws: fix shared context to use local defaults
> 
> 
Can you describe the problem first?

> Fix default miss behavior for shared resources, the problem
> could happen in two cases:
> When the table created, the default miss should go to the alias ft
> that will direct it back to local context.
> 
What is expected and what is currently happening?
> When the rule is without specific hit address and we are in a shared
> RTC from here it should be redirected back to the local context.
> 

How does your fix address this issue?

> Fixes: ce946c7d3999 ("net/mlx5/hws: support ibv context shared with local
> one")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Erez Shitrit <erezsh@nvidia.com>
> Reviewed-by: Alex Vesker <valex@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---

As a general comment, 
1- this patch is a V3 of the original series : http://patches.dpdk.org/project/dpdk/list/?series=27465
2- you should be sending it as a reply to v1 and set version numbers in general stating the diff in between the versions.
3- I see only v1 was sent as one series then you decided to send it as one patch at a time is there a reason for that?
4- I'd appreciate it if you can send a V4 that has these details so that it will be clear on what is changing.

Kindest regards,
Raslan Darawsheh