From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9732BA050A; Thu, 14 Apr 2022 09:34:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F0C340687; Thu, 14 Apr 2022 09:34:23 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2042.outbound.protection.outlook.com [40.107.212.42]) by mails.dpdk.org (Postfix) with ESMTP id 8EC1F4003F; Thu, 14 Apr 2022 09:34:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CCFrBElzFz49ZJDutJkzUWDYEw3LDvH7XYaWLuxEGKzLYlTIshPy6WLHE2FwcA28y95CFxSO1PM7byv4sZaVchRya4DcTPd/JvHXo40FobP4qrPXMJNPD+K9KCoivmxFdPT/+uI+4bu788WqlsHaSFnb3jARdS32ki3COPh0ySVdI6mK13m6CqEmZEiHmVrjZiFtNtULx7vDJfwqGQJ+zm/8ulas53AWaPFljGkwF9GV+vcbRNubu6UrQc2Cn/vr+Dq/FBxXKMHwXGdWoI6GOopxOQQqS9iLfFzEhTlia1ZFKnjRwTfVLUVnw/JTIkPsnV2DuBmP23fcFHUqseY6pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IiwHnNoARLmrvRU5dD+Ik86SKepzr2Ax/xNMF3caRzc=; b=EsRTMJofsLahGNp9zsixLptDLY7ylukjiYtQiDkdG3rowhuiDKaFq9PO/YOpQuciec/FaU+cdxzfUzuMm/SJPIHMFdtuwXlpO4cWFQ74vdNt+b01x9KbwDDCFlKR6ciWoOQiOJyHW9ajAHSZBk+4/2R5KKFPBnNYIFeUlzMrV5ttVKJFMHf8dvLL2olROVbpCXxN+F9OQ/8XNSIKZXSQEiDDnPRi6l49dhR/AC7kM78wkOb0d+wtj4+jVSDISjuON/HWf46NYuqINIrksIv234Q477S4NNql8Sjq0Gi+E+PNbPPsVNezx0uR0nzzgCEB2YmtpZEndA67/rlFxK8uEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IiwHnNoARLmrvRU5dD+Ik86SKepzr2Ax/xNMF3caRzc=; b=WkWV4E2X8izaa5TRZmiwe1yda2gXSktZFGhExPRbcu8J3kySSQ3PGygo5FUCjNlAT3CvLWkB/oqYdg6RsA+glV3ddeXTLSL06eoJjfPVaMxRFUklOF3948yG6IorLCSkKYpQkgkaJ2A5cXZeUE3isR9SCsaGyFmqsFGVeInbAYzcszIXZCDhEzGnSZ8i4p/AhXv5Z5xxsayoZDneRWjO42TpBoOFpkBcRzZbf8xft8HJJHmIOqf3r4KszFR5ahe3hE4rlhDxy/3V+VaLSIjNP3hxhvGqpz3bgO3MngZIye5c11Yvc87lUrE9kkZH9ylRFOZ+AYE+Hk4SgnM3UFZFrw== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by CY4PR1201MB0086.namprd12.prod.outlook.com (2603:10b6:910:17::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Thu, 14 Apr 2022 07:34:19 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::10e3:9c31:2a8c:2679]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::10e3:9c31:2a8c:2679%4]) with mapi id 15.20.5144.030; Thu, 14 Apr 2022 07:34:19 +0000 From: Raslan Darawsheh To: Shun Hao , Slava Ovsiienko , Matan Azrad , Ori Kam CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v1] net/mlx5: fix wrong counter in non-termination meter Thread-Topic: [PATCH v1] net/mlx5: fix wrong counter in non-termination meter Thread-Index: AQHYSZPoV1Ubhy+0AUORzSb1/LH3M6zvDN+g Date: Thu, 14 Apr 2022 07:34:19 +0000 Message-ID: References: <20220406085402.11639-1-shunh@nvidia.com> In-Reply-To: <20220406085402.11639-1-shunh@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e2ddb174-ea71-4cca-81f4-08da1de92fce x-ms-traffictypediagnostic: CY4PR1201MB0086:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OBVJiHJcTJ71+qVt/4/t/QL2/YSeaRRmNztU79N2tG6rX4UwSQ2AtQU3UH+mdEUNTND0lyPaoTRyTwjTX5CFarWzOAX79AXWZUldYD5HxYi/oRcXvn0Ul4cWsEoVh2BPgha9/AouHcscgoJzmQnECh0thijzRN/0+bai+BG5JfuTYTXGyM6iNOUP44d87yeaD2QkwRSbNxGrDYB7DBrg9lwpKROupyCITde3/KRF+UzCQDo7aIjha53yiNAMGTrq/jtvhLR3hpt8GHT3RJmhXTPwvJrjGRbt0yIET9fFakZZIXW7BJHg9IH+XijK5L/VBHfLe8l/v0IpIplNis4Pfzyns5fZI3MH1qSuzTkrjL9ScCA3deFCpg8ucLDjGMZbXrFtT9O3/YMiYfiYxUFuyisRFhTYH0XxCxdL395v223f1HloidvzEh/gIZSNqxk1APU/sWttEl8+nG53y1xzKJLz7zWnYc5EzisUFQO8kcvDsRQZC6N6DyHOo9yEotwchw8aDs65cD/cgtepQ17GLBckr3gQAHppNLUj4UVJQCDSy6IvTG2U6j3k2tUcvQPxBgib+DmxochZzbL/XyW3mXT4I1mwgRrk9MyWxpFwEsYC2TgVUFAQLQxkSj5sC8DY4W1ySAjSfQe1PIOJeHuBy4PZ6ZcfhY/axAL74dO/5lCeVDZMBoOIbgI0OgQH3XlNUfw02hfEcTXKMK/o29h94Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(110136005)(55016003)(26005)(316002)(6636002)(450100002)(66476007)(66446008)(54906003)(38070700005)(52536014)(83380400001)(8936002)(86362001)(38100700002)(186003)(5660300002)(508600001)(122000001)(53546011)(4744005)(9686003)(2906002)(8676002)(71200400001)(7696005)(76116006)(66946007)(33656002)(6506007)(64756008)(66556008)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xq0id5QygIxteaI7z52MfESGcBQOd6gxn0wrM1IWV1KQgyJ+8fShJsLuAEYp?= =?us-ascii?Q?sq45r0lg/Ps4pKEkp6myXbe831mW8OX1P2pFsCxk754LWR17igdWfuevkLaU?= =?us-ascii?Q?tEK2k4P9GPe+R09UveJsI4iZeUJvAaeaWpxpJjU76PUwdkB3/YnBv5tNSvPJ?= =?us-ascii?Q?2idVaF5w7BZmwiNRNKizms+yvl6gEusAW9WR9AAnqKqszIgH/GPw3IsR1MtP?= =?us-ascii?Q?uTtKv2tZR9AJLJ2IfoIPWw+q8loMpA3FdD4/QY6Kw7kuLXDPf7vmyfPpKwQo?= =?us-ascii?Q?wd82X4j2+doNosM0W+LKyK+qSRMY8s4IMVOr21sqfLKrujMPgXmlLBzevBXG?= =?us-ascii?Q?Mpg5+S5SwNgk4V5Gleac+bux3lHnivNlMGyge7lGeDqRq7/x86TNWGnIONqg?= =?us-ascii?Q?w3cadaJzWNW+zPyBNu/1rmPwrS64kBS0iHPo5qiPGkZ9LVuIzAOcLBdzHR5h?= =?us-ascii?Q?bRKPkGhTV+T7VA0qFIWXBylVHWOwHHP3hpWk/NicW5s2q8aIGsroOhe3R6EU?= =?us-ascii?Q?9LsYUJPLCvY+zu2o0k7flVl0XrasbTNYn5d2zm1AwDbtS9U/WH6kOfVsKdN6?= =?us-ascii?Q?sBRvW96BvhAEmbcz6mT5umzBLmfpGZemzxVRQEnxrErunO5XtfwyoIaUTnpp?= =?us-ascii?Q?AprxkLML9KchCMRnZe+HsdmMHKEMq8lxgqFLQApPtOT4JLeUDWKnlt73tg5e?= =?us-ascii?Q?5K/zNUFu1O0pBKi+dKlYYoGx6ZH1y1iSvwToJprjFoAWH2gXNFIMXsBI2Ixj?= =?us-ascii?Q?ZRuTVYdWCr5Do6mmQFQxdTodZsxtFFpdzjomDf7dLstSVKp63r8OdPaJsu/F?= =?us-ascii?Q?0+2jxdma9OSSWVYMAOOY5CuFfzvBoBsYJSchlTD7VKd6Gj/fesa54xBn4/Z5?= =?us-ascii?Q?Noj8e1vTSU9nIcmc9HDEvXBD6IZLwMVW1/3TReXgp/FHAN/ly8gPc4Lewsyr?= =?us-ascii?Q?dO6RMcwMLgQI2BJ3rvikk5eodmIQaiKlW8tYCxikH5QA4VZ8kLDyF7SrRQUF?= =?us-ascii?Q?5YWeA0TGsDWJ8kttKGOgntWFyTF2kYT6+G+hFb6ahNf5NZkty6n0eZbXrvhC?= =?us-ascii?Q?UseewHwX2hOdBo/11aRvTdo2aJOfH1VQoT83GNU3KjynaE9fmrUwYMMVXV5y?= =?us-ascii?Q?Hih6qK9BtKKwy4q2z32p2VESZ/QhGeCXi6Mv+5h9jT8UUfwayMOW6re8Q78S?= =?us-ascii?Q?cyzoBHOfF68X5d7kwmHkFSl9nw+EU0JWzCRjw5FDWMKMqYVTYLjcIu3zRgF1?= =?us-ascii?Q?1nHRt3zbPCo4BcXhnmsWn+hI32ChVbzJLoVMsmlXjSjfZ+4XbA8vFcueJOj6?= =?us-ascii?Q?s49RcuDzCT8qVOGE/q27jm3gypfnHhCjTQUtL6LgYDENMLocLxnrpJcIWQRn?= =?us-ascii?Q?/enqN/VVBcdGGNd+Au5hoOlWqUYSobLzRvWmWGKJeiGJuccvZ4L1R3F6oPiM?= =?us-ascii?Q?SqtSzeLSC4oLGq8AviFrrI+OW5+C1WwsJC/4Ix+eeidUFS2kIaca1vmQPFAn?= =?us-ascii?Q?+ajmJFqkQ92NE8G7CVsR/tJi8IEcC5xjZHXXafdn7etfo9aaKIoUt7oFhInv?= =?us-ascii?Q?vY7ADV71k3lLFKIw4t79K2dhF8OKqs8D8Hz9Jr1RklhvYhe8t29K/KA3OggG?= =?us-ascii?Q?3yzxyKetr+lr+awg1Jxj4lAyUJIQKojDNJwbjlrr5N/OJqy5JgsI8WOVhhKw?= =?us-ascii?Q?lNybQ2S+1A0aPCayzidzn682DlZnztWLmqKlkku+nYk0JjWbe75Ny0s6ZI3Y?= =?us-ascii?Q?/EQeq0MURA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2ddb174-ea71-4cca-81f4-08da1de92fce X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 07:34:19.2526 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f58RzfDDzxOCQQMAsZFnn2zeqpC3oTikF9kTZsdEbeF2FB2k/NA+DND2Xi3GYQD/q7MeJsKVIeTtfuC1uTDfSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0086 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Shun Hao > Sent: Wednesday, April 6, 2022 11:54 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: [PATCH v1] net/mlx5: fix wrong counter in non-termination meter >=20 > In RTE flow, if a counter action is before a meter which has > non-termination policy, the counter value only includes packets not > being dropped. >=20 > This patch fixes this issue by differentiating the order of counter and > non-termination meter: > 1. counter + meter, counts all packets hitting this flow. > 2. meter + counter, only counts packets not being dropped. >=20 > Fixes: 51ec04dc7bcf ("net/mlx5: connect meter policy to created flows") > Cc: stable@dpdk.org >=20 > Signed-off-by: Shun Hao > Acked-by: Matan Azrad Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh