RE: [PATCH] net/mlx5: support ESP SPI match and RSS hash

[Raslan Darawsheh <rasland@nvidia.com>]

Hi Raja,

> -----Original Message-----
> From: Raja Zidane <rzidane@nvidia.com>
> Sent: Monday, April 4, 2022 4:04 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>
> Subject: [PATCH] net/mlx5: support ESP SPI match and RSS hash
> 
> In packets with ESP header, The Inner IP will be encrypted, and
> its fields cannot be used for RSS hashing. So, ESP packets
> can be hashed only by the outer IP layer.
> So, when using RSS on ESP packets, hashing may not be efficient,
> because the fields used by the hash functions are only the Outer IPs,
> causing all traffic belonging to all tunnels between a given
> pair of GWs to land on one core.
> Adding the SPI hash field can extend the spreading of IPSec packets.
> 
> support matching on ESP SPI.
> Support RSS on ESP header by hashing SPI field.
> 
> Signed-off-by: Raja Zidane <rzidane@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  drivers/common/mlx5/linux/meson.build |  2 +
>  drivers/common/mlx5/mlx5_prm.h        |  5 +-
>  drivers/net/mlx5/mlx5_defs.h          |  2 +-
>  drivers/net/mlx5/mlx5_devx.c          |  4 +-
>  drivers/net/mlx5/mlx5_flow.c          | 84 ++++++++++++++++++++++++-
>  drivers/net/mlx5/mlx5_flow.h          | 20 ++++++
>  drivers/net/mlx5/mlx5_flow_dv.c       | 88
> ++++++++++++++++++++++++++-
>  7 files changed, 200 insertions(+), 5 deletions(-)


It seems that you missed updating two parts,
1- release notes as it's a new feature being added.
2-  features list in mlx5.ini 

devtools/check-doc-vs-code.sh
rte_flow doc out of sync for mlx5
        item esp

Kindest regards,
Raslan Darawsheh