From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67B5CA034D; Thu, 6 Jan 2022 10:05:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE17C406B4; Thu, 6 Jan 2022 10:05:08 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2052.outbound.protection.outlook.com [40.107.92.52]) by mails.dpdk.org (Postfix) with ESMTP id D64CD40150; Thu, 6 Jan 2022 10:05:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g2jWX/9uHH9g9+ZXpKrg6khs2N6BzviPtMH3weUDBF7KcaYcoHjZkenEuL6QuYFg3GM4+PXCnM/4qAsDaPIvwEjR4IplbZBpWaphV8zsw620TuJ2p4qjzi9rsCSAYXg7ol9HUQVhF+4mTdnz3OLXCEWtpZiDOYjF+tzVVstOFG9/3zam+eiiACABn0vkjWJyQERqQFMpf5q9N4QlLyT3Rsr9QRvPRXc7N/9AmgWnLU11pyd7+SItjaPHAEvCmVQCqWdaj7Z2oGPgcp9gYq1K8TzCDPgKmRX/c7MlPczSBFI60pkGrI1iUvaSsLaHmzvXR54OWt8PSHv6TbQzDxJ8rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oZHXP+Z2NfDlFaY8lABwYuLXcFRDQ3VlaAJHDXyRY8Y=; b=iGP43QPASIVN9axw0BZ4/b41In9ynJC9Fo4m/AeF9cdFp0vauKrDx0T2Yc9mjJbTuKeLb+3b5HMtJ2mdX2UfboPKv/f/bNpbEgCnPLHZs1XDViPJhqyXaog6VcxHBEUCZ529Yq5AGpePoYeawArsiDeWNU0vpi3HzDxmyvHdY2p+EyX5QMZIHPd1/hg/SQHAYPh9UEv3SPPDJcXJtcE4lG7XaaO7FmR+EkDIWKr46rqSAF1by2Qf3x4oT5fn7dK5r6EI1oVp9K10iTrxGbpeI3v4ZdIfNtvfg4IIOxCLbgy9nYv3ASg/uY4RSkxGg3w5HNw5KuCrlCoSW4mM0P20/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oZHXP+Z2NfDlFaY8lABwYuLXcFRDQ3VlaAJHDXyRY8Y=; b=keXySC1DD6JpQDandRQeT3xjRuZA0TD68LSx6taBtWcdVf6SbcMeUZ/6BMNqMXss2G7JBloI5wXL+e8nTkILjtSt2iYdZCa2y1KxUF94W5OmjE4C+GqoqvbRT2mD+r+VGatJDeEqzppftBwzVWw+1gt7pGVG3Y3gzLb7haSOZvMgTurfwYtYL2C0/YgszKZ/0HgDlpUxoFXjQJr+bYEDzl7DNb+5CkYOg2L7+ZpjZimLgHvd4srwnW5BDdcPWBS1ZChHWeWI8POOtZv6w7NgzGpXjmDgToa1ZTwxgjtYjbJvi7T48SDUeB8ADQgYwAK85gvwhJWH9NDMJGQIQZd6xQ== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by BYAPR12MB3224.namprd12.prod.outlook.com (2603:10b6:a03:137::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.7; Thu, 6 Jan 2022 09:05:04 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::587a:420a:2c5c:90ce]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::587a:420a:2c5c:90ce%6]) with mapi id 15.20.4867.009; Thu, 6 Jan 2022 09:05:04 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" Subject: RE: [PATCH] common/mlx5: fix error handling in multi-class probe Thread-Topic: [PATCH] common/mlx5: fix error handling in multi-class probe Thread-Index: AQHX4X8QIaRs1mpJcE2ct37lzipxcaxV9ehw Date: Thu, 6 Jan 2022 09:05:04 +0000 Message-ID: References: <20211124220238.3119860-1-michaelba@nvidia.com> In-Reply-To: <20211124220238.3119860-1-michaelba@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8f0e063c-d0dd-4531-d13d-08d9d0f3a0bc x-ms-traffictypediagnostic: BYAPR12MB3224:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YybW7UV7alDTLwnaAwFuwZFdlHC6IGSKQG5VcgwOzKYkiYfxtYiatttpZTtGskPVr/tMVPMyRGbX8y579wTPUZ/XpGMta2BpII8vGVkVzB703VxlEBpBLEMtSAjZOHlKjFInOMvP2wjNKIgkkEkOtpPGFiaIkG1Y5pxPcxfqxPgoEwtsM6l1g/j134e+Ks2t7B31mYCzutyv0mY0RsewLJb/9a5gnAZXKrSUZTAtod8rVA+doA56Y1VG6WnrW/5LRqB1Yp3GWc/v54kicbVrHhbw9LrUMmI9Zm7fPTMFaMFVYOgEY48cpP1pGHh5Jv9VL+GkOFH0IUCVh6f6EtO1VdakXxxceMZs8zoyUCVR0PLwJnONpMEmspE+i9CG6vSVX+/ZhaIQ46BXx1Y4evlpd+5A1oiiYodJBk6mEkVO7aIXw81zyQYUFq39YAnZeGodk5cRMVhGF8z0ZJzsiu2/hMpW+V2iomWJrdPcpK2L+EFSDZmtFsqWoNfgsX2+huHE4YBc4B3yyGvYlbzyDn5+lb4k0QFRerz+RS3snCvyknnGrpue3XHC8FqaWLLNnZfKTVwViXMFXj+wZSRPTeWSkg5cAtCyaC2/sUWdEd2Gx3qBdknnaVplnZcKR+pmhOjgtxeq0J3Q28TJIV+GazLsfPM8ZkfnUIpltLHzn8mMPz0THD6qJDyzpKV15S5QHE+LU40xNdgWM0fGbQYMQlixhQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(450100002)(4326008)(38070700005)(86362001)(122000001)(26005)(5660300002)(186003)(508600001)(6506007)(53546011)(52536014)(7696005)(2906002)(8676002)(110136005)(54906003)(8936002)(71200400001)(38100700002)(9686003)(66556008)(66476007)(66446008)(64756008)(316002)(66946007)(76116006)(33656002)(55016003)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7Yur50/iTbskZDeMV441Z8ExUUkDYOoGtQj3vKt1I0NM+JIc3WYU39VTDFiY?= =?us-ascii?Q?sJzixwxhozaE4gNASOZve6jFoXAcEMztMjM0aa2P3qXCFGUi+QyWTnJTDktz?= =?us-ascii?Q?LnRuMs5Oe65Y8394iOeNk1kbnYJBTB3n7SGwj2cnNZv7CjKCICiVsaaqEUEQ?= =?us-ascii?Q?+uqwm1lK2zZ/SxALp0o2vhXr+zEn7bAvQiFEUK2Z3aui/i70CgF75/C6bGhb?= =?us-ascii?Q?RyBnF8UlL5ikgtGupN9gxkPGAcFGp5euyfiX0f6jGVyFfiTB4/btvZwDK4Na?= =?us-ascii?Q?1ir6GL9hWmeWsYnnZMPU4QjBqFBphOtlYE7DicMJoV0KLTvcv6HpeKwRWweZ?= =?us-ascii?Q?I7UK4mzgteEtXVJyu73VR6F6W70FAKIZO30OYzzS+DYXj+ObRrldgnF9Rgpo?= =?us-ascii?Q?6u3h0iOo+yu6QLgc/X9KDyZwVhLBuB+Lv5kiQh4RPJH+KdXuYc8Imf2IGLiX?= =?us-ascii?Q?cd/QKSbIJUI9IyUXLsMkSYbj2t8gUiLsAEwujrKTGLir/HUReEUHVbPstqsg?= =?us-ascii?Q?713yGATnOQ/WE3zXuyTcPYYpvU4A33IzmwHSA8TWIOx8nro2hwySdBytQuMD?= =?us-ascii?Q?fMjXYjONmzVCQCnIeyyCmnPvd0M/v6WgTs2I3754vrtILuoiTbFSfm12jBdC?= =?us-ascii?Q?kblPUUiZ9SkhsUebbI19dYId+EyocaNBspKPlcSPPk8wmDLtGWESD6Uz54VJ?= =?us-ascii?Q?rDN3VPaAxbKqhsagD6aNkxybFsiXxNrGJpKbfSS3UlkpqjDb22vsUY3B3gHM?= =?us-ascii?Q?kdQzb2GfAKjh6zvJJ2tLq/FEzQhDdUpSVfFV46zL6ziZ1SGphlaOEky4Znds?= =?us-ascii?Q?8oEKGU107NOixPvmn8+o1MeCok1CJPzmR6+gMmyGtKE7D6BuXRiD1J3Q5+Rd?= =?us-ascii?Q?VFQr6NcWL9NfHVpPdO/ZRfxhglUjsVLuf2xnwVvauPzbOMeaUT6y3/CXCGWj?= =?us-ascii?Q?VPiATDmsx5RbAH3ZgWxpQm2E18OtiX/G7qIHmwHhLybnNMBDoWxLqkfGKaCG?= =?us-ascii?Q?5h8lgERCPufZFtNpR3Dug9G1uHnriQ/tRB3b0FPuQPASaowkxBz1AlZ0Hg0X?= =?us-ascii?Q?rdriXiA8xrxJxVV84V/y8jQJMzy69govaHxBwGDUB7MdxkonOhnmc/+Urc8c?= =?us-ascii?Q?syV+j9bGIqct3xzziTZMxc++r6orAYAETaZ6KsoxKo4NcpezpinICO45nIAT?= =?us-ascii?Q?tHQfeoNSCNt1aseuA1y7iTCYIlkyzFtwAWhPs+5XLHOmadYg//wHU4JQOH/7?= =?us-ascii?Q?oXtVKlwt1GkYFCTPH+kMK81MKQ4RT4jItM+dKCIyI6owMH4MlF7LNBvndwuO?= =?us-ascii?Q?puXTQ88lbB+yEhNzRaQbvXzkoz0uEsZXfiqjhPULDxRWQP9HMP5HkJrzl/rH?= =?us-ascii?Q?BZRyijRKJBLCpNZVjNIwindEyX0znueFREXBiCN7rN5NQZD2l2ruOok9quPB?= =?us-ascii?Q?3av8u7mOodlFnfpUSFJw0XOdxiQnMLpFKeVjoe2P0PI+66le0BN878Grdyj1?= =?us-ascii?Q?xMOg+PFts/vpdasr3ZTEdfE8ABtLeMlXDhAZFUXPG3TSSteRalftL8lLwFtA?= =?us-ascii?Q?OE5kgiRHt9/b0HaKVRp+KC6Avzlk3/9VatAX4KyBlmlhu819BVTBc0dDWf6Y?= =?us-ascii?Q?COs8vQu9NXPxseWA+YTXJ4k=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f0e063c-d0dd-4531-d13d-08d9d0f3a0bc X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2022 09:05:04.1057 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 54ZCmd8GDSyX8nj84EWDSJl/LkRvL+vOHoAinQjnEfIOq/gLbbtOgLdpcngryoGe0zotV2FqVIhG/S/FU83mZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3224 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Michael Baum > Sent: Thursday, November 25, 2021 12:03 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; Michael > Baum ; stable@dpdk.org > Subject: [PATCH] common/mlx5: fix error handling in multi-class probe >=20 > From: Michael Baum >=20 > The common drivers_probe function calls in a loop to all probe functions > for classes requested by the user. After it manages to probe them all, > it updates this on the device in the "classes_loaded" field. >=20 > If one of them fails, all those probed to it are remove using the > drivers_remove function. However, this function only releases the > classes in the "classes_loaded" field on the given device and misses the > newly probed classes. >=20 > This patch removes the condition from the release function, and ensures > that the caller function sends a more accurate parameter. >=20 > Fixes: 8a41f4deccc3 ("common/mlx5: introduce layer for multiple class > drivers") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh