From: Raslan Darawsheh <rasland@nvidia.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] net/mlx5: forbid direction attributes in transfer flow rules
Date: Sun, 6 Nov 2022 11:07:48 +0000 [thread overview]
Message-ID: <BYAPR12MB3078536765E21C04FFEE738CCF3D9@BYAPR12MB3078.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20221103101005.204800-1-dsosnowski@nvidia.com>
Hi,
> -----Original Message-----
> From: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Sent: Thursday, November 3, 2022 12:10 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH] net/mlx5: forbid direction attributes in transfer flow rules
>
> Since [1] flow API forbids usage of direction attributes in transfer
> flow rules. This patch adapts mlx5 PMD to this requirement.
>
> From this patch, flow rule validation in mxl5 PMD will reject transfer
> flow rules with any of the direction attributes set
> (i.e. 'ingress' or 'egress').
> As a result flow rule can only have one of 'ingress', 'egress' or
> 'transfer' attributes set.
>
> This patch also changes the following:
>
> - Control flow rules used in FDB are 'transfer' only.
> - Checks which assumed that 'transfer' can be used
> with 'ingress' and 'egress' are reduced to just checking
> for direction attributes, since all attributes are exclusive.
> - Flow rules for updating flow_tag are created for both ingress
> and transfer flow rules which have MARK action.
> - Moves mlx5_flow_validate_attributes() function from generic flow
> implementation to legacy Verbs flow engine implementation,
> since it was used only there. Function is renamed accordingly.
> Also removes checking if E-Switch uses DV in that
> function, since if legacy Verbs flow engine is used,
> then that is always not the case.
>
> [1] commit bd2a4d4b2e3a ("ethdev: forbid direction attribute in
> transfer flow rules")
>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2022-11-06 11:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 10:10 Dariusz Sosnowski
2022-11-06 11:07 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB3078536765E21C04FFEE738CCF3D9@BYAPR12MB3078.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).