From: Raslan Darawsheh <rasland@nvidia.com>
To: Dmitry Kozlyuk <dkozlyuk@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Li Zhang <lizh@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org>,
Stephen Hemminger <stephen@networkplumber.org>,
Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: RE: [PATCH] net/mlx5: fix GCC uninitialized variable warning
Date: Sun, 9 Jan 2022 11:58:59 +0000 [thread overview]
Message-ID: <BYAPR12MB30788B889E4FE3F77F1D0C17CF4F9@BYAPR12MB3078.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211228091704.3359132-1-dkozlyuk@nvidia.com>
Hi,
> -----Original Message-----
> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Sent: Tuesday, December 28, 2021 11:17 AM
> To: dev@dpdk.org
> Cc: Li Zhang <lizh@nvidia.com>; stable@dpdk.org; Stephen Hemminger
> <stephen@networkplumber.org>; Matan Azrad <matan@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH] net/mlx5: fix GCC uninitialized variable warning
>
> When building with -Db_sanitize=thread, GCC gives a warning:
>
> drivers/net/mlx5/mlx5_flow_meter.c: In function
> ‘mlx5_flow_meter_create’:
> drivers/net/mlx5/mlx5_flow_meter.c:1170:33: warning: ‘legacy_fm’ may be
> used uninitialized in this function [-Wmaybe-uninitialized]
>
> This is a false-positive: legacy_fm is initialized and used if and only if priv->sh-
> >meter_aso_en is false.
> Work around this by initializing legacy_fm to NULL.
> Add an assertion before legacy_fm use in case the logic changes.
>
> Fixes: 444320186393 ("net/mlx5: support meter creation with policy")
> Cc: lizh@nvidia.com
> Cc: stable@dpdk.org
>
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2022-01-09 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 9:17 Dmitry Kozlyuk
2022-01-09 11:58 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB30788B889E4FE3F77F1D0C17CF4F9@BYAPR12MB3078.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=dkozlyuk@nvidia.com \
--cc=lizh@nvidia.com \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).