DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@nvidia.com>
To: "20230703182123.210117-1-mkashani@nvidia.com"
	<20230703182123.210117-1-mkashani@nvidia.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Maayan Kashani" <mkashani@nvidia.com>,
	"Ori Kam" <orika@nvidia.com>, "Matan Azrad" <matan@nvidia.com>,
	"Slava Ovsiienko" <viacheslavo@nvidia.com>,
	"Suanming Mou" <suanmingm@nvidia.com>,
	"Mário Kuka" <kuka@cesnet.cz>
Subject: RE: [PATCH v3] net/mlx5: fix RSS expansion inner buffer overflow.
Date: Thu, 6 Jul 2023 10:58:31 +0000	[thread overview]
Message-ID: <BYAPR12MB307890F37123E3A602D978EECF2CA@BYAPR12MB3078.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230706085544.105641-1-mkashani@nvidia.com>

Hi,

> -----Original Message-----
> From: Maayan Kashani <mkashani@nvidia.com>
> Sent: Thursday, July 6, 2023 11:56 AM
> To: dev@dpdk.org
> Cc: Maayan Kashani <mkashani@nvidia.com>; Ori Kam <orika@nvidia.com>;
> Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Suanming
> Mou <suanmingm@nvidia.com>
> Subject: [PATCH v3] net/mlx5: fix RSS expansion inner buffer overflow.
> 
> The stack which used for RSS expansion was overflowed and trashed RSS
> expansion data.
[Raslan Darawsheh] line too long, wrap at 75 char will fix during integration 
> (buf->entry[MLX5_RSS_EXP_ELT_N]).
> Due to this overflow, packets such as ARP or LACP with overwritten RSS types
> due to the
> overflow will be dropped.
> 
> This increases the buffer size to avoid such overflows and adds relevant
> ASSERT for the future.
> 
> Bugzilla ID: 1173
> 
missing fixes tag and CC stable:
Fixes: 18ca4a4ec73a ("net/mlx5: support ESP SPI match and RSS hash")
    Cc: stable@dpdk.org
will fix during integration

missing:
Reported-by: Mário Kuka <kuka@cesnet.cz>
will fix during the integration

> Signed-off-by: Maayan Kashani <mkashani@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
> ---
Reviewed-by: Raslan Darawsheh <rasland@nvidia.com>

Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh

      reply	other threads:[~2023-07-06 10:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06  8:55 Maayan Kashani
2023-07-06 10:58 ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR12MB307890F37123E3A602D978EECF2CA@BYAPR12MB3078.namprd12.prod.outlook.com \
    --to=rasland@nvidia.com \
    --cc=20230703182123.210117-1-mkashani@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=kuka@cesnet.cz \
    --cc=matan@nvidia.com \
    --cc=mkashani@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=suanmingm@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).