From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AB94A0032; Wed, 17 Aug 2022 10:19:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D58D40DDA; Wed, 17 Aug 2022 10:19:31 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2073.outbound.protection.outlook.com [40.107.93.73]) by mails.dpdk.org (Postfix) with ESMTP id B45B74068E; Wed, 17 Aug 2022 10:19:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z4xHxJGaQanVxxfpijKRv4ywtERyO+J9/15qkZmXJtLsGp8LyD5bzK2SBeU5MZbbcW+c7FUWRQ0AaqsnobG/5daECKgHsQNusVesK134QE5vgmzUH4WTeZAJ/UftU6JLMhhSVfTzH2A8ztXJhDMQUpkuhtF3Tz8W44Km3lwKe2QHlnq8InDNJDBQVv1IYsP3KgXp8oNeUK+CJRs1rfFfThvowv51wVoyB0+K4BMLuNk5W7Fh46KdCz+m7iAQfYPFlFPWmfbQQUjTkOXf90Wkq7CfY92cwqQEWv1w8E2rO/+EL3I0QoxjYodOtApVPH4Pg/k9c+psVBle7FMdVfTuqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gfUQ6K4MfMmx1FHMgIQPa5xgkgQmY1I0Y4o2UqVDyUE=; b=n/MO8jHCjgmJlx+QZVU3eAaGI2CRj7RvAOfsKQyc/3AhNPcj9uHheRkbFyKbuCZluCxERoLmypioWbBhmDL5JulKT3kSm76/r0BerUHl6z/I0VyNwtRYZxItPHQQlXJrXwfK4k9xP04Dl+EcENERJqedzlRUtnadrJwQdEoQ/WmuDt2Ve/kmVJQbCcdyZA4ZvMOG8Wu6kup7mR9ubl45nkE33v28XQRLRMhZgndgqwqA4EKa0RbWjLOOJJ1Shjvaj0ATmf+IPRNB3G4Pm4E0M4NQxXqFHxqrg7VvzE0Dg2xeSRv45JwY6jiteFRhWpRAUVGulUCiy7I+TQ/Q2c29uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gfUQ6K4MfMmx1FHMgIQPa5xgkgQmY1I0Y4o2UqVDyUE=; b=KsE2x4wTHPPGhyCphZ/Aty2eNL5wfeYl0rKTZJqkYKbpMFn7iy0BmV8OBs3UKnlzbj45YZjnBFfUyKdTLgb8ojZoEzmnZp3bbu11wCJSr0nsOeeB8wioZUTLMYOMI1rd7sUWPsV9Hlft+IrNZfawu73I+8nEuNaNcpcg5JGRm/w5ja5n2zktWotZ76MY1wJ2UiAbDhPIwdQF28DLq7mz0O3rAiPNZA4ItlqBkIZaYxORNzJce31tsTpuO8GNfCK57KiA7AbsTlItPSPXLqaIxgdo7kx9Ciml48PmQVnsDt99t31ra2T9FZpRaMl8GmhfD7672VJV4ca++qDC/O8lKQ== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by BYAPR12MB5702.namprd12.prod.outlook.com (2603:10b6:a03:9a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19; Wed, 17 Aug 2022 08:19:27 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::acbb:9c84:ec42:78a3]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::acbb:9c84:ec42:78a3%5]) with mapi id 15.20.5504.020; Wed, 17 Aug 2022 08:19:27 +0000 From: Raslan Darawsheh To: Bassam Zaid AlKilani , "dev@dpdk.org" CC: "rzidane@nvidia.com" , "stable@dpdk.org" , Matan Azrad , Slava Ovsiienko Subject: RE: [PATCH] net/mlx5: fix matcher priority for esp item Thread-Topic: [PATCH] net/mlx5: fix matcher priority for esp item Thread-Index: AQHYoowk7eTVvnLYCEyifdnx4bjxFq2y3hGA Date: Wed, 17 Aug 2022 08:19:27 +0000 Message-ID: References: <20220728141203.3191-1-bzalkilani@nvidia.com> In-Reply-To: <20220728141203.3191-1-bzalkilani@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3f70ae39-1907-48ee-61eb-08da80293382 x-ms-traffictypediagnostic: BYAPR12MB5702:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ae+h+nfdN1rDoqbxK7xf7Qdj5kNHxU8CcE0h7PaklbyDzQnaAlPC89vJyqbJHUL5OiO2a+Yi2m1Im4K8wbR3n4TewjhpHoM0cGRYY/qADUK0mMc5d3x2/wk6czPgsqE9H+65fastWuqBi3TQm2tLjlODr7dCB1gOB+VeQhrFIfo3rd6HsuUJUJWg1zkvtT92XRb9mpzRa9qtBtXavc6RI5LYIuVUos1XjM3BiuYWZyHyz42j9lWSbw6uW00kvgCuRmSioo0HyEHXefH98G6dkaVbyrJiArC6nku7Bhx8RpM9hl05vpBg4Vk4Xa8DlCxwqLuxzaquL+SnuHkZEWKyqYiRZFnV4jPtjTmfBdZgG4Z8fk4ziXQc0nhdO9l1B/rjLbqEbrfYON5rsrvFVaxumLJC1kJQaRo4I3whaNryO5iru1H3mCPY+cBCxVCasp//d+tE2/paI6aVnOPcHInHxC7/10VsgHk+84H8uddrJUiVZQ0UuNyxFEbY3hp+jHBluZdjc1puMRqKlehYIwH7FUddVUzqbWtEnNBUi5MECmKu3JZMw86wJmYagi0QlfJx1YIZfLdfqvUUH67/NtrtYctWsDVnyCCmV7D8RyTOGAoVCUfbr1wGmJM2rDW98YPJ1EP8cnIBQ9UL6mTmgWz9KLVYVRq4a4jj9Wcd4/Dqx7Y3tYCM7k3c8kNWacdvwYQL+qnHPt46raKqmMPuzufHKQFcuS+kipElP563PDTIA/w4kYQ/RcCPJQKR2v3UMjXJLD6qc8pIVJ8LsfrzlTAXAQcr5AvBVY4N79yFmSBbOI7N8/ZMSbkljhi5lHj1H1OB x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(39860400002)(346002)(376002)(366004)(396003)(9686003)(26005)(53546011)(6506007)(7696005)(86362001)(33656002)(38070700005)(186003)(38100700002)(122000001)(83380400001)(55016003)(71200400001)(450100002)(5660300002)(478600001)(52536014)(66946007)(8936002)(76116006)(64756008)(8676002)(4326008)(66446008)(66476007)(66556008)(2906002)(107886003)(110136005)(41300700001)(54906003)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FGXw3uxGDukge0oXDjux7WcKZc/CYEqaN9qwMF98ks/rR95MzfO4rPTujYKm?= =?us-ascii?Q?tgvSn6c4QX2bkK1bVYZUdgoJrWJqtQntM18zdY/vKyIPGtc0foSrNL6Y/6rn?= =?us-ascii?Q?a89a2VMr1z/UZyvID661NXu+DdKvrwSLjFIFUQKlWOeO8dvj2+sADALoR/Ef?= =?us-ascii?Q?70uJIzyQuLyDH8TFaK20kr6lVyyGNgkILEBundyzt9Wcj6W7ZZGYsMDDPO+U?= =?us-ascii?Q?SgVshHx/RtbvfpeVnE4ct8yg9yDETW0EgmQURKWIP3ii/HZxJUzp7C/kjfme?= =?us-ascii?Q?y5C83AKqDk8hK4Suucbq5/Fuz2CElyhmJR3lWxDc1lUmwwMGdPz4cOlQgR1R?= =?us-ascii?Q?9ZdDVWe1BDvTtVbyKmRHI68TpsImLSFctybuXRd2cVyXVkqiJohE4JqJbauw?= =?us-ascii?Q?kPmWlOka7Oriz7Bm04LPSgDZYevdTJfCz4kAp9VxYFi00Apxt6LSS3OsafuS?= =?us-ascii?Q?LEuG0qxAvfro7pc++SQcfQ2q5awOrW0KlU5W0WzvMHaWwWCK0fv2/ZHbj1An?= =?us-ascii?Q?BinDkBkURf0oUgVm5xHLaFEZSk73Kcv+oISDuIBrE4PHvrwKHR3vwNYFRzz+?= =?us-ascii?Q?TsAiEbS5CAGIjuT34pOT0dTTHLPLqVbb2Wynm7F5etl0niLZS4ljrPOvnT3F?= =?us-ascii?Q?2jEQDnvVSsSOBTxnFWZcKLKLt+Q33les0/EiPZv6Y4ImrNQau+WgPiQE2MMT?= =?us-ascii?Q?7SRkSeFkcrSpxy40sXp97nAFwLX1OjPebXcq2vPTfdm6RhxGdxVDqMk98g7/?= =?us-ascii?Q?e8IimAM7dJ76JU6whmpGKHFEfQMoXSIBt4wtjdb+w4XM7Rz2sQ+okBS0KG+x?= =?us-ascii?Q?63kKKX2PwbixoTUZkHB4v+RYjH6TqmfvI24P5tlLe6JUQjFSVrGlACai2UHT?= =?us-ascii?Q?lrsFXGNVTORnV6KYArc3RYeFfXqhvfjf4PvNOIxy7ef6KLUn3f004BddvHJA?= =?us-ascii?Q?5OUKBUcuVRZRqBE+Ar35NpYtPT+brf2B/MydhImTYPwnw7Dgpc87oYhBI671?= =?us-ascii?Q?Ze95Qu+qnTXihD/i6w/6njHbBqpc/oPTI376blDlUgejzwd3LTGIL9c9DtrH?= =?us-ascii?Q?3I0Sz+gS63DDiGoNtgA8m3d8ekHDpkoRt0lvGvnQzA4drtdv0S5vTu5q41SZ?= =?us-ascii?Q?b4RttZNRbwRgGkD/ddU14bBY1wtjQhzR7K354afhRCZnlEWl3guz5M9IqNjx?= =?us-ascii?Q?m9BRRb9b1/5LIFEWjjy3rphRST86TSb+hjDFa7+l4xwE7ziHGtm31f13EFob?= =?us-ascii?Q?81bu14UtE63+lof+AIC4Zj131OvSj4FyMniQZIfkcucKclqtA5Sx1YDt3EIz?= =?us-ascii?Q?E5JGm7dZwC6CJ/wNYpCMdWsxWt8SGQtw0caIwcqHeZWRbnRJ+5HVY42igsFu?= =?us-ascii?Q?wZuXzEUZg8+//Z4Ta2EXJk0pHlk5cG1dG5MNYuD4y9IB9eact5S7cy0er1oz?= =?us-ascii?Q?3RJzf2is6l5pZtszCmaWf7EDGXCPIRpKN5oq6du9o2YaK2lrXC7lRjzukQ13?= =?us-ascii?Q?/NaPIupKK7nx0okhWJmSivPoDsMZ/AqYvB6HqJOLRdmyNHq5WWszTwfONtsp?= =?us-ascii?Q?ZFybvxlrLLZ0eUMhVs3o+fdPwOkosh2Qnq+RMpY2?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f70ae39-1907-48ee-61eb-08da80293382 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2022 08:19:27.2075 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vN1ejwxaUq9V4JG3fKnCxioD1GblxXBTWP8K8OEVnozDn76ZEDyNX2jAwNcm591sWuNCNVcWcJoVjpCZSywgug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB5702 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Bassam Zaid AlKilani > Sent: Thursday, July 28, 2022 5:12 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; rzidane@nvidia.com; > stable@dpdk.org; Matan Azrad ; Slava Ovsiienko > > Subject: [PATCH] net/mlx5: fix matcher priority for esp item >=20 > ESP is one of IPSec protocols over both IPv4 and IPv6 and is considered > a tunnel layer that cannot be followed by any other layer. Taking that > into consideration, esp is considered as a 4 layer. >=20 > Not defining ESP's priority will make it match with the same priority as > its prior IP layer, which has a layer 3 priority. This will lead to > issues in matching and will match the packet with the first matching > rule even if it doesn't have an esp layer in its pattern, disregarding > any following rules that could have an esp item and can be actually > a more accurate match since it will have a longer matching criterion. >=20 > This is fixed by defining the priority for the ESP item to have a > layer 4 priority, making the match be for the rule with the more > accurate and longer matching criteria. >=20 > Fixes: 18ca4a4ec73a ("net/mlx5: support ESP SPI match and RSS hash") > Cc: rzidane@nvidia.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Bassam ZaidAlKilani [Raslan Darawsh= eh]=20 Acked-by: Raslan Darawsheh Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh