From: Tal Shnaiderman <talshn@nvidia.com>
To: Pallavi Kadam <pallavi.kadam@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Cc: "ranjit.menon@intel.com" <ranjit.menon@intel.com>,
"John.Alexander@datapath.co.uk" <John.Alexander@datapath.co.uk>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
"Narcisa.Vasile@microsoft.com" <Narcisa.Vasile@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH v6] bus/pci: netuio interface for windows
Date: Thu, 8 Oct 2020 17:46:48 +0000 [thread overview]
Message-ID: <BYAPR12MB3285A7D59FCCCF6CE7DFECB3A40B0@BYAPR12MB3285.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201006215730.1584-1-pallavi.kadam@intel.com>
> Subject: [PATCH v6] bus/pci: netuio interface for windows
>
> External email: Use caution opening links or attachments
>
>
> This patch adds implementations to probe PCI devices bound to netuio with
> the help of "netuio" class device changes.
> Now Windows will support both "netuio" and "net" device class and can set
> kernel driver type based on the device class selection.
>
> Note: Few definitions and structures have been copied from
> netuio_interface.h file from ("[v5] windows/netuio: add Windows NetUIO
> kernel driver") series and this will be fixed once the exact path for netuio
> source code is known.
>
> v6 changes:
> - Split up the get_netuio_device_info() function into smaller
> functions
> - Moved get numa node id code to get_device_resource_info() in
> order to work on both RTE_PCI_KDRV_NONE and
> RTE_PCI_KDRV_NIC_UIO
> v5 changes:
> Changed when netuio driver handle is closed
> v4 changes:
> Removed 'reserved' member as it is not used
> v3 changes:
> Removed the casts
> v2 changes:
> - Moved all netuio specific definitions and functions to
> pci_netuio.c and pci_netuio.h files
> - Added a single function call to scan all the devices
>
> Signed-off-by: John Alexander <John.Alexander@datapath.co.uk>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> ---
<snip>
> diff --git a/drivers/bus/pci/windows/pci_netuio.c
> b/drivers/bus/pci/windows/pci_netuio.c
> new file mode 100644
> index 000000000..5c9790684
> --- /dev/null
> +++ b/drivers/bus/pci/windows/pci_netuio.c
> @@ -0,0 +1,190 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2020 Intel Corporation.
> + */
> +
> +#include <rte_windows.h>
> +#include <rte_errno.h>
> +#include <rte_log.h>
> +#include <rte_eal.h>
> +
> +#include "private.h"
> +#include "pci_netuio.h"
> +
> +#include <devpkey.h>
> +
> +#ifdef RTE_TOOLCHAIN_GCC
> +#include <devpropdef.h>
> +DEFINE_DEVPROPKEY(DEVPKEY_Device_Numa_Node, 0x540b947e, 0x8b40,
> 0x45bc,
> + 0xa8, 0xa2, 0x6a, 0x0b, 0x89, 0x4c, 0xbd, 0xa2, 3); #endif
The whole ifdef section and the devpkey.h include can be removed since Numa detection is done in pci.c.
next prev parent reply other threads:[~2020-10-08 17:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 1:59 [dpdk-dev] [PATCH] " Pallavi Kadam
2020-09-13 18:42 ` Tal Shnaiderman
2020-09-15 20:13 ` Ranjit Menon
2020-09-15 23:28 ` [dpdk-dev] [PATCH v2] " Pallavi Kadam
2020-09-16 1:54 ` Stephen Hemminger
2020-09-17 0:48 ` Ranjit Menon
2020-09-17 1:20 ` Ranjit Menon
2020-09-21 21:08 ` [dpdk-dev] [PATCH v3] " Pallavi Kadam
2020-09-22 3:05 ` [dpdk-dev] [PATCH v4] " Pallavi Kadam
2020-09-25 1:53 ` [dpdk-dev] [PATCH v5] " Pallavi Kadam
2020-09-29 8:28 ` Tal Shnaiderman
2020-09-29 17:29 ` Ranjit Menon
2020-09-30 7:58 ` Tal Shnaiderman
2020-10-06 23:31 ` Kadam, Pallavi
2020-10-06 21:57 ` [dpdk-dev] [PATCH v6] " Pallavi Kadam
2020-10-08 17:46 ` Tal Shnaiderman [this message]
2020-10-08 18:56 ` [dpdk-dev] [PATCH v7] " Pallavi Kadam
2020-10-08 21:50 ` Tal Shnaiderman
2020-10-09 2:12 ` Narcisa Ana Maria Vasile
2020-10-14 20:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB3285A7D59FCCCF6CE7DFECB3A40B0@BYAPR12MB3285.namprd12.prod.outlook.com \
--to=talshn@nvidia.com \
--cc=John.Alexander@datapath.co.uk \
--cc=Narcisa.Vasile@microsoft.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).