From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B540DA0096 for ; Thu, 6 Jun 2019 18:24:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8AD1F1B970; Thu, 6 Jun 2019 18:24:06 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id AF32E1B96B for ; Thu, 6 Jun 2019 18:24:04 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x56GLFRm009926; Thu, 6 Jun 2019 09:24:03 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=1GcOIiMN+GDaH955Yz+f0Y2nYDhgWbVNRlF4veYcS8A=; b=f2gaHZdlOXlVcXEwrjzZq05XtPCTplutvP+uLVl/6YlG5SfLO6C+2NHrzimNfVGvo8rB SE9lzKLwzd6tQW3kX8EVzB+wVlGfv5bpopEffgOWg4ZoaTI+N40GQNdUcQzNCtAKeoxL pxIg1m52oi3bnFpEh0kMUefBjlp9vg8DOZHX+wBpuY8+DyEqtLvJPBU8EvRSWcbYhdFZ 3F0l3G9LMKdU52Jnb3F+CbIb+xVE5iQ3yxPa8X6QBiaUVbmV2yC2/88cpisI2wdszTN5 0xRSnm7hGW7EGur3q6A/3EjQbHisDu7TRHo2WyBrUtd6CjXDumiiYAd2b+qxWDV0nMYt VA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2sxwgnt94b-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 06 Jun 2019 09:24:03 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 6 Jun 2019 09:23:31 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.51) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 6 Jun 2019 09:23:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1GcOIiMN+GDaH955Yz+f0Y2nYDhgWbVNRlF4veYcS8A=; b=J7LYZCGuATUMWuIe0Lw0jJLm2bCWH3Z5EB0w9o2312gDOkq8dMyQhCe83kPZhACBZ2jf+C3+pneemJrPk04ZvIxUhmn2nYYdVRBqh93wVdAnfl2zOw9iBvd40FO4juGuPISsyQxesELPzpoFw9oaW8t302h2wMVoACa1rt88HBE= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2518.namprd18.prod.outlook.com (20.179.93.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.22; Thu, 6 Jun 2019 16:23:26 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c%7]) with mapi id 15.20.1965.011; Thu, 6 Jun 2019 16:23:26 +0000 From: Jerin Jacob Kollanukkaran To: Neil Horman CC: Bruce Richardson , "dev@dpdk.org" , Thomas Monjalon Thread-Topic: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag Thread-Index: AQHVEynnIvy0R3R0lkaWrQuIVgPnUKaNTWtQgAAIeYCAABfgAIABAvyAgAAgfgCAAAaRkIAAGyeAgAAFlPCAABM/AIAAAWqggAAE6wCAAAykAA== Date: Thu, 6 Jun 2019 16:23:26 +0000 Message-ID: References: <20190605164541.GH1550@bricha3-MOBL.ger.corp.intel.com> <20190605181108.GC554@hmswarspite.think-freely.org> <20190606113422.GA29521@hmswarspite.think-freely.org> <20190606133503.GB29521@hmswarspite.think-freely.org> <20190606150354.GF29521@hmswarspite.think-freely.org> <20190606152634.GG29521@hmswarspite.think-freely.org> In-Reply-To: <20190606152634.GG29521@hmswarspite.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.178.234.223] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f753e186-f016-41ee-2907-08d6ea9b4db3 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2518; x-ms-traffictypediagnostic: BYAPR18MB2518: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 00603B7EEF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39840400004)(376002)(136003)(366004)(396003)(189003)(199004)(13464003)(229853002)(55016002)(6306002)(14444005)(256004)(81166006)(64756008)(6436002)(73956011)(7736002)(76116006)(76176011)(6116002)(3846002)(71200400001)(486006)(66946007)(6916009)(14454004)(305945005)(316002)(966005)(52536014)(66476007)(86362001)(5660300002)(66556008)(8676002)(68736007)(7696005)(26005)(81156014)(186003)(9686003)(25786009)(476003)(53936002)(33656002)(71190400001)(66446008)(74316002)(66066001)(102836004)(2906002)(99286004)(6246003)(8936002)(4326008)(54906003)(446003)(478600001)(6506007)(53546011)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2518; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: J1SS944yNMAw71HySvTJ64OY6CQ/Pez4b3UhkPVsX5arsgntbKWHFPvLa6S/Ed4Mf1PJUPAawhMjHTXzpVtQjikPqu597y8JhNp8z04H4kA85E93QriofD5HAPt6po7X6SoYn3wV1gI0Zp4ttNdCaaRgXPLjEKUvezk22zXsE6BFI6YrHDdgT2vR3bCYXgVtWlDs/bnGRcvzttqZucLEx/ti4dPWz6oCvTZkNcgLh0QBb3Qoq+jfq26wSDt/ZRAuEYUf/dss0Ofb3w1whllZQW9lZII5Jj1RkY6PzpX5Pz8YAlk/xiisYRDjAqHzZIlELlAqT2Wa97OWTa+18aVDTuxaLdJNsRYH6oMkKu6zht70S3wl8U8a0s1adh9dRNDufu4HPf4LFdlM+Kug4otbpqzl5e1g+Cl+w6QYF1ocz3Y= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f753e186-f016-41ee-2907-08d6ea9b4db3 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2019 16:23:26.2632 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2518 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-06_12:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Neil Horman > Sent: Thursday, June 6, 2019 8:57 PM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > Thomas Monjalon > Subject: Re: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag >=20 > On Thu, Jun 06, 2019 at 03:14:42PM +0000, Jerin Jacob Kollanukkaran wrote= : > > > > > > I don't have any strong opinion on name prefix vs marking as > __rte_internal. > > Or combination of both. I am fine any approach. > > > > I have only strong option on not to induce objdump dependency for > checkpatch. > > For the reason mentioned in http://mails.dpdk.org/archives/dev/2019- > June/134160.html. > > >=20 > Sorry, in my haste I didn't fully adress this in your previous email >=20 > I'm really uncertain what you mean by introducing a checkpatch dependency > on objdump here. Theres nothing preventing you from running checkpatch > before you build the library. The only thing checkpatch does in dpdk is = scan > the patches for sytle violations, and for changes in the map file for > movement to and from the EXPERIMENTAL section (i.e. no use of objdump). >=20 > My patch modifies check-experimental-syms.sh (adding an objdump scan for > INTERNAL symbols, and renaming the script to check-special-syms.sh to be > more meaningful). That script however, is not run by checkpatch, its run > during compilation of the library to ensure that any symbol in a map file= is > also tagged with __rte_internal in the corresponding object). Theres no = path > from checkpatches to check-experimental-syms.sh >=20 > What I meant in my last comment was that any dependency on objdump in > check-[experimental|special]-syms.sh already existed prior to this patch. I see. I thought your patches addressing issue related to=20 http://patches.dpdk.org/patch/53590/ Where checkpatch.sh complaints when we add new internal driver API with out rte_experimental? That's where all the discussion started. The reason why I was saying the API name prefix to mark as internal API is that checkpatch can detect that case. Example: ERROR: symbol otx2_mbox_alloc_msg_rsp is added in the DPDK_19.05 section, b= ut is expected to be added in the EXPERIMENTAL section of the version map >=20 > So I'm unsure why you think checkpatches has a dependency. >=20 > Neil