From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07C60A046B for ; Tue, 23 Jul 2019 06:18:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DA67F1BF43; Tue, 23 Jul 2019 06:18:54 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id D283C1D7 for ; Tue, 23 Jul 2019 06:18:53 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6N4FnAC003430; Mon, 22 Jul 2019 21:18:53 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=+EEo6HBzrNjpMsdUjJkYcD1DzoAn4vs/lMkV8t4jFA4=; b=fyaQF16IqAJtqtXOpl/agpDIkVgH/hkakVBKFRylAaqqOE1459zzU2XgQa+KpcJlk++4 3uHEOSy7LsD9XB2+infQSGHCzdWxV+jIG8hIqUbBWv+wPkwRPM5rUVCtFkA1sg/5rnxk tz+b4FdbCHySdaVmHqTW7YudlwWUPGFxDde+NUzINePoSg66GI1LJnVzvvHTlHrR9TYY AbPNqh0kmYMD1cobKMynDDqxxoCWRg4oxHqokQjFbnKkINWm9h6K7h0KTHawL6KBRtt4 cyFzMiFyZniUrk5YHVfdhXRpPNVFSOPZfW1xXkTVS0w6RkOAkpGpjFJzY/w5FBxlt47Q Rw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2tv0ap23jv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 22 Jul 2019 21:18:52 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 22 Jul 2019 21:18:52 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.58) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 22 Jul 2019 21:18:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TftY3xHv/xv0+c3EQpy+89WbiHNBLHbeyMOAUnXWQZblElXwmSG7M+szoxhJM1+yJJhPJEGteKLqhYA0U/tHygdvWPE3sou0UhbgJ9ZZ0KEeZ50mUU88DE1rMJS9uVDInc5AtyMv5OO9HCgo1nESFtTzQwHnD69Jqc38ynrQLMJE68Yf+3JmFErLEdSHvbj5f6yGOyt73ulyI5Y73HD8Bra+CU/vHCk59rbgyMNbNszjGxjjDW4DhehFH6GdGwvE/cd44Ez1eC7yf79WSfSIdW15YHTM/E+runzKcEYatOSDXditdW3oMJYmh5Ou+8/12umAIHZHhZjMN5q0171mfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+EEo6HBzrNjpMsdUjJkYcD1DzoAn4vs/lMkV8t4jFA4=; b=kD531tyYeeTSyQIBJkfQzxSw/LdPsBBfVeQ+akU4VVn2U4Uskwg6m1SqYgAQKa4cZDvYjQnXz7fU8IWRXhmDPXgb83Pdg0thyvLGY255m3RiOrGXeAvlhT6SDwk9JAfr6iE2iKSrz9egRljh49osEgKCgU4tSqlHixxROS6xAOe4+QaQpMMGfF1aXmrRiUq0Ry0IFGj7K4jD8QjGs84uiFH1wyOakdgbKXQuYNi6ZxjGXoK2ubt7NqxOQ+GCUsTBxOIlViHNt4NsiV2axgVsglngDkPaDRWlf5rNWDRCr8bH78jW86K57uCu+URvGb2uDD9Syx5aKOkV1VdXfciVag== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+EEo6HBzrNjpMsdUjJkYcD1DzoAn4vs/lMkV8t4jFA4=; b=fl9rVgSzJ8PNDd/SdVWwhlE4JK6GCnPzfFuuLxW93hgj934qjBJozZ8TdRtYGlSfS/HWMgVz2BlcImDCJFcVtt+ybH3oDxo0IiSc/OFhwuLot7V5BCzdpshBjFiMQG1vH9j+KeF2R7zHSqGhucPpg1Ql6YuNsZlliXDBMfeE5lQ= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2934.namprd18.prod.outlook.com (20.179.59.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Tue, 23 Jul 2019 04:18:50 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2094.013; Tue, 23 Jul 2019 04:18:50 +0000 From: Jerin Jacob Kollanukkaran To: "Stojaczyk, Dariusz" , Thomas Monjalon , David Marchand , "Burakov, Anatoly" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection Thread-Index: AQHVQQe8sqi9vPlkxkmyxie40lyIBKbXlQIw Date: Tue, 23 Jul 2019 04:18:50 +0000 Message-ID: References: <1562795329-16652-1-git-send-email-david.marchand@redhat.com> <1563800213-29839-1-git-send-email-david.marchand@redhat.com> <1735440.496QTsyyT4@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 68b3cff6-7fbb-46a9-3b2d-08d70f24dd62 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2934; x-ms-traffictypediagnostic: BYAPR18MB2934: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0107098B6C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(136003)(376002)(366004)(39860400002)(54534003)(13464003)(199004)(189003)(3846002)(52536014)(7736002)(305945005)(8676002)(66446008)(76116006)(66476007)(66556008)(64756008)(66946007)(6116002)(5024004)(14444005)(256004)(5660300002)(86362001)(8936002)(76176011)(66066001)(81166006)(81156014)(4326008)(7696005)(71190400001)(71200400001)(99286004)(6246003)(74316002)(26005)(53936002)(476003)(68736007)(25786009)(9686003)(55016002)(2906002)(6506007)(478600001)(229853002)(53546011)(14454004)(110136005)(486006)(316002)(33656002)(446003)(6436002)(11346002)(186003)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2934; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: hPXTG1XTOSm1eWfARvLCRMhil9ArfGNYNO+XmN6GxQLiVxCDtLU5RsEAETeYg/gL0VslqAfEkDPAzTPK6KxlUVkNO/iTguDPjr4uHvAKFzxoZeF7chb1cZVaSRqcqtM3GpLIVKNUOdwRi44K9RhaMOnGuq4NLzJTlNH+bS6LZvLB22UhR7nXTGwcIluFrNFdyLrIzOR2VfOQDuCmZUoX1Wk0wBKdxcNEVhRidXJ/IoREKGaDnB9IcMohdD3ROpWt1Q0I4QDsiZwqHa33+OFN8SGu4bl2e+GumDQUxT/KRmUilRsGXBDmLIPSEOClDpXDwgiynVzsWOS9j2uydXCeKvtYafHDTLPUlH0UIonlxpKxM6x91RA3R634K6fhqsJA4sK8VOxYMIBX4O88yX0Lj/Rllzu542e98vFEzkQxvBQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 68b3cff6-7fbb-46a9-3b2d-08d70f24dd62 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2019 04:18:50.2147 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2934 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-23_03:2019-07-23,2019-07-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stojaczyk, Dariusz > Sent: Tuesday, July 23, 2019 9:06 AM > To: Thomas Monjalon ; David Marchand > ; Burakov, Anatoly > ; Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org > Subject: [EXT] RE: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection >=20 > This introduces a regression where uio-bound devies are attached to a DPD= K > app at runtime. Just to understand the requirements; # Is this requirement for SPDK? # Is brand new PCI device scanned and attached to DPDK at runtime? # Any specific reason for using uio vs vfio? If it is for SPDK,=20 # How about introducing rte_eal_init_with_mode(enum rte_iova_mode)? # How about adding dummy bus which returns RTE_IOVA_PA in the bus_get_iommu= s_class() in SPDK code base? >=20 > When there are no devices attached at initialization, the only safe defau= lt > should be RTE_IOVA_PA. With RTE_IOVA_VA we just won't be able to do > any DMA to uio-bound PCI devices. >=20 > Can we revert this patch? >=20 > D. >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Monday, July 22, 2019 5:53 PM > > To: David Marchand ; Burakov, Anatoly > > ; jerinj@marvell.com > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection > > > > 22/07/2019 14:56, David Marchand: > > > Following the issues reported by Jerin and the discussion that > > > emerged from it, here are fixes to restore and document the behavior > > > of the EAL and the pci bus driver. > > > > > > I pondered all the arguments and tried to have the less changes > > > possible. > > > I can't find a need for a flag to just announce support of physical > > > addresses from the pmd point of view. > > > So it ended up with something really close to what Jerin had suggeste= d. > > > > > > But the problem is that this is still unfinished wrt the documentatio= n. > > > I will be offline for 10 days and we need this to move forward, so > > > sending anyway. > > > > > > Changelog since v3: > > > - fixed typos in patch 2, > > > - updated patch 3 title, > > > - moved and reworded comments in the note section in patch 4, > > > > > > Changelog since v2 (Jerin): > > > - Patch 2/4 - Remove personal appeals in log messages(Anatoly) > > > - Patch 4/4 - Added documentation (Anatoly) > > > > > > Changelog since v1 (Jerin): > > > - Changed RTE_PCI_DRV_IOVA_AS_VA flag name as > > RTE_PCI_DRV_NEED_IOVA_AS_VA > > > (patch 3/4) > > > - Changed IOVA mode as VA for default case(patch 4/4) with > > documentation > > > - Tested the patch series on octeontx2 platform > > > > Applied, thanks Jerin, Anatoly and David for converging on a > > documented solution together. > > > >