From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id D2B191B144 for ; Sat, 13 Apr 2019 08:24:35 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3D6GVA5005890; Fri, 12 Apr 2019 23:24:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=YIooKo0xRvbnprIkV3604LdC0G/7OXGZlSUDy9kX0rY=; b=iq0Q+8sGx+nAz7/QVlaBg1fqZjK82Nq4v+9GCKo6eB+i/tQ0l6lvI4FnG04uKy9I5YAJ Na/wI8vsj9d9lCUCzU5VNSu8ZoSDegxexq46F/73f6LmVXV9fmzHbHChi7imSAuFy5Gg obMTuRF57XaLz4UzYndx/mkxpEQ04rgZCy94BX/B6IVrIgx/0Uc8Pn5b/DuvjQS6MFRX 4DoXx9Awo9LgRlcAABHk0h7ET/Wbl40v2CZqUJUanrhF76Rw2999dsLdM4zDvIyWAmep jqu4Vr/tAefmT8HmB+buP5lYdkEoMBCwDSun/S07smWffoguOVFtXcCuTj4OaABG5n6I Nw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2rtxxta501-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 12 Apr 2019 23:24:34 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 12 Apr 2019 23:24:33 -0700 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.50) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 12 Apr 2019 23:24:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YIooKo0xRvbnprIkV3604LdC0G/7OXGZlSUDy9kX0rY=; b=BmnFMnjDQlwNjVly2dEMlvDBoImaBG/5w7/RWmxqm5M9/jgG7YJRd8lzFff4DqCWY90D6vXqhst6D5UF0vPjVzwNCCWZcEaiZJYgyX1mgP5NPlc7ti05Pf77jTAQrjdV4nO7teIuZeqwiQARrMM9zJP8kg31crDAtIW6PTuz+98= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2501.namprd18.prod.outlook.com (20.179.92.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.15; Sat, 13 Apr 2019 06:24:31 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e%7]) with mapi id 15.20.1771.019; Sat, 13 Apr 2019 06:24:31 +0000 From: Jerin Jacob Kollanukkaran To: Thomas Monjalon CC: Pavan Nikhilesh Bhagavatula , "dev@dpdk.org" , "jerinjacobk@gmail.com" , "yskoh@mellanox.com" , "bruce.richardson@intel.com" Thread-Topic: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags Thread-Index: AQHU77iSorMd3V4+3E+iXjS7cN1vMqY3n5YAgAB8OICAABzUgIABaIuQ Date: Sat, 13 Apr 2019 06:24:31 +0000 Message-ID: References: <20190406142737.20091-1-jerinj@marvell.com> <7046361.HPUSkOkSIl@xps> <1848175.uIgEXrQmFj@xps> In-Reply-To: <1848175.uIgEXrQmFj@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.182.194.144] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f857f94f-dce1-4be2-5109-08d6bfd8b07b x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2501; x-ms-traffictypediagnostic: BYAPR18MB2501: x-microsoft-antispam-prvs: x-forefront-prvs: 00064751B6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(366004)(346002)(396003)(376002)(39860400002)(136003)(199004)(189003)(4326008)(478600001)(97736004)(54906003)(256004)(305945005)(14454004)(6436002)(7736002)(316002)(6246003)(66066001)(71200400001)(74316002)(71190400001)(86362001)(25786009)(106356001)(52536014)(446003)(68736007)(11346002)(229853002)(105586002)(3846002)(81166006)(8676002)(93886005)(6506007)(26005)(486006)(7696005)(53936002)(81156014)(186003)(6916009)(2906002)(5660300002)(102836004)(476003)(33656002)(9686003)(99286004)(8936002)(55016002)(6116002)(76176011)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2501; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: mH8nIqe2mhut/MKWpTPSgG3MGwBhdN5dk7lT0kpyQbDrpHf/DY/HkdLsqQUpN+UytBfotFoPTTtu5PHHAfhiNHgoPxGBMD5lL396CVObdtLkMQoPZZuxoA3cxwUMl12v6Cdw7deyTzDzF3zJoFXMNYhRn4AikGs2Zql9xXa+A1l3AstFq8xwb1gcmizpl1VJo2Z261jlwmlc/NmQuCZRdZuGC2D+udavm3MXbfUGkS9sjTNTxL2483ItYP5uQWYsHKF1B4cIF0KVrIetR5aBYSSULp/Mj9XsnFkgrGcJGrO2VOPsHztXAV3qYbcRSp/RPVqt00+kCkJXw6cBCHENltGlEUwONwCaodX6eVck6Qg9pwyamZ1ByiFGuoypNibgwnnmKhsOMKWwAN+N3Aji1C3Yt4HtMAjVREdCFeMz6pQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f857f94f-dce1-4be2-5109-08d6bfd8b07b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2019 06:24:31.2895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2501 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-13_02:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Apr 2019 06:24:36 -0000 > > > > +machine_args_cavium =3D [ > > > > + ['default', ['-march=3Darmv8-a+crc+crypto','-mcpu=3Dthunderx']], > > > > + ['native', ['-march=3Dnative']], > > > > + ['0xa1', ['-mcpu=3Dthunderxt88'], flags_thunderx_extra], > > > > + ['0xa2', ['-mcpu=3Dthunderxt81'], flags_thunderx_extra], > > > > + ['0xa3', ['-mcpu=3Dthunderxt83'], flags_thunderx_extra]] > > > > > > I think we should have a simpler model. > > > We need only to know the machine name and get all the related > > > machine config. > > > In native compilation, machine name is guessed from implementor id > > > and pn (from config/arm/armv8_machine.py). We can directly output > > > the machine name from this script and leave the naming logic in this = script. > > > In the cross-compilation config files (config/arm/*), we can just > > > specify the machine name. > > > Then every machine config (machine_args and dpdk_conf) would be > > > specified in some arrays based on the machine name. > > > Of course, we can keep some common default values. > > > > Thomas, > > > > This patch was around last three months. It reached upto v8. > > I think, in that last minute for RC2, We cannot take major rework on > > this as it needs to tested for Other arm64 platform too. It was pulled = out from > RC1 because other pcap issue from meson. > > Now its not fair to say to rework the meson stuff now. > > I suggest to take other rework in next release. >=20 > I was not confortable with this patch without being able to say why. > Yesterday I spent more time to understand and see what may be improved. > I agree it is late, so it won't block this patch for 19.05. > Do you agree this file can be improved? Moving to the all to static config file is an option but we lose the flexi= bility of runtime detecting the options and few of them are probing at runtime bas= ed on gcc versions and mcpu combination etc. I am not expert in meson area and not sure meson/python has better data str= cture for this other than list/array combo. If Bruce has any feedback on this, then we will try to prototype it. > Please would you like to look at reworking during next cycle? > Thanks >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DD77EA0096 for ; Sat, 13 Apr 2019 08:24:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 468761B146; Sat, 13 Apr 2019 08:24:38 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id D2B191B144 for ; Sat, 13 Apr 2019 08:24:35 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3D6GVA5005890; Fri, 12 Apr 2019 23:24:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=YIooKo0xRvbnprIkV3604LdC0G/7OXGZlSUDy9kX0rY=; b=iq0Q+8sGx+nAz7/QVlaBg1fqZjK82Nq4v+9GCKo6eB+i/tQ0l6lvI4FnG04uKy9I5YAJ Na/wI8vsj9d9lCUCzU5VNSu8ZoSDegxexq46F/73f6LmVXV9fmzHbHChi7imSAuFy5Gg obMTuRF57XaLz4UzYndx/mkxpEQ04rgZCy94BX/B6IVrIgx/0Uc8Pn5b/DuvjQS6MFRX 4DoXx9Awo9LgRlcAABHk0h7ET/Wbl40v2CZqUJUanrhF76Rw2999dsLdM4zDvIyWAmep jqu4Vr/tAefmT8HmB+buP5lYdkEoMBCwDSun/S07smWffoguOVFtXcCuTj4OaABG5n6I Nw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2rtxxta501-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 12 Apr 2019 23:24:34 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 12 Apr 2019 23:24:33 -0700 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.50) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 12 Apr 2019 23:24:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YIooKo0xRvbnprIkV3604LdC0G/7OXGZlSUDy9kX0rY=; b=BmnFMnjDQlwNjVly2dEMlvDBoImaBG/5w7/RWmxqm5M9/jgG7YJRd8lzFff4DqCWY90D6vXqhst6D5UF0vPjVzwNCCWZcEaiZJYgyX1mgP5NPlc7ti05Pf77jTAQrjdV4nO7teIuZeqwiQARrMM9zJP8kg31crDAtIW6PTuz+98= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2501.namprd18.prod.outlook.com (20.179.92.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.15; Sat, 13 Apr 2019 06:24:31 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e%7]) with mapi id 15.20.1771.019; Sat, 13 Apr 2019 06:24:31 +0000 From: Jerin Jacob Kollanukkaran To: Thomas Monjalon CC: Pavan Nikhilesh Bhagavatula , "dev@dpdk.org" , "jerinjacobk@gmail.com" , "yskoh@mellanox.com" , "bruce.richardson@intel.com" Thread-Topic: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags Thread-Index: AQHU77iSorMd3V4+3E+iXjS7cN1vMqY3n5YAgAB8OICAABzUgIABaIuQ Date: Sat, 13 Apr 2019 06:24:31 +0000 Message-ID: References: <20190406142737.20091-1-jerinj@marvell.com> <7046361.HPUSkOkSIl@xps> <1848175.uIgEXrQmFj@xps> In-Reply-To: <1848175.uIgEXrQmFj@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.182.194.144] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f857f94f-dce1-4be2-5109-08d6bfd8b07b x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2501; x-ms-traffictypediagnostic: BYAPR18MB2501: x-microsoft-antispam-prvs: x-forefront-prvs: 00064751B6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(366004)(346002)(396003)(376002)(39860400002)(136003)(199004)(189003)(4326008)(478600001)(97736004)(54906003)(256004)(305945005)(14454004)(6436002)(7736002)(316002)(6246003)(66066001)(71200400001)(74316002)(71190400001)(86362001)(25786009)(106356001)(52536014)(446003)(68736007)(11346002)(229853002)(105586002)(3846002)(81166006)(8676002)(93886005)(6506007)(26005)(486006)(7696005)(53936002)(81156014)(186003)(6916009)(2906002)(5660300002)(102836004)(476003)(33656002)(9686003)(99286004)(8936002)(55016002)(6116002)(76176011)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2501; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: mH8nIqe2mhut/MKWpTPSgG3MGwBhdN5dk7lT0kpyQbDrpHf/DY/HkdLsqQUpN+UytBfotFoPTTtu5PHHAfhiNHgoPxGBMD5lL396CVObdtLkMQoPZZuxoA3cxwUMl12v6Cdw7deyTzDzF3zJoFXMNYhRn4AikGs2Zql9xXa+A1l3AstFq8xwb1gcmizpl1VJo2Z261jlwmlc/NmQuCZRdZuGC2D+udavm3MXbfUGkS9sjTNTxL2483ItYP5uQWYsHKF1B4cIF0KVrIetR5aBYSSULp/Mj9XsnFkgrGcJGrO2VOPsHztXAV3qYbcRSp/RPVqt00+kCkJXw6cBCHENltGlEUwONwCaodX6eVck6Qg9pwyamZ1ByiFGuoypNibgwnnmKhsOMKWwAN+N3Aji1C3Yt4HtMAjVREdCFeMz6pQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f857f94f-dce1-4be2-5109-08d6bfd8b07b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2019 06:24:31.2895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2501 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-13_02:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190413062431.JKcZHuKSRAfaP_Ia8mthCjtFbPXi4CSzpgHe5OGioLM@z> > > > > +machine_args_cavium =3D [ > > > > + ['default', ['-march=3Darmv8-a+crc+crypto','-mcpu=3Dthunderx']], > > > > + ['native', ['-march=3Dnative']], > > > > + ['0xa1', ['-mcpu=3Dthunderxt88'], flags_thunderx_extra], > > > > + ['0xa2', ['-mcpu=3Dthunderxt81'], flags_thunderx_extra], > > > > + ['0xa3', ['-mcpu=3Dthunderxt83'], flags_thunderx_extra]] > > > > > > I think we should have a simpler model. > > > We need only to know the machine name and get all the related > > > machine config. > > > In native compilation, machine name is guessed from implementor id > > > and pn (from config/arm/armv8_machine.py). We can directly output > > > the machine name from this script and leave the naming logic in this = script. > > > In the cross-compilation config files (config/arm/*), we can just > > > specify the machine name. > > > Then every machine config (machine_args and dpdk_conf) would be > > > specified in some arrays based on the machine name. > > > Of course, we can keep some common default values. > > > > Thomas, > > > > This patch was around last three months. It reached upto v8. > > I think, in that last minute for RC2, We cannot take major rework on > > this as it needs to tested for Other arm64 platform too. It was pulled = out from > RC1 because other pcap issue from meson. > > Now its not fair to say to rework the meson stuff now. > > I suggest to take other rework in next release. >=20 > I was not confortable with this patch without being able to say why. > Yesterday I spent more time to understand and see what may be improved. > I agree it is late, so it won't block this patch for 19.05. > Do you agree this file can be improved? Moving to the all to static config file is an option but we lose the flexi= bility of runtime detecting the options and few of them are probing at runtime bas= ed on gcc versions and mcpu combination etc. I am not expert in meson area and not sure meson/python has better data str= cture for this other than list/array combo. If Bruce has any feedback on this, then we will try to prototype it. > Please would you like to look at reworking during next cycle? > Thanks >=20